[{"id":610,"web_url":"https://patchwork.libcamera.org/comment/610/","msgid":"<20190125171351.GC4515@pendragon.ideasonboard.com>","date":"2019-01-25T17:13:51","subject":"Re: [libcamera-devel] [PATCH 0/5] libcamera: camera data: Address\n\treview comments","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patches.\n\nOn Fri, Jan 25, 2019 at 06:03:55PM +0100, Jacopo Mondi wrote:\n> Address review comments with follow up patches.\n> \n> Jacopo Mondi (5):\n>   libcamera: pipeline: Fix operator= declaration\n>   libcamera: pipeline: Remove duplicated include\n>   libcamera: pipeline: Rework class destructor\n>   libcamera: pipeline: Misc comments update\n\nFor 1-4,\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n>   libcamera: pipeline: Refuse to substitute camera data\n> \n>  src/libcamera/include/pipeline_handler.h |  4 +-\n>  src/libcamera/pipeline_handler.cpp       | 47 +++++++++++-------------\n>  2 files changed, 24 insertions(+), 27 deletions(-)\n>","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E571560C6A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 25 Jan 2019 18:13:52 +0100 (CET)","from pendragon.ideasonboard.com\n\t(250-166-145-178.mobileinternet.proximus.be [178.145.166.250])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8BF28325;\n\tFri, 25 Jan 2019 18:13:52 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548436432;\n\tbh=cCOxgYb0jKunICQBEfVSv3VYiWh6LtdyRmetEgzyFpQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=o+v1uLmMVSV/glod+kM3P5pO/GM9CvWHyteKfrjsiWzby1egiKa/5PeVA9VzmPmZY\n\t+tzRMW6O/h+32rx2vllE8gaft1/vW2kfhHCO9gE+q3bAucyeeQyint+mHC9lkQBGrf\n\tUZi6t3uYFNrfTXmYd+jr/UVJqW8RTgC3hYfMb79o=","Date":"Fri, 25 Jan 2019 19:13:51 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Jacopo Mondi <jacopo@jmondi.org>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190125171351.GC4515@pendragon.ideasonboard.com>","References":"<20190125170400.24821-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190125170400.24821-1-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 0/5] libcamera: camera data: Address\n\treview comments","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 25 Jan 2019 17:13:53 -0000"}}]