[{"id":4904,"web_url":"https://patchwork.libcamera.org/comment/4904/","msgid":"","date":"2020-05-26T08:31:31","subject":"Re: [libcamera-devel] [RFC v2] [PATCH 0/1] qcam: Render YUV formats\n\tframe by OpenGL shader","submitter":{"id":24,"url":"https://patchwork.libcamera.org/api/people/24/","name":"Show Liu","email":"show.liu@linaro.org"},"content":"Hi Laurent,\n\nSorry I forgot to have a brief description about what's the difference with\nthe v1.\nMainly,\n1. To have a viewfinder handle interface to handle viewfinder and\nviewfinderGL both.\n2. able to select different NV formats family by the YUV format.\n3. and some changes according to the v1's review comments.\n\nBR,\nShow\n\nOn Tue, May 26, 2020 at 3:52 PM Show Liu wrote:\n\n> This patch is to render the YUV(NV formats family) frame by OpenGL shader.\n> I rework viewfinder class and give viewfinder handle abstract class as\n> interface\n> and make it able to handle viewfinder and viewfinderGL both.\n>\nI tested on rockpi4b with kernel 5.7rc4+imx219 camera module.\n>\n> Show Liu (1):\n> qcam: Render YUV formats frame by OpenGL shader\n>\n> src/qcam/fshader.h | 86 ++++++++++\n> src/qcam/main.cpp | 2 +\n> src/qcam/main_window.cpp | 19 ++-\n> src/qcam/main_window.h | 3 +-\n> src/qcam/meson.build | 2 +\n> src/qcam/viewfinder.cpp | 18 +-\n> src/qcam/viewfinder.h | 23 ++-\n> src/qcam/viewfinderGL.cpp | 346 ++++++++++++++++++++++++++++++++++++++\n> src/qcam/viewfinderGL.h | 102 +++++++++++\n> 9 files changed, 587 insertions(+), 14 deletions(-)\n> create mode 100644 src/qcam/fshader.h\n> create mode 100644 src/qcam/viewfinderGL.cpp\n> create mode 100644 src/qcam/viewfinderGL.h\n>\n> --\n> 2.20.1\n>\n>","headers":{"Return-Path":"","Received":["from mail-ej1-x641.google.com (mail-ej1-x641.google.com\n\t[IPv6:2a00:1450:4864:20::641])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 46891603D1\n\tfor ;\n\tTue, 26 May 2020 10:31:43 +0200 (CEST)","by mail-ej1-x641.google.com with SMTP id l21so22876560eji.4\n\tfor ;\n\tTue, 26 May 2020 01:31:43 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=linaro.org\n\theader.i=@linaro.org header.b=\"uNcK6c/X\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=tFcjI+TSA2Ic7hqMh982Z+nGaFefvQz44UvmYXd6eFo=;\n\tb=uNcK6c/XAXdp8hdH7wODEPbI1hkD9YQ3Fg9jgnZIZdNapah49W6oACMClPpRunLOfa\n\th2nmKcLPLG2O12JuIDsuhrVv/afr2ucZQQnnqU6plflmgSxXoEdxlPpMtPOTt+M+CVpR\n\tJSL+LnWp5QmVT/9QHWWgy4+oL7OCzBClwbGUO2kYwIwFx3IVR6Uc+T/YH1JQQNlxD9eS\n\t/W0CaiqGCBEf+/x36YUHTI4RUx+gLorx3znraEL78e3p/Wczip9liWTtTUIJ9SZsdLiY\n\twNmEtFoxM7/Oq/t287eRrq+AE0ls9oo1zNkLi/DabekXucvMsRmCScoLZtJk6B11IJzM\n\teePw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=tFcjI+TSA2Ic7hqMh982Z+nGaFefvQz44UvmYXd6eFo=;\n\tb=YdmVrZXahEw5W/5vQFnzJNL/j4tC8fF51HReKAX7RtvbuEDrGoBgSMaDQYUSlpSd2W\n\tyCP6kClSLN4IsMLrR7rnHhn4IiV0FOIrTgOdPfVG6uZM1vw1brbbVFW/upYNUvq1OTYR\n\tfceDiisYUmDpNdlI/3QPXsuvJBioRpmRX793a4yp1CDIgJPxK+F5FkDOHD2LbL8LuJvB\n\tyGBX1FpuYGl9CwE8z/gGLxF7DjgqGQz647b1SFYlXy/d8Iq3pu1yIfDAy6WVntI6Rd3U\n\ttpHc7d8rfwIZ9+QjkizLEJsyuXVDeI1YFOBU4qWQcUNJwWtqjUpFZidPWCf00jwsLFX7\n\tozfw==","X-Gm-Message-State":"AOAM532szj7K4JxA164dtGHBlYu3MiX5NusFHv3VirGBWBzPReqw5lFy\n\tTUq3gBii7d9El3kNcCGOp26jns7rb+Jpm6vQoebzJq/WiN+iuA==","X-Google-Smtp-Source":"ABdhPJyFqtPRAfqIJBmjyZd+IHQn9oGF4ANBcucv9bOGEKDdvzbEjd7sMxWATAEH0NgGUcMWio4WhW0MuKTWaxFK1Mw=","X-Received":"by 2002:a17:906:b251:: with SMTP id\n\tce17mr131726ejb.165.1590481902396; \n\tTue, 26 May 2020 01:31:42 -0700 (PDT)","MIME-Version":"1.0","References":"<20200526075203.4503-1-show.liu@linaro.org>","In-Reply-To":"<20200526075203.4503-1-show.liu@linaro.org>","From":"Show Liu ","Date":"Tue, 26 May 2020 16:31:31 +0800","Message-ID":"","To":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"000000000000d0887c05a688ece5\"","Subject":"Re: [libcamera-devel] [RFC v2] [PATCH 0/1] qcam: Render YUV formats\n\tframe by OpenGL shader","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 26 May 2020 08:31:43 -0000"}}]