[{"id":4957,"web_url":"https://patchwork.libcamera.org/comment/4957/","msgid":"<652604cd-5128-31d0-4375-3c746c9bb411@ideasonboard.com>","date":"2020-06-02T09:43:33","subject":"Re: [libcamera-devel] [PATCH v2 0/4] Coverity scan fixes","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Umang,\n\nThese all look good to me. I've updated the coverity tagging style to\nmatch Laurent's usage (not your fault, as we haven't really declared the\nstyle of reporting that yet)\n\nI've got them applied to a local branch, and they pass the tests, so if\nthere are no further comments I'll push these to master today.\n\nThank you,\n\nKieran\n\n\nOn 15/05/2020 13:42, Umang Jain wrote:\n> Fixes of issues pointed out by coverity scans.\n> Some of them were reviewed earlier (attached\n> review tags for them) and some have been reworked\n> to address the review.\n> \n> Umang Jain (4):\n> test: ipc: unixsocket: Close open fds on error paths\n> test: log: log_process: Close open fds on error paths\n> test: log: log_api: Close open fds on error paths\n> libcamera: camera: Return -EINVAL if any stream is null while\n> configure()\n> \n> src/libcamera/camera.cpp | 5 ++++-\n> test/ipc/unixsocket.cpp | 2 ++\n> test/log/log_api.cpp | 2 ++\n> test/log/log_process.cpp | 1 +\n> 4 files changed, 9 insertions(+), 1 deletion(-)\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1FA11603CA\n\tfor ;\n\tTue, 2 Jun 2020 11:43:37 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 996992E5;\n\tTue, 2 Jun 2020 11:43:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"iwpT1Cuh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591091016;\n\tbh=BxcxtMsRzQwKsMOAVXxtaHRpdbpPqGawlbIQdytzUa0=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=iwpT1CuhSms+aZFjrSmoFEqA5z7t1FwyTaWSc3KjAK4q4nArGWnaRNs/OLSimLyRz\n\tXHkboh14iybMsGYSLoXULQddRnnKeECmz05+bDBf3+CoevKUv7b2fVqq5iNCniyOCX\n\t20AVBSyYzdyN0TbksXaiAeQNw+PUUu9ojYrPf2VQ=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Umang Jain ,\n\tlibcamera-devel ","References":"<20200515124245.18040-1-email@uajain.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<652604cd-5128-31d0-4375-3c746c9bb411@ideasonboard.com>","Date":"Tue, 2 Jun 2020 10:43:33 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.7.0","MIME-Version":"1.0","In-Reply-To":"<20200515124245.18040-1-email@uajain.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2 0/4] Coverity scan fixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 02 Jun 2020 09:43:37 -0000"}},{"id":4969,"web_url":"https://patchwork.libcamera.org/comment/4969/","msgid":"<02ff674d-af65-f778-8982-a46c47e383c1@uajain.com>","date":"2020-06-02T15:04:33","subject":"Re: [libcamera-devel] [PATCH v2 0/4] Coverity scan fixes","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi Kieran,\n\nOn 6/2/20 3:13 PM, Kieran Bingham wrote:\n> Hi Umang,\n>\n> These all look good to me. I've updated the coverity tagging style to\n> match Laurent's usage (not your fault, as we haven't really declared the\n> style of reporting that yet)\nAh, I have taken note of this for future references.\n>\n> I've got them applied to a local branch, and they pass the tests, so if\n> there are no further comments I'll push these to master today.\nNo further comments. Thanks for the review.\n> Thank you,\n>\n> Kieran\n>\n>\n> On 15/05/2020 13:42, Umang Jain wrote:\n>> Fixes of issues pointed out by coverity scans.\n>> Some of them were reviewed earlier (attached\n>> review tags for them) and some have been reworked\n>> to address the review.\n>>\n>> Umang Jain (4):\n>> test: ipc: unixsocket: Close open fds on error paths\n>> test: log: log_process: Close open fds on error paths\n>> test: log: log_api: Close open fds on error paths\n>> libcamera: camera: Return -EINVAL if any stream is null while\n>> configure()\n>>\n>> src/libcamera/camera.cpp | 5 ++++-\n>> test/ipc/unixsocket.cpp | 2 ++\n>> test/log/log_api.cpp | 2 ++\n>> test/log/log_process.cpp | 1 +\n>> 4 files changed, 9 insertions(+), 1 deletion(-)\n>>","headers":{"Return-Path":"","Received":["from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 145B661012\n\tfor ;\n\tTue, 2 Jun 2020 17:04:34 +0200 (CEST)","by filterdrecv-p3iad2-8ddf98858-lwgxm with SMTP id\n\tfilterdrecv-p3iad2-8ddf98858-lwgxm-19-5ED66A81-26\n\t2020-06-02 15:04:33.310255192 +0000 UTC m=+5925422.894401130","from mail.uajain.com (unknown)\n\tby ismtpd0007p1hnd1.sendgrid.net (SG) with ESMTP\n\tid fa8VVnhOTDuZXOd7snOxnA Tue, 02 Jun 2020 15:04:32.651 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"ZPjeDYVB\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=subject:references:from:mime-version:in-reply-to:to:content-type:\n\tcontent-transfer-encoding;\n\ts=s1; bh=GbqoBpjbHpBp0Q93Jcoz/MplQVXf9518TXc/rFCHkog=;\n\tb=ZPjeDYVB60CWKPUZGz0rWRudYO9WIU4gOwgeHK0S5AXyrEhsnyAU42dPr7OnFY6RTZFL\n\tv/t7TrudJgA/7FlKEkd2DhZBXM6KD98nvx0xhVJXB3lnEs7+6YgwL0KJlCQQ4Gff5jp8zi\n\tuNE+NrNE3snm4c4HVyQoeH4j9jqNVolMI=","References":"<20200515124245.18040-1-email@uajain.com>\n\t<652604cd-5128-31d0-4375-3c746c9bb411@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<02ff674d-af65-f778-8982-a46c47e383c1@uajain.com>","Date":"Tue, 02 Jun 2020 15:04:33 +0000 (UTC)","Mime-Version":"1.0","In-Reply-To":"<652604cd-5128-31d0-4375-3c746c9bb411@ideasonboard.com>","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcwyK5CDkYX8/iiotPdJ0nvuZFN1M1c3RmexwlmuVyXTia3BicKkG9dKUAHqBBx77ItCnc98FvXQ4J7hKVYUjvu6Bl9k91DhUthdGitX/xI5wPNtkZOHtIRB/kPOZQkUC/Xd6fosK5aGVFOT8aLDRneU5+Gg2TqjSrqNFOFYRQHiUtnffv0+sobxeZND34OlsVanVhNBaKuzRQxWklEucUTA==","To":"kieran.bingham@ideasonboard.com, libcamera-devel\n\t","Content-Type":"text/plain; charset=us-ascii; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v2 0/4] Coverity scan fixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 02 Jun 2020 15:04:36 -0000"}}]