[{"id":4796,"web_url":"https://patchwork.libcamera.org/comment/4796/","msgid":"<98f3255b-ffca-88ea-4c1b-e20662a032b5@ideasonboard.com>","date":"2020-05-12T08:35:05","subject":"Re: [libcamera-devel] [PATCH 00/24] utils: raspberrypi: ctt: Comply\n\twith pycodestyle","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 12/05/2020 01:02, Laurent Pinchart wrote:\n> Hello,\n> \n> This patch series fixes most of the coding style issues reported by\n> pycodestyle in the ctt tool. I've left out two remaining issues as they\n> could be more controversial:\n> \n> - Spaces around operators (E226 and 227)\n> - Usage of docstrings for comments (flagged by E302)\n> \n> I can easily fix them if desired.\n\nFor all the below (excepting the discussion point in 13/24):\n\nReviewed-by: Kieran Bingham \n\nBut it would be good to get feedback from David/Naush here too of course.\n\n--\nKieran\n\n\n\n> Laurent Pinchart (24):\n> utils: raspberrypi: ctt: Fix pycodestyle E231\n> utils: raspberrypi: ctt: Fix pycodestyle E201 and E202\n> utils: raspberrypi: ctt: Fix pycodestyle E203\n> utils: raspberrypi: ctt: Fix pycodestyle E241\n> utils: raspberrypi: ctt: Fix pycodestyle E211\n> utils: raspberrypi: ctt: Fix pycodestyle E251\n> utils: raspberrypi: ctt: Fix pycodestyle E128\n> utils: raspberrypi: ctt: Fix pycodestyle E225\n> utils: raspberrypi: ctt: Fix pycodestyle E228\n> utils: raspberrypi: ctt: Fix pycodestyle E701\n> utils: raspberrypi: ctt: Fix pycodestyle E303\n> utils: raspberrypi: ctt: Fix pycodestyle E261 and E262\n> utils: raspberrypi: ctt: Fix pycodestyle W605\n> utils: raspberrypi: ctt: Fix pycodestyle E222\n> utils: raspberrypi: ctt: Fix pycodestyle E711 and E712\n> utils: raspberrypi: ctt: Fix pycodestyle E123 and E126\n> utils: raspberrypi: ctt: Fix pycodestyle E116 and E117\n> utils: raspberrypi: ctt: Fix pycodestyle E713\n> utils: raspberrypi: ctt: Fix pycodestyle E721\n> utils: raspberrypi: ctt: Fix pycodestyle E722\n> utils: raspberrypi: ctt: Fix pycodestyle W504\n> utils: raspberrypi: ctt: Fix pycodestyle E741\n> utils: raspberrypi: ctt: Fix pycodestyle E305\n> utils: raspberrypi: ctt: Fix pycodestyle E302\n> \n> utils/raspberrypi/ctt/ctt.py | 257 ++++++++--------\n> utils/raspberrypi/ctt/ctt_alsc.py | 146 ++++-----\n> utils/raspberrypi/ctt/ctt_awb.py | 140 ++++-----\n> utils/raspberrypi/ctt/ctt_ccm.py | 67 ++--\n> utils/raspberrypi/ctt/ctt_geq.py | 50 +--\n> utils/raspberrypi/ctt/ctt_image_load.py | 125 ++++----\n> utils/raspberrypi/ctt/ctt_lux.py | 19 +-\n> utils/raspberrypi/ctt/ctt_macbeth_locator.py | 288 +++++++++---------\n> utils/raspberrypi/ctt/ctt_noise.py | 30 +-\n> .../raspberrypi/ctt/ctt_pretty_print_json.py | 9 +-\n> utils/raspberrypi/ctt/ctt_ransac.py | 56 ++--\n> utils/raspberrypi/ctt/ctt_tools.py | 64 ++--\n> 12 files changed, 641 insertions(+), 610 deletions(-)\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D3198603DF\n\tfor ;\n\tTue, 12 May 2020 10:35:09 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5008333E;\n\tTue, 12 May 2020 10:35:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"gfe8dt7A\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1589272509;\n\tbh=8Cyb4wQklbEzztiOTt7qm8QyOoOKXiDjDb3pRbnrGoE=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=gfe8dt7AjKfpww66duM/kGYWxbjEA4i8/nEZnFehhZfdrcfyhWnqOSXzguW3ghkBN\n\tC+PaNDAqvXvVrXQw3atAyD4Icuayy0+MW66x9sUNSHJbwL/CG4BylhFcWMpRZGgQgb\n\tJhOnPXI5+3R8ISMOaEuFX0ZrJAb44RcZRsvYnvtw=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200512000322.11753-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<98f3255b-ffca-88ea-4c1b-e20662a032b5@ideasonboard.com>","Date":"Tue, 12 May 2020 09:35:05 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.7.0","MIME-Version":"1.0","In-Reply-To":"<20200512000322.11753-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 00/24] utils: raspberrypi: ctt: Comply\n\twith pycodestyle","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 12 May 2020 08:35:10 -0000"}},{"id":4799,"web_url":"https://patchwork.libcamera.org/comment/4799/","msgid":"<20200512141123.GD5861@pendragon.ideasonboard.com>","date":"2020-05-12T14:11:23","subject":"Re: [libcamera-devel] [PATCH 00/24] utils: raspberrypi: ctt: Comply\n\twith pycodestyle","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Tue, May 12, 2020 at 09:35:05AM +0100, Kieran Bingham wrote:\n> On 12/05/2020 01:02, Laurent Pinchart wrote:\n> > Hello,\n> > \n> > This patch series fixes most of the coding style issues reported by\n> > pycodestyle in the ctt tool. I've left out two remaining issues as they\n> > could be more controversial:\n> > \n> > - Spaces around operators (E226 and 227)\n> > - Usage of docstrings for comments (flagged by E302)\n> > \n> > I can easily fix them if desired.\n> \n> For all the below (excepting the discussion point in 13/24):\n> \n> Reviewed-by: Kieran Bingham \n> \n> But it would be good to get feedback from David/Naush here too of course.\n\nAbsolutely. David, Naush, as this is code you authored, I don't want to\nmerge anything that you wouldn't be comfortable with. I think\npycodestyle overall does a fairly good job of recommending a bit more\nblank space in the code, and improve consistency, which I think improves\nreadability. There are exceptions, for instance E226 and E227 listed\nabove may not look nice in the numpy array slices notation, which is why\nI've left those out for now.\n\n> > Laurent Pinchart (24):\n> > utils: raspberrypi: ctt: Fix pycodestyle E231\n> > utils: raspberrypi: ctt: Fix pycodestyle E201 and E202\n> > utils: raspberrypi: ctt: Fix pycodestyle E203\n> > utils: raspberrypi: ctt: Fix pycodestyle E241\n> > utils: raspberrypi: ctt: Fix pycodestyle E211\n> > utils: raspberrypi: ctt: Fix pycodestyle E251\n> > utils: raspberrypi: ctt: Fix pycodestyle E128\n> > utils: raspberrypi: ctt: Fix pycodestyle E225\n> > utils: raspberrypi: ctt: Fix pycodestyle E228\n> > utils: raspberrypi: ctt: Fix pycodestyle E701\n> > utils: raspberrypi: ctt: Fix pycodestyle E303\n> > utils: raspberrypi: ctt: Fix pycodestyle E261 and E262\n> > utils: raspberrypi: ctt: Fix pycodestyle W605\n> > utils: raspberrypi: ctt: Fix pycodestyle E222\n> > utils: raspberrypi: ctt: Fix pycodestyle E711 and E712\n> > utils: raspberrypi: ctt: Fix pycodestyle E123 and E126\n> > utils: raspberrypi: ctt: Fix pycodestyle E116 and E117\n> > utils: raspberrypi: ctt: Fix pycodestyle E713\n> > utils: raspberrypi: ctt: Fix pycodestyle E721\n> > utils: raspberrypi: ctt: Fix pycodestyle E722\n> > utils: raspberrypi: ctt: Fix pycodestyle W504\n> > utils: raspberrypi: ctt: Fix pycodestyle E741\n> > utils: raspberrypi: ctt: Fix pycodestyle E305\n> > utils: raspberrypi: ctt: Fix pycodestyle E302\n> > \n> > utils/raspberrypi/ctt/ctt.py | 257 ++++++++--------\n> > utils/raspberrypi/ctt/ctt_alsc.py | 146 ++++-----\n> > utils/raspberrypi/ctt/ctt_awb.py | 140 ++++-----\n> > utils/raspberrypi/ctt/ctt_ccm.py | 67 ++--\n> > utils/raspberrypi/ctt/ctt_geq.py | 50 +--\n> > utils/raspberrypi/ctt/ctt_image_load.py | 125 ++++----\n> > utils/raspberrypi/ctt/ctt_lux.py | 19 +-\n> > utils/raspberrypi/ctt/ctt_macbeth_locator.py | 288 +++++++++---------\n> > utils/raspberrypi/ctt/ctt_noise.py | 30 +-\n> > .../raspberrypi/ctt/ctt_pretty_print_json.py | 9 +-\n> > utils/raspberrypi/ctt/ctt_ransac.py | 56 ++--\n> > utils/raspberrypi/ctt/ctt_tools.py | 64 ++--\n> > 12 files changed, 641 insertions(+), 610 deletions(-)","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D8C91603E0\n\tfor ;\n\tTue, 12 May 2020 16:11:30 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E8AEC51F;\n\tTue, 12 May 2020 16:11:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"emyrJuHv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1589292690;\n\tbh=f0MYfxfJEjgFZ16VpzIUsxRmf+UQcUfyKyyVkCzY6i8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=emyrJuHvIbNGaB9E8Y4EnimrQiB7M0zE5f6T8rHCictJF0ErItV38nf7acwYjpjQI\n\tOYNJwNc5J5VrBiIHojpXzE3vGAzicZT9fCd7kdiNZ+FXbItVghgJTo/wYv8ImDnSJ6\n\tBH7zw9/JGdpNVNdygWIh4+/ciSkxXFKwlLlsTP94=","Date":"Tue, 12 May 2020 17:11:23 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200512141123.GD5861@pendragon.ideasonboard.com>","References":"<20200512000322.11753-1-laurent.pinchart@ideasonboard.com>\n\t<98f3255b-ffca-88ea-4c1b-e20662a032b5@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<98f3255b-ffca-88ea-4c1b-e20662a032b5@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 00/24] utils: raspberrypi: ctt: Comply\n\twith pycodestyle","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 12 May 2020 14:11:31 -0000"}},{"id":4812,"web_url":"https://patchwork.libcamera.org/comment/4812/","msgid":"","date":"2020-05-13T11:18:55","subject":"Re: [libcamera-devel] [PATCH 00/24] utils: raspberrypi: ctt: Comply\n\twith pycodestyle","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"On Tue, 12 May 2020 at 01:03, Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> Hello,\n>\n> This patch series fixes most of the coding style issues reported by\n> pycodestyle in the ctt tool. I've left out two remaining issues as they\n> could be more controversial:\n>\n> - Spaces around operators (E226 and 227)\n> - Usage of docstrings for comments (flagged by E302)\n>\n> I can easily fix them if desired.\n>\n> Laurent Pinchart (24):\n> utils: raspberrypi: ctt: Fix pycodestyle E231\n> utils: raspberrypi: ctt: Fix pycodestyle E201 and E202\n> utils: raspberrypi: ctt: Fix pycodestyle E203\n> utils: raspberrypi: ctt: Fix pycodestyle E241\n> utils: raspberrypi: ctt: Fix pycodestyle E211\n> utils: raspberrypi: ctt: Fix pycodestyle E251\n> utils: raspberrypi: ctt: Fix pycodestyle E128\n> utils: raspberrypi: ctt: Fix pycodestyle E225\n> utils: raspberrypi: ctt: Fix pycodestyle E228\n> utils: raspberrypi: ctt: Fix pycodestyle E701\n> utils: raspberrypi: ctt: Fix pycodestyle E303\n> utils: raspberrypi: ctt: Fix pycodestyle E261 and E262\n> utils: raspberrypi: ctt: Fix pycodestyle W605\n> utils: raspberrypi: ctt: Fix pycodestyle E222\n> utils: raspberrypi: ctt: Fix pycodestyle E711 and E712\n> utils: raspberrypi: ctt: Fix pycodestyle E123 and E126\n> utils: raspberrypi: ctt: Fix pycodestyle E116 and E117\n> utils: raspberrypi: ctt: Fix pycodestyle E713\n> utils: raspberrypi: ctt: Fix pycodestyle E721\n> utils: raspberrypi: ctt: Fix pycodestyle E722\n> utils: raspberrypi: ctt: Fix pycodestyle W504\n> utils: raspberrypi: ctt: Fix pycodestyle E741\n> utils: raspberrypi: ctt: Fix pycodestyle E305\n> utils: raspberrypi: ctt: Fix pycodestyle E302\n>\n> utils/raspberrypi/ctt/ctt.py | 257 ++++++++--------\n> utils/raspberrypi/ctt/ctt_alsc.py | 146 ++++-----\n> utils/raspberrypi/ctt/ctt_awb.py | 140 ++++-----\n> utils/raspberrypi/ctt/ctt_ccm.py | 67 ++--\n> utils/raspberrypi/ctt/ctt_geq.py | 50 +--\n> utils/raspberrypi/ctt/ctt_image_load.py | 125 ++++----\n> utils/raspberrypi/ctt/ctt_lux.py | 19 +-\n> utils/raspberrypi/ctt/ctt_macbeth_locator.py | 288 +++++++++---------\n> utils/raspberrypi/ctt/ctt_noise.py | 30 +-\n> .../raspberrypi/ctt/ctt_pretty_print_json.py | 9 +-\n> utils/raspberrypi/ctt/ctt_ransac.py | 56 ++--\n> utils/raspberrypi/ctt/ctt_tools.py | 64 ++--\n> 12 files changed, 641 insertions(+), 610 deletions(-)\n>\n>\nReviewed-by: David Plowman \n\n(Can I reply just to this message to cover all 24 individual patches?\nThanks...!)\n\n\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n>","headers":{"Return-Path":"","Received":["from mail-oo1-xc30.google.com (mail-oo1-xc30.google.com\n\t[IPv6:2607:f8b0:4864:20::c30])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A047E60DE6\n\tfor ;\n\tWed, 13 May 2020 13:19:06 +0200 (CEST)","by mail-oo1-xc30.google.com with SMTP id a83so1560902oob.9\n\tfor ;\n\tWed, 13 May 2020 04:19:06 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"FK/Qxy8w\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=TJsHSY/CxD2MSbMl8jZo5ZP6TC0FevHNCY90zwFjZ7Y=;\n\tb=FK/Qxy8wi8cpkt/kXeqkazKJigpMDSgpdsMAW2q6LrPS5w+RU9bhCIvikZd2RydgZv\n\tKtNxtSR/Sa1vkHWVqxfjO7Ww1mMFgMk5AFcuHIZTQ/M82d4OSvksgV8qSDI6HSxh2Y3q\n\tnV9NF6F+03Xde1CGiidUWOAfksLOnChZ1i2jkGZzr7hoH0tqRVSs/CX3rqh8YRQtY7Oz\n\tMHGBEdXkR1izQYa+IUfWNZd7uCSxmQzB6ltV1AjriCCv9ZB2+yG3jNz1Fd1cLMsXDY4c\n\tQ3PDttC/4bFWyq0+mt7VAh7nw13CtVWONorJs911SKaM/5H7g+C7yA64wpFZYXVOmgOK\n\tKosQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=TJsHSY/CxD2MSbMl8jZo5ZP6TC0FevHNCY90zwFjZ7Y=;\n\tb=kaEwyoupzIPf6s8BQoD3nPRD0vwgCbQqjdp+c6p7vkqRumtZlRdbEvaQXJmlEngfn/\n\tUgsqM/Zya5hfm+x5k1Y8bN11+EyZF9Fkt0jXDCHWvFqONMTCoY+JUjBUMtJ/OM8B+Lor\n\tgS71L2NIUq35J7bvaRG/kF7/pGPqYQYSN02YtBektsfskRRz1uiCfYnRegOL9N1olUlm\n\t7kfWdYcvrz6nw0/n6/d5/lgrxkOU0Bzt/aVsLoYl+XS7eLoayp7un7lL4xLPl9L1Vk30\n\twlNWNAKH9xa+0cw0IRoJkPYEEAhIlQUlLd1NprYRF9hy0Su2WAxoYvqMwLNtlTunZbDZ\n\tZtmQ==","X-Gm-Message-State":"AGi0PuYLV3M4g35pKa6dcLGlRL53n2vzu9AhiubGrgqM0Us4wWp4h4H6\n\tFTXctmLsUo2Fc/dvAAMv0RNtq1lFIoBYo3YYad2ihw==","X-Google-Smtp-Source":"APiQypKHw94ZGis+NAT4peMtWjoNYE+pJ0eQZ0nHzmr1qL1VWXHz8cEds64BIaAg+3rWDRWD5YVW8HSxvmtV+0EGfyQ=","X-Received":"by 2002:a4a:cb0e:: with SMTP id\n\tr14mr18956222ooq.28.1589368745116; \n\tWed, 13 May 2020 04:19:05 -0700 (PDT)","MIME-Version":"1.0","References":"<20200512000322.11753-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20200512000322.11753-1-laurent.pinchart@ideasonboard.com>","From":"David Plowman ","Date":"Wed, 13 May 2020 12:18:55 +0100","Message-ID":"","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, \n\tNaushir Patuck ","Content-Type":"multipart/alternative; boundary=\"00000000000078606b05a585bfa4\"","Subject":"Re: [libcamera-devel] [PATCH 00/24] utils: raspberrypi: ctt: Comply\n\twith pycodestyle","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 13 May 2020 11:19:07 -0000"}},{"id":4815,"web_url":"https://patchwork.libcamera.org/comment/4815/","msgid":"<20200513140425.GH5945@pendragon.ideasonboard.com>","date":"2020-05-13T14:04:25","subject":"Re: [libcamera-devel] [PATCH 00/24] utils: raspberrypi: ctt: Comply\n\twith pycodestyle","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nOn Wed, May 13, 2020 at 12:18:55PM +0100, David Plowman wrote:\n> On Tue, 12 May 2020 at 01:03, Laurent Pinchart wrote:\n> > Hello,\n> >\n> > This patch series fixes most of the coding style issues reported by\n> > pycodestyle in the ctt tool. I've left out two remaining issues as they\n> > could be more controversial:\n> >\n> > - Spaces around operators (E226 and 227)\n> > - Usage of docstrings for comments (flagged by E302)\n> >\n> > I can easily fix them if desired.\n> >\n> > Laurent Pinchart (24):\n> > utils: raspberrypi: ctt: Fix pycodestyle E231\n> > utils: raspberrypi: ctt: Fix pycodestyle E201 and E202\n> > utils: raspberrypi: ctt: Fix pycodestyle E203\n> > utils: raspberrypi: ctt: Fix pycodestyle E241\n> > utils: raspberrypi: ctt: Fix pycodestyle E211\n> > utils: raspberrypi: ctt: Fix pycodestyle E251\n> > utils: raspberrypi: ctt: Fix pycodestyle E128\n> > utils: raspberrypi: ctt: Fix pycodestyle E225\n> > utils: raspberrypi: ctt: Fix pycodestyle E228\n> > utils: raspberrypi: ctt: Fix pycodestyle E701\n> > utils: raspberrypi: ctt: Fix pycodestyle E303\n> > utils: raspberrypi: ctt: Fix pycodestyle E261 and E262\n> > utils: raspberrypi: ctt: Fix pycodestyle W605\n> > utils: raspberrypi: ctt: Fix pycodestyle E222\n> > utils: raspberrypi: ctt: Fix pycodestyle E711 and E712\n> > utils: raspberrypi: ctt: Fix pycodestyle E123 and E126\n> > utils: raspberrypi: ctt: Fix pycodestyle E116 and E117\n> > utils: raspberrypi: ctt: Fix pycodestyle E713\n> > utils: raspberrypi: ctt: Fix pycodestyle E721\n> > utils: raspberrypi: ctt: Fix pycodestyle E722\n> > utils: raspberrypi: ctt: Fix pycodestyle W504\n> > utils: raspberrypi: ctt: Fix pycodestyle E741\n> > utils: raspberrypi: ctt: Fix pycodestyle E305\n> > utils: raspberrypi: ctt: Fix pycodestyle E302\n> >\n> > utils/raspberrypi/ctt/ctt.py | 257 ++++++++--------\n> > utils/raspberrypi/ctt/ctt_alsc.py | 146 ++++-----\n> > utils/raspberrypi/ctt/ctt_awb.py | 140 ++++-----\n> > utils/raspberrypi/ctt/ctt_ccm.py | 67 ++--\n> > utils/raspberrypi/ctt/ctt_geq.py | 50 +--\n> > utils/raspberrypi/ctt/ctt_image_load.py | 125 ++++----\n> > utils/raspberrypi/ctt/ctt_lux.py | 19 +-\n> > utils/raspberrypi/ctt/ctt_macbeth_locator.py | 288 +++++++++---------\n> > utils/raspberrypi/ctt/ctt_noise.py | 30 +-\n> > .../raspberrypi/ctt/ctt_pretty_print_json.py | 9 +-\n> > utils/raspberrypi/ctt/ctt_ransac.py | 56 ++--\n> > utils/raspberrypi/ctt/ctt_tools.py | 64 ++--\n> > 12 files changed, 641 insertions(+), 610 deletions(-)\n>\n> Reviewed-by: David Plowman \n> \n> (Can I reply just to this message to cover all 24 individual patches?\n> Thanks...!)\n\nAbsolutely :-)\n\nI've pushed all patches except for the one fixing W605, as I still need\nto address a comment from Kieran.","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 33517603DF\n\tfor ;\n\tWed, 13 May 2020 16:04:32 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A18ED51F;\n\tWed, 13 May 2020 16:04:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"rYzhgLu3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1589378671;\n\tbh=w5EiV7jsPktrjI05QkiHUTXq/dYkhzje0sjhxcu+7ok=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rYzhgLu3+CsG/aLv0RobFUz5wCwdpIilZztT4v2TDwfqXLFsoAyvMz316MpscOXCN\n\torbS/M+7DRt3ZeVnfWKt5T7GRqiiyY3Mr0wJX0VBav9Fz6PI3tBIb5rdaNipCjmB2C\n\tJiZlQtf1jAWp0+PQrkQfCq+xSl+sHY5j0g9p1yPk=","Date":"Wed, 13 May 2020 17:04:25 +0300","From":"Laurent Pinchart ","To":"David Plowman ","Cc":"libcamera-devel@lists.libcamera.org,\n\tNaushir Patuck ","Message-ID":"<20200513140425.GH5945@pendragon.ideasonboard.com>","References":"<20200512000322.11753-1-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 00/24] utils: raspberrypi: ctt: Comply\n\twith pycodestyle","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 13 May 2020 14:04:32 -0000"}}]