{"id":37,"url":"https://patchwork.libcamera.org/api/covers/37/?format=json","web_url":"https://patchwork.libcamera.org/cover/37/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<1544612976-27101-1-git-send-email-jacopo@jmondi.org>","date":"2018-12-12T11:09:34","name":"[libcamera-devel,v4,0/2] Documentation: coding style and style checker tool","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/cover/37/mbox/","series":[{"id":17,"url":"https://patchwork.libcamera.org/api/series/17/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=17","date":"2018-12-12T11:09:34","name":"Documentation: coding style and style checker tool","version":4,"mbox":"https://patchwork.libcamera.org/series/17/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/37/comments/","headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 32D9660A71\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 12 Dec 2018 12:09:54 +0100 (CET)","from w540.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id A23DE24001C;\n\tWed, 12 Dec 2018 11:09:53 +0000 (UTC)"],"From":"Jacopo Mondi <jacopo@jmondi.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 12 Dec 2018 12:09:34 +0100","Message-Id":"<1544612976-27101-1-git-send-email-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.7.4","Subject":"[libcamera-devel] [PATCH v4 0/2] Documentation: coding style and\n\tstyle checker tool","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Wed, 12 Dec 2018 11:09:54 -0000"},"content":"Hello,\n   this patch adds the 'coding style' section to the project's Documentation.\n\nAlong with the the documentation itself, the second patch adds an intial\nattempt to implement a style checker script, that uses astyle to validate the\nchanges as recorded in the topmost git commit. Also, add documentation on how\nto use the tool to the previously introduced coding-style.rst.\n\nThe script is in a -very- early stage, tested locally only, on\nGNU bash, version 4.3.48(1)-release.\n\nI expect a lot of false positive (good) and also a lot of false negatives (bad,\nas we don't see what the script has missed easily).\n\nIn future we might want to re-implement it in something saner than plain shell\nscripting, but for now please use it locally, and report errors as you see them.\n\nThanks\n   j\n\nJacopo Mondi (2):\n  Documentation: Add coding style document\n  Documentation: Add style checker tool\n\n Documentation/coding-style.rst | 125 ++++++++++++++++++++++++++++++++++++\n Documentation/index.rst        |   1 +\n Documentation/meson.build      |   1 +\n utils/checkstyle.sh            | 141 +++++++++++++++++++++++++++++++++++++++++\n 4 files changed, 268 insertions(+)\n create mode 100644 Documentation/coding-style.rst\n create mode 100755 utils/checkstyle.sh\n\n--\n2.7.4"}