[{"id":4694,"web_url":"https://patchwork.libcamera.org/comment/4694/","msgid":"<20200501105959.GA2479064@oden.dyn.berto.se>","date":"2020-05-01T10:59:59","subject":"Re: [libcamera-devel] [PATCH v3 0/6] {cam,\n\tqcam}: Unify stream option parsing","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi,\n\nI have now pushed this to master.\n\nOn 2020-05-01 04:34:26 +0200, Niklas Söderlund wrote:\n> Hi,\n> \n> Prepare for allowing multiple streams in qcam by unifying the cam and\n> qcam command line options parsing for stream options. With this RAW\n> capture support can be added to qcam without first redesigning the whole\n> GUI to allow for individual stream configuration.\n> \n> Also having the same options for cam and qcam to configure streams is a\n> good idea. As this series reveals some features where enabled in cam but\n> not in qcam.\n> \n> Niklas Söderlund (6):\n> cam: options: Make KeyValueParser::parse() virtual\n> cam: options: Add public method to invalidate options\n> cam: Add helper class to parse stream configuration\n> cam: Make use of StreamKeyValueParser\n> qcam: Make use of StreamKeyValueParser\n> qcam: Check that camera can generate configuration from roles\n> \n> src/cam/main.cpp | 68 ++-----------------\n> src/cam/meson.build | 1 +\n> src/cam/options.cpp | 6 ++\n> src/cam/options.h | 6 +-\n> src/cam/stream_options.cpp | 129 +++++++++++++++++++++++++++++++++++++\n> src/cam/stream_options.h | 32 +++++++++\n> src/qcam/main.cpp | 13 ++--\n> src/qcam/main_window.cpp | 41 +++++++-----\n> src/qcam/main_window.h | 4 +-\n> src/qcam/meson.build | 1 +\n> 10 files changed, 212 insertions(+), 89 deletions(-)\n> create mode 100644 src/cam/stream_options.cpp\n> create mode 100644 src/cam/stream_options.h\n> \n> -- \n> 2.26.2\n>","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E9872603F3\n\tfor ;\n\tFri, 1 May 2020 13:00:01 +0200 (CEST)","by mail-lj1-x243.google.com with SMTP id e25so2287990ljg.5\n\tfor ;\n\tFri, 01 May 2020 04:00:01 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tc2sm1776760ljk.97.2020.05.01.03.59.59\n\tfor \n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 01 May 2020 04:00:00 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com header.b=\"TTT9ZQRj\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=hSEscfOxq6Vf2rPC2mPQsNBTc0nlQY228pkekNjbKyE=;\n\tb=TTT9ZQRjrroQC7tzF+EaTn+9N+w7hj1FEfw3Ua119U1NNpGPh3rWrDzt7Ao0Vqo0Xu\n\tU4IgyC9Sz0ezhMNvt/Jdf0GZzVgo3ejn/AgU0/y4TwLTAFn/J55HpJpVy8CT2ovXJB/k\n\tj3Kv1iT4WwdgGXqGh9YlY77NJbWaeSMDT3C4Ms5zdx7WMKjG76ZDDV7qmlJzs+jv4dca\n\tv5wxxYvNkE96R6S0/RgxIJqJv8QUarnD4DabjdbAoF3LPkIscwX6j8AYwSiTxjrsGTnl\n\tOonlbmAlUKr3TGo0sKsg2v1K/ZK3gRpMNARK7l9cD765qg3xL3RDECD1n1gGEkwEayst\n\txIgw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=hSEscfOxq6Vf2rPC2mPQsNBTc0nlQY228pkekNjbKyE=;\n\tb=aw7Qe0UEvk3GxOTZVFGBuggV6X78R0/1wpOT5H9j1yhcpdb6q0tmISURRkOZAoz8jl\n\tTlzQWvtmc4zBU1CN78G5uolU4qGhVhxVKUA/jyvfaKj2FwJ90L+lv8LrzDYsrm+BgFkP\n\tm+Q88aQihRzjdr58/Zfh+QDUYCeY6H56R2x2Ueh1fuNd7dzHlSrs/lu39AZpVtgbyepy\n\tzxMvLlidSLZYSaq9uhwQxPz/FkOGHYy5Y95NoyZ/OciQkVVI/xENI92eF5GeB3L6T/3f\n\tL5l5MQ6mG3goClDMgfjljb5I6obdpL90LDPMaAlBg5JULWDTx5af/nDGFd8PuCfdsRHs\n\t0eZA==","X-Gm-Message-State":"AGi0PuaEiCpygozgUZj/4ofw6Pu6NHeIqwS2C19pYEOTHbB9850FwcZA\n\tut4m5JQYrSKMDR6y0jovPpdHvDml7yQ=","X-Google-Smtp-Source":"APiQypLkaU337PkD602wTtKuiJ/Febi4vKQy+Z8MOht9VEDKs8MVeFaf7NReE2M80hZV4qSfULSL/g==","X-Received":"by 2002:a2e:b1c9:: with SMTP id e9mr2206648lja.102.1588330800856;\n\tFri, 01 May 2020 04:00:00 -0700 (PDT)","Date":"Fri, 1 May 2020 12:59:59 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200501105959.GA2479064@oden.dyn.berto.se>","References":"<20200501023432.90032-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200501023432.90032-1-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v3 0/6] {cam,\n\tqcam}: Unify stream option parsing","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 01 May 2020 11:00:02 -0000"}}]