[{"id":4624,"web_url":"https://patchwork.libcamera.org/comment/4624/","msgid":"<20200428174507.GJ5859@pendragon.ideasonboard.com>","date":"2020-04-28T17:45:07","subject":"Re: [libcamera-devel] [PATCH v5 0/7] libcamera: Add CameraSensorInfo","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Tue, Apr 28, 2020 at 11:17:13AM +0200, Jacopo Mondi wrote:\n> Hello,\n> I intend to push this new version, rebased on the fast moving recent master,\n> as soon as the following patches on which this series depends on are merged:\n> \n> libcamera: camera_sensor: Add model() function\n> libcamera: v4l2_device: Simplify usage of getControls()\n> libcamera: controls: Return ControlValue reference from ControlList::set()\n> libcamera: controls: Add rectangle and size control types\n> \n> Laurent, as you're tha author, this:\n> libcamera: controls: Return ControlValue reference from ControlList::set()\n> is the only one that needs a small rework imho, all the rest is good to go.\n\nI've pushed \n\nlibcamera: v4l2_device: Simplify usage of getControls()\nlibcamera: controls: Add rectangle and size control types\n\nand I'm working on a new version of\n\nlibcamera: camera_sensor: Add model() function\n\nThe other patch (\"libcamera: controls: Return ControlValue reference\nfrom ControlList::set()\") isn't needed anymore.\n\n> Jacopo Mondi (7):\n> libcamera: v4l2_subdevice: Expose setSelection()\n> libcamera: v4l2_videodevice: Expose setSelection()\n> libcamera: v4l2_subdevice: Implement getSelection()\n> libcamera: camera_sensor: Define CameraSensorInfo\n> libcamera: v4l2_subdevice: Add format information\n> libcamera: camera_sensor: Add method to get sensor info\n> libcamera: ipa: Add support for CameraSensorInfo\n> \n> include/ipa/ipa_interface.h | 27 ++-\n> src/ipa/libipa/ipa_interface_wrapper.cpp | 19 +-\n> src/ipa/libipa/ipa_interface_wrapper.h | 1 +\n> src/ipa/rkisp1/rkisp1.cpp | 12 +-\n> src/ipa/vimc/vimc.cpp | 3 +-\n> src/libcamera/camera_sensor.cpp | 143 ++++++++++++++\n> src/libcamera/include/camera_sensor.h | 14 ++\n> src/libcamera/include/ipa_context_wrapper.h | 3 +-\n> src/libcamera/include/v4l2_subdevice.h | 11 +-\n> src/libcamera/include/v4l2_videodevice.h | 5 +-\n> src/libcamera/ipa_context_wrapper.cpp | 23 ++-\n> src/libcamera/ipa_interface.cpp | 73 +++++++\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 4 +-\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 10 +-\n> src/libcamera/proxy/ipa_proxy_linux.cpp | 3 +-\n> src/libcamera/proxy/ipa_proxy_thread.cpp | 8 +-\n> src/libcamera/v4l2_subdevice.cpp | 201 ++++++++++++++++----\n> src/libcamera/v4l2_videodevice.cpp | 20 +-\n> test/ipa/ipa_wrappers_test.cpp | 22 ++-\n> 19 files changed, 516 insertions(+), 86 deletions(-)","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DE5B960AF4\n\tfor ;\n\tTue, 28 Apr 2020 19:45:23 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5652772C;\n\tTue, 28 Apr 2020 19:45:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"JTujRz+x\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1588095923;\n\tbh=iELITT0szv5MBE/wpnLVWk+JcGPRkFIEJnYcsJGJR3I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=JTujRz+xOw+bKdiRFxK7bxGTtWQCtbHo9Atq79SVjlcifBElQukVLnidxl/iZPi/U\n\tcNjiuuVHdq8knpkfISZaahonwVt5Ky5tNyaJxQtRHhYqMR6MtBOkYmBra5xy5fAoTP\n\tL2pRkTvLXfevKLoFBDIZSDuggGi670RCZ57OV6qE=","Date":"Tue, 28 Apr 2020 20:45:07 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200428174507.GJ5859@pendragon.ideasonboard.com>","References":"<20200428091713.341322-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200428091713.341322-1-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v5 0/7] libcamera: Add CameraSensorInfo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 28 Apr 2020 17:45:24 -0000"}}]