[{"id":4483,"web_url":"https://patchwork.libcamera.org/comment/4483/","msgid":"<57bd6139-7616-981d-cd45-323706a96ae3@linaro.org>","date":"2020-04-21T21:18:59","subject":"Re: [libcamera-devel] [PATCH 0/2] Simple pipeline: skip broken\n\tpipeline configurations","submitter":{"id":25,"url":"https://patchwork.libcamera.org/api/people/25/","name":"Andrey Konovalov","email":"andrey.konovalov@linaro.org"},"content":"Forgot to mention that this series is to be applied on top of Simple pipeline handler,\nv4 patch set:\nhttps://lists.libcamera.org/pipermail/libcamera-devel/2020-April/007880.html\n\nThanks,\nAndrey\n\nOn 21.04.2020 23:39, Andrey Konovalov wrote:\n> When enumerating the possible pipeline configurations, SimpleCameraData::init()\n> doesn't check if the sink pad uses the same format as the source pad of the\n> same link does. This can result in broken pipeline configurations added to\n> the formats_ map, and if such a configuration is selected the issue reveals\n> late as a failure to start streaming.\n> \n> The first patch adds the check into SimpleCameraData::setupFormats() - now\n> it returns -EINVAL if a link is misconfigured.\n> \n> The second patch prevents the enumeration of the possible pipeline\n> configurations from being aborted on the first broken configuration\n> and proceeds with the next media bus code instead.\n> \n> Andrey Konovalov (2):\n> libcamera: pipeline: simple: make sure the formats at the link's pads\n> match\n> libcamera: pipeline: simple: try next mbus code if setupFormats()\n> fails\n> \n> src/libcamera/pipeline/simple/simple.cpp | 17 +++++++++++++++--\n> 1 file changed, 15 insertions(+), 2 deletions(-)\n>","headers":{"Return-Path":"","Received":["from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C5F2260406\n\tfor ;\n\tTue, 21 Apr 2020 23:19:02 +0200 (CEST)","by mail-lf1-x144.google.com with SMTP id h6so12331239lfc.0\n\tfor ;\n\tTue, 21 Apr 2020 14:19:02 -0700 (PDT)","from [192.168.118.216] (37-144-159-139.broadband.corbina.ru.\n\t[37.144.159.139]) by smtp.gmail.com with ESMTPSA id\n\ti18sm2994419lfo.57.2020.04.21.14.19.00\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tTue, 21 Apr 2020 14:19:01 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=linaro.org\n\theader.i=@linaro.org header.b=\"a+uWY6AT\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=EmJbm7VCNxhhb9OcHJg/qliopSea/cRLi8IVIjstLcs=;\n\tb=a+uWY6ATT25zeMMpfBuiARzktVkGarYZjdd6yINCcb0xE2T2t+0RJrHZaH78VHUnzC\n\tQGujgRzR+4LzWpalex+Ptwt2BSiVD/sx3baCevUDpMSPXc0yWoi04lIMi5mGOZgiSsuj\n\tV6o6G87eNigfngorbGB/ZeVSIbUg45vGAl8CFcTC20jIMZY+KTOdzIVHMQ3pIMNvWzd6\n\tJqL9uMNFwFFcCPYi3+BSK0J5uL+XJPEnnLjXnKBwjsHwpdSYXb/2IQ6wqVd2dobbnQm1\n\t5JLKmdWObvJmtA1NtkmAFlNBssQLOj9dGr5hstgq3QS0rgS4EVxtxLoyDgeIcbQdOiEk\n\tvmMA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=EmJbm7VCNxhhb9OcHJg/qliopSea/cRLi8IVIjstLcs=;\n\tb=mPwR9Dz/oaVM/btGGPzbHvmf+pYjxPSGr/c+wIYBHlAjrz8WLIjMGxTW0VEV9NdwwY\n\ttfNMFwLDAUPWmEPq0x+aPvgEnsPs8KMXV+6p839IS1VXryym2mI/dfqkYJR67+cc1P4b\n\t81dhANV22tMbDuTBrczUaeHlf2+6sWHLeLUjcvbyqGEGtIl8ZyL3SxSvLhAis+us3mBk\n\tvVo8spV9iUx3dMRctAy6fuCJOPg12IiOw6rJfZ7Q9FYHZc7hpKznwEdhiDzKvba7QXJJ\n\tjiqNh6pMOXXSvG7+xT+SXDrH2N2KVxhRGJYZIZGj/JQFQo0y3JSYHRpIs5jDgaLaRIjg\n\thb7A==","X-Gm-Message-State":"AGi0Pub+6rAwJRLeNfnT5NtmdEd8uw8z1pDx1bxuo0WPx/j8VCH93IfS\n\tEZn1W2UqcNefLozpdeE8g/yRF1ajxok=","X-Google-Smtp-Source":"APiQypJe7ni7qVkJvgv2/Wk/6vDep2VNladg44/8EVYVS0+lLlCSBPA6LCGVXYTXQcnwW7EazpMIjw==","X-Received":"by 2002:a05:6512:10c9:: with SMTP id\n\tk9mr14943774lfg.183.1587503942071; \n\tTue, 21 Apr 2020 14:19:02 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","References":"<20200421203954.15585-1-andrey.konovalov@linaro.org>","From":"Andrey Konovalov ","Message-ID":"<57bd6139-7616-981d-cd45-323706a96ae3@linaro.org>","Date":"Wed, 22 Apr 2020 00:18:59 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.7.0","MIME-Version":"1.0","In-Reply-To":"<20200421203954.15585-1-andrey.konovalov@linaro.org>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 0/2] Simple pipeline: skip broken\n\tpipeline configurations","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 21 Apr 2020 21:19:03 -0000"}}]