[{"id":4161,"web_url":"https://patchwork.libcamera.org/comment/4161/","msgid":"<20200321102634.pivlmc534fuvbfwi@uno.localdomain>","date":"2020-03-21T10:26:34","subject":"Re: [libcamera-devel] [PATCH v2 0/7] Add support for V4L2 array\n\tcontrols","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n thanks for the review and for v2\n\nOn Sat, Mar 21, 2020 at 02:36:33AM +0200, Laurent Pinchart wrote:\n> Hello,\n>\n> This is the second version of Jacopo's \"[PATCH 00/11] Adda support for\n> V4L2 array control and strings\". Support for string controls has since\n> then been merged, so the series now focusses solely on V4L2 array\n> controls.\n>\n> Compared to v1, a patch has been added to introduce a zero-copy set API\n> for ControlValue (1/7). Subsequent patches have been adapted to use this\n> new API, and review comments on v1 have been addressed. Please see\n> individual patches for details.\n\nYou've heard my initial skepticism for such a potentially disruptive\nAPI, but the final result is -so much- better I'm now sold.\n\nTest looks much better as well, so please have my\nReviewed-by: Jacopo Mondi \nfor the series and feel free to push!\n\nThanks\n j\n\n>\n> The series is based on the latest master branch.\n>\n> Jacopo Mondi (6):\n> libcamera: v4l2_controls: Cache query control information\n> libcamera: v4l2_device: Support writing array U8 controls\n> libcamera: v4l2_device: Support reading U8 array controls\n> libcamera: v4l2_controls: Support U8 array controls\n> libcamera: v4l2_device: Enable enumeration of U8 controls\n> test: v4l2_videodevice: Test U8 array controls\n>\n> Laurent Pinchart (1):\n> libcamera: controls: Add zero-copy set API for ControlValue\n>\n> include/libcamera/controls.h | 4 ++\n> src/libcamera/control_serializer.cpp | 61 ++----------------\n> src/libcamera/controls.cpp | 54 ++++++++++++----\n> src/libcamera/include/control_serializer.h | 3 -\n> src/libcamera/include/v4l2_device.h | 1 +\n> src/libcamera/v4l2_controls.cpp | 9 +++\n> src/libcamera/v4l2_device.cpp | 75 +++++++++++++++++-----\n> test/v4l2_videodevice/controls.cpp | 30 ++++++++-\n> 8 files changed, 148 insertions(+), 89 deletions(-)\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","Received":["from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D9DF560414\n\tfor ;\n\tSat, 21 Mar 2020 11:23:37 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 4D85A200007;\n\tSat, 21 Mar 2020 10:23:37 +0000 (UTC)"],"Date":"Sat, 21 Mar 2020 11:26:34 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200321102634.pivlmc534fuvbfwi@uno.localdomain>","References":"<20200321003640.2156-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200321003640.2156-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 0/7] Add support for V4L2 array\n\tcontrols","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 21 Mar 2020 10:23:38 -0000"}}]