{"id":3208,"url":"https://patchwork.libcamera.org/api/covers/3208/?format=json","web_url":"https://patchwork.libcamera.org/cover/3208/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200320014839.14683-1-laurent.pinchart@ideasonboard.com>","date":"2020-03-20T01:48:28","name":"[libcamera-devel,v3,00/11] Simple pipeline handler","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/3208/mbox/","series":[{"id":749,"url":"https://patchwork.libcamera.org/api/series/749/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=749","date":"2020-03-20T01:48:28","name":"Simple pipeline handler","version":3,"mbox":"https://patchwork.libcamera.org/series/749/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/3208/comments/","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8EF2760418\n\tfor ;\n\tFri, 20 Mar 2020 02:48:51 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DC824504;\n\tFri, 20 Mar 2020 02:48:50 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584668931;\n\tbh=LE/mMqHicUbR6RW7xvCfwE1o5s8TmhqMf7S2dXmlcLM=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=IWDwzZVeLYQNIdNG7pVBdbTixhwbnPxbJePiwdh+6emGJqzmhglW6Sl6eQ0q+Aonz\n\th/J91ne2q41Kfj9p4SepLJUuO6bKOcLIvyc2KyqWEElnViMVoLkKcbda5PNzSz+qP/\n\tdUHljeLJ2C9JJTBvB6UqURX2eDQF1b4gGLxAqhiI=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"Martijn Braam ,\n\tBenjamin GAIGNARD ,\n\tAndrey Konovalov ","Date":"Fri, 20 Mar 2020 03:48:28 +0200","Message-Id":"<20200320014839.14683-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 00/11] Simple pipeline handler","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 20 Mar 2020 01:48:51 -0000"},"content":"Hello,\n\nThis patch series builds on Martijn's work to implement a pipeline\nhandler for simpler pipelines. Additional information about the pipeline\nhandler itself can be found in patch 09/11.\n\nCompared to v2, this version has been rebased on top of master to\ninclude the V4L2PixelFormat class, and incorporates the review comments\nreceived so far. It also fixes a crash in the pipeline handler when the\ndriver entry has no converter, and updated the VIDIOC_ENUM_FMT extension\nto the latest version posted to the linux-media mailing list.\n\nPatch 01/11 adds a V4L2 API extension required for pipeline\nauto-configuration, and patches 02/11 to 08/11 add a new utlity function\nand miscellaneous small extensions.\n\nPatch 09/11 adds the new simple pipeline handler, patch 10/11 the\nsimpler converter, and patch 11/11 integrates converter support into the\nsimple pipeline handler. The converter API hasn't changed and should\nstill be improved, it's currently a proof of concept. Other options also\nexist, such as making the simple pipeline handler a base class from\nwhich more specialized pipeline handlers could derive from, and\nimplement support for converters in device-specific code.\n\nThe code has been tested on an i.MX7 platform with a greyscale sensor\nand the i.MX PXP as format converter to produce RGB. I've kept sun6i-csi\nfrom Martijn's work in the list of supported drivers, but supporting\nthat platform will require extending the corresponding driver to support\nthe VIDIOC_ENUM_FMT extension. Once done, if all goes well, the platform\nshould work out of the box.\n\nAs before, this is meant to be compatible with the stm32 and qcom-camss\nthat pipeline handlers have previously been submitted for, although for\nqcom-camss the pipeline configuration is a bit more complex, and the\nbest strategy to move forward remains to be decided. The respective\ndrivers need be added to the drivers array in\nSimplePipelineHandler::match(), and, as for sun6i-csi, support for the\nVIDIOC_ENUM_FMT extension needs to be implemented in the drivers, which\nshould be fairly easy.\n\nLaurent Pinchart (10):\n [DNI] include: linux: Extend VIDIOC_ENUM_FMT to support MC-centric\n devices\n libcamera: utils: Add string join function\n libcamera: v4l2_subdevice: Extend [gs]etFormat() to specify format\n type\n libcamera: v4l2_subdevice: Don't use doxygen \\ref needlessly\n libcamera: v4l2_videodevice: Support filtering formats by media bus\n code\n libcamera: v4l2_videodevice: Expose the device capabilities\n libcamera: v4l2_videodevice: Downgrade 4CC conversion errors to\n warnings\n libcamera: v4l2_videodevice: Map V4L2_PIX_FMT_GREY to DRM FourCC\n libcamera: pipeline: simple: Add simple format converter\n libcamera: pipeline: simple: Integrate converter support\n\nMartijn Braam (1):\n libcamera: pipeline: Add a simple pipeline handler\n\n include/linux/videodev2.h | 5 +-\n src/libcamera/include/utils.h | 44 +\n src/libcamera/include/v4l2_subdevice.h | 11 +-\n src/libcamera/include/v4l2_videodevice.h | 6 +-\n src/libcamera/pipeline/meson.build | 1 +\n src/libcamera/pipeline/simple/converter.cpp | 209 +++++\n src/libcamera/pipeline/simple/converter.h | 60 ++\n src/libcamera/pipeline/simple/meson.build | 4 +\n src/libcamera/pipeline/simple/simple.cpp | 870 ++++++++++++++++++++\n src/libcamera/utils.cpp | 16 +\n src/libcamera/v4l2_subdevice.cpp | 28 +-\n src/libcamera/v4l2_videodevice.cpp | 36 +-\n test/utils.cpp | 7 +-\n 13 files changed, 1279 insertions(+), 18 deletions(-)\n create mode 100644 src/libcamera/pipeline/simple/converter.cpp\n create mode 100644 src/libcamera/pipeline/simple/converter.h\n create mode 100644 src/libcamera/pipeline/simple/meson.build\n create mode 100644 src/libcamera/pipeline/simple/simple.cpp"}