[{"id":4062,"web_url":"https://patchwork.libcamera.org/comment/4062/","msgid":"<3f71a0f2-658d-8348-ae2e-1187548f147c@ideasonboard.com>","date":"2020-03-17T20:44:05","subject":"Re: [libcamera-devel] [PATCH LIBCAMERA 0/4] libcamera: determine\n\tIPA_PROXY_PATH at runtime","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Kaaira,\n\nThank you for these patches - they're a good start.\n\nThe most common issue in my review was just whitespace topics, which is\njust a style thing. You could skim read\n\n https://www.libcamera.org/coding-style.html#coding-style-guidelines\n\nBut installing clang-format and using the pre-commit hook will\nautomatically identify style topics for the most part for you.\n\nThe only other topic that came up is that I hadn't realised (or had\nforgotten) that we need to move the static helpers isLibcameraInstalled\nand libcameraPath out to be re-usable helpers in the utils module.\n\nI'm sorry - it would have been easier if I'd mentioned that first :-(\n\nCould you do that move as a separate patch please?\n\nOtherwise, it's looking good - and solves the issue!\n\nThanks\n\nKieran\n\n\nOn 17/03/2020 17:31, Kaaira Gupta wrote:\n> This is a series of patches to determine IPA_PROXY_PATH at runtime and\n> removing hard-coded LIBCAMERA_IPA_PROXY_PATH from test.cpp\n> \n> Kaaira Gupta (4):\n> libcamera: ipa_proxy: use utils::split()\n> libcamera: ipa_proxy: rearrange proxies precedence\n> libcamera: ipa_proxy: search for proxy in build tree\n> tests: remove IPA_PROXY_PATH environment variable\n> \n> src/libcamera/ipa_proxy.cpp | 72 ++++++++++++++++++++++++++++---------\n> test/libtest/test.cpp | 4 ---\n> 2 files changed, 55 insertions(+), 21 deletions(-)\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2907762923\n\tfor ;\n\tTue, 17 Mar 2020 21:44:09 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 54ED2F9;\n\tTue, 17 Mar 2020 21:44:08 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584477848;\n\tbh=2hcStLA4UITzXng/GhqYpGSK81M5Y0RRymiuWffRBC4=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=MsUvFTYmiKTJrCh8o0JYWmDu9JxLymKqrJcNiPVTE828cLoqg3g8oXRCI68Eks5zM\n\tkjQH0awEMYYigbunqZUMpP73BmSSQQEuK0lADcEUStxJZlwb0qd979cbrjnyqqQEUQ\n\tt1wAKtVUD6DUJx/v2gkglfsXeAPGrzhXT5Kp3Etc=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Kaaira Gupta , libcamera-devel@lists.libcamera.org,\n\tHelen Koike ,\n\tVaishali Thakkar ","References":"<20200317173145.18226-1-kgupta@es.iitr.ac.in>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<3f71a0f2-658d-8348-ae2e-1187548f147c@ideasonboard.com>","Date":"Tue, 17 Mar 2020 20:44:05 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200317173145.18226-1-kgupta@es.iitr.ac.in>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH LIBCAMERA 0/4] libcamera: determine\n\tIPA_PROXY_PATH at runtime","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 17 Mar 2020 20:44:09 -0000"}},{"id":4065,"web_url":"https://patchwork.libcamera.org/comment/4065/","msgid":"<20200317213908.GA27666@kaaira-HP-Pavilion-Notebook>","date":"2020-03-17T21:39:08","subject":"Re: [libcamera-devel] [PATCH LIBCAMERA 0/4] libcamera: determine\n\tIPA_PROXY_PATH at runtime","submitter":{"id":39,"url":"https://patchwork.libcamera.org/api/people/39/","name":"Kaaira Gupta","email":"kgupta@es.iitr.ac.in"},"content":"On Tue, Mar 17, 2020 at 08:44:05PM +0000, Kieran Bingham wrote:\n> Hi Kaaira,\n> \n> Thank you for these patches - they're a good start.\n\nThanks :D\n\n> \n> The most common issue in my review was just whitespace topics, which is\n> just a style thing. You could skim read\n\nI'll fix them up\n\n> \n> https://www.libcamera.org/coding-style.html#coding-style-guidelines\n> \n> But installing clang-format and using the pre-commit hook will\n> automatically identify style topics for the most part for you.\n> \n> The only other topic that came up is that I hadn't realised (or had\n> forgotten) that we need to move the static helpers isLibcameraInstalled\n> and libcameraPath out to be re-usable helpers in the utils module.\n> \n> I'm sorry - it would have been easier if I'd mentioned that first :-(\n> \n> Could you do that move as a separate patch please?\n\nYes, sure. I'll just send that as patch 3 of this series.\n\n> \n> Otherwise, it's looking good - and solves the issue!\n> \n> Thanks\n> \n> Kieran\n> \n> \n> On 17/03/2020 17:31, Kaaira Gupta wrote:\n> > This is a series of patches to determine IPA_PROXY_PATH at runtime and\n> > removing hard-coded LIBCAMERA_IPA_PROXY_PATH from test.cpp\n> > \n> > Kaaira Gupta (4):\n> > libcamera: ipa_proxy: use utils::split()\n> > libcamera: ipa_proxy: rearrange proxies precedence\n> > libcamera: ipa_proxy: search for proxy in build tree\n> > tests: remove IPA_PROXY_PATH environment variable\n> > \n> > src/libcamera/ipa_proxy.cpp | 72 ++++++++++++++++++++++++++++---------\n> > test/libtest/test.cpp | 4 ---\n> > 2 files changed, 55 insertions(+), 21 deletions(-)\n> > \n> \n> -- \n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","Received":["from mail-pl1-x643.google.com (mail-pl1-x643.google.com\n\t[IPv6:2607:f8b0:4864:20::643])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D8EE762923\n\tfor ;\n\tTue, 17 Mar 2020 22:39:17 +0100 (CET)","by mail-pl1-x643.google.com with SMTP id a23so10210589plm.1\n\tfor ;\n\tTue, 17 Mar 2020 14:39:17 -0700 (PDT)","from kaaira-HP-Pavilion-Notebook ([103.113.213.153])\n\tby smtp.gmail.com with ESMTPSA id\n\tm12sm301701pjf.25.2020.03.17.14.39.12\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 17 Mar 2020 14:39:14 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=es-iitr-ac-in.20150623.gappssmtp.com; s=20150623;\n\th=from:date:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=hUSxw21lLmh0PozDHf15b/XFjYcftqdh6xbT6VarVJU=;\n\tb=VNXu/3DA/qBMLHY1AT7iHcD/bLS7lYhwKeHR+kVjMSzoNz64sDJN9856dnFPmjAm2g\n\tOg3nJ1gwh8P/fRTRPOeWOiRcLbmnEaM3kM56TGgkbAEeXPMBgEdTbsHIeV6ZrK4FCBJW\n\ttiACy1gfzEwPL7AHZv/XU20AcvvKxafLD3NhUPxoFdAsCDUnnSlV5xL5lPTECS9lZmSh\n\tsVAJEiSc94dQoWc2TenXBmMzp51BGc4oYdJK0XsBzBwCTk5M9C2PZ3BCaxKgHTbtPyey\n\tRf1vtbu6F4s6nLBVK3raecFnvaHen94LwqCMl81uZEO4dfyt7GmWvf4z8LLA/pT1Btmu\n\tGH2Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:date:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=hUSxw21lLmh0PozDHf15b/XFjYcftqdh6xbT6VarVJU=;\n\tb=nrqO71MrE4Nl//LL/KV8PT6qjtJU9Y1JkuAW+UIKRKzo3hEGcfCQ7UtoiY6IjuR+Vy\n\tL2NgyWN8ji0neX6ZFm4TWW+crh9sEWaXS92OK51mHG5KiYD3AQj3BWdezLpJgrSNsjop\n\tK0MYHxSPgZdooplBXKxrWfqWV+DR3s5Rio5yck0X4t/xe0HrGmuk2WoklDthZc9+rwvv\n\toofon90MP1esf4tSt1lDFJqRl6PAg+DlSA6AI6V5J1kKrQc/znyJNpnWu0XT+GE340Ie\n\toUbxFN1JQOtYjnRMUacVRTdecsd9KfzUK23gEwkiPQmUD5XmqGRANcAvuLBMafxWRkoR\n\tZ9/w==","X-Gm-Message-State":"ANhLgQ2IJ5jzMms79hjQa7iJ1F5xM5iAlcRDDZdNZFmwnVa+Z6Osn2iV\n\tBySp0wssPfVT31gTb1LsM9vHAA==","X-Google-Smtp-Source":"ADFU+vv3+IrWxvfXtSsfvJylIIuOcrdIVMy2slGz5tagSrZhSgGGz3LqzuR7XMjU9JnSTLgCl8sAtA==","X-Received":"by 2002:a17:90a:8d81:: with SMTP id\n\td1mr1264137pjo.63.1584481155339; \n\tTue, 17 Mar 2020 14:39:15 -0700 (PDT)","From":"Kaaira Gupta ","X-Google-Original-From":"Kaaira Gupta ","Date":"Wed, 18 Mar 2020 03:09:08 +0530","To":"Kieran Bingham ","Cc":"Kaaira Gupta , libcamera-devel@lists.libcamera.org,\n\tHelen Koike ,\n\tVaishali Thakkar ","Message-ID":"<20200317213908.GA27666@kaaira-HP-Pavilion-Notebook>","References":"<20200317173145.18226-1-kgupta@es.iitr.ac.in>\n\t<3f71a0f2-658d-8348-ae2e-1187548f147c@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<3f71a0f2-658d-8348-ae2e-1187548f147c@ideasonboard.com>","User-Agent":"Mutt/1.9.4 (2018-02-28)","Subject":"Re: [libcamera-devel] [PATCH LIBCAMERA 0/4] libcamera: determine\n\tIPA_PROXY_PATH at runtime","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 17 Mar 2020 21:39:20 -0000"}}]