[{"id":3966,"web_url":"https://patchwork.libcamera.org/comment/3966/","msgid":"<20200306165639.GF1791497@oden.dyn.berto.se>","date":"2020-03-06T16:56:39","subject":"Re: [libcamera-devel] [PATCH v4 0/7] libcamera: V4L2BufferCache:\n\tImprove cache eviction strategy","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi,\n\nI have now pushed this series to master.\n\nOn 2020-03-05 21:38:01 +0100, Niklas Söderlund wrote:\n> Hello,\n> \n> This series improves the function of the V4L2BufferCache and how\n> it selects which cache entries to evict. This solves a real issue where\n> if the cache is not pre-allocated the cache can perform suboptimally and\n> not utilise all the entries in the cache.\n> \n> Patch 1/7 fix an error in the test class BufferSource found as code in\n> v1 of this series was based on it. 2/7 Extracts the BufferSource from\n> the camera buffer import test so it can be used in the new test\n> for the V4L2BufferCache. Patch 3/7, 4/7 and 5/7 fix small issues with\n> the V4L2BufferCache pointed out in review of v2. Patch 6/7 add tests\n> which breaks without the improved cache eviction strategy introduced in\n> 7/7.\n> \n> Niklas Söderlund (7):\n> test: camera: buffer_import: Fix error messages\n> test: Extract BufferSource class out of camera tests to libtest\n> libcamera: V4L2BufferCache: Mark Entry::operator==() as const\n> libcamera: V4L2BufferCache: Use the entry reference\n> libcamera: V4L2BufferCache: Check for hot hit first\n> test: v4l2_videodevice: Add test for V4L2BufferCache\n> libcamera: V4L2BufferCache: Improve cache eviction strategy\n> \n> src/libcamera/include/v4l2_videodevice.h | 9 +-\n> src/libcamera/v4l2_videodevice.cpp | 31 ++--\n> test/camera/buffer_import.cpp | 92 +---------\n> test/libtest/buffer_source.cpp | 98 +++++++++++\n> test/libtest/buffer_source.h | 32 ++++\n> test/libtest/meson.build | 11 +-\n> test/v4l2_videodevice/buffer_cache.cpp | 215 +++++++++++++++++++++++\n> test/v4l2_videodevice/meson.build | 1 +\n> 8 files changed, 379 insertions(+), 110 deletions(-)\n> create mode 100644 test/libtest/buffer_source.cpp\n> create mode 100644 test/libtest/buffer_source.h\n> create mode 100644 test/v4l2_videodevice/buffer_cache.cpp\n> \n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED9EE60424\n\tfor ;\n\tFri, 6 Mar 2020 17:56:42 +0100 (CET)","by mail-lj1-x242.google.com with SMTP id 19so108343ljj.7\n\tfor ;\n\tFri, 06 Mar 2020 08:56:42 -0800 (PST)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\tf10sm4252619ljn.44.2020.03.06.08.56.40\n\tfor \n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 06 Mar 2020 08:56:40 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=ydLkSivNBS4mN6xaoNA3S8DE+8Ouaeb6Ew9W9CVk11w=;\n\tb=R57FnC/0Ve3ZoEqGzeKz7fAo/DjtUlrJ/MVChUHzjo/2SyQNQvN8Q3PxOcqDkYn8Rj\n\tsyeqTttZqxIhjs39MNY4JVMFIsktUTKojTu83J5Bk9WkUz7kqVHfZTvmlckag7F5nsCB\n\t6qvE7ysJkyuXrmdpnMBafkCbSWTU0+G9Fq0ZxvaB4QERqXuMf4ctYxgEvoYj2DkwkLGh\n\ta4HCEsTH5MP0IMZfyV6rjxudxI+2rWIQR4DToGLLVqxCvbRbxKeYU4MoUDgCPRLpSGlo\n\tXVJh8oDPBJhNdCoEEHGvWHplyudRc/GkVqIJ4biARMbPQqQ7T6PnkY4WNo/z111m+PMO\n\tLtDw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=ydLkSivNBS4mN6xaoNA3S8DE+8Ouaeb6Ew9W9CVk11w=;\n\tb=hPofQfP0C0hpSce8zzcps31gs+i/34fcxr+5Plt0ls3TyB5xyF7YmTGYdqxZtVBhN8\n\tQS1yx3Vq78mYOV/9MEazUepqNx8giaPMX/Y/i77sNO8BUa86AYAHk1YD62JOjMQnPjW3\n\tR/Y7EHO4IvXaANz9ekrRZQ9NaTH13Bpxqe/ozamCltdU9ZVw/DAdlPaydYXr5uVX1lAp\n\tp39NLs77s1mkfC4GXVqw0PT/S/nSUocpgjuYH0uI03k8OBMiyC1+zaFonrNi70lZgc1v\n\tAHunSWoUz7iM7MrG6zavTPJi5TBC95/qpPUqGsLlfU8b2f3eccSq1+iHt7i0I0wl496z\n\tVneg==","X-Gm-Message-State":"ANhLgQ0Yu0yl6lMOjAiHflWZPjU126ssW01IDJAG5KPOZGYih4/t2li3\n\t45GYc+Rbtl8+67kgb59zxTryI/3s+SQ=","X-Google-Smtp-Source":"ADFU+vuGaBSSYvLAy/OSw2ycmfeC9r4cAiiaaqshbDvL6VvYH74VeBrnLPDnjNgwPwoYnJryYn0ABg==","X-Received":"by 2002:a2e:b04b:: with SMTP id\n\td11mr2655222ljl.267.1583513801393; \n\tFri, 06 Mar 2020 08:56:41 -0800 (PST)","Date":"Fri, 6 Mar 2020 17:56:39 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200306165639.GF1791497@oden.dyn.berto.se>","References":"<20200305203808.536050-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200305203808.536050-1-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v4 0/7] libcamera: V4L2BufferCache:\n\tImprove cache eviction strategy","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 06 Mar 2020 16:56:43 -0000"}}]