[{"id":3883,"web_url":"https://patchwork.libcamera.org/comment/3883/","msgid":"<20200229152831.GC18738@pendragon.ideasonboard.com>","date":"2020-02-29T15:28:31","subject":"Re: [libcamera-devel] [PATCH 0/2] rkisp1: don't enable immutable\n\tlink","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Helen,\n\n(CC'ing Niklas)\n\nOn Wed, Feb 26, 2020 at 11:59:59PM -0300, Helen Koike wrote:\n> The following patch was merged in the Linux kernel media tree:\n> 3eed7385bff6 (\"media: staging: media: rkisp1: make links immutable by default\")\n> \n> Which causes the topology configuration in libcamera to fail, since it tries to\n> enable immutable links.\n> \n> This patchset fixes the rkisp1-capture.sh scrips and the pipeline\n> handler.\n> \n> Question: I was wondering how releases are being mananged by libcamera.\n> Does this patchset needs to wait for the patch mentioned above to reach\n> mainline kernel?\n\nShort answer: we don't have a release process yet :-) Longer term our\nbaseline for merging code in libcamera is having corresponding support\nin mainline. For drivers not in staging, userspace API breakages are not\nallowed, so we'd need to consider that for kernel changes. For drivers\nin staging I think waiting for the change to appear in a release would\nbe nice for end-users.\n\nI think we'll need to care about backward compatibility, and handle that\nin libcamera. This may actually make it easier to change the kernel\nuserspace API in a non backward-compatible way. For this specific\nchange, enabling an immutable link should be a no-op, right ? We would\nthen likely keep the code in libcamera, maybe with a comment explaining\nthe issue, and with a scheduled removal data.\n\nAs we have no release yet, I think we can just merge the changes\nalready. Niklas, any opinion ? Can you handle this ?\n\n> Helen Koike (2):\n> utils: rkisp1: don't enable immutable link\n> libcamera: pipeline: rkisp1: don't enable immutable link\n> \n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 8 --------\n> utils/rkisp1/rkisp1-capture.sh | 1 -\n> 2 files changed, 9 deletions(-)","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EFB7D62689\n\tfor ;\n\tSat, 29 Feb 2020 16:28:54 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5FD9433E;\n\tSat, 29 Feb 2020 16:28:54 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1582990134;\n\tbh=tWYy0b0biiX4usGr9tM52AzsJFi2VUhMHS9HZqSXTSA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=R74bGve3PBLzJbcurmezf+Y524nWrs92vJ0BvKHhIh1wz53TdMbut8FFN3fUNszI+\n\ti/akS3GEi+0ffVZ3Y3vGbwhFcygkyW2Ohc4Sqhci+U9fS0yud+CjyS8s+maqz9OdTK\n\tNv4JSV17NNMToljPq1cli7qgdRo9io8Gq/8Y5rko=","Date":"Sat, 29 Feb 2020 17:28:31 +0200","From":"Laurent Pinchart ","To":"Helen Koike ","Cc":"libcamera-devel@lists.libcamera.org, kernel@collabora.com, Niklas\n\t=?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200229152831.GC18738@pendragon.ideasonboard.com>","References":"<20200227030001.333291-1-helen.koike@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200227030001.333291-1-helen.koike@collabora.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 0/2] rkisp1: don't enable immutable\n\tlink","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 29 Feb 2020 15:28:55 -0000"}},{"id":4061,"web_url":"https://patchwork.libcamera.org/comment/4061/","msgid":"<20200317203730.GA2754491@oden.dyn.berto.se>","date":"2020-03-17T20:37:30","subject":"Re: [libcamera-devel] [PATCH 0/2] rkisp1: don't enable immutable\n\tlink","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hello,\n\nSorry for the very late reply, I had completely missed this thread.\n\nOn 2020-02-29 17:28:31 +0200, Laurent Pinchart wrote:\n> Hi Helen,\n> \n> (CC'ing Niklas)\n> \n> On Wed, Feb 26, 2020 at 11:59:59PM -0300, Helen Koike wrote:\n> > The following patch was merged in the Linux kernel media tree:\n> > 3eed7385bff6 (\"media: staging: media: rkisp1: make links immutable by default\")\n> > \n> > Which causes the topology configuration in libcamera to fail, since it tries to\n> > enable immutable links.\n> > \n> > This patchset fixes the rkisp1-capture.sh scrips and the pipeline\n> > handler.\n> > \n> > Question: I was wondering how releases are being mananged by libcamera.\n> > Does this patchset needs to wait for the patch mentioned above to reach\n> > mainline kernel?\n> \n> Short answer: we don't have a release process yet :-) Longer term our\n> baseline for merging code in libcamera is having corresponding support\n> in mainline. For drivers not in staging, userspace API breakages are not\n> allowed, so we'd need to consider that for kernel changes. For drivers\n> in staging I think waiting for the change to appear in a release would\n> be nice for end-users.\n> \n> I think we'll need to care about backward compatibility, and handle that\n> in libcamera. This may actually make it easier to change the kernel\n> userspace API in a non backward-compatible way. For this specific\n> change, enabling an immutable link should be a no-op, right ? We would\n> then likely keep the code in libcamera, maybe with a comment explaining\n> the issue, and with a scheduled removal data.\n> \n> As we have no release yet, I think we can just merge the changes\n> already. Niklas, any opinion ? Can you handle this ?\n\nI think we only need to start to _really_ care about backwards \ncompatibility once we have a release. So think we should merge this \nseries.\n\nI can handle this. I will test the latest media tree with this series \nand if everything works as it should I will merge it. Unfortunately I'm \nquiet swamped at the moment so will probably be at the end of the week.\n\n> \n> > Helen Koike (2):\n> > utils: rkisp1: don't enable immutable link\n> > libcamera: pipeline: rkisp1: don't enable immutable link\n> > \n> > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 8 --------\n> > utils/rkisp1/rkisp1-capture.sh | 1 -\n> > 2 files changed, 9 deletions(-)\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DB98962923\n\tfor ;\n\tTue, 17 Mar 2020 21:37:32 +0100 (CET)","by mail-lf1-x142.google.com with SMTP id t21so18419175lfe.9\n\tfor ;\n\tTue, 17 Mar 2020 13:37:32 -0700 (PDT)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\tz21sm3146239ljz.49.2020.03.17.13.37.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 17 Mar 2020 13:37:30 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=SrdOHAhVn50aQMf1NeiMS0IvxCFcge18sAYi03T3Auo=;\n\tb=y6JASyU5jjcaNTF21MpPsSFnGvIwImG+GdBU/T9v/gw9tivZZ2I22b8iPkJ7ra7hhL\n\tFH9Y0VLJS9BDnhkt/tu+kEnOVKmBNJwyVKmz9/vLx1aVQEHBOIkeaWWdKWXyS0nYr/Xm\n\tvKwh8ijtO5DYGP6S7+QuR1nMzCOkdKnou4fECD3+H6KxB0BQaRNwIYHb/6m1wPu786Qh\n\teFpRRIJ+ph/oq8pZIhVr/pBJoUUcvko0h6xgxVc6HGLzhbo9zwQioBzBaaneCwJQ5QKs\n\tGiCnZM3YjomiDGXJ+bYU/kqRvFPr1kP6xsol07ZrEb4OIJedut8hbSqnMgZLeTvNpIi8\n\tx41w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=SrdOHAhVn50aQMf1NeiMS0IvxCFcge18sAYi03T3Auo=;\n\tb=pl6tbXOcgCRIxx09A5uwsByEpVcmxRrLs9vswE1B5vIxNdX2NxGJWiXqbJ5BXHP//L\n\t/8j/YLShqsCC2tg4/cR8jQlf32A4jGrMlf7q6VEuwwTcSIh8cRLPWm8H3kyqadO741Sd\n\tdpf5TdxhvGfnREf2cHc+aXUy3ecZWFgwB3dEfOG4DFwB03pKbOkfczr5r4XGswvG1jr0\n\trbi4p5Bd2V/vHp5WO29/W3XH3uILn1eEK5WIpCxCEZst8NiRYPqumWH5TcNEjzuQE9tP\n\tmHkSfI9HqqRb8lKqJSOOxxLrQu4UIMmUqnd/8yKoL4ln4fCWyITRzdAQMtAcmLHn2v4q\n\trwHA==","X-Gm-Message-State":"ANhLgQ2HXL1P/JkO2tKdKOCEUcG68D7581/+S2+9G9GvweUM5GgEgFb0\n\tqCTNej9dkfjhwEpTHt4t+1dsWAPSZM4=","X-Google-Smtp-Source":"ADFU+vt63qQTRRSewPuewKJ+w8jnXEPeiabBNPrsREAbVwQW4NtZtlE7n3PH78oWAcKf/tfjxLJuTg==","X-Received":"by 2002:ac2:484f:: with SMTP id 15mr704104lfy.3.1584477451987;\n\tTue, 17 Mar 2020 13:37:31 -0700 (PDT)","Date":"Tue, 17 Mar 2020 21:37:30 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"Helen Koike ,\n\tlibcamera-devel@lists.libcamera.org, kernel@collabora.com","Message-ID":"<20200317203730.GA2754491@oden.dyn.berto.se>","References":"<20200227030001.333291-1-helen.koike@collabora.com>\n\t<20200229152831.GC18738@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200229152831.GC18738@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 0/2] rkisp1: don't enable immutable\n\tlink","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 17 Mar 2020 20:37:33 -0000"}},{"id":4116,"web_url":"https://patchwork.libcamera.org/comment/4116/","msgid":"<20200320005236.GA3553651@oden.dyn.berto.se>","date":"2020-03-20T00:52:36","subject":"Re: [libcamera-devel] [PATCH 0/2] rkisp1: don't enable immutable\n\tlink","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Helen,\n\nMerged to master, thanks for your work.\n\nOn 2020-02-26 23:59:59 -0300, Helen Koike wrote:\n> The following patch was merged in the Linux kernel media tree:\n> 3eed7385bff6 (\"media: staging: media: rkisp1: make links immutable by default\")\n> \n> Which causes the topology configuration in libcamera to fail, since it tries to\n> enable immutable links.\n> \n> This patchset fixes the rkisp1-capture.sh scrips and the pipeline\n> handler.\n> \n> Question: I was wondering how releases are being mananged by libcamera.\n> Does this patchset needs to wait for the patch mentioned above to reach\n> mainline kernel?\n> \n> Helen Koike (2):\n> utils: rkisp1: don't enable immutable link\n> libcamera: pipeline: rkisp1: don't enable immutable link\n> \n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 8 --------\n> utils/rkisp1/rkisp1-capture.sh | 1 -\n> 2 files changed, 9 deletions(-)\n> \n> -- \n> 2.25.0\n>","headers":{"Return-Path":"","Received":["from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B1F3060418\n\tfor ;\n\tFri, 20 Mar 2020 01:52:39 +0100 (CET)","by mail-lf1-x143.google.com with SMTP id n20so3194417lfl.10\n\tfor ;\n\tThu, 19 Mar 2020 17:52:39 -0700 (PDT)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\tb190sm2382447lfg.44.2020.03.19.17.52.37\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 19 Mar 2020 17:52:37 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=1wZtyEit1dekzsAW58ekjo3X6+79V6bULWBsTEJJAT0=;\n\tb=BhLK/yTccxTvcj9LbB/Z84+GgQfNmSc6jvLAX0v7RlrrnGGZ2ZFT91am3061drHdaW\n\t74bUW8tTz/GCykZnp8331/wHxxMiUqLzg9wupI1ZRBCed3TcyhhxDR2lfudcbpklcYKW\n\t6/gg25D/+Zey7VuUvVPT8sMaReYT6iuesUaIR6Zpb8XChRS2VNjaS6wgOg7102hCryMg\n\tl7l5jH8i+t6AAECWDyje5Nm6IEmBQMJ8boGnX5VTDUtGXeyDv9UDmGCjIy5L7GjDWaHz\n\tXebdmDKN3TEBYZXe7uFkHZFJoIqUjDjRlyl6iap9bTu1a145tZ6xp09G7TPWwM+9iLKG\n\tjpVA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=1wZtyEit1dekzsAW58ekjo3X6+79V6bULWBsTEJJAT0=;\n\tb=PpXVQ2bH3I6FtaDVXEQVXtfLIHaZUNBA8GCsc6dn+1z+uIfDLu/GWK5FvVJI6J53ci\n\tgMljCRs80UeYbaksZiHH95cAWYMTa4/F42JM4MyD5vAJ2UrUpIAeelYMOxXOdk10/oBr\n\tDUZEfuWFWvPEbfhY3l82qcPLDxRLZ+jdyb8d77uT1ZFip5nNmvlIGAvG8jY1VAzexX9p\n\tzdsDFgtCR0m9vyVnX/ffsysU7ir2kMA7DoS4F8nVMPUmgzcTKv/V/PTCxZQaH623UROE\n\tlowqYmuWhGTI9fC2X626KfwF0eWIdmEss/JXam69FP0+6aT7cmTQUF09pK4ZPDqCU/MM\n\tK/Ng==","X-Gm-Message-State":"ANhLgQ1hZOV6LO9fWUX5QaGE1fbwTYl7W1JS4sGWfZYr5t+MH9OJyi3x\n\tjcfdMsnv4SVxnXvbNw5XdsVocw==","X-Google-Smtp-Source":"ADFU+vuRpfevF20pKnv7Zw7ZTSve/CFkfTgfV1zDaI/AhwwZK3EN9lh4/idSvc8LBj7V7c0s0L3eiQ==","X-Received":"by 2002:ac2:5e85:: with SMTP id b5mr3435708lfq.99.1584665557970; \n\tThu, 19 Mar 2020 17:52:37 -0700 (PDT)","Date":"Fri, 20 Mar 2020 01:52:36 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Helen Koike ","Cc":"libcamera-devel@lists.libcamera.org, kernel@collabora.com,\n\ttfiga@chromium.org, dafna.hirschfeld@collabora.com","Message-ID":"<20200320005236.GA3553651@oden.dyn.berto.se>","References":"<20200227030001.333291-1-helen.koike@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200227030001.333291-1-helen.koike@collabora.com>","Subject":"Re: [libcamera-devel] [PATCH 0/2] rkisp1: don't enable immutable\n\tlink","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 20 Mar 2020 00:52:39 -0000"}}]