[{"id":3793,"web_url":"https://patchwork.libcamera.org/comment/3793/","msgid":"<20200218003830.GK4830@pendragon.ideasonboard.com>","date":"2020-02-18T00:38:30","subject":"Re: [libcamera-devel] [PATCH 0/3] Patchset for libcamera controls","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Mon, Feb 17, 2020 at 02:26:06PM +0000, Naushir Patuck wrote:\n> Hi,\n> \n> I would like to discuss the following patch set. In it are the following\n> changes:\n> \n> 1) Add double and std::string ControlValue types.\n> 2) Update units and types of existing controls.\n> 3) Add new camera controls.\n> \n> There are two main points of discussion for (1). Firstly, I have not added\n> any support for serialisation of these ControlValue types. I understand that\n> the serialisation code is being revamped, so will wait for that to be completed\n> before addressing this.\n\nNo issue with that.\n\n> Secondly, from eariler discussions, std::string\n> ControlValue type may not be the most sutiable for AE/AWB modes. Instead we\n> may want to use fixed enum values which makes things a little bit more\n> restrictive.\n\nI'll reply to this question in the review of patch 1/3.\n\n> Thoughts?\n> \n> Naushir Patuck (3):\n> libcamera: controls: Add std::string and double ControlValue type.\n> libcamera: controls: Specify manual gain units and change exposure\n> units\n> libcamera: controls: Add AE/AWB mode, manual and EV controls.\n> \n> include/libcamera/controls.h | 6 +++\n> src/libcamera/control_ids.yaml | 46 +++++++++++++++++++--\n> src/libcamera/controls.cpp | 72 ++++++++++++++++++++++++++++++++-\n> test/controls/control_value.cpp | 26 ++++++++++++\n> 4 files changed, 146 insertions(+), 4 deletions(-)","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7575961A44\n\tfor ;\n\tTue, 18 Feb 2020 01:38:49 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EFB811220;\n\tTue, 18 Feb 2020 01:38:48 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581986329;\n\tbh=YxyzPhat6kr6GHXluQ0/55SF39oVYrtcu9UG2mu+gI4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=piWECg9zKinY8/MczO1XRKxjLnWEZt4mDYd1i871JNdB1JO/D9pt8Y/J18HX37pdc\n\txUY2O78S4AWGsuWiBR+pHkOB5ZEJm+uEyHVYhFklHbR/D6ZniMFPVnrihwKJkuPWEU\n\tudHKLoLQcRHdWvUNp9ytsQUxVh4SRcC9V/Cuzxds=","Date":"Tue, 18 Feb 2020 02:38:30 +0200","From":"Laurent Pinchart ","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200218003830.GK4830@pendragon.ideasonboard.com>","References":"<20200217142609.22837-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200217142609.22837-1-naush@raspberrypi.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 0/3] Patchset for libcamera controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 18 Feb 2020 00:38:49 -0000"}}]