{"id":2840,"url":"https://patchwork.libcamera.org/api/covers/2840/?format=json","web_url":"https://patchwork.libcamera.org/cover/2840/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200217142609.22837-1-naush@raspberrypi.com>","date":"2020-02-17T14:26:06","name":"[libcamera-devel,0/3] Patchset for libcamera controls","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"mbox":"https://patchwork.libcamera.org/cover/2840/mbox/","series":[{"id":679,"url":"https://patchwork.libcamera.org/api/series/679/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=679","date":"2020-02-17T14:26:06","name":"Patchset for libcamera controls","version":1,"mbox":"https://patchwork.libcamera.org/series/679/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/2840/comments/","headers":{"Return-Path":"","Received":["from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n\t[IPv6:2a00:1450:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3615461937\n\tfor ;\n\tMon, 17 Feb 2020 15:28:14 +0100 (CET)","by mail-wm1-x32f.google.com with SMTP id q9so17338128wmj.5\n\tfor ;\n\tMon, 17 Feb 2020 06:28:14 -0800 (PST)","from naushir-VirtualBox.pitowers.org (cust51-dsl50.idnet.net.\n\t[212.69.50.51]) by smtp.gmail.com with ESMTPSA id\n\tp15sm760960wma.40.2020.02.17.06.28.12\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 17 Feb 2020 06:28:13 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id;\n\tbh=BhEpKTpqUjTTE5Ox1bsYk1sy+oLIUxNm5htRak7q+/Y=;\n\tb=iKYzgHZQ0A/lQjpBRzl9iEg3pxEbv1Yp0lLlhzYZGrNW5Fn7NFkwc1QZsCFqYU78X4\n\t+eCBUaypSHuUvvkSKd8gg/OYUlH2J/F1MgnSOBYY2/v7DSBzu2aMghgcPzx5qHwZ3DQr\n\tvzudw//VBLaNtNgB0hYn8SYtD1O+zOcA1sjJyoQw1gaygiQSFK3vKghb0HF89KocK/IS\n\t9gdkaPzfXCI/8TrvyG+FoXcXNgBlRVFrMmhjSwhZsy9xI5F+pZ4VekuvZQ7hVa6r6HXU\n\ttjkxn6ib+VveMEkyU/V595mUJksDNlK1Ei4nTQZxbznPs4TJswizAh/wcDTTi25C92kD\n\tMgIA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=BhEpKTpqUjTTE5Ox1bsYk1sy+oLIUxNm5htRak7q+/Y=;\n\tb=eC2Taru+28yTGlKTcMLOXG1OiTy6NnT2Z/jCiO+awDU01pywecpF/YZnqfi1WcXpjB\n\tnLCEFckgfmWzrerfIZ5qlwly5UaEK4Tk3ah9eH3tVFH9xam+wdz8Y5dtqDviZlfsBVYM\n\trU6LgYiYjKfN18PZtoxLK7fjQulhOlvVXSJDMTqk/8Os3X+0Rw1hsUUJrj1JftkelI7V\n\t1HAMdwQFqXaD3y/YT/Ob8UrjyFvWR3ElPuErKLIGzSOzE9lNIHDX6D85DtUL+CHugD83\n\t6VvqA8RpsjoCJEHgiDYIUA79bOWg2WqfO26mK08/lKASPQgFDs/dDMUTIDQ59kd1lP7x\n\tSuRQ==","X-Gm-Message-State":"APjAAAXcLO9Rwz7UIJL5CzPd2LxsEeNrScp2nH+O6CU0+oNoImGtjEaY\n\tHHPWclhh2ySRYc5c9fxvmQpzbUlRBA+nvQ==","X-Google-Smtp-Source":"APXvYqz2ilWPzs7Dsy1UgoQ2flTHro+NkZjMHpkqPDerwcoK0tiMphzkMLppphtArwXFB5djrmpxKA==","X-Received":"by 2002:a1c:3b87:: with SMTP id\n\ti129mr22133421wma.142.1581949693507; \n\tMon, 17 Feb 2020 06:28:13 -0800 (PST)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 17 Feb 2020 14:26:06 +0000","Message-Id":"<20200217142609.22837-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.17.1","Subject":"[libcamera-devel] [PATCH 0/3] Patchset for libcamera controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 17 Feb 2020 14:28:14 -0000"},"content":"Hi,\n\nI would like to discuss the following patch set. In it are the following\nchanges:\n\n1) Add double and std::string ControlValue types.\n2) Update units and types of existing controls.\n3) Add new camera controls.\n\nThere are two main points of discussion for (1). Firstly, I have not added\nany support for serialisation of these ControlValue types. I understand that\nthe serialisation code is being revamped, so will wait for that to be completed\nbefore addressing this. Secondly, from eariler discussions, std::string\nControlValue type may not be the most sutiable for AE/AWB modes. Instead we\nmay want to use fixed enum values which makes things a little bit more\nrestrictive.\n\nThoughts?\n\nRegards,\nNaush\n\n\nNaushir Patuck (3):\n libcamera: controls: Add std::string and double ControlValue type.\n libcamera: controls: Specify manual gain units and change exposure\n units\n libcamera: controls: Add AE/AWB mode, manual and EV controls.\n\n include/libcamera/controls.h | 6 +++\n src/libcamera/control_ids.yaml | 46 +++++++++++++++++++--\n src/libcamera/controls.cpp | 72 ++++++++++++++++++++++++++++++++-\n test/controls/control_value.cpp | 26 ++++++++++++\n 4 files changed, 146 insertions(+), 4 deletions(-)"}