[{"id":39937,"web_url":"https://patchwork.libcamera.org/comment/39937/","msgid":"","date":"2026-07-31T16:23:31","subject":"Re: [PATCH v4 0/2] Add imx471 soft-ISP sensor support","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi John\n\nhow did you formatted/sent the patches ?\nI can't apply them with `git am` as I usually do:\n\nerror: git diff header lacks filename information when removing 1 leading pathname component at .git/rebase-apply/patch:6\n\nApparently the client you used to send emails broke lines which makes\nthe patch untreatable for git am.\n\nDid you use git-send-email to send the patch ?\nSee Documentation/contributing.rst in particular\nhttps://git-send-email.io/\n\nThanks\n j\n\nOn Fri, Jul 31, 2026 at 08:15:05AM -0700, John Cronin wrote:\n> Add CameraSensorHelper and static sensor properties for Sony IMX471\n> (SONY471A), used on Lenovo ThinkPad X9 / X1 Carbon Gen14 (IPU7).\n>\n> Changes since v3:\n> - Document measured analogue gain model and black level on real\n> hardware (raw Bayer sweep, fixed exposure).\n> - Confirm G = 1024/(1024-code) within ~1.5% over codes 0..800; max\n> ~4.57x is the V4L2 code range under that model.\n> - Black level ~64 DN @ 10-bit from min exposure/gain raw frames.\n>\n> v3 process notes (still apply): new thread, split patches, empty\n> sensorDelays, no self Tested-by.\n>\n> Tested on Fedora 44 / ThinkPad X9-15 Gen 1 (kernel 7.1.5).\n>\n> John Cronin (2):\n> libipa: camera_sensor_helper: Add imx471\n> libcamera: camera_sensor_properties: Add imx471\n>\n> src/ipa/libipa/camera_sensor_helper.cpp | 29 +++++++++++++++++++\n> .../sensor/camera_sensor_properties.cpp | 14 +++++++++\n> 2 files changed, 43 insertions(+)\n>\n> --\n> 2.55.0","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0B38CBE080\n\tfor ;\n\tFri, 31 Jul 2026 16:23:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3F5AD67FDF;\n\tFri, 31 Jul 2026 18:23:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 448BB65F9F\n\tfor ;\n\tFri, 31 Jul 2026 18:23:35 +0200 (CEST)","from ideasonboard.com (mob-109-113-25-35.net.vodafone.it\n\t[109.113.25.35])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 024021494;\n\tFri, 31 Jul 2026 18:22:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Q+YgClnd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785514948;\n\tbh=uUvzmLnZa7hep9KGA9M9nZ+zNVntnqtgagw5ifFiqQo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Q+YgClndV+Ng4ll8Gkj0whrYL+Oy60oW2+X6ECdO/J4xO9gb2XSS4gkQf/BL/8sVO\n\tY5difP2E5pQ6HOqFmJ60ql/HESpyLiWWe4iHAhHyM+3wfwf/L45eiUmyYtD5oVAC+9\n\taNJV+0kfp+PcjC72g4xTk/5zoXcpQT3XGf7iWFJw=","Date":"Fri, 31 Jul 2026 18:23:31 +0200","From":"Jacopo Mondi ","To":"John Cronin ","Cc":"libcamera-devel@lists.libcamera.org, jacopo.mondi@ideasonboard.com, \n\tkieran.bingham@ideasonboard.com","Subject":"Re: [PATCH v4 0/2] Add imx471 soft-ISP sensor support","Message-ID":"","References":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":39938,"web_url":"https://patchwork.libcamera.org/comment/39938/","msgid":"","date":"2026-07-31T16:33:33","subject":"Re: [PATCH v4 0/2] Add imx471 soft-ISP sensor support","submitter":{"id":476,"url":"https://patchwork.libcamera.org/api/people/476/","name":"John Cronin","email":"john@stromback.com"},"content":"Hi Jacopo,\n\nOn Fri, Jul 31, 2026 at 06:23:31PM +0200, Jacopo Mondi wrote:\n> how did you formatted/sent the patches ?\n> I can't apply them with `git am` as I usually do:\n>\n> error: git diff header lacks filename information when removing 1 leading\n> pathname component ...\n>\n> Apparently the client you used to send emails broke lines which makes\n> the patch untreatable for git am.\n>\n> Did you use git-send-email to send the patch ?\n\nSorry about that — no, I did not use git-send-email. The patches were\nsent as plain-text bodies through Gmail's API/web path, which wrapped\nlong lines and mangled the format-patch headers for `git am`.\n\nI do not have git-send-email/SMTP set up on this machine yet (will fix\nthat for future submissions; thanks for the contributing.rst pointer).\n\nTo unblock apply without relying on the MUA, here is a **git-am-ready**\nformat-patch series (raw files, tabs preserved, verified with `git am`\nlocally):\n\n https://gist.github.com/johncronin3/51dfc0bb2204b8ab13c678b9fad0bb13\n\n curl -fsSL https://gist.githubusercontent.com/johncronin3/51dfc0bb2204b8ab13c678b9fad0bb13/raw/0001-libipa-camera_sensor_helper-Add-imx471.patch\n| git am\n curl -fsSL https://gist.githubusercontent.com/johncronin3/51dfc0bb2204b8ab13c678b9fad0bb13/raw/0002-libcamera-camera_sensor_properties-Add-imx471.patch\n| git am\n\nThat series is **v5** vs the broken Gmail v4:\n- Drop the long in-code helper comment (measurement detail stays in the\n commit message only) — please do drop it if you still prefer that.\n- Drop the redundant test-pattern comment on properties (as on your R-b).\n- Same functional code (blackLevel 4096, AnalogueGainLinear 1024 model).\n\nAlso fine if you apply from the earlier content and just drop the\ncomments yourself; the gist is only to give you a clean `git am` path.\n\nMeasurement write-up/script remains at:\n https://gist.github.com/johncronin3/15d9eacbf64f91ecc600fe583686325f\n\nThanks for your patience,\nJohn Cronin","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 59A30BDE4C\n\tfor ;\n\tFri, 31 Jul 2026 16:33:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8076B67FE1;\n\tFri, 31 Jul 2026 18:33:37 +0200 (CEST)","from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com\n\t[IPv6:2607:f8b0:4864:20::112b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 67C2365F9F\n\tfor ;\n\tFri, 31 Jul 2026 18:33:35 +0200 (CEST)","by mail-yw1-x112b.google.com with SMTP id\n\t00721157ae682-80e24970f1dso8943567b3.0\n\tfor ;\n\tFri, 31 Jul 2026 09:33:35 -0700 (PDT)","from 313336824172 named unknown by gmailapi.google.com with\n\tHTTPREST; Fri, 31 Jul 2026 09:33:33 -0700","from 313336824172 named unknown by gmailapi.google.com with\n\tHTTPREST; Fri, 31 Jul 2026 09:33:33 -0700"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=stromback-com.20251104.gappssmtp.com\n\theader.i=@stromback-com.20251104.gappssmtp.com\n\theader.b=\"XJxWelPC\"; dkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1785515614; cv=none;\n\td=google.com; s=arc-20260327;\n\tb=BwVpJ/g8BS0BN/AjbmsszRdghpn0cx2Qx0VCi5JqorYcVqBxxQILDXph4tH5A8tF2f\n\tA9j/eoN7FwgKmCqtbhRitcCnNd6XfR31t8zHaToDzyxSZz9CuZohEhei2xFF6EUU162I\n\tBVxVdjbB9PkGpWu3UX6DWHIxhcyuR2SIwmTZW/pjh/tVIQ57gt5HnJ/FtjJKZfkEc9+J\n\tfB0nXfrcJNLHOgEsGIfn5pS6ale8EdYJOHzljg5RajFq21Q44oSjgzPIplwMl6DGy5QG\n\tNTq6J5UzqQJXplv7UGwL+FqJ+8TD2aTE62ftDe8WV7XGgkBBPVCgOWGYmtkvzr7ewjD/\n\t5Osw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20260327; \n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:references:in-reply-to:mime-version:dkim-signature;\n\tbh=l7KtEncyCo/q19lgbmgiUBGAJ/P0BwaV4K0vXDuBUE8=;\n\tfh=4ABwDVbi3TEfhgDpP3olu+HotWul1r8ABwbXyPI0LTA=;\n\tb=CtwWUtzJbANbdVXUjh7cwI11TSUGBIp8ZWjJU7Xjuf5kttVhAHl/QiSFMip+/mYFtl\n\tqloYzkuGDzx7OTlfEOnTJRiBxeZFvYrX0NwN2Ig6O/8sIygrc20ZAHit1XqmcISujZGj\n\tSL3koWAvBLD/c0Tc+QwDPfc0/SxSLLGdzcd5NQk+EO+0IqcxUbO0nJussGH2oS5HnqqN\n\tnprvWxkYnKqfzrWweyQ3UMKWpPoznPLj3RisdJJrUxLaRSDDj0wIF7PDLwlfyErnU1UB\n\tM+duAzsHAr4ya5J0hceMBMU7PL+1nASYfQZAJpS4FgTEUYvZ1WGVWkqyOOQhiT81b+Kt\n\tsDHg==; darn=lists.libcamera.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=stromback-com.20251104.gappssmtp.com; s=20251104; t=1785515614;\n\tx=1786120414; darn=lists.libcamera.org; \n\th=content-transfer-encoding:content-type:cc:to:subject:message-id\n\t:date:from:references:in-reply-to:mime-version:from:to:cc:subject\n\t:date:message-id:reply-to:content-type;\n\tbh=l7KtEncyCo/q19lgbmgiUBGAJ/P0BwaV4K0vXDuBUE8=;\n\tb=XJxWelPCQS2JjO8jPM6WUSBPxTHTTk4XhZ7tFshVUvkqQHaS3GJs/yFTHcjfgCsnhn\n\ttN70tHiZDDdB6Snut6/s4hk3kPNK1/s2RYG52eXHm9/XzZp+RRqFFo6cpRSEcmqF4pIw\n\tyCVvBBvAYHDwkDqUtSSYn0mSShU9F0AFz8vCWFWpb/zjAwWPpwt7FNQRE8/qapcRt4yV\n\tu2QaaS+wuv0Xm8/P/MNuVifnzr8QEBkyJs4eIwBRkTD4QccR1DEpIKTbWYMpdbFypnhA\n\tCDs4BT7Fbupmt5/zYsC9QIwOBopHpFbFfJ7Wk/gf6Q07hPvNO8/f0WEP47hzCR3J6OPb\n\t6t7Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1785515614; x=1786120414;\n\th=content-transfer-encoding:content-type:cc:to:subject:message-id\n\t:date:from:references:in-reply-to:mime-version:x-gm-gg\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to\n\t:content-type;\n\tbh=l7KtEncyCo/q19lgbmgiUBGAJ/P0BwaV4K0vXDuBUE8=;\n\tb=rYfqNkfPr5woC7OD1shxTt8iq4iH78YnzEmFWCTQ6wZQn5bd6CzK8xq7uOk9qOn3Wl\n\ts9JZICfz7Fiq2prkKBfKGsGupo2EkMa6T5zDQyun6lttOx6ZPh3EgmNXFfZGgoAiyXT2\n\t79R0K5D9JJAnNXbQF+RemgyzMUacCndzohtkA8XWsOeQxyMb4QbJBTlk9+r4EDL6x1cu\n\t8GdsrFA/cJCUopzVRLiC7vsRKyH/q3lbD8EMLmb+R9nvMZoUVhS70BEJfQGsmZhgQix1\n\tGTFLWupgUrd1Blwk4QBlP58e/0MK2pJmt2Xke1iz+ugE0dbbEzKnuwD6/EhG8kKEz5zk\n\tuozA==","X-Gm-Message-State":"AOJu0Yz2DoIpw9WIMRyBHlG4arHYVAz3Ubs6FPyvQeT0n2X3p+Mk8avf\n\t+x7e3GNthxg80SmzjO4JjBvlAhcgYsAUFG/izYZs/nQgkRh8D+J9JEA3DoMD8ZZ92POPr/RHOmB\n\tYgDhInyJs+J17IJL/YZy9aeBUD7aQoT6kSTJIJTPgIyMw5sN3rfUduBc=","X-Gm-Gg":"AR+sD104uu7WUjjfKbuT7pWJ69S4RNZtan0ErqqkWIjQDQAHFh0AkCQlGqGaDeztzoI\n\tiqNtvuP2ln2dFstYYGkZ2zY2nbaLJh9UVizYnjpN0l0C+T61Y8o7xsxgptqb2eKw8Vu4sah3Rjc\n\tDsJ63VlqX6KrUvG6q5v3eyXH9qXW73x1+RFqgxxCGpz1GOQ1TQBx6xVZ1Ho059vMWO2mJdye/bc\n\tovjRhsXRWYZBifuc4+mNaGd0li6beSmoye0O//kBduvsjIcwdNcMQXIJV6mOzK6gu7q3eYMEBVS\n\tcQAzIbajgkF+owRtJiUXm8SBEw+VH7SI5Pyoyc7X8+Rmg6iec7jaHSAuhLdaAb4vf27xStuskST\n\tVOOsXOiukYPJRfD1ZQI595Al/JjkVAy0bzNWWgzWg7JCuahxs1Ok9IWC22BwdBonjtEwHhK0ZSk\n\tuQDCCFhbMYnk1MOI94/4DFrHQVC8rG7aZC9a3TYTj3r1Szj+ByGhNXrTpCxC0ddxv1CpUJiCgWg\n\taw6gB3h2CqQpyVaDZTdtv5wOBNxKfAiviinOvsLVA==","X-Received":"by 2002:a05:690c:6604:b0:812:be92:6ea6 with SMTP id\n\t00721157ae682-81fd4b909d3mr5198967b3.28.1785515614031;\n\tFri, 31 Jul 2026 09:33:34 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"","From":"John Cronin ","Date":"Fri, 31 Jul 2026 09:33:33 -0700","X-Gm-Features":"AUfX_myEfvNNNYyrGffhIWikqFDwwFCW_WMDJetHBXY0HAv24yjXowkZD2iQJZk","Message-ID":"","Subject":"Re: [PATCH v4 0/2] Add imx471 soft-ISP sensor support","To":"jacopo.mondi@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org, kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]