{"id":27237,"url":"https://patchwork.libcamera.org/api/covers/27237/?format=json","web_url":"https://patchwork.libcamera.org/cover/27237/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260706110120.2509826-1-bryan.odonoghue@linaro.org>","date":"2026-07-06T11:01:13","name":"[v4,0/7] libcamera: software_isp: gpu: Add go faster stripes","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"mbox":"https://patchwork.libcamera.org/cover/27237/mbox/","series":[{"id":6040,"url":"https://patchwork.libcamera.org/api/series/6040/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6040","date":"2026-07-06T11:01:13","name":"libcamera: software_isp: gpu: Add go faster stripes","version":4,"mbox":"https://patchwork.libcamera.org/series/6040/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/27237/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 34EFDC330A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon,  6 Jul 2026 11:01:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DAB8A66011;\n\tMon,  6 Jul 2026 13:01:32 +0200 (CEST)","from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com\n\t[IPv6:2a00:1450:4864:20::42c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EC9F0658E0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  6 Jul 2026 13:01:30 +0200 (CEST)","by mail-wr1-x42c.google.com with SMTP id\n\tffacd0b85a97d-47122683cf3so1815195f8f.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 06 Jul 2026 04:01:30 -0700 (PDT)","from inspiron14p-linux ([109.77.44.220])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-47aa0960634sm25190846f8f.26.2026.07.06.04.01.29\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 06 Jul 2026 04:01:29 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"HZUdKRII\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1783335690; x=1783940490;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=uBLEZqkxgji7+B1U/JPw5brX2uATQx0vKBZCMrMOBGs=;\n\tb=HZUdKRIItczHCCLrn7Oh4qeqA+2Psr6DleF32N7blErLatYL0CvYGtLPlGZkQbEUI7\n\tMJYz/vOZokVUeBb4Xdl5pHrK+UXQ8TbFf/I2cL9wl/+1OLgrpH3+EBggLlFZYKiU3KFj\n\tQbz9brXzZ8AzTIRFM+uIlyUYUlwtUqw8N+92i/vZWdOT182DVTaxkAx1Uv3OSZVxU0j/\n\tSN/8himxuEbMxY8xeok3AJxkANbf2KFkTifG3lOZwLyXNJverIKeoGZJIO4c2oBj8ZHr\n\t0/DuM7P0sbGzuQJB/0nZScOkVfW7LIjpDhaiGRYqaQeFo9utv0ue5XkDZ5IKalLwxKAy\n\tLZEQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1783335690; x=1783940490;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=uBLEZqkxgji7+B1U/JPw5brX2uATQx0vKBZCMrMOBGs=;\n\tb=WE89gX4sxcVXHhElwk+5I5jDKmwamF8IfvpjS36odlZZtYWAHKSEDTs5l+sAb3eIya\n\tKZUYnzNDq/phHoQprm5iVuQTDqa4rH690iKanxYrYm953MfQsMnTnWHIE4EyVZHxVkYY\n\tQ2Fc6MmADFRhwJ5sNZhyAV16aPuDMbGIsY7dO7rtmh0/ENi0pDP37sZCq56w20Nyi8gx\n\tHgmiAQuzEjR0WAk5wIJUfskLx7xfCkxzBmLOoml2AzfvDmdTbWsNibi6NQrMz407/Hca\n\tBswsudAQkWURQ34/mABgfCgpQFaZEygSdbm3xe+8VtuvIiqvVmFhCrRjhwJSUmPBQlNk\n\tItHQ==","X-Gm-Message-State":"AOJu0Yzm0ejGq5uQpeQwaP13DpPhQ7vPF1YBRo8xAjsgTErnZFjA3/5b\n\tD9OJM/z5LsMz88vxKhDGX7rerQNpPrfCOKl3QF/CSaAcInTFL/NuZExUR5WsdrAkkF8fvUCZk3f\n\tmzs5V","X-Gm-Gg":"AfdE7ckKffweyBLHehl4+aSU79EvJJbJu6y9DOyiWaREA8v31P8xXcxpxjqIJ5BnOeS\n\tvFtSYmxqtvrV29H+/ouApj4gVHPw2OsTsXnPi3OlNq3zX3aveCCwCws+et4WEXs22OfbgBB6qTN\n\t2hO1/EXYIVRBBGoA/Mo85ST4Ck/0GygEFMU3VHThzmd2qwEGrRO8coFb1KxXPDZ6Da3+zT7VROG\n\tIPuWxaXzeL5+OgHFF08ac6cNWfX6gJ5g8vUKLXOhKT8ngyu/KrOy/l4nRiUb2B88ohSL2lUP2CS\n\txLAGimPKfc3NGQHTSzxRxDEiGMCkDi/jmW8JMNXLMJrCv7hqrXO/5VqKo8eYUAWFxpxj2P9yQ//\n\t0t/Jv1kEbxitz6nKJtIM+lhlp2I23cVpLepG9dBmvPeavdxaQ1z1q+DnsIk1OaZ2k9x+06Q5QZ7\n\tjJpqjoycc2YUtQUVHeuNjQapOay3Df","X-Received":"by 2002:a05:6000:2c05:b0:47d:df96:c9f4 with SMTP id\n\tffacd0b85a97d-47ddf96cc37mr6174625f8f.10.1783335690418; \n\tMon, 06 Jul 2026 04:01:30 -0700 (PDT)","From":"Bryan O'Donoghue <bryan.odonoghue@linaro.org>","To":"libcamera-devel@lists.libcamera.org","Cc":"bryan.odonoghue@linaro.org,\n\tpavel@ucw.cz","Subject":"[PATCH v4 0/7] libcamera: software_isp: gpu: Add go faster stripes","Date":"Mon,  6 Jul 2026 12:01:13 +0100","Message-ID":"<20260706110120.2509826-1-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.54.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"v4:\n- Sizes cache as indicated at configure\n- Ejects oldest entry on cache miss if cache is full. This allows an external\n  application to keep feeding buffers in.\n- Reverts to using per image dma-buf flags - this is because again we can\n  have heterogeneous sources of buffers.\n- Takes Barnabas' suggested SharedFD patch - Robert\n- Accumulates RB as indicated by Milan\n\nLink: https://gitlab.freedesktop.org/camera/libcamera-softisp/-/pipelines/1700354\n\nv3:\n- Fixes a missing switch default from libcamera ci loop - bod\n\nv2:\n- Reverts to debayer_egl specific caching mechanism - Laurent\n- Pivots on dmabuf handle as key for cache. dmabuf handle\n  must be unique between start() and stop() for eglCreateImageKHR to work - Barnabas\n- Ensures sizeof cache doesn't exceed the number of expected buffers\n  as discovered during configure() - Barnabas\n- Drops GL_16F patch - Robert\n- Drops the \"input\" name from createInputTexture2D() - Robert\n- Adds RB as specified by Robert\n\nv1:\nFollowing on from Robert Mader's ask to bring forward GPUISP multi-pass\ncache operations to mainline first, I've done some work to enable that.\n\nThis series implements an input/output texture caching scheme which results\nin an overall absolute 4.5 millisecond - roughly improvement in performance\nper processed frame. This is a bit of an odd result as I was expecting to\nshave a particular % off of each frame in the order of 20% or so. My best\nguess is that particular paths we are optimising here are around texture\ngeneration and these are \"fixed costs\" on the CPU side.\n\nOne very welcome outcome of this series is genuine zero-copy on dma-buf\npaths we can support it on i.e. on paths where the CSI2 and GPU strides\nagree.\n\nThe numbers cited in my example are for non dma-buf handle upload and\ndma-buf handle render-to-texture on the output so, in fact I'd expect to\nsee a much larger improvement on systems where dma-buf handle is used on\nboth paths.\n\nAs it is on my test reference systems I have a 50% improvement per frame\nfor one system, a 20% improvement on another system or we could view it as\na fixed 4.5 millisecond improvement on both.\n\nI implemented the cache around V4L2BufferCache as per Barnabas' suggestion,\nincluding a fixed cache size.\n\nBryan O'Donoghue (6):\n  libcamera: software_isp: debayer_egl: Pass eglImage as parameter to\n    setShaderVariables\n  libcamera: egl: Add new helper attachTextureToFBO\n  libcamera: egl: Add createOutputTexture2D\n  libcamera: egl: Add updateTexture2D\n  libcamera: egl: Add activateBindTexture\n  libcamera: software_isp: debayer_egl: Implement input/output frame\n    caching mechanism\n\nRobert Mader (1):\n  libcamera: base: shared_fd: Add hash template\n\n Documentation/Doxyfile-common.in           |   2 +\n include/libcamera/base/shared_fd.h         |   9 ++\n include/libcamera/internal/egl.h           |   5 +\n src/libcamera/egl.cpp                      |  97 ++++++++++++++---\n src/libcamera/software_isp/debayer_egl.cpp | 116 +++++++++++++++------\n src/libcamera/software_isp/debayer_egl.h   |  15 ++-\n 6 files changed, 195 insertions(+), 49 deletions(-)"}