{"id":27200,"url":"https://patchwork.libcamera.org/api/covers/27200/?format=json","web_url":"https://patchwork.libcamera.org/cover/27200/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260706-libipa-algorithms-v3-0-968757b038bb@ideasonboard.com>","date":"2026-07-06T08:01:20","name":"[v3,00/35] ipa: libipa: Introduce libipa algorithms","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/27200/mbox/","series":[{"id":6038,"url":"https://patchwork.libcamera.org/api/series/6038/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6038","date":"2026-07-06T08:01:20","name":"ipa: libipa: Introduce libipa algorithms","version":3,"mbox":"https://patchwork.libcamera.org/series/6038/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/27200/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 74306C3308\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon,  6 Jul 2026 08:01:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5605C65FFE;\n\tMon,  6 Jul 2026 10:01:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 11AD765EFF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  6 Jul 2026 10:01:57 +0200 (CEST)","from [192.168.125.177] (mob-109-113-60-81.net.vodafone.it\n\t[109.113.60.81])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DA59E9CE;\n\tMon,  6 Jul 2026 10:01:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rdj/u/SV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783324868;\n\tbh=lmpNA7iOrnlZDs3RjZosRoaZ+4GqvpYGLhrwD6AjRnU=;\n\th=From:Subject:Date:To:Cc:From;\n\tb=rdj/u/SVadjmWfMquEX8uR8IO8HFL6GpxuXAk+P89acFW04l7HmxpvdbpUOrb/YFF\n\t+PeYxcsgz7T9TXhwNGGGw1+mZ+usjQ485YFM/c1xHso7s0gVfoHa2pBQT++CnL/cym\n\tdo+TGJGtB1zWA/hVa2NlplhXLTP611osesiDSaoo=","From":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Subject":"[PATCH v3 00/35] ipa: libipa: Introduce libipa algorithms","Date":"Mon, 06 Jul 2026 10:01:20 +0200","Message-Id":"<20260706-libipa-algorithms-v3-0-968757b038bb@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","X-B4-Tracking":"v=1; b=H4sIANBgS2oC/33NQQ6DIBCF4as0rEsDA2LoqvdoukAddBIVA8a0M\n\td696KoL0+X/kvlmZQkjYWL3y8oiLpQojDnU9cLqzo0tcmpyMxBghJEF76miyXHXtyHS3A2JF9Y\n\tYU9VOOPAs300RPb0P8/nK3VGaQ/wcLxa5r/+0RXLB0WpbW1VqAHxQgy6FsQouNrc6DGxHF/iBQ\n\tJ1BkCFvS62Ul4D6DNq27QvqZhD0AgEAAA==","X-Change-ID":"20260615-libipa-algorithms-59666bca0a2f","To":"libcamera-devel@lists.libcamera.org, \n\tStefan Klug <stefan.klug@ideasonboard.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>, \n\tKieran Bingham <kieran.bingham@ideasonboard.com>, \n\tDaniel Scally <dan.scally@ideasonboard.com>, \n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=openpgp-sha256; l=6571;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=lmpNA7iOrnlZDs3RjZosRoaZ+4GqvpYGLhrwD6AjRnU=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqS2DuHT++5/8Nw0LqhlZxErJnXM/00rH4bnVSJ\n\tJadpcafmDOJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaktg7gAKCRByNAaPFqFW\n\tPOFZD/4rS3B6ppRLclHLEPA/sfKvc1tEvII8pn9veDeOW0RNJXUBkAVG+ERga+KwhPs7Y6NSBcZ\n\tqldjubjcpOgFHQF3+bHJO3GAxJl3ZF6qrVgwSalH/8fazhjcKSuK/xUl3vubiK4pkidj7WBPRFV\n\t7vIHhxA7q/IMpGt4XnNcEdLhI9i2UG5R5recW5x4v7FKPBCxyArZ7L1ipCNWwMgrZ0VGS74jep2\n\t7Rz+VvedLEndJQvvcmxsxrcyQPxyUQyXsO/ez/LXtY/DZAauGEpBUmC8xmbCZiqV5gmwBfnIJVn\n\txYnG5taB/SkuHS4guY7s5HFmz4y+cnV7xH8zgsB1PhXXWnTyFApPkrcRwUqB70yh7QGxVvI4Msi\n\t6FLRygq5p39LVDa5Mfxcxszw1EkkpHXOCKms+NKJEg3w+8vVLui4QO7x8jXEJnhO2gWV6SSLCTB\n\tO4qsdbigsDJgV5+h5E5LhuBbjbeH+BtWo6TaT59TfQUA4pJ25mP7qhZ1eT2N3WKIvqfE1okI5+x\n\tgWpSlKqFKcTGtxjWb8a6hdBcbjm6cAZCCGuW/w2ryCqruaFGzSmU6vnbb0AlmTIknUMjq2pMGY7\n\tk+Wzw/bbxXwYsr7hPmecE5IKT/dsvsHWlr60m3l+cmnQlTOHKqnqoWBn/+ns+29JTNjK0xDkg9m\n\tQamhv0jRDkS590Q==","X-Developer-Key":"i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"This series introduces the first algorithms in libipa: Awb, Lsc and Ccm.\n\nAs most of the implementations of the common algorithms derive from\nRkISP1 it wasn't possible to separate the algorithm introduction with\nthe RkISP1 IPA modifications to maintain bisectability.\n\nThis series contains:\n\n- Awb (Grey and Bayes)\n - RkISP1\n - Simple\n - Mali-C55\n\n- Ccm\n - RkISP1\n - Simple\n - Mali-C55\n\n- Lsc (grid and polynomial)\n - RkISP1\n - Mali-C55\n\nTested on RkISP1 with imx219 (Grey world awb and grid-based LSC) and on\nMali-C55 with imx708 (Bayes AWB and grid-based LSC).\n\nMore test on Simple and with polynomial LSC would be helpful :)\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\nChanges in v3:\n- Address comments on Awb from Stefan:\n  - Introduce AwbImplementation::Result\n  - Move AwbStats implementation to IPAs\n  - Drop AwbStats::rg()/bg() and re-implement AwbGray accordingly\n- Fix Saturation bug in Simple Ccm algorithm\n- Fix Simple Ccm gain limits using Q<2, 8>\n- Update Mali CCM and Gamma to latest uAPI patch version\n- Fix Mali CCM gain masking as reported by Dan\n- Break down libIPA Lsc implementation as requested by Stefan\n\nChanges in v2:\n- Introduce awb::Context to simplify ActiveState and FrameContext\n  definition\n- Add mali uAPI header for CCM and Gamma\n- Do not rename Mali functions for hardware configuration in awb and lsc\n- Spelling and documentation\n\n---\nJacopo Mondi (32):\n      ipa: libipa: awb: Reimplement AwbAlgorithm\n      ipa: mali-c55: awb: Port to use libipa AwbAlgorithm\n      ipa: libipa: Add CcmAlgorithm to libipa\n      ipa: rkisp1: ccm: Port to use CcmAlgorithm\n      include: linux: mali-c55: Update to support CCM and Gamma\n      ipa: mali-c55: Implement Ccm algorithm\n      ipa: rkisp1: lsc: Re-architecture Lsc support\n      ipa: libipa: Introduce lsc_base.h\n      ipa: libipa: lsc_polynomial: Rename LscPolynomial\n      ipa: libipa: lsc_polynomial: Do not inline functions\n      ipa: libipa: lsc: Move Interpolator<lsc::Components> to lsc_base\n      ipa: rkisp1: lsc: Remove rogue empty line\n      ipa: libipa: lsc_polynomial: Move LscPolynomial from RkISP1\n      ipa: libipa: lsc_table: Move LscTable from RkISP1\n      ipa: libipa: lsc_base: Add sampleForCrop documentation\n      ipa: rksip1: lsc: Make parseSizes() a class function\n      ipa: libipa: lsc: Introduce lsc::ActiveState\n      ipa: libipa: lsc: Introduce lsc::FrameContext\n      ipa: libipa: lsc: Introduce LscAlgorithm\n      ipa: libipa: lsc: Move sizesListToPositions() back to rkisp1\n      ipa: rkisp1: lsc: Port to use LscAlgorithm\n      ipa: libipa: lsc: Make Components a map<>\n      ipa: libipa: lsc: Document Components parsing\n      ipa: libipa: lsc_polynomial: Remove sensorSize_\n      ipa: libipa: lsc: Document LscDescriptor::sensorSize usage\n      ipa: libipa: lsc: Template LscAlgorithm with register format\n      ipa: libipa: lsc_base: Describe the function of lsc_base\n      ipa: libipa: lsc: Template lsc::Components\n      ipa: libipa: lsc: Rename sampleForCrop to resampleLscData\n      ipa: libipa: lsc: Specialize Interpolator for uint8_t\n      ipa: mali-c55: Add sensorInfo to IPAContext\n      ipa: mali-c55: Port to use LscAlgorithm\n\nKieran Bingham (2):\n      ipa: simple: awb: Port to use libipa AwbAlgorithm\n      ipa: simple: Use libipa CcmAlgorithm\n\nLaurent Pinchart (1):\n      ipa: libipa: lsc_polynomial: Don't inline ValueNode accessor\n\n .../internal/software_isp/debayer_params.h         |   4 +-\n include/linux/media/arm/mali-c55-config.h          |  86 +++-\n src/ipa/libipa/awb.cpp                             | 472 ++++++++++++++++++---\n src/ipa/libipa/awb.h                               | 109 ++++-\n src/ipa/libipa/awb_bayes.cpp                       |  52 +--\n src/ipa/libipa/awb_bayes.h                         |  12 +-\n src/ipa/libipa/awb_grey.cpp                        |  25 +-\n src/ipa/libipa/awb_grey.h                          |   6 +-\n src/ipa/libipa/ccm.cpp                             | 245 +++++++++++\n src/ipa/libipa/ccm.h                               |  77 ++++\n src/ipa/libipa/lsc.cpp                             | 311 ++++++++++++++\n src/ipa/libipa/lsc.h                               | 137 ++++++\n src/ipa/libipa/lsc_base.cpp                        | 178 ++++++++\n src/ipa/libipa/lsc_base.h                          |  90 ++++\n src/ipa/libipa/lsc_polynomial.cpp                  | 175 +++++++-\n src/ipa/libipa/lsc_polynomial.h                    | 152 ++++---\n src/ipa/libipa/lsc_table.cpp                       |  40 ++\n src/ipa/libipa/lsc_table.h                         | 118 ++++++\n src/ipa/libipa/meson.build                         |   8 +\n src/ipa/mali-c55/algorithms/awb.cpp                | 213 +++++-----\n src/ipa/mali-c55/algorithms/awb.h                  |  28 +-\n src/ipa/mali-c55/algorithms/ccm.cpp                | 173 ++++++++\n src/ipa/mali-c55/algorithms/ccm.h                  |  66 +++\n src/ipa/mali-c55/algorithms/lsc.cpp                | 156 ++++---\n src/ipa/mali-c55/algorithms/lsc.h                  |  32 +-\n src/ipa/mali-c55/algorithms/meson.build            |   1 +\n src/ipa/mali-c55/ipa_context.cpp                   |   6 +\n src/ipa/mali-c55/ipa_context.h                     |  24 +-\n src/ipa/mali-c55/mali-c55.cpp                      |  29 +-\n src/ipa/mali-c55/params.h                          |   2 +\n src/ipa/rkisp1/algorithms/awb.cpp                  | 360 +++++-----------\n src/ipa/rkisp1/algorithms/awb.h                    |  18 +-\n src/ipa/rkisp1/algorithms/ccm.cpp                  |  97 +----\n src/ipa/rkisp1/algorithms/ccm.h                    |  17 +-\n src/ipa/rkisp1/algorithms/lsc.cpp                  | 430 +++----------------\n src/ipa/rkisp1/algorithms/lsc.h                    |  41 +-\n src/ipa/rkisp1/ipa_context.h                       |  49 +--\n src/ipa/simple/algorithms/awb.cpp                  | 131 ++++--\n src/ipa/simple/algorithms/awb.h                    |  29 ++\n src/ipa/simple/algorithms/blc.cpp                  |   2 +-\n src/ipa/simple/algorithms/ccm.cpp                  |  72 ++--\n src/ipa/simple/algorithms/ccm.h                    |  23 +-\n src/ipa/simple/ipa_context.h                       |  15 +-\n src/libcamera/software_isp/debayer_cpu.cpp         |  12 +-\n 44 files changed, 3067 insertions(+), 1256 deletions(-)\n---\nbase-commit: 709ad59a8d90af3570be1c8d02dee0ec9e011954\nchange-id: 20260615-libipa-algorithms-59666bca0a2f\n\nBest regards,"}