{"id":27179,"url":"https://patchwork.libcamera.org/api/covers/27179/?format=json","web_url":"https://patchwork.libcamera.org/cover/27179/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260703153819.1088752-1-barnabas.pocze@ideasonboard.com>","date":"2026-07-03T15:38:02","name":"[RFC,v1,00/17] ipa: libipa: agc rework","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/27179/mbox/","series":[{"id":6036,"url":"https://patchwork.libcamera.org/api/series/6036/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6036","date":"2026-07-03T15:38:02","name":"ipa: libipa: agc rework","version":1,"mbox":"https://patchwork.libcamera.org/series/6036/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/27179/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 53D40C3261\n\tfor ;\n\tFri, 3 Jul 2026 15:38:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 843F365FD9;\n\tFri, 3 Jul 2026 17:38:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 081CD65F9F\n\tfor ;\n\tFri, 3 Jul 2026 17:38:23 +0200 (CEST)","from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B8458DF3\n\tfor ;\n\tFri, 3 Jul 2026 17:37:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"i3Tc+DGk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783093056;\n\tbh=EfavAryUew1DTfbXFwjO+S8OTsVYRFlpeamgmGfX9/g=;\n\th=From:To:Subject:Date:From;\n\tb=i3Tc+DGkIL+l1alSkNZCvcUyQp1KFvon11XwiQdOtUsejBl5DO0SQVU5lixe7J199\n\tzNGh9F3LfEoB94cW37W0k9MbmMCkDmO9Z5yVUjFx9o9TqxCVZdGHT4vqrIhCFaBjsy\n\tKZqOGnn/EM0g1VFtOcFl8rnb6SzbhZTgGmdc1KcE=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 00/17] ipa: libipa: agc rework","Date":"Fri, 3 Jul 2026 17:38:02 +0200","Message-ID":"<20260703153819.1088752-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This is a first early of the AGC rework that is supposed to remove duplication\nof AGC related code from multiple IPA modules.\n\nIt also enables the use of AgcMeanLuminance in the simple pipeline handler\nif a camera sensor helper is available.\n\nThis applies on top of the current master branch, not rebased on any of\nthe libipa rework yet. Conflicts should be minimal.\n\nTODO: handling of DigitalGain + AeEnable needs to be clarified\n\nBarnabás Pőcze (17):\n ipa: simple: Fix control presence sanity check\n ipa: rkisp1: Remove `IPASessionConfiguration::sensor.defVBlank`\n ipa: simple: agc: Do not overwrite sensor exposure/gain\n ipa: libipa: agc_mean_luminance: Remove the need for inheritance\n ipa: rkisp1: Move sensor control info map to context\n ipa: rkisp1: Update sensor info when configuring\n ipa: rkisp1: updateControls(): Use sensor info from context\n ipa: rkisp1: Move AGC related controls into AGC algorithm\n ipa: mali-c55: Remove `DigitalGain` support\n ipa: libipa: Add `AgcMeanLuminance` wrapper\n ipa: rkisp1: Port to `AgcMeanLuminanceAlgorithm`\n ipa: mali-c55: Port to `AgcMeanLuminanceAlgorithm`\n ipa: ipu3: Port to `AgcMeanLuminanceAlgorithm`\n ipa: libipa: agc_mean_luminance: controls(): Return const ref\n ipa: libipa: Add `AgcAlgorithm`\n ipa: simple: agc: Port to `AgcAlgorithm`\n ipa: simple: agc: Use `AgcMeanLuminance` if sensor helper is available\n\n src/ipa/ipu3/algorithms/agc.cpp | 199 +++++------\n src/ipa/ipu3/algorithms/agc.h | 19 +-\n src/ipa/ipu3/ipa_context.cpp | 49 +--\n src/ipa/ipu3/ipa_context.h | 27 +-\n src/ipa/ipu3/ipu3.cpp | 138 ++------\n src/ipa/libipa/agc.cpp | 488 ++++++++++++++++++++++++++\n src/ipa/libipa/agc.h | 100 ++++++\n src/ipa/libipa/agc_mean_luminance.cpp | 268 ++++++++++++--\n src/ipa/libipa/agc_mean_luminance.h | 65 +++-\n src/ipa/libipa/meson.build | 2 +\n src/ipa/mali-c55/algorithms/agc.cpp | 205 +++--------\n src/ipa/mali-c55/algorithms/agc.h | 7 +-\n src/ipa/mali-c55/ipa_context.h | 38 +-\n src/ipa/mali-c55/mali-c55.cpp | 163 ++-------\n src/ipa/rkisp1/algorithms/agc.cpp | 478 ++++++-------------------\n src/ipa/rkisp1/algorithms/agc.h | 13 +-\n src/ipa/rkisp1/algorithms/lux.cpp | 2 +-\n src/ipa/rkisp1/algorithms/wdr.cpp | 2 +-\n src/ipa/rkisp1/ipa_context.cpp | 104 +-----\n src/ipa/rkisp1/ipa_context.h | 48 +--\n src/ipa/rkisp1/rkisp1.cpp | 120 +------\n src/ipa/simple/agc_simple.cpp | 197 +++++++++++\n src/ipa/simple/agc_simple.h | 59 ++++\n src/ipa/simple/algorithms/agc.cpp | 296 ++++++++--------\n src/ipa/simple/algorithms/agc.h | 16 +-\n src/ipa/simple/ipa_context.h | 25 +-\n src/ipa/simple/meson.build | 1 +\n src/ipa/simple/soft_simple.cpp | 80 ++---\n 28 files changed, 1743 insertions(+), 1466 deletions(-)\n create mode 100644 src/ipa/libipa/agc.cpp\n create mode 100644 src/ipa/libipa/agc.h\n create mode 100644 src/ipa/simple/agc_simple.cpp\n create mode 100644 src/ipa/simple/agc_simple.h\n\n--\n2.54.0"}