{"id":27142,"url":"https://patchwork.libcamera.org/api/covers/27142/?format=json","web_url":"https://patchwork.libcamera.org/cover/27142/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260630125214.3327516-1-laurent.pinchart@ideasonboard.com>","date":"2026-06-30T12:52:09","name":"[v2,0/5] libcamera: Improve shader header generation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/27142/mbox/","series":[{"id":6029,"url":"https://patchwork.libcamera.org/api/series/6029/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6029","date":"2026-06-30T12:52:09","name":"libcamera: Improve shader header generation","version":2,"mbox":"https://patchwork.libcamera.org/series/6029/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/27142/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A96DDC3261\n\tfor ;\n\tTue, 30 Jun 2026 12:52:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C8F2365F74;\n\tTue, 30 Jun 2026 14:52:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 864B965F55\n\tfor ;\n\tTue, 30 Jun 2026 14:52:15 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-70f3-e800--a06.rev.dnainternet.fi\n\t[IPv6:2001:14ba:70f3:e800::a06])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 84D78104C;\n\tTue, 30 Jun 2026 14:51:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hZUw1KiO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782823891;\n\tbh=AOQBr/KZ34GGjfSrPsQbq90WoFg2rMFDpQL3TT5sYj0=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=hZUw1KiOLZ05+YaTEUHnnZmRqq+/eVvFEX7QNaXSJgfocTdh43ZdIbZtjuJbiQLih\n\tCix63Pxthhgc92jEi8LSPESSn/U0t83+V8Q/EF+RXi/az0pgPfM5Vs3pQZb3cn8VVx\n\tLGbVQAssU6MfQD0Oz1O2luIyhZPWfrBadZwiDWmA=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"Bryan O'Donoghue ","Subject":"[PATCH v2 0/5] libcamera: Improve shader header generation","Date":"Tue, 30 Jun 2026 15:52:09 +0300","Message-ID":"<20260630125214.3327516-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello,\n\nI found a cleanup branch in my tree that I had forgotten to send out.\nHere it is after a rebase.\n\nThe goal was to use std::array in the generated shader header. This is\ndone in patch 4/5. As a byproduct, I ended up simplifying the generation\nby merging the two scripts into one (2/5) and moving the build logic\n(1/5) and generation script (3/5) to the right location.\n\nThe last patch (5/5) is an API improvement for the eGL class that\nresults from a suggestion received in the review of v1.\n\n\nLaurent Pinchart (5):\n libcamera: shaders: Move header generation to shaders directory\n utils: Merge shader header generation scripts\n utils: Rename and move shader header generation script\n libcamera: shaders: Replace C array with std::array\n libcamera: egl: Replace pointer and length with span for shader\n sources\n\n include/libcamera/internal/egl.h | 9 +--\n src/libcamera/egl.cpp | 29 ++++-----\n src/libcamera/meson.build | 10 ---\n src/libcamera/shaders/meson.build | 10 +++\n src/libcamera/software_isp/debayer_egl.cpp | 25 +++-----\n utils/codegen/gen-shader-header.py | 74 ++++++++++++++++++++++\n utils/codegen/meson.build | 1 +\n utils/gen-shader-header.py | 37 -----------\n utils/gen-shader-headers.sh | 54 ----------------\n utils/meson.build | 2 -\n 10 files changed, 109 insertions(+), 142 deletions(-)\n create mode 100755 utils/codegen/gen-shader-header.py\n delete mode 100755 utils/gen-shader-header.py\n delete mode 100755 utils/gen-shader-headers.sh\n\n\nbase-commit: 7a033dbdd4ca29cca2ef7eb144f6a6f57979b70d"}