[{"id":39509,"web_url":"https://patchwork.libcamera.org/comment/39509/","msgid":"<20260630084749.GN3054459@killaraus.ideasonboard.com>","date":"2026-06-30T08:47:49","subject":"Re: [PATCH 0/4] libcamera: Improve shader header generation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Jun 30, 2026 at 11:30:27AM +0300, Laurent Pinchart wrote:\n> Hello,\n> \n> I found a cleanup branch in my tree that I had forgotten to send out.\n> Here it is after a rebase.\n> \n> The goal was to use std::array in the generated shader header. This is\n> done in patch 4/4. As a byproduct, I ended up simplifying the generation\n> by merging the two scripts into one (2/4) and moving the build logic\n> (1/4) and generation script (3/4) to the right location.\n\nI forgot to mention that one of the byproducts is the removal of the\n\"[SHADER-GEN] $name\" messages during build. This is another thing that\npushed me to look at the scripts.\n\n> Laurent Pinchart (4):\n> libcamera: shaders: Move header generation to shaders directory\n> utils: Merge shader header generation scripts\n> utils: Rename and move shader header generation script\n> libcamera: shaders: Replace C array with std::array\n> \n> src/libcamera/meson.build | 10 ---\n> src/libcamera/shaders/meson.build | 10 +++\n> src/libcamera/software_isp/debayer_egl.cpp | 25 +++-----\n> utils/codegen/gen-shader-header.py | 72 ++++++++++++++++++++++\n> utils/codegen/meson.build | 1 +\n> utils/gen-shader-header.py | 37 -----------\n> utils/gen-shader-headers.sh | 54 ----------------\n> utils/meson.build | 2 -\n> 8 files changed, 91 insertions(+), 120 deletions(-)\n> create mode 100755 utils/codegen/gen-shader-header.py\n> delete mode 100755 utils/gen-shader-header.py\n> delete mode 100755 utils/gen-shader-headers.sh\n> \n> \n> base-commit: 7a033dbdd4ca29cca2ef7eb144f6a6f57979b70d","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AB986C3261\n\tfor ;\n\tTue, 30 Jun 2026 08:47:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D6DBE65F46;\n\tTue, 30 Jun 2026 10:47:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 48183658C5\n\tfor ;\n\tTue, 30 Jun 2026 10:47:51 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-70f3-e800--a06.rev.dnainternet.fi\n\t[IPv6:2001:14ba:70f3:e800::a06])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6FDEFD52;\n\tTue, 30 Jun 2026 10:47:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TY6t2Ry3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782809227;\n\tbh=R9Aekq/gTBEIUdIj1Vpw/xWb8Lj4VXzuo7J5phV63c0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=TY6t2Ry3qzP8v8WZgwXXZKstwryIPa2+kbTBQrvd2yYMra8sXJY/Tvf56u9m3J0WZ\n\tIi2EvPOXsH748YuVMVHnw0n3DC9aN7OIyvFbSpvmarK7A1jw3jCIqjlJz/+IBsVans\n\tCzlubIVwP0q2GvhrWS/+RV2IImjFKaoTp0wDnqb8=","Date":"Tue, 30 Jun 2026 11:47:49 +0300","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"Bryan O'Donoghue ","Subject":"Re: [PATCH 0/4] libcamera: Improve shader header generation","Message-ID":"<20260630084749.GN3054459@killaraus.ideasonboard.com>","References":"<20260630083031.3197714-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260630083031.3197714-1-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]