[{"id":39636,"web_url":"https://patchwork.libcamera.org/comment/39636/","msgid":"<178351594457.2174993.10029186193259181797@ping.linuxembedded.co.uk>","date":"2026-07-08T13:05:44","subject":"Re: [PATCH v2 0/2] Add cmNew to dewarp paremeters","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2026-06-17 15:48:33)\n> Hi all,\n> \n> This tiny series adds support for a second camera matrix to the dw100\n> dewarp implementation (reasoning see patch 2).\n> \n> Patch 1 contains a bit of preparatory refactoring, patch 2 implements\n> the feature.\n> \n> In v2 the union was dropped from DewarpParams to ensure we don't get\n> into undefined-behavior-land.\n\nThese patches have a small checkpatch style warning but a more difficult\ndocumetnation failure in CI:\n\nhttps://gitlab.freedesktop.org/camera/libcamera/-/jobs/104412395#L178\n\n> \n> Best regards,\n> Stefan\n> \n> Stefan Klug (2):\n> libcamera: converter: converter_dw100: Refactor dewarp param handling\n> libcamera: converter: converter_dw100: Allow to transform between\n> different camera matrices\n> \n> .../internal/converter/converter_dw100.h | 7 +-\n> .../converter/converter_dw100_vertexmap.h | 36 ++++-\n> src/libcamera/converter/converter_dw100.cpp | 28 +++-\n> .../converter/converter_dw100_vertexmap.cpp | 131 +++++++++++-------\n> 4 files changed, 137 insertions(+), 65 deletions(-)\n> \n> -- \n> 2.53.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0C773C3318\n\tfor ;\n\tWed, 8 Jul 2026 13:05:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 340546608D;\n\tWed, 8 Jul 2026 15:05:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B17066080\n\tfor ;\n\tWed, 8 Jul 2026 15:05:48 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1324FEAA;\n\tWed, 8 Jul 2026 15:04:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fVXq4zWh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783515898;\n\tbh=nPac0AETiR5+eRL9Wz13p5jl+lmQrOAUc/V6ozs1fRk=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=fVXq4zWht6hlgwiFLZgb2o8qhdM0h7s0zUX7W+HwxucH13b8Yh9EX0CfmOfiOQWsD\n\t+tkBiRrN63oCQa9EWR6Gw3uRDoitUBbzqdJu4kvWsAZteRyie08OIawgolyni2nb8C\n\tKkCtuocpOeEpA7VmwOP1Y3S1FrsqSZFcw436bFU0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260617144858.754729-1-stefan.klug@ideasonboard.com>","References":"<20260617144858.754729-1-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v2 0/2] Add cmNew to dewarp paremeters","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 08 Jul 2026 14:05:44 +0100","Message-ID":"<178351594457.2174993.10029186193259181797@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]