[{"id":39537,"web_url":"https://patchwork.libcamera.org/comment/39537/","msgid":"<178288785488.471733.12872969993534125395@ping.linuxembedded.co.uk>","date":"2026-07-01T06:37:34","subject":"Re: [PATCH v1 0/2] Clarify rectangle behavior","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Stefan,\n\nI'm trying to test this on a Raspberry Pi 5 and I get this:\n\nroot@beehive:~# rpicam-still --list\n[2:40:58.858381253] [3075] INFO IPAProxyRPiWorker raspberrypi_ipa_proxy_worker.cpp:556 Starting worker for IPA module /lib/aarch64-linux-gnu/libcamera/ipa/ipa_rpi_pisp.so with IPC fd = 12\nAvailable cameras\n-----------------\n0 : imx283 [5496x3694 12-bit RGGB] (/base/axi/pcie@1000120000/rp1/i2c@80000/imx283@1a)\n Modes: 'SRGGB10_CSI2P' : 5472x3648 [30.00 fps - (65535, 65535)/65535x65535 crop]\n 'SRGGB12_CSI2P' : 48x3694 [30.00 fps - (65535, 65535)/65535x65535 crop]\n 2736x450 [30.00 fps - (65535, 65535)/65535x65535 crop]\n 4096x450 [30.00 fps - (65535, 65535)/65535x65535 crop]\n 1824x1216 [30.00 fps - (65535, 65535)/65535x65535 crop]\n 5472x450 [30.00 fps - (65535, 65535)/65535x65535 crop]\n 2736x1824 [30.00 fps - (65535, 65535)/65535x65535 crop]\n 2304x3072 [30.00 fps - (65535, 65535)/65535x65535 crop]\n 4096x3072 [30.00 fps - (65535, 65535)/65535x65535 crop]\n 5472x3648 [30.00 fps - (65535, 65535)/65535x65535 crop]\n 5496x3672 [30.00 fps - (65535, 65535)/65535x65535 crop]\n 5496x3694 [30.00 fps - (65535, 65535)/65535x65535 crop]\n 5592x3710 [30.00 fps - (65535, 65535)/65535x65535 crop]\n\n\nThat could potentially be from rpicam-still or otherwise, but reporting\nhere as I expect we need to make sure that's verified.\n\nOtherwise - looking through - I definitely see the need to be able to\nreport the full native size! So I look forward to this progressing.\n\n--\nKieran\n\nQuoting Stefan Klug (2026-06-16 13:08:13)\n> Hi all,\n> \n> This series changes the behavior of PixelArraySize to represent the\n> physical sensor area instead of the readable pixel area. The reasoning\n> is explained in a bit more detail in patch 1. Patch 2 is a small cleanup\n> that also shows how limited the impact on the overall project is.\n> \n> With these patches applied I am able to draw proper bounding rectangles\n> in camshark. An implemented is available in\n> https://gitlab.freedesktop.org/camera/camshark/-/tree/sklug/next?ref_type=heads\n> \n> Best regards,\n> Stefan\n> \n> Stefan Klug (2):\n> libcamera: Clarify meaning of PixelArraySize and other rectangles\n> libcamera: ipa: core: Rename IPACameraSensorInfo::activeAreaSize to\n> pixelArraySize\n> \n> include/libcamera/ipa/core.mojom | 6 +-\n> src/ipa/rkisp1/algorithms/lsc.cpp | 6 +-\n> src/ipa/rpi/common/ipa_base.cpp | 4 +-\n> src/libcamera/property_ids_core.yaml | 116 ++++++++++--------\n> src/libcamera/sensor/camera_sensor_legacy.cpp | 28 +++--\n> src/libcamera/sensor/camera_sensor_raw.cpp | 18 ++-\n> 6 files changed, 96 insertions(+), 82 deletions(-)\n> \n> -- \n> 2.53.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BA7EFC3301\n\tfor ;\n\tWed, 1 Jul 2026 06:37:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F225065F7D;\n\tWed, 1 Jul 2026 08:37:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F2CA665F29\n\tfor ;\n\tWed, 1 Jul 2026 08:37:37 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7AEC81E48;\n\tWed, 1 Jul 2026 08:36:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"alvLNxH5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782887813;\n\tbh=PTxm0vfTZmnzpXoTAkxpiWlSkj5vOxnfxGntHHMPwFc=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=alvLNxH5BSXuavYsR7a1YmIDPlQfXO6Thk/wrsfjDDIEbu5JB6ZUIkzYFnvuUa1jL\n\tqPZuyFFyt5BcJyhyRcABXQJAO43+3yRz2nsrMx472vHLG08268aZqWGg7C4ifrxxsg\n\tlLURrrSAVfFy6bqqyTbZXyL0xRRSS27UzGPfiyjo=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260616120828.375547-1-stefan.klug@ideasonboard.com>","References":"<20260616120828.375547-1-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v1 0/2] Clarify rectangle behavior","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 01 Jul 2026 07:37:34 +0100","Message-ID":"<178288785488.471733.12872969993534125395@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":39539,"web_url":"https://patchwork.libcamera.org/comment/39539/","msgid":"<178288898398.471733.15936163250597083770@ping.linuxembedded.co.uk>","date":"2026-07-01T06:56:23","subject":"Re: [PATCH v1 0/2] Clarify rectangle behavior","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Kieran Bingham (2026-07-01 07:37:34)\n> Hi Stefan,\n> \n> I'm trying to test this on a Raspberry Pi 5 and I get this:\n> \n> root@beehive:~# rpicam-still --list\n> [2:40:58.858381253] [3075] INFO IPAProxyRPiWorker raspberrypi_ipa_proxy_worker.cpp:556 Starting worker for IPA module /lib/aarch64-linux-gnu/libcamera/ipa/ipa_rpi_pisp.so with IPC fd = 12\n> Available cameras\n> -----------------\n> 0 : imx283 [5496x3694 12-bit RGGB] (/base/axi/pcie@1000120000/rp1/i2c@80000/imx283@1a)\n> Modes: 'SRGGB10_CSI2P' : 5472x3648 [30.00 fps - (65535, 65535)/65535x65535 crop]\n> 'SRGGB12_CSI2P' : 48x3694 [30.00 fps - (65535, 65535)/65535x65535 crop]\n> 2736x450 [30.00 fps - (65535, 65535)/65535x65535 crop]\n> 4096x450 [30.00 fps - (65535, 65535)/65535x65535 crop]\n> 1824x1216 [30.00 fps - (65535, 65535)/65535x65535 crop]\n> 5472x450 [30.00 fps - (65535, 65535)/65535x65535 crop]\n> 2736x1824 [30.00 fps - (65535, 65535)/65535x65535 crop]\n> 2304x3072 [30.00 fps - (65535, 65535)/65535x65535 crop]\n> 4096x3072 [30.00 fps - (65535, 65535)/65535x65535 crop]\n> 5472x3648 [30.00 fps - (65535, 65535)/65535x65535 crop]\n> 5496x3672 [30.00 fps - (65535, 65535)/65535x65535 crop]\n> 5496x3694 [30.00 fps - (65535, 65535)/65535x65535 crop]\n> 5592x3710 [30.00 fps - (65535, 65535)/65535x65535 crop]\n> \n> \n> That could potentially be from rpicam-still or otherwise, but reporting\n> here as I expect we need to make sure that's verified.\n\nUhm ... never mind, please ignore my ignorance - There was a duplicated\ninstall in /usr/local/share/ causing a conflict:\n\nroot@beehive:~# rpicam-still --list\n[2:59:10.608039049] [3349] INFO IPAProxyRPiWorker raspberrypi_ipa_proxy_worker.cpp:556 Starting worker for IPA module /lib/aarch64-linux-gnu/libcamera/ipa/ipa_rpi_pisp.so with IPC fd = 12\nAvailable cameras\n-----------------\n0 : imx283 [5496x3694 12-bit RGGB] (/base/axi/pcie@1000120000/rp1/i2c@80000/imx283@1a)\n Modes: 'SRGGB10_CSI2P' : 5472x3648 [10.62 fps - (108, 36)/5472x3648 crop]\n 'SRGGB12_CSI2P' : 48x3694 [10.91 fps - (24, 16)/48x3694 crop]\n 2736x450 [151.06 fps - (108, 1404)/5472x900 crop]\n 4096x450 [79.78 fps - (792, 1632)/4096x450 crop]\n 1824x1216 [49.51 fps - (108, 36)/5472x3648 crop]\n 5472x450 [67.64 fps - (108, 1632)/5472x450 crop]\n 2736x1824 [37.46 fps - (108, 36)/5472x3648 crop]\n 2304x3072 [12.86 fps - (1692, 324)/2304x3072 crop]\n 4096x3072 [15.17 fps - (792, 324)/4096x3072 crop]\n 5472x3648 [10.70 fps - (108, 36)/5472x3648 crop]\n 5496x3672 [10.70 fps - (96, 28)/5496x3672 crop]\n 5496x3694 [10.70 fps - (96, 16)/5496x3694 crop]\n 5592x3710 [10.70 fps - (0, 0)/5592x3710 crop]\n\nNote that 5592x3710 is now at 0,0, and I think that's \"correct\" in\n'native' coordinates.\n\nSo now I have to clean up this rootfs ;-)\n\n--\nKieran\n\n> \n> Otherwise - looking through - I definitely see the need to be able to\n> report the full native size! So I look forward to this progressing.\n> \n> --\n> Kieran\n> \n> Quoting Stefan Klug (2026-06-16 13:08:13)\n> > Hi all,\n> > \n> > This series changes the behavior of PixelArraySize to represent the\n> > physical sensor area instead of the readable pixel area. The reasoning\n> > is explained in a bit more detail in patch 1. Patch 2 is a small cleanup\n> > that also shows how limited the impact on the overall project is.\n> > \n> > With these patches applied I am able to draw proper bounding rectangles\n> > in camshark. An implemented is available in\n> > https://gitlab.freedesktop.org/camera/camshark/-/tree/sklug/next?ref_type=heads\n> > \n> > Best regards,\n> > Stefan\n> > \n> > Stefan Klug (2):\n> > libcamera: Clarify meaning of PixelArraySize and other rectangles\n> > libcamera: ipa: core: Rename IPACameraSensorInfo::activeAreaSize to\n> > pixelArraySize\n> > \n> > include/libcamera/ipa/core.mojom | 6 +-\n> > src/ipa/rkisp1/algorithms/lsc.cpp | 6 +-\n> > src/ipa/rpi/common/ipa_base.cpp | 4 +-\n> > src/libcamera/property_ids_core.yaml | 116 ++++++++++--------\n> > src/libcamera/sensor/camera_sensor_legacy.cpp | 28 +++--\n> > src/libcamera/sensor/camera_sensor_raw.cpp | 18 ++-\n> > 6 files changed, 96 insertions(+), 82 deletions(-)\n> > \n> > -- \n> > 2.53.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78BEEC3301\n\tfor ;\n\tWed, 1 Jul 2026 06:56:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8DE9C65F8D;\n\tWed, 1 Jul 2026 08:56:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D188365F29\n\tfor ;\n\tWed, 1 Jul 2026 08:56:27 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 359231E48;\n\tWed, 1 Jul 2026 08:55:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TRKYpQRj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782888943;\n\tbh=oIOy/cXT7+oN8IZee2AduDG+cjKmc5jrONIJ9RssCBU=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=TRKYpQRjg7NqRJwhxXTQ9Nd/62uAJ6ZY0Hte4l+aE7IrmE5CY9NXH8iw2C8CzAq0Y\n\tAZN7A5x877RTE+0Q/RyHuKE1tmVlnjp4wPK4QEQlaQCUbjKThE56OJakJUNwtrVuk8\n\t9Cgs8XttkknoGB3FiSNdSXtOC1lp/5M2lOsroXkE=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<178288785488.471733.12872969993534125395@ping.linuxembedded.co.uk>","References":"<20260616120828.375547-1-stefan.klug@ideasonboard.com>\n\t<178288785488.471733.12872969993534125395@ping.linuxembedded.co.uk>","Subject":"Re: [PATCH v1 0/2] Clarify rectangle behavior","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 01 Jul 2026 07:56:23 +0100","Message-ID":"<178288898398.471733.15936163250597083770@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]