[{"id":38664,"web_url":"https://patchwork.libcamera.org/comment/38664/","msgid":"<CAEmqJPp7itsT6_UnuOkz1KAbtuiWS0rNgXBBrANekjk2whnZ1Q@mail.gmail.com>","date":"2026-04-28T14:11:51","subject":"Re: [PATCH v3 0/3] Atomic control lists on Raspberry Pi","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nWe seem to have lost my tags, so for this series:\n\nReviewed-by: Naushir Patuck <naush@raspberrypi.com>\n\nOn Tue, 28 Apr 2026 at 14:40, David Plowman\n<david.plowman@raspberrypi.com> wrote:\n>\n> Hi\n>\n> Version 3 of this set improves the commit message and corrects some of\n> the documentation in the first of these patches (\"Simplify delayed\n> controls\") as Laurent suggested. Otherwise there's just a single typo\n> fix that Jacopo pointed out.\n>\n> Thanks!\n>\n> David\n>\n> David Plowman (3):\n>   pipeline: rpi: Simplify delayed controls\n>   controls: rpi: Add ControlListSequence control\n>   pipeline: rpi: Make control lists in requests properly atomic\n>\n>  src/ipa/rpi/common/ipa_base.cpp               | 24 ++++---\n>  src/libcamera/control_ids_rpi.yaml            |  9 +++\n>  .../pipeline/rpi/common/delayed_controls.cpp  | 62 +++++++++++--------\n>  .../pipeline/rpi/common/delayed_controls.h    |  1 -\n>  .../pipeline/rpi/common/pipeline_base.cpp     | 46 ++++++++++++++\n>  .../pipeline/rpi/common/pipeline_base.h       |  8 +++\n>  src/libcamera/pipeline/rpi/pisp/pisp.cpp      |  3 +\n>  src/libcamera/pipeline/rpi/vc4/vc4.cpp        |  3 +\n>  8 files changed, 121 insertions(+), 35 deletions(-)\n>\n> --\n> 2.47.3\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 475FEBDCB5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 28 Apr 2026 14:12:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 18C2A62FD3;\n\tTue, 28 Apr 2026 16:12:31 +0200 (CEST)","from mail-vs1-xe2c.google.com (mail-vs1-xe2c.google.com\n\t[IPv6:2607:f8b0:4864:20::e2c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0F26762DC4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Apr 2026 16:12:29 +0200 (CEST)","by mail-vs1-xe2c.google.com with SMTP id\n\tada2fe7eead31-605767272f2so389804137.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Apr 2026 07:12:28 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"CuoVkoV+\"; dkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1777385548; cv=none;\n\td=google.com; s=arc-20240605;\n\tb=bn89ScxlT4DcKB20VlcYkEkhCg2e1Te06eFVOsE+lIz7kK6uHWRbRhziVDIeTFFAba\n\t/0nHg5CuULVCAnJ7ucokEQj0PSQ5C8yf3y5TMZyKLsV1r0MBAIuCT+SEc2wSK1hhxxZb\n\tUMSn0I0Z4GhrnrZ+OdfPMBcESOqrYOy+t/60KvSDHLKSV9ZHWp2z9Y+XsLBGXX+beOk9\n\t7nbSrzv6EYr0TRpiBtyhNfM/w4G7tLCWGE/28gArPJpA6Qy3HV8E9Is7+mUOVC8D5WIl\n\tIyi6TKD29NsaQNaMvhGjslusd0WYF3uAeTJ9yv2oW8NQx1VVIm/fZKsueH0Vbx5Wzrhq\n\tzhlQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20240605; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:dkim-signature;\n\tbh=gKb2ayoIgJnZoqnyEwR2pFFbrw0UjIsxdhy96tF+FeE=;\n\tfh=raf7gMhxwhTsDETG3li6wpOfdJf6YyDg/c7aYJ8coN8=;\n\tb=NGZl51AzjL2wmQCA03muujUhni0FsvefMCrwMHcvgah3mmvd+Z6+zoA/h0+yqmoEsY\n\tcm37lbqNQ123qE8+aBsp1OzrKu8WLf7cENINKeAh6zoZQlhNkNADh+fHOhJTZu8yyAod\n\t4XaSEI5IiSpetgyyOehJXs9QhBLQ524iuxhYp4BuJGBbGivhkJCxt8foSVwszR2gIRuv\n\tG8dlKmtkrCvvirrtsn/SS69CmXYRxvf1ljbjeixoBqjK7ByMH4OIDcGkUwu7wJzyRZfD\n\tHUCvOS8eub+KoyQvceTlIXCrB9gTesUXENMQUWwtN1kwcMs0ly0c6w09dZROXlC8ntUc\n\twqDQ==; darn=lists.libcamera.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1777385548; x=1777990348;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=gKb2ayoIgJnZoqnyEwR2pFFbrw0UjIsxdhy96tF+FeE=;\n\tb=CuoVkoV+RJCbRGko4xtvxWyNFgZuMWWMsGnpQH25j4MTTMhdXiXNyde04+K7UMcjd1\n\tee7FQBSBYMJx+6KbZOupmH4Lc1cUMiLkIJGrUxjwLJV9aScO3lqpD3ZG7hFA7FN72kHP\n\tQbnYfosQq2em1KbJc6kpHNTzfpExrM4O0b3Af9KhRGhuZu9KN5z/62cSGRDXEla59sBC\n\t7f6v0ESb2Hvux5hkIVNMHJkMhqetr4bBAJchmMTaVN8gfXXIls+rCkRWemIDCtDuJkDk\n\tIKsmhotyvdTn+VDvWwsH8x7/DD3YWsj4VvIEowE7FsSYKve/A1+OFq1sjy7TqO+RbeSV\n\tohsA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1777385548; x=1777990348;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=gKb2ayoIgJnZoqnyEwR2pFFbrw0UjIsxdhy96tF+FeE=;\n\tb=JYds80EWsnl0xTE3H4iK+i1yKbQKtlOIqH/I2/3v7cx4ATt/Nu4CoBKu3rlugyk5gV\n\tvKlzI1QVqQt6KLtCFCjCJHOQIrokdrWokRl/QX4s6QM3lLF4zQci2oEmVehIL9qEK9/C\n\t+rYGc817a7smXWym8rZxbG5GDP21hdIUbsMRQ/0fij3uqn4dO6v3lYwaM7RUqJrp5/qS\n\tmueKddHH6rpv7hxfXgAhWcKG+nNYlvcoCG7pqMvGKUA1YaEwuRgzc+FRR0+ZB/mKmv86\n\tGGlxrAyGqy/+LzUBqGG6IY0YT2nPo/i0fctopnaLJ+FLSgMtCc9pialmUxJL/AzYUnU+\n\t/nsg==","X-Gm-Message-State":"AOJu0YxKTd73fsTkPE52ELllDwbu/tDo3cZt8lPShbuZTbvoW08PLpCB\n\tOaMCIom68mXAYvXE3S11FlK8R58Fqu3FyarCEjTPve0B/UGF485w/gOUJ2o31iDOIEOSfREbAfd\n\tNUvoOtMGsMZjwbLUlas8viDON84dddlR94Zcf/hZGSQ==","X-Gm-Gg":"AeBDieupp70zAedZvuP0A0CM4nCfVCnWWz6jGi5UIdqS2nb1w9luFINES938HzE0RW5\n\tlArtTGBzcB250G+yVsyQqiyjDpWBuLBIdHSUW4+5aEKUwZVUlcHjT6pILt+Xh9CzF0D8ueOpyzK\n\tn8R6oQEpUQToukxAIuoZU3gGVwsV8ZWZ7Y8BRxKr0txij8R+1or6pINMQKBaAjtqCPlD8hoigCT\n\tIG6LyseMVnPRwVjz6oKyJJ2+ZqJQZGLUorG6+bHc6g4T+zkExSOqypF89XPwWVPq5xuBekFfdM7\n\tUT6Ng2fFWjECHqo+rVJS4i8l7mEw2NVQMM6JdKb9EAUkT4/HsQjP1utn1IyOGD5+66+jPTvyZcG\n\t7A2oXUo/BmhSIyImTVCmiyoHGKjzWxHYlokkaZ+xdawHy+F12WKMe06sIe+9JeHPd0VB85DlCL7\n\t0M31dtGIF35hqo7PyHW1hFe+uEua5Oktgynw==","X-Received":"by 2002:a05:6102:508f:b0:610:edb0:c5a1 with SMTP id\n\tada2fe7eead31-627d55c69e4mr638085137.6.1777385547537; Tue, 28 Apr 2026\n\t07:12:27 -0700 (PDT)","MIME-Version":"1.0","References":"<20260428133952.6582-1-david.plowman@raspberrypi.com>","In-Reply-To":"<20260428133952.6582-1-david.plowman@raspberrypi.com>","From":"Naushir Patuck <naush@raspberrypi.com>","Date":"Tue, 28 Apr 2026 15:11:51 +0100","X-Gm-Features":"AVHnY4KOjXEfAyQ1-P9TqHeCDvGfMJ847GgVGyDZD3MXoer7Vyh4BpwMb6V2yIY","Message-ID":"<CAEmqJPp7itsT6_UnuOkz1KAbtuiWS0rNgXBBrANekjk2whnZ1Q@mail.gmail.com>","Subject":"Re: [PATCH v3 0/3] Atomic control lists on Raspberry Pi","To":"David Plowman <david.plowman@raspberrypi.com>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]