[{"id":38470,"web_url":"https://patchwork.libcamera.org/comment/38470/","msgid":"<20260401072622.GB3678287@killaraus.ideasonboard.com>","date":"2026-04-01T07:26:22","subject":"Re: [PATCH 0/2] Add Disco Mode to the rkisp1 pipeline handler","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Funkmaster General,\n\nOn Wed, Apr 01, 2026 at 08:16:37AM +0100, Isaac Scott wrote:\n> I'm sure I can speak for many users here in saying that libcamera's\n> current implementation of the pipeline handler of the rkisp1 has a\n> disappointing lack of \"groove\". It has made me really struggle to set up\n> my iMX8MP to record my music videos.\n> \n> Ultimately, I have had to resort to manually adjusting the output colour\n> of my monitor, which has proven to be impractical. I've thought about\n> maybe using a spinning wheel connected to a diesel generator, but alas;\n> It's just a bit too loud to be able to hear the thumpin' beats from my\n> meaty subwoofer, so I thought I'd tackle the problem at the source.\n> \n> This series adds support for 'Disco Mode', with an adjustable Funk\n> level.\n> \n> I hope this series helps as many people as possible, as it's certainly\n> helped me.\n\nThank you for the patches, this implements a missing feature in\nlibcamera that I think many people were waiting for.\n\nAs an image is worth a thousand words, I thought a short video that\ndemonstrates the new disco mode will help the review process:\nhttps://ideasonboard.org/libcamera-disco-mode.mp4\n\n> Best wishes,\n> \n> Signed-off-by: Isaac \"Funkmaster General\" Scott \n> \n> Isaac Scott (2):\n> rkisp1: Add disco mode\n> rkisp1: Turn it up to 11\n> \n> src/ipa/rkisp1/algorithms/awb.cpp | 25 +++++++++++++++++++++++++\n> src/ipa/rkisp1/ipa_context.h | 4 ++++\n> src/libcamera/control_ids_core.yaml | 17 +++++++++++++++++\n> 3 files changed, 46 insertions(+)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D3739BEFBE\n\tfor ;\n\tWed, 1 Apr 2026 07:26:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C38A562D44;\n\tWed, 1 Apr 2026 09:26:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 41F1162781\n\tfor ;\n\tWed, 1 Apr 2026 09:26:24 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 1BA93E0D;\n\tWed, 1 Apr 2026 09:25:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"A+WWzMIO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775028301;\n\tbh=+rmMt+PjwIhAknKKi6AUv63vR4WYIj5kN7YKbterOgk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=A+WWzMIOpOUd2BjmrPI+NdpD4a62YhAavVenFhPY3hjFPT6sQuD2xfUkz9oKR5Y3d\n\tVb/4hxiy5nbnP3m5PNF5r+5/xF9luxWFHaeUL6O0Ra5v4oVIg13LrHGBUdoltLrfas\n\tWlQN+x+gTeuQxOSONpDgA+LCY/F99TbM7H1Db1SM=","Date":"Wed, 1 Apr 2026 10:26:22 +0300","From":"Laurent Pinchart ","To":"Isaac Scott ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 0/2] Add Disco Mode to the rkisp1 pipeline handler","Message-ID":"<20260401072622.GB3678287@killaraus.ideasonboard.com>","References":"<20260401071650.116344-2-isaac.scott@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260401071650.116344-2-isaac.scott@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38477,"web_url":"https://patchwork.libcamera.org/comment/38477/","msgid":"<177503710328.3376561.3114501439486984791@ping.linuxembedded.co.uk>","date":"2026-04-01T09:51:43","subject":"Re: [PATCH 0/2] Add Disco Mode to the rkisp1 pipeline handler","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Isaac,\n\nQuoting Isaac Scott (2026-04-01 08:16:37)\n> I'm sure I can speak for many users here in saying that libcamera's\n> current implementation of the pipeline handler of the rkisp1 has a\n> disappointing lack of \"groove\". It has made me really struggle to set up\n> my iMX8MP to record my music videos.\n> \n> Ultimately, I have had to resort to manually adjusting the output colour\n> of my monitor, which has proven to be impractical. I've thought about\n> maybe using a spinning wheel connected to a diesel generator, but alas;\n> It's just a bit too loud to be able to hear the thumpin' beats from my\n> meaty subwoofer, so I thought I'd tackle the problem at the source.\n> \n> This series adds support for 'Disco Mode', with an adjustable Funk\n> level.\n> \n> I hope this series helps as many people as possible, as it's certainly\n> helped me.\n> \n> Best wishes,\n> \n> Signed-off-by: Isaac \"Funkmaster General\" Scott \n\nThis is a clear advantage to end users, Especially when Nigel Tufnel\nexpects his extra push over the cliff, which he has personally asked\nfor.\n\nI think we should merge it before lunch time even...\n\nRubber-stamped-by: Kieran Bingham \n\n> \n> Isaac Scott (2):\n> rkisp1: Add disco mode\n> rkisp1: Turn it up to 11\n> \n> src/ipa/rkisp1/algorithms/awb.cpp | 25 +++++++++++++++++++++++++\n> src/ipa/rkisp1/ipa_context.h | 4 ++++\n> src/libcamera/control_ids_core.yaml | 17 +++++++++++++++++\n> 3 files changed, 46 insertions(+)\n> \n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0E570BEFBE\n\tfor ;\n\tWed, 1 Apr 2026 09:51:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 021F262D4D;\n\tWed, 1 Apr 2026 11:51:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB8B862781\n\tfor ;\n\tWed, 1 Apr 2026 11:51:46 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AD898F04;\n\tWed, 1 Apr 2026 11:50:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cMKPuUi6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775037023;\n\tbh=zBV1YB57n0EMZM6kMpNZpVVuA9cHzB5E+29RBKozEdI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=cMKPuUi62Xfdupy5ey1rju3xUgiF7/Cw1xoXKDuV/ajW3AAQi6suWg/I2jvK3lPVR\n\tw2I7ZH4syU3CQJpuR2sOmbKTNSFrhIwlxNsBoOEbw3zMALtQDzslPkUUPwKert+mvw\n\tl0HMCg67Wkt6kNlcttuYoZPbK7QbZeOXcUAzGasQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260401071650.116344-2-isaac.scott@ideasonboard.com>","References":"<20260401071650.116344-2-isaac.scott@ideasonboard.com>","Subject":"Re: [PATCH 0/2] Add Disco Mode to the rkisp1 pipeline handler","From":"Kieran Bingham ","Cc":"Isaac Scott ","To":"Isaac Scott ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 01 Apr 2026 10:51:43 +0100","Message-ID":"<177503710328.3376561.3114501439486984791@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]