[{"id":390,"web_url":"https://patchwork.libcamera.org/comment/390/","msgid":"<20190117215411.GG23244@pendragon.ideasonboard.com>","date":"2019-01-17T21:54:11","subject":"Re: [libcamera-devel] [PATCH v4 0/2] V4L2Device: Add basic V4L2\n\tsupport class","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patches.\n\nOn Thu, Jan 17, 2019 at 09:27:01PM +0000, Kieran Bingham wrote:\n> Define the beginnings of a V4L2 device management object.\n> \n> This basic class supports opening the device and parsing the device\n> capabilities including obtaining the driver, device, and bus\n> information.\n> \n> The device will reject ->open() calls on devices which are not either\n> CAPTURE or OUTPUT devices and those which do not support the streaming\n> I/O interface.\n> \n> Kieran Bingham (2):\n> libcamera: Add V4L2 Device object\n> test: v4l2_device: Add test suite and initial test\n\nFor the whole series,\n\nReviewed-by: Laurent Pinchart \n\n> src/libcamera/include/v4l2_device.h | 60 +++++++++\n> src/libcamera/meson.build | 2 +\n> src/libcamera/v4l2_device.cpp | 186 ++++++++++++++++++++++++++\n> test/meson.build | 1 +\n> test/v4l2_device/double_open.cpp | 38 ++++++\n> test/v4l2_device/meson.build | 12 ++\n> test/v4l2_device/v4l2_device_test.cpp | 43 ++++++\n> test/v4l2_device/v4l2_device_test.h | 27 ++++\n> 8 files changed, 369 insertions(+)\n> create mode 100644 src/libcamera/include/v4l2_device.h\n> create mode 100644 src/libcamera/v4l2_device.cpp\n> create mode 100644 test/v4l2_device/double_open.cpp\n> create mode 100644 test/v4l2_device/meson.build\n> create mode 100644 test/v4l2_device/v4l2_device_test.cpp\n> create mode 100644 test/v4l2_device/v4l2_device_test.h","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 04E1A60B2D\n\tfor ;\n\tThu, 17 Jan 2019 22:54:11 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 58F8153E;\n\tThu, 17 Jan 2019 22:54:11 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1547762051;\n\tbh=ui9/J52Rpowy84jgVhaBSSjivR1CvzQuoeSbgufdhH4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PfVC+ielTu798m2SOpi78L3dhD5vrlNdWT0elQtN/RIxnkLJ50BPNPoVRX3rmJOEt\n\t6RWR2F+e+r/luffWwGRNr2kQ/Pt3XIKjSVFlgfR0t0PiV8MAedhhjQyejA9L6hErM5\n\tIVGs39lfAtcZ1nGjWwRQzBCiHRQKxsk0/R2qLID8=","Date":"Thu, 17 Jan 2019 23:54:11 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20190117215411.GG23244@pendragon.ideasonboard.com>","References":"<20190117212703.24047-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190117212703.24047-1-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v4 0/2] V4L2Device: Add basic V4L2\n\tsupport class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 17 Jan 2019 21:54:12 -0000"}}]