{"id":26136,"url":"https://patchwork.libcamera.org/api/covers/26136/?format=json","web_url":"https://patchwork.libcamera.org/cover/26136/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260212151238.3736234-1-laurent.pinchart@ideasonboard.com>","date":"2026-02-12T15:12:34","name":"[v2,0/4] libcamera: Clean up iterators","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/26136/mbox/","series":[{"id":5787,"url":"https://patchwork.libcamera.org/api/series/5787/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5787","date":"2026-02-12T15:12:34","name":"libcamera: Clean up iterators","version":2,"mbox":"https://patchwork.libcamera.org/series/5787/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/26136/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6FC1BBD78E\n\tfor ;\n\tThu, 12 Feb 2026 15:12:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6CABD621CD;\n\tThu, 12 Feb 2026 16:12:42 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2676B61FBF\n\tfor ;\n\tThu, 12 Feb 2026 16:12:40 +0100 (CET)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 00B43492\n\tfor ;\n\tThu, 12 Feb 2026 16:11:51 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eDExc50T\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770909112;\n\tbh=b1TXD08RIibjjKmvxusskqSCPz/vjZqIieafFbmA2aA=;\n\th=From:To:Subject:Date:From;\n\tb=eDExc50TvpEMxzVHoF1qHkEjOaEU4mZzBAogdNg0GcF5mPuio2Rw5UUwgI9XLG22n\n\txgX96hnElXUHxB8IALsgPGaaq2KZ9ZPm6zdP0VPXE+rwlJqbLPX+8KCycRBCAWN2VH\n\tQoNjV/KVyB8MUrJbUP8vHb0Jd0O0GUonwGVe0Y2M=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v2 0/4] libcamera: Clean up iterators","Date":"Thu, 12 Feb 2026 17:12:34 +0200","Message-ID":"<20260212151238.3736234-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.52.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello,\n\nThis patch series cleans up usage of iterators to standardize on\nrange-based loops and structured bindings wherever possible (and\nconvenient). What started as a single patch is now a series that\n\n- Replaces map iterators and pairs with structured bindings (1/4)\n- Replaces iterators for non-associative containers (vector, span, ...)\n with range-based for loops (2/4)\n- Rename one occurrence of a variable named 'it' that does not refer to\n an iterator (3/4)\n- Standardize on 'const auto' instead of 'auto const'\n\nOne thing *not* addressed by this series is replacement of 'auto' with\n'const auto' or 'const auto &' where applicable. This could be done on\ntop by someone with enough motivation :-)\n\nLaurent Pinchart (4):\n libcamera: Replace iterators with structured bindings\n libcamera: Replace iterators with range-based for loops\n libcamera: Use `it` variable name for iterators only\n libcamera: Standardize on 'const auto'\n\n .../guides/application-developer.rst | 2 +-\n include/libcamera/base/utils.h | 10 ++--\n .../libcamera/internal/ipa_data_serializer.h | 10 ++--\n src/apps/common/options.cpp | 6 +--\n src/apps/common/stream_options.cpp | 4 +-\n src/gstreamer/gstlibcamera-controls.cpp.in | 7 +--\n src/gstreamer/gstlibcamera-utils.cpp | 50 ++++++++-----------\n src/ipa/ipu3/ipu3.cpp | 8 +--\n src/ipa/mali-c55/mali-c55.cpp | 8 +--\n src/ipa/rkisp1/rkisp1.cpp | 8 +--\n src/ipa/rpi/common/ipa_base.cpp | 4 +-\n src/ipa/rpi/controller/controller.cpp | 6 +--\n src/ipa/rpi/controller/rpi/agc.cpp | 4 +-\n src/ipa/rpi/controller/rpi/agc_channel.cpp | 2 +-\n src/ipa/rpi/controller/rpi/lux.cpp | 2 +-\n src/ipa/rpi/pisp/pisp.cpp | 2 +-\n src/ipa/rpi/vc4/vc4.cpp | 2 +-\n src/ipa/simple/soft_simple.cpp | 8 +--\n src/libcamera/camera.cpp | 4 +-\n .../converter/converter_v4l2_m2m.cpp | 8 +--\n src/libcamera/delayed_controls.cpp | 4 +-\n src/libcamera/media_device.cpp | 2 +-\n src/libcamera/pipeline/ipu3/cio2.cpp | 6 +--\n src/libcamera/pipeline/ipu3/ipu3.cpp | 11 ++--\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-\n .../pipeline/rpi/common/delayed_controls.cpp | 4 +-\n .../pipeline/rpi/common/pipeline_base.cpp | 29 ++++++-----\n .../pipeline/rpi/common/rpi_stream.cpp | 8 +--\n src/libcamera/pipeline/rpi/pisp/pisp.cpp | 6 +--\n src/libcamera/pipeline/rpi/vc4/vc4.cpp | 2 +-\n src/libcamera/pipeline/vimc/vimc.cpp | 10 ++--\n src/libcamera/pipeline/virtual/virtual.cpp | 2 +-\n src/libcamera/sensor/camera_sensor_legacy.cpp | 4 +-\n src/libcamera/sensor/camera_sensor_raw.cpp | 4 +-\n src/libcamera/software_isp/software_isp.cpp | 3 +-\n src/libcamera/stream.cpp | 8 +--\n src/libcamera/v4l2_videodevice.cpp | 8 ++-\n test/media_device/media_device_print_test.cpp | 10 ++--\n test/v4l2_videodevice/buffer_cache.cpp | 2 +-\n 39 files changed, 125 insertions(+), 155 deletions(-)\n\n\nbase-commit: 1dcf9957a47fb54fce4fbae9daec0b587e52562e"}