{"id":25845,"url":"https://patchwork.libcamera.org/api/covers/25845/?format=json","web_url":"https://patchwork.libcamera.org/cover/25845/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260119113104.3560802-1-barnabas.pocze@ideasonboard.com>","date":"2026-01-19T11:30:58","name":"[v2,0/5] libcamera: base: log: Do not instantiate disabled `LogMessage`s","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/25845/mbox/","series":[{"id":5716,"url":"https://patchwork.libcamera.org/api/series/5716/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5716","date":"2026-01-19T11:30:58","name":"libcamera: base: log: Do not instantiate disabled `LogMessage`s","version":2,"mbox":"https://patchwork.libcamera.org/series/5716/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/25845/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80997BDCBF\n\tfor ;\n\tMon, 19 Jan 2026 11:31:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9E00761FC4;\n\tMon, 19 Jan 2026 12:31:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D2F67606D5\n\tfor ;\n\tMon, 19 Jan 2026 12:31:07 +0100 (CET)","from pb-laptop.local (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4C30E2D9\n\tfor ;\n\tMon, 19 Jan 2026 12:30:37 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"I+yIuKtf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768822237;\n\tbh=gGKW9oEvAb52Rzk2mkoHGbv7zCeCan397cCE5Sg2s10=;\n\th=From:To:Subject:Date:From;\n\tb=I+yIuKtfRwN6aAu4qvtk/FJq/93W8k8W6bWlaY0vyT+DVCudtGpYvi3qBGSgUxTOB\n\t++Pn/G2AbMjkKDny20cEaDE8lieSB6N8aM2tD2c4wtwOA/aGWA7LL6//SkU7x2DAw+\n\toDbrngkNZDSONH5E4lSXm3nfH1zP4/t7Q9AoDaCs=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v2 0/5] libcamera: base: log: Do not instantiate disabled\n\t`LogMessage`s","Date":"Mon, 19 Jan 2026 12:30:58 +0100","Message-ID":"<20260119113104.3560802-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.52.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The main goal of this series is to avoid the construction of `LogMessage`s\nthat in the end will not be printed and just discarded.\n\nchanges in v2:\n * remove the unnecessary log level checks in:\n * ~LogMessage()\n * ASSERT()\n\nv1: https://patchwork.libcamera.org/cover/22909/\n\nBarnabás Pőcze (5):\n treewide: Remove `libcamera::LOG(...)` occurrences\n libcamera: base: log: Do not instantiate disabled `LogMessage`s\n libcamera: base: log: Do not check severity before printing\n libcamera: base: log: Remove `LogInvalid` check\n libcamera: base: log: Inline `LOG()` into `ASSERT()`\n\n include/libcamera/base/log.h | 17 ++++++++++++-----\n src/libcamera/base/log.cpp | 7 +------\n src/libcamera/sensor/camera_sensor_raw.cpp | 8 +++++---\n src/libcamera/v4l2_device.cpp | 10 ++++++----\n 4 files changed, 24 insertions(+), 18 deletions(-)\n\n--\n2.52.0"}