[{"id":37684,"web_url":"https://patchwork.libcamera.org/comment/37684/","msgid":"","date":"2026-01-16T08:49:00","subject":"Re: [PATCH v8 0/7] refactor DPF parsing and initialization","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hu Rui\n\nOn Thu, Jan 15, 2026 at 11:33:11AM -0500, Rui Wang wrote:\n> This patch series refactors the DPF (Denoise Pre-Filter) parsing and\n> nitialization\n> in the rkisp1 IPA module, and enables DPF tuning for the IMX219/OV5647/OV5640 sensor.\n> The changes include restructuring the DPF configuration handling, improving\n> readability, and adding support for sensor-specific DPF parameters.\n> Support mode selection base on tuning parameters\n\nI see you have taken in the suggestion to remove the \"default\"\nconfiguration and only keep modes. Please record it in the changelog\nnext time when such change is made, as it's a change that impacts the\nwhole series.\n\nThanks\n j\n\n>\n> Rui Wang (7):\n> ipa: rkisp1: algorithms: dpf: refactor DPF parsing and initialization\n> ipa: rkisp1: algorithms: dpf: Implement mode switching\n> ipa: rkisp1: algorithms: dpf: Refactor prepare() into helpers\n> ipa: rkisp1: algorithms: dpf: Simplify YAML key names\n> ipa: rkisp1: algorithms: dpf: Add detailed config logging\n> ipa: rkisp1: algorithms: data: enable DPF tuning for sensors\n> ipa: rkisp1: algorithms: data: Add OV5647 tuning file\n>\n> src/ipa/rkisp1/algorithms/dpf.cpp | 272 ++++++++++++++++++++++++------\n> src/ipa/rkisp1/algorithms/dpf.h | 24 +++\n> src/ipa/rkisp1/data/imx219.yaml | 24 +++\n> src/ipa/rkisp1/data/meson.build | 1 +\n> src/ipa/rkisp1/data/ov5640.yaml | 59 +++++--\n> src/ipa/rkisp1/data/ov5647.yaml | 32 ++++\n> 6 files changed, 342 insertions(+), 70 deletions(-)\n> create mode 100644 src/ipa/rkisp1/data/ov5647.yaml\n>\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B547AC3226\n\tfor ;\n\tFri, 16 Jan 2026 08:49:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9006361FC3;\n\tFri, 16 Jan 2026 09:49:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 597B961A35\n\tfor ;\n\tFri, 16 Jan 2026 09:49:09 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2001:b07:6462:5de2:520d:d7a3:63ca:99e8])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 490853D7;\n\tFri, 16 Jan 2026 09:48:36 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Kyfw3rnn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768553321;\n\tbh=OLER9Y3ZuGCVjImlEDYkdm673ENHW4a5RybF39bHuRE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Kyfw3rnnW1boQiggm42K49eHRJ5knAT7fSRlZ6wrrogt3dRy5asHMUCQCBpGK5Ft/\n\tCioa18705LtLIYDG+PTX3sBG61wNfkcot5WZGpqtmTAG/v4gNrPZNQcRfPQVGE6iVK\n\tHP73ZhfqnZYUJQ7TFZpC8mcWLI2jljVLcRgBGhjA=","Date":"Fri, 16 Jan 2026 09:49:00 +0100","From":"Jacopo Mondi ","To":"Rui Wang ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v8 0/7] refactor DPF parsing and initialization","Message-ID":"","References":"<20260115163318.1339354-1-rui.wang@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260115163318.1339354-1-rui.wang@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]