[{"id":37658,"web_url":"https://patchwork.libcamera.org/comment/37658/","msgid":"<4c460593-60ee-4189-90a1-973ad375b913@oss.qualcomm.com>","date":"2026-01-14T15:20:50","subject":"Re: [PATCH 0/4] GPUISP cleanups","submitter":{"id":242,"url":"https://patchwork.libcamera.org/api/people/242/","name":"Hans de Goede","email":"johannes.goede@oss.qualcomm.com"},"content":"Hi,\n\nOn 10-Jan-26 18:09, Robert Mader wrote:\n> Some minor cleanups and one possibly helpful debug print.\n> \n> Robert Mader (4):\n> egl: Remove unused functions\n> egl: Remove bpp variable\n> egl: Remove duplicated logging of EGL version\n> egl: Detect and print GLES version\n\nThanks, I've given this a quick test run and not found any issues:\n\nTested-by: Hans de Goede # Thinkpad X1 Carbon G13 IPU7 ov08x40\n\nRegards,\n\nHans","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D1430BDCBF\n\tfor ;\n\tWed, 14 Jan 2026 15:20:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E042F61FBC;\n\tWed, 14 Jan 2026 16:20:57 +0100 (CET)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n\t[205.220.168.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BE32961F9F\n\tfor ;\n\tWed, 14 Jan 2026 16:20:56 +0100 (CET)","from pps.filterd (m0279864.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t60EERspi148452 for ;\n\tWed, 14 Jan 2026 15:20:54 GMT","from mail-qk1-f197.google.com (mail-qk1-f197.google.com\n\t[209.85.222.197])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bp6rahncr-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ;\n\tWed, 14 Jan 2026 15:20:54 +0000 (GMT)","by mail-qk1-f197.google.com with SMTP id\n\taf79cd13be357-8b234bae2a7so2466033485a.3\n\tfor ;\n\tWed, 14 Jan 2026 07:20:54 -0800 (PST)","from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec?\n\t(2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:5bfa:a036:83f0:f9ec])\n\tby smtp.gmail.com with ESMTPSA id\n\t4fb4d7f45d1cf-6507b8c4454sm23518383a12.3.2026.01.14.07.20.51\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tWed, 14 Jan 2026 07:20:51 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"Vouejaxf\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"VKxwhsQr\"; dkim-atps=neutral","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcontent-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n\tmZHfAnlY7X53djLm5rGOzL+6YPuTvMyyNm4gwpKau4M=; b=Vouejaxf9D4J78nG\n\tbFvhpJh73yXbVwW4H77FtZfjkZ226F7PbWEyPE7TA9yQA3x7yNUMqk5yQZzxEhO6\n\tZuoBwF2gh5EyhoIPiVsJH40AuFbLtUwIF4d7MIgUHlyzvECvT22iAUa5PlsEIEMC\n\taQszONcnh+JSmzwLqtnXIDAsBg8aHBwCIgk4Bo4oyhHkvlgoc7forNEFYzVDWc0K\n\tYrBwMETHx480tT1JaMwrITq5FVYVNW/3MIKbmkiEBOSNESohyt+leG2q4SVa9o4a\n\tGvnrLAIlfkvz119K3fo5UoDMvqk4VBIULgbBvWutiYZOU896qPzwnXlQos+ijikB\n\tcQNPzw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1768404053; x=1769008853;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:content-language:from\n\t:references:to:subject:user-agent:mime-version:date:message-id:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=mZHfAnlY7X53djLm5rGOzL+6YPuTvMyyNm4gwpKau4M=;\n\tb=VKxwhsQrhvhxJI9J5JFWQHtaNc097h3iszJQMbnnEqknXRNqZSZGpBgkInsCoYDRNk\n\tfy0Z+ZMbTFgYDa/43JfqM1VaB7mNGzcuDsXIL6tyQcNnd/VoVYIPKSqklGk1ksewrJbd\n\txK+12M/jt3hZaPOen9r84q1lXzLQf1Q0XvYvQQnUXROIqGF007Oslmug0JcylQ6MtB+D\n\tZ7aq6pv7X7BYps1KdsemPIw2BJTzxKaKTCeWqAbjWxfa9LMH9skpowymHHcBkj2e/p47\n\ttrIDwqQ2tXdx0gVji/EnsavWo7LOQuEqQgrHseuUOdso1JJPZKFBNnubjZ17kWG/RkzX\n\tnbZQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1768404053; x=1769008853;\n\th=content-transfer-encoding:in-reply-to:content-language:from\n\t:references:to:subject:user-agent:mime-version:date:message-id\n\t:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=mZHfAnlY7X53djLm5rGOzL+6YPuTvMyyNm4gwpKau4M=;\n\tb=keWXvHPXQCu8+xgNSV+9x1eVMTCdLmceELvqgRCL2m0QkKWL4/hQZE3+JZ1rlZNGMm\n\tnkyI8k2VA+hMNy8EXt347iadr3tNspzBsZtRAWiGsb/cxyCBGCDnSnccVohk+hq8D/OS\n\toSLhDDz+PECEpflLRVxbcKheiPmDTHHPNEpnGLu8wp9xbeA/Ib7lQnn4R0ZSDmUO5nIw\n\tS5XA1PGZOtIBrtZVpBzJIpfjw6gf48mOBtbnaAzIGH2eH60fEaCT8gpf/aMYpmDZoFBF\n\tZadIm2xfAsNs7vDVl3+uxfNCW+JblgFRg6ug7o0cL04kn38qIyN+oMb5loiMUOhGVVJv\n\tJ/lw==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCXUQ/yiwKHf/dDxGnIiP2M4YVW62Y5mn7Bk9o2at2mtqOYV1waw9AUOaH9+OwkenGs032DePg5jNdLJpb8S/jc=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YyBYiE3M+7b9KeFsZyLGTM9wBYJj28OJLX/ncQDJfnBkNAS/4gT\n\tv6Ubh3nhj0hHL63B5gkmemKpQ4zzTfOBtTvjqJOj5jYE8zhpXF1QVLoMHBvauGQW/kCzJkkzMLd\n\t8JezFJkU3nGlVGXizYhxqGCVpUrMXvV4RUUUW99CPisYm8jm/8P/EB+0pSdkUfExRL14hkATpBu\n\tx4sbT/ubVs","X-Gm-Gg":"AY/fxX7r/fv20KKurVW2bmMJholtEBFeC0neE3aWgfQy8MiuFLFNfkAoQbbb4eGoYfD\n\tPZy2+awiwb+jSpAGYDRLmKCcvNPKkY2qOAtBMM6CYQx24t1aCHcXjhlVTR0jpPpdyFUJpiJsx4Y\n\t6HTPJ6S/bw4oE/dYS4yaWMN11LHe/Giyh/CZAQ+0rJiEAoTtuy1a2tVZ6UFY6WMrGfX/cVbC6PG\n\tgZMtLkFANZdnlYUYLdYVUPr2LaonLnRC85jM1VbaAXCjGdwlp6BAflVmLybKR4FKeIrEDMxm7U2\n\tVTXOa7uBMKlMAkMAi55ZnlYuB6DFZQGM6HZRVW8PUouZZetcTtoTUkJiQton9N1pOTwTy9syiEz\n\t5zwNu/1TilCsXrrltbMaSXN3cRCyEVf5Bev5uxgTLMyNRrF2VWxfkZNGe2uJVS3ZTi3WoJAyVeB\n\tuK+ZbO4Lqrdd6GxaYFGTHB6Q+NtpOPbbAuL0SteAHr0a6p0afdSW1N0B3/pUTvfc5+mjgbtS5Li\n\tGpK","X-Received":["by 2002:a05:620a:3726:b0:8c0:d16b:b09c with SMTP id\n\taf79cd13be357-8c52fbdd39fmr362964785a.58.1768404053366; \n\tWed, 14 Jan 2026 07:20:53 -0800 (PST)","by 2002:a05:620a:3726:b0:8c0:d16b:b09c with SMTP id\n\taf79cd13be357-8c52fbdd39fmr362960785a.58.1768404052892; \n\tWed, 14 Jan 2026 07:20:52 -0800 (PST)"],"Message-ID":"<4c460593-60ee-4189-90a1-973ad375b913@oss.qualcomm.com>","Date":"Wed, 14 Jan 2026 16:20:50 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 0/4] GPUISP cleanups","To":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260110170927.79918-1-robert.mader@collabora.com>","From":"Hans de Goede ","Content-Language":"en-US, nl","In-Reply-To":"<20260110170927.79918-1-robert.mader@collabora.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwMTE0MDEyOCBTYWx0ZWRfX2Ljs5IDycRQC\n\tESFQbCiDWMtMe4+yAOVfuOrirofgs0ZrNJbVpbgK02qSoyq8f8S5rV+is2gdgqS+/LyOeSqCZXg\n\tejqjfXGFd34TWyx2AA2kQBNniSyTvTsy+2KynREb/qSLlKUeJytVgUQUjXKcp2gnuqgsPlTCuH0\n\tLsRUy4FIm43k/uBPMx6fW9uejpPzTiZqGT6+liNuEkqeQUst4CJ6ZDJ0b/Sr1IzgZMswePDMJsP\n\tmP+faryTUQsGnSdj9ZwFJJxPnlt1pXZwpzCKzsU+PHl+VG+rAF376Aa3QoV8w1dv14O11TypAd0\n\t6yu9JDyG3O40DJy9PwMoSDuUzbl+uCTZBWvja4wd1XLPg/snGmC9GVZnSWx4yIUeFmhD8lV64s8\n\tYUimK0QiG9XGn19qVOzWM8WNur9fHKAYTBXEz1aCO2jMVBzhPGn13BJW9w11BLOUt77E7klT/II\n\tjgyja9jtyF+60m3fYPw==","X-Proofpoint-GUID":"3P6xVT0kWVdswLfPerCYCl49mdrCJMJ1","X-Proofpoint-ORIG-GUID":"3P6xVT0kWVdswLfPerCYCl49mdrCJMJ1","X-Authority-Analysis":"v=2.4 cv=L/EQguT8 c=1 sm=1 tr=0 ts=6967b456 cx=c_pps\n\ta=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10\n\ta=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n\ta=EUspDBNiAAAA:8 a=Yk-SkkECRpEFX6TdghgA:9 a=QEXdDO2ut3YA:10\n\ta=IoWCM6iH3mJn3m4BftBB:22","X-Proofpoint-Virus-Version":"vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1121, Hydra:6.1.9,\n\tFMLib:17.12.100.49\n\tdefinitions=2026-01-14_04,2026-01-14_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tsuspectscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015\n\tspamscore=0\n\tphishscore=0 malwarescore=0 priorityscore=1501 impostorscore=0\n\tbulkscore=0\n\tclassifier=typeunknown authscore=0 authtc= authcc= route=outbound\n\tadjust=0\n\treason=mlx scancount=1 engine=8.22.0-2512120000\n\tdefinitions=main-2601140128","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37662,"web_url":"https://patchwork.libcamera.org/comment/37662/","msgid":"<85jyxk2m4u.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2026-01-14T16:29:37","subject":"Re: [PATCH 0/4] GPUISP cleanups","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Robert Mader writes:\n\n> Some minor cleanups and one possibly helpful debug print.\n>\n> Robert Mader (4):\n> egl: Remove unused functions\n> egl: Remove bpp variable\n> egl: Remove duplicated logging of EGL version\n> egl: Detect and print GLES version\n>\n> include/libcamera/internal/egl.h | 17 +++----------\n> src/libcamera/egl.cpp | 28 +++++++++++++---------\n> src/libcamera/software_isp/debayer_egl.cpp | 6 ++---\n> 3 files changed, 22 insertions(+), 29 deletions(-)\n\nTested-by: Milan Zamazal # TI AM69","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA3D5C3226\n\tfor ;\n\tWed, 14 Jan 2026 16:29:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2568661FBC;\n\tWed, 14 Jan 2026 17:29:48 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AB14F61F9F\n\tfor ;\n\tWed, 14 Jan 2026 17:29:46 +0100 (CET)","from mail-wm1-f72.google.com (mail-wm1-f72.google.com\n\t[209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-192-C_q8bUWdNoScXFaSck0qeA-1; Wed, 14 Jan 2026 11:29:43 -0500","by mail-wm1-f72.google.com with SMTP id\n\t5b1f17b1804b1-477c49f273fso195525e9.3\n\tfor ;\n\tWed, 14 Jan 2026 08:29:43 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-434af6e1b7bsm161702f8f.34.2026.01.14.08.29.40\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 14 Jan 2026 08:29:40 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"asDm3w6s\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1768408185;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=d7RUo7vszKTb/bJw/i8mm3xYo8f2t+q1HV8Iyd+X2QU=;\n\tb=asDm3w6sXRr15dOxnX4R1CD77FZ0VEckRNYi3fHinwz2+X9WpPTBlVuFVa19b/BSv2iCCL\n\tCWvH11pYTUzXnHQaPrFAVTch8yTVNC77hHFd+8puecP4CbZLQkZf9PlFuDP3s+iDJx+m4f\n\t2v3WNFXuHao+c4oFwGdZcUUoKxAMccg=","X-MC-Unique":"C_q8bUWdNoScXFaSck0qeA-1","X-Mimecast-MFC-AGG-ID":"C_q8bUWdNoScXFaSck0qeA_1768408182","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1768408182; x=1769012982;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=d7RUo7vszKTb/bJw/i8mm3xYo8f2t+q1HV8Iyd+X2QU=;\n\tb=hhR4jAOnDD4/5qqEOX9GQIMcD41cmZw+nY12plJ+63UnDtmMtCNul7cwHz88Ih+j9I\n\tbrNO6DU/dDR7T88mEaqHUrE9PA5NKbXPzxZIHrE1p3fa/BMFMITcwEppO90MF3hLx4WB\n\tFdFE0qydMa3GCKpWcZ0NnkaaInJVniaq0hgaiJ767rWyNQXC8rbgpr9gv+6cx1vFo9gl\n\t7PHD9skHZtK7D2xyY8Q1BYo3/ZNSYfuUityUhtVrXGNyQEsrQAW/4AfEpagMnlRROwxy\n\t/tgISWwbFLUMVey7Ljtv1VJc+yS5ytAy6waFP4xuV32Vj2bhhI6OCeeNiPMNYPNzZ6cP\n\tQ2Lg==","X-Gm-Message-State":"AOJu0Yx6/RtGlK6Fm/6eRX+FgseHuBkwhYz2Lzs7j193tFCU1e5Kw3aC\n\tOYyfs/5mROqQIfVhqiXbRBzz12+z8bNZnUT4irnMaWwwl/hJLPdvdQJOBMofREuTcgumpiWDqur\n\tEV8qgmkKkPBPx+xtnafkGro40WiZoI8WcWoe7+4R/r8aAgEXJB8c3H/iTLg3mO6VJ2sNzm2vOCM\n\t9PwOImUZW7ugGMvZdxi2NZ+ljsMQ2+2DHyJudbmbvYijXleaU1xFCrkMQX27E=","X-Gm-Gg":"AY/fxX4cfGo2p3dIhnUocW7lCBNKoI75G0Rq9O6qz52By9OlnX/MOrVBIBTXLwAjaI7\n\taApXJEPbj5/aaeoUZybjefNdPRQA9DM3/MlQ0V2fGHNbswSfw+ygqhnKgllVNcdpAz+/OZk7Xl+\n\t79TXTFS73frhP1JpCUsoy4cjTfTvGs44tLQLliGy9QdpO01lnfuQqHRaXqYSs+ih+THhcJLPgDS\n\txpuUmkXr4TCSU8W1g4GGtNRrhzn6f937Unlld7dfOsSlIaQ4LKGc34JQ26DcpkuRWa8bfdbe5QY\n\tvA0dup9bBWA/UOvc2m0fyDUB73YoESV4mYOxYi2lcznmIWe7ca2GQhGQ0yh100X5PBcyKhozdBw\n\t/1EGVDs71pug4i28k+zT1HeqyqEXjJ2fxDoJqhTnWt75S1x4UWjmqZyknGr+Z6k0=","X-Received":["by 2002:a05:600c:a11:b0:479:1a09:1c4a with SMTP id\n\t5b1f17b1804b1-47ee4841128mr38808515e9.31.1768408182199; \n\tWed, 14 Jan 2026 08:29:42 -0800 (PST)","by 2002:a05:600c:a11:b0:479:1a09:1c4a with SMTP id\n\t5b1f17b1804b1-47ee4841128mr38808105e9.31.1768408181642; \n\tWed, 14 Jan 2026 08:29:41 -0800 (PST)"],"From":"Milan Zamazal ","To":"Robert Mader ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 0/4] GPUISP cleanups","In-Reply-To":"<20260110170927.79918-1-robert.mader@collabora.com> (Robert\n\tMader's message of \"Sat, 10 Jan 2026 18:09:23 +0100\")","References":"<20260110170927.79918-1-robert.mader@collabora.com>","Date":"Wed, 14 Jan 2026 17:29:37 +0100","Message-ID":"<85jyxk2m4u.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"NeQ5p7dsrUMIwX-tkVEnINWDEpU-KeBiYAuXDkLeEiM_1768408182","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]