{"id":25627,"url":"https://patchwork.libcamera.org/api/covers/25627/?format=json","web_url":"https://patchwork.libcamera.org/cover/25627/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260105171142.147792-1-rui.wang@ideasonboard.com>","date":"2026-01-05T17:11:41","name":"[v4,0/1] Fix filter mode register issue","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/people/241/?format=json","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/25627/mbox/","series":[{"id":5686,"url":"https://patchwork.libcamera.org/api/series/5686/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5686","date":"2026-01-05T17:11:41","name":"Fix filter mode register issue","version":4,"mbox":"https://patchwork.libcamera.org/series/5686/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/25627/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9466ABDCBF\n\tfor ;\n\tMon, 5 Jan 2026 17:12:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7CA5261FB9;\n\tMon, 5 Jan 2026 18:12:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0286D61F35\n\tfor ;\n\tMon, 5 Jan 2026 18:12:00 +0100 (CET)","from rui-Precision-7560.local (unknown [209.216.103.65])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5EADD25D5;\n\tMon, 5 Jan 2026 18:11:38 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RVqUJ0Oi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1767633100;\n\tbh=KnRyxlWiYmitQ1tAEkHqz9bq2NDqcaHpHmYcf0N+xgI=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=RVqUJ0OikiXvWEi/akktgaIZmwD/sLH0ALepesoFR6IXCH34V5aIN6pbd7dN+dvk1\n\t5F3VkFncLQfec+GBHYnH0STGHyiSyUMNLx67kRciRCVKh2AFp+JXoRnJYxrPhz2TPa\n\tg/EYjDMlwDrjXn5BSFZvdva1WBw3s7r7qhJQ9jRg=","From":"Rui Wang ","To":"linux-media@vger.kernel.org, dafna@fastmail.com,\n\tlaurent.pinchart@ideasonboard.com, mchehab@kernel.org, heiko@sntech.de,\n\tlinux-rockchip@lists.infradead.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org","Cc":"libcamera-devel@lists.libcamera.org, Rui Wang ","Subject":"[PATCH v4 0/1] Fix filter mode register issue","Date":"Mon, 5 Jan 2026 12:11:41 -0500","Message-ID":"<20260105171142.147792-1-rui.wang@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi,\n\nThis series contains a single patch that fixes an issue in the rkisp1\nfilter mode configuration logic.\n\nThe rkisp1_flt_config() function performs a direct write to the\nFILT_MODE register before the read/modify/write update. This write\ndoes not include the RKISP1_CIF_ISP_FLT_ENA bit, which clears the\nenable bit in hardware. After that, the read/modify/write sequence\ncannot restore the original enable state, causing the filter to be\ndisabled unintentionally.\n\nThe patch removes the redundant direct write. The remaining\nread/modify/write sequence correctly updates the mode fields while\npreserving the existing enable bit.\n\nPlease review.\n\nThanks,\nRui Wang\n\nRui Wang (1):\n media: rkisp1: Fix filter mode register configuration\n\n drivers/media/platform/rockchip/rkisp1/rkisp1-params.c | 6 ------\n 1 file changed, 6 deletions(-)"}