[{"id":37438,"web_url":"https://patchwork.libcamera.org/comment/37438/","msgid":"<37hpo63q3snrwoy6huov7j4udo4mzlevkdpjvsft6iq6aawuq3@ctfcgjmjlnnu>","date":"2025-12-18T16:38:38","subject":"Re: [PATCH v2 0/2] \tRPi: Internal buffer alloaction rework","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Naush\n\nOn Thu, Dec 18, 2025 at 12:31:22PM +0000, Naushir Patuck wrote:\n> Hi,\n>\n> No code changes in v2, only tags added.\n>\n> Jacopo, I thought it would be a trival change to address your comment regarding\n> calling importBuffers() unconditionally for disabled nodes. Turns out it's not,\n> and will need a bit of quite annoying plumbing since the base pipeline handler\n> class knows nothing about TDN and Sitch device nodes which are PiSP specific.\n> In the interest of getting this merged quickly I suggest we keep this as-is as\n> the unconditional call only does allocation of v4l2 slots, so is not a big deal.\n> If you are ok with that, we can go ahead and merge this.\n\nAbsolutely, I pointed it out just to check if it was intentional or\nnot, but if you're fine, I am as well!\n\n>\n> Regards,\n> Naush\n>\n> Naushir Patuck (2):\n> pipeline: rpi: Rename Stream::prepareBuffers to\n> Stream::allocateBuffers\n> pipeline: rpi: Rework internal buffer allocations\n>\n> .../pipeline/rpi/common/pipeline_base.cpp | 10 ++++++--\n> .../pipeline/rpi/common/pipeline_base.h | 2 +-\n> .../pipeline/rpi/common/rpi_stream.cpp | 25 ++++++-------------\n> .../pipeline/rpi/common/rpi_stream.h | 3 +--\n> src/libcamera/pipeline/rpi/pisp/pisp.cpp | 6 ++---\n> src/libcamera/pipeline/rpi/vc4/vc4.cpp | 6 ++---\n> 6 files changed, 24 insertions(+), 28 deletions(-)\n>\n> --\n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55389BD7D8\n\tfor ;\n\tThu, 18 Dec 2025 16:38:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7F64361F0A;\n\tThu, 18 Dec 2025 17:38:42 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 17DF061A61\n\tfor ;\n\tThu, 18 Dec 2025 17:38:41 +0100 (CET)","from ideasonboard.com (93-46-82-201.ip106.fastwebnet.it\n\t[93.46.82.201])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B84B71189;\n\tThu, 18 Dec 2025 17:38:33 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nWnxA6yN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1766075913;\n\tbh=5NIHVLiA+9AA6pjzMv6I30twu1B5vUkfeP0ovFmC6NY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=nWnxA6yNI0Uvb8kB3kOyL0yAyusLAGKS8jfX+HEpX55EYEvJje7qy9ZJLsC08CS3D\n\tjH4p9wNAPD/NwCNQ2plWfyLF/9rzhf0wkMGT4JhQdBs8sE5PXACoK3IJS9KJB8e5gJ\n\tSNLa4enqf2UkMerO6D26U8Vu6vIEinqX7cYCnNJk=","Date":"Thu, 18 Dec 2025 17:38:38 +0100","From":"Jacopo Mondi ","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org, \n\tJacopo Mondi ","Subject":"Re: [PATCH v2 0/2] \tRPi: Internal buffer alloaction rework","Message-ID":"<37hpo63q3snrwoy6huov7j4udo4mzlevkdpjvsft6iq6aawuq3@ctfcgjmjlnnu>","References":"<20251218123524.130886-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20251218123524.130886-1-naush@raspberrypi.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37493,"web_url":"https://patchwork.libcamera.org/comment/37493/","msgid":"","date":"2026-01-06T10:26:42","subject":"Re: [PATCH v2 0/2] RPi: Internal buffer alloaction rework","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi all,\n\nI think this series is now ready to be merged. Let me know if\nanything else is needed.\n\nRegards,\nNaush\n\n\nOn Thu, 18 Dec 2025 at 12:35, Naushir Patuck wrote:\n>\n> Hi,\n>\n> No code changes in v2, only tags added.\n>\n> Jacopo, I thought it would be a trival change to address your comment regarding\n> calling importBuffers() unconditionally for disabled nodes. Turns out it's not,\n> and will need a bit of quite annoying plumbing since the base pipeline handler\n> class knows nothing about TDN and Sitch device nodes which are PiSP specific.\n> In the interest of getting this merged quickly I suggest we keep this as-is as\n> the unconditional call only does allocation of v4l2 slots, so is not a big deal.\n> If you are ok with that, we can go ahead and merge this.\n>\n> Regards,\n> Naush\n>\n> Naushir Patuck (2):\n> pipeline: rpi: Rename Stream::prepareBuffers to\n> Stream::allocateBuffers\n> pipeline: rpi: Rework internal buffer allocations\n>\n> .../pipeline/rpi/common/pipeline_base.cpp | 10 ++++++--\n> .../pipeline/rpi/common/pipeline_base.h | 2 +-\n> .../pipeline/rpi/common/rpi_stream.cpp | 25 ++++++-------------\n> .../pipeline/rpi/common/rpi_stream.h | 3 +--\n> src/libcamera/pipeline/rpi/pisp/pisp.cpp | 6 ++---\n> src/libcamera/pipeline/rpi/vc4/vc4.cpp | 6 ++---\n> 6 files changed, 24 insertions(+), 28 deletions(-)\n>\n> --\n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 77F11BDCC0\n\tfor ;\n\tTue, 6 Jan 2026 10:27:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A68F461F9F;\n\tTue, 6 Jan 2026 11:27:22 +0100 (CET)","from mail-ua1-x92f.google.com (mail-ua1-x92f.google.com\n\t[IPv6:2607:f8b0:4864:20::92f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8FCE3615B2\n\tfor ;\n\tTue, 6 Jan 2026 11:27:20 +0100 (CET)","by mail-ua1-x92f.google.com with SMTP id\n\ta1e0cc1a2514c-940e2630162so16656241.3\n\tfor ;\n\tTue, 06 Jan 2026 02:27:20 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"RnftkBpt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1767695239; x=1768300039;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=a1+brF6l3PDSBAxxoduPtbYMXizpMTQoBL6/lpOCVNg=;\n\tb=RnftkBptfDex09c8tWOVy9V9Ry/hOYfOr4FAAGLifb2wjN7++W9ZtpHsClyGh416c5\n\tZnHfDokMu2tXg3hIb5OtH/IuBz8+KhMEzuyD4EClBzW/pMbFAIhDFFhlskI3VGfKoFH6\n\tjwQX26OZjyPb2LVrmthKYsBYdhr80DCjsUn0JBVZ25ZDgkl+meW0/femGxRgz80XCh9A\n\tkxxa74vpqvlQq8VgtPZhf+RNrGMX16JdJlT50rVVtyohBWr0cy4Cq7tXN+vbVXNh1gcv\n\tz2/9ijD18/uyrm8xbtZ4dK22IHDB58AddOgLcd/aJfRO52fivS41l4RCs0TshoJFcmB8\n\tFzcQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1767695239; x=1768300039;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=a1+brF6l3PDSBAxxoduPtbYMXizpMTQoBL6/lpOCVNg=;\n\tb=VrwLUnQ4+7bO0WDJLeG7CCk1/Tm+TwF7dmbHIzZvVesF800Hqg/G+cWbxahy1CxmoK\n\tBrj4j2w5kbM/e5qjPnyO85Xmg8/ImOfZpyP/pT65NafxbzEf/CPLC1DUWZi+iHmVHXdi\n\tOwuO9Bq1TXQFTgzaYPBbV2wkyKgAeYedgP4U/Km+NrS5y5ywrzQPyabdxgEA3btzBVLL\n\tacMEJN0calEkN8cKBppkHM20BgtHekIf9VYxBvRwLKF4y+acG3CXOoGKq/X/k7gXsW1M\n\tJfWF7NN+R6J1ivuvHM8TLEcWZfQQy8fZx4Vc7ii7/Y+AoyM55I5AtFlbfaafqvDU3Gdj\n\tl95A==","X-Gm-Message-State":"AOJu0Yzz+XO9iKfrGhQLjLzGJVHx1tDpkjWVyHJP9ns04U+x7v+kwvJS\n\t7HsBVXwaFYxg2WW09Dno4XUo+vQ46eBBBj4rcqnZOUOmYOWbL3Hi+yGZ6KFNkSk2xvBySvlNs0F\n\tmRFULb6kqmrVz6APB8tqmddlKGA6sIAppJiBAEnsXaMmPdE6kKzb+","X-Gm-Gg":"AY/fxX7aRdeuDTy0snUlQE8SJSyTJEHmRxJceAPjDIA0hvESjTATQkpLXeDdwwBtLuN\n\tbISwjv1aMaRFKFY53H9il5Nr/5ocE8wCU5pgxt/QaZwHR9lMZ3zUe3VZMLWw7X2Da9TyxlkPSQ5\n\tP6PsKS3QXZ2uDT+BfAO57HNAmKeOZhjWvuJ6gdqOvdj9qsadaEGYkSkEQTiBDQWXB7ENafY8vhA\n\tzfdfkXgg1juoGjshyMgKZv322K3PZVnhXC+AdCFczCDW1NlhalT4D+4ujMo7/VfPOdYzqYzCJYT\n\tlLGVZSVHDmaSVwczHx6yqn8RoRc=","X-Google-Smtp-Source":"AGHT+IE64GunjTqluzbSS4ukJk/FdV1MhHU8zpyUCvdbGcfCcNo6f8/78FhtMNEdY8+Z4XCVsHr3ifnmmMzQER/Vwwc=","X-Received":"by 2002:a67:c581:0:b0:5e4:933e:5748 with SMTP id\n\tada2fe7eead31-5ec7456e8f5mr293984137.7.1767695239113; Tue, 06 Jan 2026\n\t02:27:19 -0800 (PST)","MIME-Version":"1.0","References":"<20251218123524.130886-1-naush@raspberrypi.com>","In-Reply-To":"<20251218123524.130886-1-naush@raspberrypi.com>","From":"Naushir Patuck ","Date":"Tue, 6 Jan 2026 10:26:42 +0000","X-Gm-Features":"AQt7F2rdr69PCJ2S-7Ro4HXwycOrNUGepteC2Jwfakt8hfEjMyQsX_QlsagJmV0","Message-ID":"","Subject":"Re: [PATCH v2 0/2] RPi: Internal buffer alloaction rework","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37498,"web_url":"https://patchwork.libcamera.org/comment/37498/","msgid":"<1edd4751-639b-4558-aa48-565fb9c9751b@ideasonboard.com>","date":"2026-01-06T12:41:27","subject":"Re: [PATCH v2 0/2] RPi: Internal buffer alloaction rework","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 06. 11:26 keltezéssel, Naushir Patuck írta:\n> Hi all,\n> \n> I think this series is now ready to be merged. Let me know if\n> anything else is needed.\n\nMerged.\n\n\n> \n> Regards,\n> Naush\n> \n> \n> On Thu, 18 Dec 2025 at 12:35, Naushir Patuck wrote:\n>>\n>> Hi,\n>>\n>> No code changes in v2, only tags added.\n>>\n>> Jacopo, I thought it would be a trival change to address your comment regarding\n>> calling importBuffers() unconditionally for disabled nodes. Turns out it's not,\n>> and will need a bit of quite annoying plumbing since the base pipeline handler\n>> class knows nothing about TDN and Sitch device nodes which are PiSP specific.\n>> In the interest of getting this merged quickly I suggest we keep this as-is as\n>> the unconditional call only does allocation of v4l2 slots, so is not a big deal.\n>> If you are ok with that, we can go ahead and merge this.\n>>\n>> Regards,\n>> Naush\n>>\n>> Naushir Patuck (2):\n>> pipeline: rpi: Rename Stream::prepareBuffers to\n>> Stream::allocateBuffers\n>> pipeline: rpi: Rework internal buffer allocations\n>>\n>> .../pipeline/rpi/common/pipeline_base.cpp | 10 ++++++--\n>> .../pipeline/rpi/common/pipeline_base.h | 2 +-\n>> .../pipeline/rpi/common/rpi_stream.cpp | 25 ++++++-------------\n>> .../pipeline/rpi/common/rpi_stream.h | 3 +--\n>> src/libcamera/pipeline/rpi/pisp/pisp.cpp | 6 ++---\n>> src/libcamera/pipeline/rpi/vc4/vc4.cpp | 6 ++---\n>> 6 files changed, 24 insertions(+), 28 deletions(-)\n>>\n>> --\n>> 2.51.0\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 96F0ABDCC0\n\tfor ;\n\tTue, 6 Jan 2026 12:41:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 92E0F61FBB;\n\tTue, 6 Jan 2026 13:41:42 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5ED761F9F\n\tfor ;\n\tTue, 6 Jan 2026 13:41:40 +0100 (CET)","from [192.168.33.34] (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 37117581;\n\tTue, 6 Jan 2026 13:41:18 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sWReroKH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1767703279;\n\tbh=L23LQCCt60OO79eUesV9gl2kbb2xCO0NMhG1PdcTvU4=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=sWReroKHI9CPo2i8oBFjaOyGzGqGYmr/BExoU8JaxxPPd89Lhw5tWH4b4UmPAYT7R\n\tgvGOc4L0ZkyeYBSdmk4tz7GXNsk4akyeSMwyynC9g/wEGueMVoeGvTi9AtVKPKCdK4\n\tCS3d2JiN+nfbEZa5XAQeXuDEqjCEV37CQ1qSkBaQ=","Message-ID":"<1edd4751-639b-4558-aa48-565fb9c9751b@ideasonboard.com>","Date":"Tue, 6 Jan 2026 13:41:27 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 0/2] RPi: Internal buffer alloaction rework","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ","References":"<20251218123524.130886-1-naush@raspberrypi.com>\n\t","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]