[{"id":37278,"web_url":"https://patchwork.libcamera.org/comment/37278/","msgid":"<20251211013327.GM28860@pendragon.ideasonboard.com>","date":"2025-12-11T01:33:27","subject":"Re: [PATCH v2 0/6] include: linux: Update headers to Linux v6.18","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, Dec 10, 2025 at 09:19:11AM +0100, Jacopo Mondi wrote:\n> Update Linux headers to the Linux v6.18 LTS release using the\n> utils/update-kernel-headers.sh script.\n> \n> A few downstream symbols conflict with newly added ones in mainline.\n> \n> The symbols used from drm_fourcc have been kept even if they conflict\n> with newly added symbols in mainline.\n> \n> The only remaining ABI-breaking change is now in videodev2.h\n> -#define MEDIA_BUS_FMT_RGB202020_1X60           0x1026\n> +#define MEDIA_BUS_FMT_RGB202020_1X60           0x1029\n> \n> This is however justified, as we defined RGB202020_1X60 downstream\n> before it got mainlined. The symbols will land in v6.19 with the\n> Mali C55 ISP driver with a value of 0x1029, so this change actually\n> aligns the libcamera definition with the forthcoming ones in Linux.\n\nThis won't break the libcamera ABI as media bus codes are not exposed to\nusers. However, it may cause issues if someone uses libcamera with an\nolder kernel (with the out-of-tree C55 ISP kernel driver), or the other\nway around. That's likely unavoidable, but I wonder if we could improve\nthe user experience with a clear error message. Should we update the C55\npipeline handler to log an error for kernels older than v6.19 ?\n\n> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n> ---\n> Changes in v2:\n> - Do not change the definition of drm_fourcc downstream symbols\n> - Add tags\n> \n> ---\n> Jacopo Mondi (6):\n>       include: linux: drm_fourcc.h: Update to v6.18\n>       include: linux: intel-ipu3.h: Update to v6.18\n>       include: linux: media-bus-format.h: Update to v6.18\n>       include: linux: v4l2-controls.h: Update to v6.18\n>       include: linux: videodev2.h: Update to v6.18\n>       include: linux: README: Update to Linux v6.18\n> \n>  include/linux/README             |   2 +-\n>  include/linux/drm_fourcc.h       | 191 ++++++++++++++++++++++++++++++++++++---\n>  include/linux/intel-ipu3.h       |   3 +-\n>  include/linux/media-bus-format.h |   6 +-\n>  include/linux/v4l2-controls.h    | 128 +++++++++++++-------------\n>  include/linux/videodev2.h        |  64 +++++++++----\n>  6 files changed, 300 insertions(+), 94 deletions(-)\n> ---\n> base-commit: 0a9cf7e0eb6aafcfaeda4c5774fb04db9186430d\n> change-id: 20251204-headers-update-v6-18-e7b7dc8375b2","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D225BC3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 11 Dec 2025 01:33:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 302C3614B9;\n\tThu, 11 Dec 2025 02:33:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 206A2606D5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 11 Dec 2025 02:33:47 +0100 (CET)","from pendragon.ideasonboard.com (fs96f9c361.tkyc007.ap.nuro.jp\n\t[150.249.195.97])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 5B99056D;\n\tThu, 11 Dec 2025 02:33:43 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pCOF64dD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765416825;\n\tbh=SVQGhUYmX1As1or2nq+2YMRF8cJfpR+0kbjP8AhKYMc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pCOF64dDwvxxmi0xnv3qiJr1OxhIEJOZkWBTOQpf8XpL/z81VHMLTd/yMf3etwMLN\n\tDN4EZbGxoHbTx0Mwf7QUMbbGET4FwDrgCYk8x/KWFgGKs+FchmMs9EmCuiseol4Qnd\n\t3Qu5+5xA+vdb0uJm965N0D/HPvl5ZMFAKZ+7i/O8=","Date":"Thu, 11 Dec 2025 10:33:27 +0900","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= <barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v2 0/6] include: linux: Update headers to Linux v6.18","Message-ID":"<20251211013327.GM28860@pendragon.ideasonboard.com>","References":"<20251210-headers-update-v6-18-v2-0-3f726742a4c8@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20251210-headers-update-v6-18-v2-0-3f726742a4c8@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":37291,"web_url":"https://patchwork.libcamera.org/comment/37291/","msgid":"<176544411965.890597.830091387342928694@ping.linuxembedded.co.uk>","date":"2025-12-11T09:08:39","subject":"Re: [PATCH v2 0/6] include: linux: Update headers to Linux v6.18","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2025-12-11 01:33:27)\n> Hi Jacopo,\n> \n> Thank you for the patch.\n> \n> On Wed, Dec 10, 2025 at 09:19:11AM +0100, Jacopo Mondi wrote:\n> > Update Linux headers to the Linux v6.18 LTS release using the\n> > utils/update-kernel-headers.sh script.\n> > \n> > A few downstream symbols conflict with newly added ones in mainline.\n> > \n> > The symbols used from drm_fourcc have been kept even if they conflict\n> > with newly added symbols in mainline.\n> > \n> > The only remaining ABI-breaking change is now in videodev2.h\n> > -#define MEDIA_BUS_FMT_RGB202020_1X60           0x1026\n> > +#define MEDIA_BUS_FMT_RGB202020_1X60           0x1029\n> > \n> > This is however justified, as we defined RGB202020_1X60 downstream\n> > before it got mainlined. The symbols will land in v6.19 with the\n> > Mali C55 ISP driver with a value of 0x1029, so this change actually\n> > aligns the libcamera definition with the forthcoming ones in Linux.\n> \n> This won't break the libcamera ABI as media bus codes are not exposed to\n> users. However, it may cause issues if someone uses libcamera with an\n> older kernel (with the out-of-tree C55 ISP kernel driver), or the other\n> way around. That's likely unavoidable, but I wonder if we could improve\n> the user experience with a clear error message. Should we update the C55\n> pipeline handler to log an error for kernels older than v6.19 ?\n\nWhile we should definitely keep an eye on this, I don't think we need\ncustom code adding - as the number of users on this platform are\ncurrently very low as support is not fully released yet, and the\nMali-C55 driver itself only lands in v6.19. I don't think we need to\nsupport out-of-tree pre-releases here.\n\n\n\n> \n> > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n> > ---\n> > Changes in v2:\n> > - Do not change the definition of drm_fourcc downstream symbols\n> > - Add tags\n> > \n> > ---\n> > Jacopo Mondi (6):\n> >       include: linux: drm_fourcc.h: Update to v6.18\n> >       include: linux: intel-ipu3.h: Update to v6.18\n> >       include: linux: media-bus-format.h: Update to v6.18\n> >       include: linux: v4l2-controls.h: Update to v6.18\n> >       include: linux: videodev2.h: Update to v6.18\n> >       include: linux: README: Update to Linux v6.18\n> > \n> >  include/linux/README             |   2 +-\n> >  include/linux/drm_fourcc.h       | 191 ++++++++++++++++++++++++++++++++++++---\n> >  include/linux/intel-ipu3.h       |   3 +-\n> >  include/linux/media-bus-format.h |   6 +-\n> >  include/linux/v4l2-controls.h    | 128 +++++++++++++-------------\n> >  include/linux/videodev2.h        |  64 +++++++++----\n> >  6 files changed, 300 insertions(+), 94 deletions(-)\n> > ---\n> > base-commit: 0a9cf7e0eb6aafcfaeda4c5774fb04db9186430d\n> > change-id: 20251204-headers-update-v6-18-e7b7dc8375b2\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6F96DBD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 11 Dec 2025 09:08:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D389615D2;\n\tThu, 11 Dec 2025 10:08:44 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5997361593\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 11 Dec 2025 10:08:42 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7A04156D;\n\tThu, 11 Dec 2025 10:08:40 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"s9Pgkf/v\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765444120;\n\tbh=rk3+QiU8TdNJ59Aci9ub7lGGshN4qFtQfVi9KBoi/oU=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=s9Pgkf/vsqCeath7JRtpL1rw7VB/hygy8teNXBmMqFXLA/WMlEjbzQcS2iQplm41O\n\txZpnsWKo+mwU+rVgj+TEHbugpjVSyNSynU9jtzFYihhRTnwzB5liAl9+eHgrB+lq7c\n\tzxjQ59p1n/Lqc7bnqNP8EE6H/U8DM/JAfeLivaP0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251211013327.GM28860@pendragon.ideasonboard.com>","References":"<20251210-headers-update-v6-18-v2-0-3f726742a4c8@ideasonboard.com>\n\t<20251211013327.GM28860@pendragon.ideasonboard.com>","Subject":"Re: [PATCH v2 0/6] include: linux: Update headers to Linux v6.18","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= <barnabas.pocze@ideasonboard.com>","To":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>","Date":"Thu, 11 Dec 2025 09:08:39 +0000","Message-ID":"<176544411965.890597.830091387342928694@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":37293,"web_url":"https://patchwork.libcamera.org/comment/37293/","msgid":"<czb3jkyziz5hxtkhqqwp7732pjq2ixzu3efxdhjwqiuwyihbuv@3ptcq77agg5z>","date":"2025-12-11T09:17:38","subject":"Re: [PATCH v2 0/6] include: linux: Update headers to Linux v6.18","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"On Thu, Dec 11, 2025 at 09:08:39AM +0000, Kieran Bingham wrote:\n> Quoting Laurent Pinchart (2025-12-11 01:33:27)\n> > Hi Jacopo,\n> >\n> > Thank you for the patch.\n> >\n> > On Wed, Dec 10, 2025 at 09:19:11AM +0100, Jacopo Mondi wrote:\n> > > Update Linux headers to the Linux v6.18 LTS release using the\n> > > utils/update-kernel-headers.sh script.\n> > >\n> > > A few downstream symbols conflict with newly added ones in mainline.\n> > >\n> > > The symbols used from drm_fourcc have been kept even if they conflict\n> > > with newly added symbols in mainline.\n> > >\n> > > The only remaining ABI-breaking change is now in videodev2.h\n> > > -#define MEDIA_BUS_FMT_RGB202020_1X60           0x1026\n> > > +#define MEDIA_BUS_FMT_RGB202020_1X60           0x1029\n> > >\n> > > This is however justified, as we defined RGB202020_1X60 downstream\n> > > before it got mainlined. The symbols will land in v6.19 with the\n> > > Mali C55 ISP driver with a value of 0x1029, so this change actually\n> > > aligns the libcamera definition with the forthcoming ones in Linux.\n> >\n> > This won't break the libcamera ABI as media bus codes are not exposed to\n> > users. However, it may cause issues if someone uses libcamera with an\n> > older kernel (with the out-of-tree C55 ISP kernel driver), or the other\n> > way around. That's likely unavoidable, but I wonder if we could improve\n> > the user experience with a clear error message. Should we update the C55\n> > pipeline handler to log an error for kernels older than v6.19 ?\n>\n> While we should definitely keep an eye on this, I don't think we need\n> custom code adding - as the number of users on this platform are\n> currently very low as support is not fully released yet, and the\n> Mali-C55 driver itself only lands in v6.19. I don't think we need to\n> support out-of-tree pre-releases here.\n>\n\nI share Kieran's opinion here.\n\nThe Mali C55 support is not even complete upstream libcamera yet, so\nit really requires some effort and customization to be used. This\ndoesn't mean we should intentionally make things complicated for\nusers, but we can't guarantee compatibility between out-of-tree\ncomponents of libcamera/linux.\n\n>\n>\n> >\n> > > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n> > > ---\n> > > Changes in v2:\n> > > - Do not change the definition of drm_fourcc downstream symbols\n> > > - Add tags\n> > >\n> > > ---\n> > > Jacopo Mondi (6):\n> > >       include: linux: drm_fourcc.h: Update to v6.18\n> > >       include: linux: intel-ipu3.h: Update to v6.18\n> > >       include: linux: media-bus-format.h: Update to v6.18\n> > >       include: linux: v4l2-controls.h: Update to v6.18\n> > >       include: linux: videodev2.h: Update to v6.18\n> > >       include: linux: README: Update to Linux v6.18\n> > >\n> > >  include/linux/README             |   2 +-\n> > >  include/linux/drm_fourcc.h       | 191 ++++++++++++++++++++++++++++++++++++---\n> > >  include/linux/intel-ipu3.h       |   3 +-\n> > >  include/linux/media-bus-format.h |   6 +-\n> > >  include/linux/v4l2-controls.h    | 128 +++++++++++++-------------\n> > >  include/linux/videodev2.h        |  64 +++++++++----\n> > >  6 files changed, 300 insertions(+), 94 deletions(-)\n> > > ---\n> > > base-commit: 0a9cf7e0eb6aafcfaeda4c5774fb04db9186430d\n> > > change-id: 20251204-headers-update-v6-18-e7b7dc8375b2\n> >\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 419B3C3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 11 Dec 2025 09:17:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 54E2D615B2;\n\tThu, 11 Dec 2025 10:17:43 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9240B610A6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 11 Dec 2025 10:17:41 +0100 (CET)","from ideasonboard.com (93-46-82-201.ip106.fastwebnet.it\n\t[93.46.82.201])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7BCCE56D;\n\tThu, 11 Dec 2025 10:17:39 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Li1Bo0AT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765444659;\n\tbh=E2+qpAJwbZhDVCyAm5eckaX7fui7QFFahQuA3dxzEvQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Li1Bo0ATO/pn71+9EZEBUJIJDsvvho19rc835msWeuLWF0vwOyH4HVhAg2VTRdpXS\n\tYFFyou1wnn3JLxk8DHdNzt0ajIC65bkZwHyDxf/stf80IiqoxkDZartzPLGVGHVPhp\n\taOcNJ7QksIgdfI2tDOb4y2qrglG/pizYpjAW7o+k=","Date":"Thu, 11 Dec 2025 10:17:38 +0100","From":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>, Laurent Pinchart\n\t<laurent.pinchart@ideasonboard.com>, \n\tlibcamera-devel@lists.libcamera.org, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= <barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v2 0/6] include: linux: Update headers to Linux v6.18","Message-ID":"<czb3jkyziz5hxtkhqqwp7732pjq2ixzu3efxdhjwqiuwyihbuv@3ptcq77agg5z>","References":"<20251210-headers-update-v6-18-v2-0-3f726742a4c8@ideasonboard.com>\n\t<20251211013327.GM28860@pendragon.ideasonboard.com>\n\t<176544411965.890597.830091387342928694@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<176544411965.890597.830091387342928694@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":37308,"web_url":"https://patchwork.libcamera.org/comment/37308/","msgid":"<20251211134943.GD28411@pendragon.ideasonboard.com>","date":"2025-12-11T13:49:43","subject":"Re: [PATCH v2 0/6] include: linux: Update headers to Linux v6.18","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Dec 11, 2025 at 10:17:38AM +0100, Jacopo Mondi wrote:\n> On Thu, Dec 11, 2025 at 09:08:39AM +0000, Kieran Bingham wrote:\n> > Quoting Laurent Pinchart (2025-12-11 01:33:27)\n> > > Hi Jacopo,\n> > >\n> > > Thank you for the patch.\n> > >\n> > > On Wed, Dec 10, 2025 at 09:19:11AM +0100, Jacopo Mondi wrote:\n> > > > Update Linux headers to the Linux v6.18 LTS release using the\n> > > > utils/update-kernel-headers.sh script.\n> > > >\n> > > > A few downstream symbols conflict with newly added ones in mainline.\n> > > >\n> > > > The symbols used from drm_fourcc have been kept even if they conflict\n> > > > with newly added symbols in mainline.\n> > > >\n> > > > The only remaining ABI-breaking change is now in videodev2.h\n> > > > -#define MEDIA_BUS_FMT_RGB202020_1X60           0x1026\n> > > > +#define MEDIA_BUS_FMT_RGB202020_1X60           0x1029\n> > > >\n> > > > This is however justified, as we defined RGB202020_1X60 downstream\n> > > > before it got mainlined. The symbols will land in v6.19 with the\n> > > > Mali C55 ISP driver with a value of 0x1029, so this change actually\n> > > > aligns the libcamera definition with the forthcoming ones in Linux.\n> > >\n> > > This won't break the libcamera ABI as media bus codes are not exposed to\n> > > users. However, it may cause issues if someone uses libcamera with an\n> > > older kernel (with the out-of-tree C55 ISP kernel driver), or the other\n> > > way around. That's likely unavoidable, but I wonder if we could improve\n> > > the user experience with a clear error message. Should we update the C55\n> > > pipeline handler to log an error for kernels older than v6.19 ?\n> >\n> > While we should definitely keep an eye on this, I don't think we need\n> > custom code adding - as the number of users on this platform are\n> > currently very low as support is not fully released yet, and the\n> > Mali-C55 driver itself only lands in v6.19. I don't think we need to\n> > support out-of-tree pre-releases here.\n> \n> I share Kieran's opinion here.\n> \n> The Mali C55 support is not even complete upstream libcamera yet, so\n> it really requires some effort and customization to be used. This\n> doesn't mean we should intentionally make things complicated for\n> users, but we can't guarantee compatibility between out-of-tree\n> components of libcamera/linux.\n\nOK, I'm fine with that.\n\n> > > > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n> > > > ---\n> > > > Changes in v2:\n> > > > - Do not change the definition of drm_fourcc downstream symbols\n> > > > - Add tags\n> > > >\n> > > > ---\n> > > > Jacopo Mondi (6):\n> > > >       include: linux: drm_fourcc.h: Update to v6.18\n> > > >       include: linux: intel-ipu3.h: Update to v6.18\n> > > >       include: linux: media-bus-format.h: Update to v6.18\n> > > >       include: linux: v4l2-controls.h: Update to v6.18\n> > > >       include: linux: videodev2.h: Update to v6.18\n> > > >       include: linux: README: Update to Linux v6.18\n> > > >\n> > > >  include/linux/README             |   2 +-\n> > > >  include/linux/drm_fourcc.h       | 191 ++++++++++++++++++++++++++++++++++++---\n> > > >  include/linux/intel-ipu3.h       |   3 +-\n> > > >  include/linux/media-bus-format.h |   6 +-\n> > > >  include/linux/v4l2-controls.h    | 128 +++++++++++++-------------\n> > > >  include/linux/videodev2.h        |  64 +++++++++----\n> > > >  6 files changed, 300 insertions(+), 94 deletions(-)\n> > > > ---\n> > > > base-commit: 0a9cf7e0eb6aafcfaeda4c5774fb04db9186430d\n> > > > change-id: 20251204-headers-update-v6-18-e7b7dc8375b2","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 07368C3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 11 Dec 2025 13:50:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DE25D61609;\n\tThu, 11 Dec 2025 14:50:03 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E93B4609D8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 11 Dec 2025 14:50:01 +0100 (CET)","from pendragon.ideasonboard.com (p7838222-ipoefx.ipoe.ocn.ne.jp\n\t[123.225.39.221])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id C74A3667;\n\tThu, 11 Dec 2025 14:49:58 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vTcdxSrw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765460999;\n\tbh=pUo3YqFdvNYXirKHsArxzUKFmlWdscnXruVW9oW4Pq8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vTcdxSrw4sZr7/3GDOEJUI6ANX3m88UCD/C4E+3p6DUP26KU/1jwTSVM4V6vYZNPz\n\tWhUs/tPipvk/UAcq9qThMMXwxdHD6v2LS2rhKzRRnJ1wTRXPs/pPhCmmmAcAsVcwql\n\tifAo1IcB54njoqZMm8O8G1m1c06zdLLIX41ehi3g=","Date":"Thu, 11 Dec 2025 22:49:43 +0900","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Cc":"Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= <barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v2 0/6] include: linux: Update headers to Linux v6.18","Message-ID":"<20251211134943.GD28411@pendragon.ideasonboard.com>","References":"<20251210-headers-update-v6-18-v2-0-3f726742a4c8@ideasonboard.com>\n\t<20251211013327.GM28860@pendragon.ideasonboard.com>\n\t<176544411965.890597.830091387342928694@ping.linuxembedded.co.uk>\n\t<czb3jkyziz5hxtkhqqwp7732pjq2ixzu3efxdhjwqiuwyihbuv@3ptcq77agg5z>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<czb3jkyziz5hxtkhqqwp7732pjq2ixzu3efxdhjwqiuwyihbuv@3ptcq77agg5z>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]