[{"id":37179,"web_url":"https://patchwork.libcamera.org/comment/37179/","msgid":"<aTAt95m2cI0qHg4q@duo.ucw.cz>","date":"2025-12-03T12:32:55","subject":"Re: [PATCH v16 0/9] Enable raw streams with software ISP","submitter":{"id":49,"url":"https://patchwork.libcamera.org/api/people/49/","name":"Pavel Machek","email":"pavel@ucw.cz"},"content":"Hi!\n\n\n> This makes raw streams working again in ?simple? pipeline when software\n> ISP is enabled for the given device.  At most one raw stream and one\n> processed stream (possibly both at once) are supported.\n> \n> An example ?cam? invocation requesting a raw stream rather than a debayered stream:\n> \n>   cam -c1 -C8 -s role=raw,width=1920,height=1080 -Ffile#.raw\n> \n> Or for both raw and processed streams:\n> \n>   cam -c1 -C8 -Ffile# \\\n>     -s role=viewfinder,width=1920,height=1080,pixelformat=RGB888 \\\n>     -s role=raw,width=3280,height=2464,pixelformat=SRGGB8\n\nThanks for doing this.\n\n> When only a raw stream is requested, there are no exposure/gain\n> adjustments applied.  This could be improved in future, once software\n> ISP gets a mechanism to gather image statistics without processing and\n> using them to make the adjustments, or once manual exposure controls are\n> added to software ISP.  In the meantime, exposure must be changed\n> externally.\n\nYes, AE when raw stream is requested would be nice.\n\nCould I ask for Cc with next version of patches? I'm not subscribed on\nthe list, and list archives damage the patches significantly.\n\n> Tested-by: Kieran Bingham <kieran.bingham at ideasonboard.com>\n\nI got it to work on Librem 5 with mcam. No detailed tests yet, but I\ndo get different data from different streams.\n\nTested-by: Pavel Machek <pavel@ucw.cz>\n\nThanks,\n\t\t\t\t\t\t\t\tPavel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A5ED9BD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  3 Dec 2025 12:32:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D522060E40;\n\tWed,  3 Dec 2025 13:32:58 +0100 (CET)","from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5955609D8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  3 Dec 2025 13:32:56 +0100 (CET)","by jabberwock.ucw.cz (Postfix, from userid 1017)\n\tid 0770F1C008F; Wed,  3 Dec 2025 13:32:56 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ucw.cz header.i=@ucw.cz header.b=\"nMBJrvOg\";\n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1;\n\tt=1764765176;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=EBALMFxQd/lMCfQq4Err+uHTg7BedTBd6OKSCkGbLsY=;\n\tb=nMBJrvOgFKyvJDk3S3C+VnPjwu+x5EFjn70nsYcvMS/IsU2uHOrshKWO0agdxdCm+0Etly\n\tsKLYdqfBGc7rPL4c2wLC5iBI4qgtVXhB3v1jZnJJlPo1aj0NONJN3+aXMyMjdz6jzX7l1y\n\t4D2VRQoES2R/cnd2zCr/yJVE23BgYSc=","Date":"Wed, 3 Dec 2025 13:32:55 +0100","From":"Pavel Machek <pavel@ucw.cz>","To":"Milan Zamazal <mzamazal@redhat.com>, libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v16 0/9] Enable raw streams with software ISP","Message-ID":"<aTAt95m2cI0qHg4q@duo.ucw.cz>","References":"<20251127211932.122463-1-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"qCX0vPCeqLDRkexM\"","Content-Disposition":"inline","In-Reply-To":"<20251127211932.122463-1-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":37212,"web_url":"https://patchwork.libcamera.org/comment/37212/","msgid":"<85ldjikxx6.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-12-04T16:35:17","subject":"Re: [PATCH v16 0/9] Enable raw streams with software ISP","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Pavel,\n\nPavel Machek <pavel@ucw.cz> writes:\n\n> Hi!\n>\n>\n>> This makes raw streams working again in ?simple? pipeline when software\n>> ISP is enabled for the given device.  At most one raw stream and one\n>> processed stream (possibly both at once) are supported.\n>> \n>> An example ?cam? invocation requesting a raw stream rather than a debayered stream:\n>> \n>>   cam -c1 -C8 -s role=raw,width=1920,height=1080 -Ffile#.raw\n>> \n>> Or for both raw and processed streams:\n>> \n>>   cam -c1 -C8 -Ffile# \\\n>>     -s role=viewfinder,width=1920,height=1080,pixelformat=RGB888 \\\n>>     -s role=raw,width=3280,height=2464,pixelformat=SRGGB8\n>\n> Thanks for doing this.\n>\n>> When only a raw stream is requested, there are no exposure/gain\n>> adjustments applied.  This could be improved in future, once software\n>> ISP gets a mechanism to gather image statistics without processing and\n>> using them to make the adjustments, or once manual exposure controls are\n>> added to software ISP.  In the meantime, exposure must be changed\n>> externally.\n>\n> Yes, AE when raw stream is requested would be nice.\n>\n> Could I ask for Cc with next version of patches? I'm not subscribed on\n> the list, and list archives damage the patches significantly.\n\nOK.  The patches can be accessed also from\nhttps://patchwork.libcamera.org/project/libcamera/list/, which may work\nbetter than the mailing list archive and provides a way to import the\npatches to your git tree.\n\n>> Tested-by: Kieran Bingham <kieran.bingham at ideasonboard.com>\n>\n> I got it to work on Librem 5 with mcam. No detailed tests yet, but I\n> do get different data from different streams.\n\nGreat, thanks for testing!\n\n> Tested-by: Pavel Machek <pavel@ucw.cz>\n>\n> Thanks,\n> \t\t\t\t\t\t\t\tPavel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A63CEBD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  4 Dec 2025 16:35:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D61F661136;\n\tThu,  4 Dec 2025 17:35:25 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B472609E0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  4 Dec 2025 17:35:23 +0100 (CET)","from mail-wm1-f71.google.com (mail-wm1-f71.google.com\n\t[209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-654-70iRgQybOXCJnEE5t4o8_Q-1; Thu, 04 Dec 2025 11:35:20 -0500","by mail-wm1-f71.google.com with SMTP id\n\t5b1f17b1804b1-477b8a667bcso15801635e9.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 04 Dec 2025 08:35:20 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-479310ca502sm39809415e9.7.2025.12.04.08.35.17\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 04 Dec 2025 08:35:17 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"TOWglltJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1764866122;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=uMS4TdKYn+50K+9UUrbBt82LT/VYBsas0/GXloz8tyI=;\n\tb=TOWglltJxNT/zFkfMJcVwN/DPzGrlt7BEumbfk7Hunjq5i/pwReaM7twGivLPs3HKZUgcN\n\t5PFVOjkb+qPXEW9rmqySd771pBrYYk/vAyNgUnr5yQ07136QUEwzF/69h++G9VAxVb8o82\n\t2ijHPaGYTJ4od0pbpWgIaPOxKOQtang=","X-MC-Unique":"70iRgQybOXCJnEE5t4o8_Q-1","X-Mimecast-MFC-AGG-ID":"70iRgQybOXCJnEE5t4o8_Q_1764866120","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764866119; x=1765470919;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=uMS4TdKYn+50K+9UUrbBt82LT/VYBsas0/GXloz8tyI=;\n\tb=d/T5jKShkhCHJdty5PORQKur9r2ux/1mUMMLsj3yN2kjJQYRi8lsmPUT+0DwGMC21W\n\tHJKB2FiLuqBHGzmM4+uOBwRCP+r23hwJVcQ14g6RXy2ONcTKJ/WPQ+KUA7Y/jeLGVNh6\n\tCXWYbgXeqRXHDM6gNRVtGpeAavDCbdBbSZHMCuiuZiIdCuIuWr5NJXcuFbFra2DJB+Om\n\t68j8rLdc4CY+zjClgvONHhMfmnBVd70RA1dSiwHpXjNlrktXoN0C/Nktr/Rj3mK1jBcZ\n\toW1s2S/oAAFeNaTSzk4E18k2g+8m9CBdAh6aHlIx5MmA19KdFOleYsuuR4E5Kvqi9rgZ\n\tAytA==","X-Gm-Message-State":"AOJu0Yzq9QMZMFZM7sFwUjA/ceXd3FQC9IbSFi0Z/NQUWYCrCTNdfFb4\n\tIY7Iv3VndHnfl1F+SaZFwIUIVYmRLm0J2GW+NP2BhjST4ew+I1ikDHQ5t2xT91HgDzU9u4JNRBi\n\tTwRJb2BkjWdCOCo61Z8ioQTaqxgSzr6F+3ahqJqHC7YzjuVgaE5vJcCRC9e9sCPepNl1ws/DKL7\n\t8rIHKh1RyReoMY6nZtMVqViT3/JOCzHu5Dp9LRMBC7o20YGPdEoZ5p761i6NQ=","X-Gm-Gg":"ASbGncsN33BVCNXM6Dd5sI9HZWQ5Gmqyh3WlfnQQLabt2XG8xGWe1h6p2D5RLPh3QUf\n\tWtJS06QgnG40ot2zvTgslDoR4MwVoKF3PwItLYTz5NWNzXF6REElEoueX9E2XhXZahV+Nh7nO7E\n\tMy5+B+W+4xcWIaKBfN/EuYO5BtuBhmC1bUurcljGf2cPo/9b4JhF4zDBRwbmntJicAzaWtqLDMT\n\tlOsHHPPTWWoXwx5ffb0nr8Y02Qm4jEnWTMbOxAZ9cE2FS77TYPbRFjd9mu/1nbJ4vorZiqrCCCI\n\tynZCjlP4akesGatXWytLqsifbb7vzMR4q/2YMgaNtil5vS6YVJPYQxA2m5KALrCXiJm6YS9EzaH\n\toEnJrZrMlG1rttPWgupJDy0RiLoJZRH5s2JCrk7Z4dL5fKJhVZxFpBqdJAVgqD7s=","X-Received":["by 2002:a05:600c:1e8f:b0:477:5c58:3d42 with SMTP id\n\t5b1f17b1804b1-4792f25a126mr31552635e9.10.1764866119148; \n\tThu, 04 Dec 2025 08:35:19 -0800 (PST)","by 2002:a05:600c:1e8f:b0:477:5c58:3d42 with SMTP id\n\t5b1f17b1804b1-4792f25a126mr31552245e9.10.1764866118536; \n\tThu, 04 Dec 2025 08:35:18 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IFr045yG/VjVU4qCczFxMEo/zPWj0I81CO2kBRhMchdKXDASGZfu5r+Pq7WqwPzzrZpG2RQuw==","From":"Milan Zamazal <mzamazal@redhat.com>","To":"Pavel Machek <pavel@ucw.cz>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v16 0/9] Enable raw streams with software ISP","In-Reply-To":"<aTAt95m2cI0qHg4q@duo.ucw.cz> (Pavel Machek's message of \"Wed, 3\n\tDec 2025 13:32:55 +0100\")","References":"<20251127211932.122463-1-mzamazal@redhat.com>\n\t<aTAt95m2cI0qHg4q@duo.ucw.cz>","Date":"Thu, 04 Dec 2025 17:35:17 +0100","Message-ID":"<85ldjikxx6.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"OfjHpT83DSiMjoB_DomM26tn8mMzjwZcVJlkqb9aDJc_1764866120","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]