{"id":25265,"url":"https://patchwork.libcamera.org/api/covers/25265/?format=json","web_url":"https://patchwork.libcamera.org/cover/25265/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251127211932.122463-1-mzamazal@redhat.com>","date":"2025-11-27T21:19:21","name":"[v16,0/9] Enable raw streams with software ISP","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"mbox":"https://patchwork.libcamera.org/cover/25265/mbox/","series":[{"id":5619,"url":"https://patchwork.libcamera.org/api/series/5619/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5619","date":"2025-11-27T21:19:21","name":"Enable raw streams with software ISP","version":16,"mbox":"https://patchwork.libcamera.org/series/5619/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/25265/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 62BB0C3260\n\tfor ;\n\tThu, 27 Nov 2025 21:19:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 94B1F60A9E;\n\tThu, 27 Nov 2025 22:19:47 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 69624606A0\n\tfor ;\n\tThu, 27 Nov 2025 22:19:45 +0100 (CET)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-658-npcM1xHvO5OcPDo9wIJ0Zg-1;\n\tThu, 27 Nov 2025 16:19:41 -0500","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 3F2CC195608F; Thu, 27 Nov 2025 21:19:39 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.224.67])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 321EE19560B0; Thu, 27 Nov 2025 21:19:34 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"eO3Naugy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1764278384;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=nEcNJoRgb56xKvzDoLqph88nlEcIluai4QqWcLCQbOk=;\n\tb=eO3NaugydYODaDy91yhEBx7JDMXTg9vUsNYN8d8KsH1TTU3LPQK4R2iroOn6soEyEa5Nug\n\tCZm0yw1kHcT6EERfAtpNg1rq/WyydpUNkPSa4mhKBkkhcEO0V4qdwGHZ+VejPvcWiVzFKM\n\tZgZEPc+mxtRpQ0Qelg3osEzswgyvgeY=","X-MC-Unique":"npcM1xHvO5OcPDo9wIJ0Zg-1","X-Mimecast-MFC-AGG-ID":"npcM1xHvO5OcPDo9wIJ0Zg_1764278380","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Laurent Pinchart\n\t, Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t, Paul Elder\n\t, Umang Jain ","Subject":"[PATCH v16 0/9] Enable raw streams with software ISP","Date":"Thu, 27 Nov 2025 22:19:21 +0100","Message-ID":"<20251127211932.122463-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"UGQGTr4IlgpwHyv5L-_kv-xTstml84q6_CkT4sm-UIg_1764278380","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This makes raw streams working again in ‘simple’ pipeline when software\nISP is enabled for the given device. At most one raw stream and one\nprocessed stream (possibly both at once) are supported.\n\nAn example ‘cam’ invocation requesting a raw stream rather than a debayered stream:\n\n cam -c1 -C8 -s role=raw,width=1920,height=1080 -Ffile#.raw\n\nOr for both raw and processed streams:\n\n cam -c1 -C8 -Ffile# \\\n -s role=viewfinder,width=1920,height=1080,pixelformat=RGB888 \\\n -s role=raw,width=3280,height=2464,pixelformat=SRGGB8\n\nWhen only a raw stream is requested, there are no exposure/gain\nadjustments applied. This could be improved in future, once software\nISP gets a mechanism to gather image statistics without processing and\nusing them to make the adjustments, or once manual exposure controls are\nadded to software ISP. In the meantime, exposure must be changed\nexternally.\n\nTested-by: Kieran Bingham \n\nChanges in v16:\n- Buffer completion with processed+raw streams fixed as suggested by\n Umang.\n- A spelling fix.\n- Patch fixing a misplaced LOG added.\n- Patch fixing invalid raw stream size adjustment added.\n\nChanges in v15:\n- The removed useConversion_ part of the condition for request\n completion on error returned back.\n- Missing Reviewed-by tags added.\n- Duplicate Signed-off-by tags.\n\nChanges in v14:\n- Some redundant conditions removed.\n- Missing data->rawStream_ reset to nullptr added in configure.\n- SimpleCameraConfiguration::validate() brought close to Umang’s version.\n- Spelling typo in log messages fixed.\n\nChanges in v13:\n- The redundant check for multiple raw streams in\n SimplePipelineHandler::configure() removed.\n- Typo in a source code comment fixed.\n- Information about the number of streams in a commit message corrected.\n\nChanges in v12:\n- Formatting change suggested by Laurent.\n- The patch setting the number of software ISP streams moved after the\n patches enabling raw streams.\n- Colour spaces are set and validated according to the pixel format and\n only pixel format.\n\nChanges in v11:\n- Use rawStream_ pointer to a raw stream rather than rawRequested_ and\n processedRequested_ flags, as suggested by Umang.\n- Selection of pipeline configurations reworked, partially incorporating\n Umang’s ideas and permitting adjustments of raw stream configurations\n if they don’t match the processed stream or what’s available from the\n sensor.\n- Tested-by tags removed from here because the changes are substantial.\n v11 works better for me than both v10 and Umang’s RFC but it requires\n independent testing.\n\nChanges in v10:\n- Missing initialisation of swIspEnabled_ added.\n- \"Add plain output configurations\" patch dropped. Raw configurations\n can be built implicitly from capture parameters. Related adjustments\n in \"Validate raw stream configurations\".\n- \"Identify requested stream roles\" patch dropped and merged into\n followup patches; camera configuration is updated in validate() and\n not in generateConfiguration() now.\n- A commit title improved as suggested by Umang.\n\nChanges in v9:\n- Fix of calling a wrong output buffer allocator when both raw and\n processed streams are used.\n\nChanges in v8:\n- A missing `status = Adjusted' added to\n SimpleCameraConfiguration::validate.\n- Code comments regarding raw colour space for raw requested roles\n added.\n- Dropped raw format helpers.\n\nChanges in v7:\n- Rebased on current master.\n\nChanges in v6:\n- An unnecessary copy of formats avoided.\n- rawRequested_ and processedrequested_ set to false when there are no\n roles.\n- rawRequested_ and processedrequested_ updated in\n SimpleCameraConfiguration::validate().\n\nChanges in v5:\n- Possible temporary segfault in the patch adding plain output\n configurations avoided.\n- PixelFormatInfo::isRaw() helper added.\n- SimplePipelineHandler::setUpFormatSizes replaced with a lambda\n function.\n- SimpleCameraData::{rawRequested_,processedRequested_} are set in\n SimpleCameraConfiguration first and copied to SimpleCameraData only\n after successful configure().\n\nChanges in v4:\n- Broken range pruning due to passing a value rather than a reference\n fixed.\n- New common function isFormatRaw introduced.\n- The patch assigning colour spaces in the simple pipeline, previously\n posted separately, included in this series, as the first patch. It\n can still be handled separately; in any case the rest sort of depends\n on it.\n- Setting metadataRequired to false where needed to prevent freezes and\n assertion errors; related to metadata reporting support merged to\n master since v3.\n\nChanges in v3:\n- Significantly reworked, with both functional and clarity improvements.\n The level of guesswork and confusion is hopefully reduced enough now\n to drop the RFC prefix.\n- The number of streams is set to 2 only with software ISP.\n- SimpleCameraData::pipeConfig_ nullptr check patch dropped.\n- PPM/raw file output patch dropped from this series. Let’s handle this\n separately as the patch series is already complex enough.\n\nChanges in v2:\n- Completely reworked.\n- Extended to be able to produce a raw stream together with a processed\n stream.\n\nMilan Zamazal (9):\n libcamera: simple: Exclude raw configurations from output conversions\n libcamera: simple: Handle processed and raw formats separately\n libcamera: simple: Validate raw stream configurations\n libcamera: simple: Don't enforce conversion with an added raw stream\n libcamera: simple: Set the number of software ISP streams to 2\n libcamera: simple: Require metadata only when software ISP is used\n libcamera: simple: Make raw streams working\n libcamera: simple: Move colour space logging after adjustment\n libcamera: simple: Compute separate max stream sizes\n\n src/libcamera/pipeline/simple/simple.cpp | 265 ++++++++++++++++-------\n 1 file changed, 192 insertions(+), 73 deletions(-)"}