{"id":25209,"url":"https://patchwork.libcamera.org/api/covers/25209/?format=json","web_url":"https://patchwork.libcamera.org/cover/25209/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251126-cam-control-override-v2-0-305024a1f190@ideasonboard.com>","date":"2025-11-26T09:38:50","name":"[v2,0/3] libcamera: ipc: ControlLists without valid idmap break IPC","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/25209/mbox/","series":[{"id":5614,"url":"https://patchwork.libcamera.org/api/series/5614/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5614","date":"2025-11-26T09:38:50","name":"libcamera: ipc: ControlLists without valid idmap break IPC","version":2,"mbox":"https://patchwork.libcamera.org/series/5614/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/25209/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 738CDC32DE\n\tfor ;\n\tWed, 26 Nov 2025 09:39:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3A5AA60AA4;\n\tWed, 26 Nov 2025 10:39:08 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16C8E6069A\n\tfor ;\n\tWed, 26 Nov 2025 10:39:06 +0100 (CET)","from [192.168.0.172] (mob-5-90-63-219.net.vodafone.it\n\t[5.90.63.219])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6D2C4593;\n\tWed, 26 Nov 2025 10:36:56 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VRrL6U5P\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764149816;\n\tbh=kyxvH5N1lSBWSmdL0P3nxdD1jcQKrii/5kAtgyvKUak=;\n\th=From:Subject:Date:To:Cc:From;\n\tb=VRrL6U5PsK/Suns0SSpDjMnLeexY0FYZivi9GgXxpCJSCYCOa5IuhFfjCBBydcBMG\n\tvk0zaN8SFPJ8MFKVLgeRv3M9zSSUA93vamiE5PDKyyrY9J/9nBAm9Va0339U0KMTHH\n\tRzDAjoXhgg9NrDgUObaAKvLdH91wHYhSvVTBUaD4=","From":"Jacopo Mondi ","Subject":"[PATCH v2 0/3] libcamera: ipc: ControlLists without valid idmap\n\tbreak IPC","Date":"Wed, 26 Nov 2025 10:38:50 +0100","Message-Id":"<20251126-cam-control-override-v2-0-305024a1f190@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","X-B4-Tracking":"v=1; b=H4sIAKrKJmkC/4WNTQrCMBBGr1Jm7UiSWgVX3kO6yM/EBmxGJiUop\n\tXc39gIu34PvfSsUkkQFrt0KQjWVxLmBOXTgJ5sfhCk0BqPMoLU5obczes6L8BO5kkgKhINW5/7\n\tivHFaQZu+hGJ679n72HhKZWH57C9V/+yfYNWoMETfWxP7SES3Zm3h7NhKOHqeYdy27QvYmp+Qv\n\twAAAA==","X-Change-ID":"20251124-cam-control-override-510637bc2b10","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi , \n\tKieran Bingham ","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2176;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=kyxvH5N1lSBWSmdL0P3nxdD1jcQKrii/5kAtgyvKUak=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpJsq4WHoJRqclcJkCwyRGBxHV3HLTJOEjBPwGo\n\tYtSYM2EM3eJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaSbKuAAKCRByNAaPFqFW\n\tPPNPD/95+U+qPPho08dUM/xLT0eWTqClKVs4e3Zbd5I3uK1raOFjbFEiOZxOrZTp1x8SeuBt7CW\n\tRTvA8PAXmXbz3eON3WrOu61lWWPfkTfOiXUIii7s2mSu1UnhlhHoWTMseEtj+XcnfB46g2K+3dl\n\tsFXLG4cM/aqb02Hr0pCk5waLEeRgskw8PXdJPSq25vyGfVuaEulBpkdPKhz8S7Lq9zWHoUCXbC9\n\tqY0dfzTyGyI/ZOvbkkx369u4v/TTnqMo9+cRYC/c7/jsHeB9C9OcS/jAqqTc4jifiSLIaSjcEzO\n\tQOwaUkSrfSg6rMPm4VPqjdXFGEdKXKcRvcibHVUb2xeSXJfl/bxSIlIpouiCkuJAwZpIhTSql/Y\n\t5KEuROww8jotHDYiJ1PTmUNaZetWjNE8FZo/FF1Qhkue69c+WfXukdOnSAL4U1M3PktNDdzVwze\n\tMAwnyvobRIrdAZewZB/YxJJ+vwaSg6lrFtQSuky/va4dnMcFIHCcGACzatL/sAN6PBVAJLAiU7l\n\t19cvCIzzw5zROu7ik3WXUu0mzxQIG/0GU6ylmPR2sWHqhCl1j1crGdDV14lTyxZz5RmW1ORH5jW\n\toEkNh3VMkwhkXje7nTsxEUt5OJHo3C/KhGkfhKAthKvzboMcdZtbZ/Php44+jcc1CiVHGsUSCG8\n\teuBJb0yefA4SH2w==","X-Developer-Key":"i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"https://gitlab.freedesktop.org/camera/libcamera/-/issues/295\n\nAfter the first attempt for a simple fix, this attempt doesn't actually\nsuperseded the first version but rather provides a different approach\nthat changes the libcamera API to make the situation highlighted in the\nissue impossible to happen.\n\nSigned-off-by: Jacopo Mondi \n---\nChanges in v2:\n- Properly change the access to Request::controls() to const &\n- Add patch to make metadata read-only\n- Yes, this breaks the API/ABI very much\n\n---\nJacopo Mondi (3):\n libcamera: request: Create control list with Camera info map\n libcamera: request: Move metadata_ to Private\n libcamera: request: Remove write-access to controls_\n\n include/libcamera/internal/request.h | 4 +\n include/libcamera/request.h | 30 +++++++-\n src/android/camera_device.cpp | 8 +-\n src/apps/cam/camera_session.cpp | 2 +-\n src/gstreamer/gstlibcamera-controls.cpp.in | 2 +-\n src/libcamera/camera.cpp | 2 +-\n src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 3 +-\n src/libcamera/pipeline/ipu3/ipu3.cpp | 16 ++--\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 10 +--\n .../pipeline/rpi/common/pipeline_base.cpp | 13 ++--\n src/libcamera/pipeline/rpi/common/pipeline_base.h | 2 +-\n src/libcamera/pipeline/simple/simple.cpp | 8 +-\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 6 +-\n src/libcamera/pipeline/vimc/vimc.cpp | 6 +-\n src/libcamera/pipeline/virtual/virtual.cpp | 4 +-\n src/libcamera/request.cpp | 85 ++++++++++++++--------\n src/py/libcamera/py_main.cpp | 2 +-\n src/v4l2/v4l2_camera.cpp | 2 +-\n 19 files changed, 131 insertions(+), 76 deletions(-)\n---\nbase-commit: 4e720d5baeae889af7da74cda9ad85f8098b1284\nchange-id: 20251124-cam-control-override-510637bc2b10\n\nBest regards,"}