{"id":25086,"url":"https://patchwork.libcamera.org/api/covers/25086/?format=json","web_url":"https://patchwork.libcamera.org/cover/25086/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251120104548.80268-1-mzamazal@redhat.com>","date":"2025-11-20T10:45:35","name":"[RFC,v2,00/13] Simple pipeline IPA cleanup","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"mbox":"https://patchwork.libcamera.org/cover/25086/mbox/","series":[{"id":5597,"url":"https://patchwork.libcamera.org/api/series/5597/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5597","date":"2025-11-20T10:45:35","name":"Simple pipeline IPA cleanup","version":2,"mbox":"https://patchwork.libcamera.org/series/5597/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/25086/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E542AC3330\n\tfor ;\n\tThu, 20 Nov 2025 10:46:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0864460A8B;\n\tThu, 20 Nov 2025 11:46:02 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5AB55606E6\n\tfor ;\n\tThu, 20 Nov 2025 11:46:00 +0100 (CET)","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-437-UYQoLfCWNkOCtEFu8kq7cw-1;\n\tThu, 20 Nov 2025 05:45:55 -0500","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 3154E19560A1; Thu, 20 Nov 2025 10:45:54 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.34.39])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 66A291800947; Thu, 20 Nov 2025 10:45:52 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"L4T0ODCo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1763635559;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=O/iNu+lXhP3a7mkJvplUj27y9bev+3O8Hv2MFAIc73I=;\n\tb=L4T0ODCoGnS6kAYnGtl0h6MWOdSjxgWIi5AOCr4CfIscmaTCNC8RugoxOn9bxE3YZqfKUJ\n\tmL/IdwWgWg5xIc0ISY3N3TSIU8mnCr2chEc+i/XdNpFIFXjH59ELJNLbNcvp9ji0mNZNtp\n\t7eDm8Gu8p/ITxDAZXR08qDTDvZKFEtM=","X-MC-Unique":"UYQoLfCWNkOCtEFu8kq7cw-1","X-Mimecast-MFC-AGG-ID":"UYQoLfCWNkOCtEFu8kq7cw_1763635554","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t","Subject":"[RFC PATCH v2 00/13] Simple pipeline IPA cleanup","Date":"Thu, 20 Nov 2025 11:45:35 +0100","Message-ID":"<20251120104548.80268-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"W6OSdlm_Fa5YhHZv8E1ilQBf6c8ftbQukOCa5qwU2Lk_1763635554","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The simple pipeline IPA algorithms inappropriately mix various stuff\ntogether. For example, contrast and saturation processing is mixed with\nCCM and LUT processing, algorithms cannot be disabled without making\nsoftware ISP malfunctioning and some \"algorithms\", like lookup table\nconstruction, are not algorithms at all.\n\nThis patch series introduces new algorithm Adjust for contrast,\nsaturation and gamma adjustments, moves lookup table construction to\ndebayering, separates CCM from the combined matrix (which includes white\nbalance and saturation adjustments), and cleans up some other things.\n\nThis is currently RFC because it conflicts with the changes in GPU ISP.\nIt should be rebased on top of GPU ISP once it is merged.\n\nChanges in v2:\n- Commit message of \"Generalise tracking matrix changes\" improved a bit.\n- correctionMatrix renamed to combinedMatrix.\n- combinedMatrix initialisations fixed and Matrix::identity utilised.\n- gamma made adjustable.\n- Types of contrast, saturation, gamma set to float (from double in some\n places).\n- Symbolic constants are used for contrast, saturation, gamma defaults.\n- The gain matrix is applied directly in awb.cpp now.\n- Lut \"algorithm\" removed; lookup tables construction moved to\n debayering.\n\nMilan Zamazal (13):\n libcamera: ipa: simple: Remove an unused include from awb.cpp\n libcamera: ipa: simple: Unwrap IPAFrameContext::ccm\n libcamera: ipa: simple: Generalise tracking matrix changes\n libcamera: ipa: simple: Rename \"ccm\" identifiers not specific to CCM\n libcamera: ipa: simple: Introduce a general correction matrix\n libcamera: ipa: simple: Initialise the general correction matrix\n libcamera: ipa: simple: Separate saturation from CCM\n libcamera: ipa: simple: Move contrast settings to adjust.cpp\n libcamera: ipa: simple: Make gamma adjustable\n libcamera: ipa: simple: Apply gain matrix in awb\n libcamera: ipa: simple: Use float type for adjustment controls\n libcamera: ipa: simple: Use symbolic constants for adjust defaults\n libcamera: ipa: simple: Remove Lut algorithm\n\n .../internal/software_isp/debayer_params.h | 42 +----\n src/ipa/simple/algorithms/adjust.cpp | 129 ++++++++++++++\n src/ipa/simple/algorithms/{lut.h => adjust.h} | 32 ++--\n src/ipa/simple/algorithms/awb.cpp | 15 +-\n src/ipa/simple/algorithms/blc.cpp | 8 +\n src/ipa/simple/algorithms/blc.h | 6 +-\n src/ipa/simple/algorithms/ccm.cpp | 80 ++-------\n src/ipa/simple/algorithms/ccm.h | 10 +-\n src/ipa/simple/algorithms/lut.cpp | 166 ------------------\n src/ipa/simple/algorithms/meson.build | 2 +-\n src/ipa/simple/data/uncalibrated.yaml | 2 +-\n src/ipa/simple/ipa_context.h | 23 +--\n src/ipa/simple/soft_simple.cpp | 10 ++\n src/libcamera/software_isp/debayer.cpp | 71 ++------\n src/libcamera/software_isp/debayer_cpu.cpp | 165 ++++++++++++-----\n src/libcamera/software_isp/debayer_cpu.h | 30 +++-\n src/libcamera/software_isp/software_isp.cpp | 17 --\n 17 files changed, 370 insertions(+), 438 deletions(-)\n create mode 100644 src/ipa/simple/algorithms/adjust.cpp\n rename src/ipa/simple/algorithms/{lut.h => adjust.h} (53%)\n delete mode 100644 src/ipa/simple/algorithms/lut.cpp"}