[{"id":36585,"web_url":"https://patchwork.libcamera.org/comment/36585/","msgid":"<176194324666.926901.5619767123217035593@ping.linuxembedded.co.uk>","date":"2025-10-31T20:40:46","subject":"Re: [PATCH v3 0/2] libcamera: base: utils: Prevent hex signed\n\textension","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Except actually this is v4.\n\nQuoting Kieran Bingham (2025-10-31 20:38:52)\n> When converting signed values to hex strings using the utils::hex\n> helpers, signed negative values get sign extended to the larger 64 bit\n> type.\n> \n> This causes values such as 0x80 to be printed as 0xffffffffffffff80\n> instead.\n> \n> Fix this by first adding a test to catch and identify the issue, and\n> secondly by reconfiguring the hex adaptor to use a single templated type\n> which always casts to an unsigned version of the incoming type.\n> \n> Kieran Bingham (2):\n> test: utils: Validate hex sign extension\n> libcamera: base: utils: Simplify hex adaptor\n> \n> include/libcamera/base/utils.h | 68 +++++++---------------------------\n> src/libcamera/base/utils.cpp | 3 +-\n> test/utils.cpp | 17 +++++++++\n> 3 files changed, 33 insertions(+), 55 deletions(-)\n> \n> -- \n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1270C3259\n\tfor ;\n\tFri, 31 Oct 2025 20:40:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 45E1860A80;\n\tFri, 31 Oct 2025 21:40:51 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54107609D8\n\tfor ;\n\tFri, 31 Oct 2025 21:40:49 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 59E99558\n\tfor ;\n\tFri, 31 Oct 2025 21:38:58 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mspatm6v\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761943138;\n\tbh=v+ysCvfAOfrCPaG7bzHEKI1fuw0BvS2PouXPvWVrtA0=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=mspatm6v0uBOmGs57IygprUa5W0yWTS8EqRsbNIGe5nwoJPMSryAFmQgwwPHxbvo4\n\txHNC7FBRtS7seO65Dfzx+4pmq4P8nJ8G1xWqO7X0WQedDvA/Oj/1xp44dUblGCW2wS\n\tqZKNCAHcGLDSZm4bbe/D7IbnULdifaeUTh7EgxAQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251031203854.19021-1-kieran.bingham@ideasonboard.com>","References":"<20251031203854.19021-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [PATCH v3 0/2] libcamera: base: utils: Prevent hex signed\n\textension","From":"Kieran Bingham ","Cc":"","To":"libcamera devel ","Date":"Fri, 31 Oct 2025 20:40:46 +0000","Message-ID":"<176194324666.926901.5619767123217035593@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36606,"web_url":"https://patchwork.libcamera.org/comment/36606/","msgid":"<20251102123955.GM797@pendragon.ideasonboard.com>","date":"2025-11-02T12:39:55","subject":"Re: [PATCH v3 0/2] libcamera: base: utils: Prevent hex signed\n\textension","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Oct 31, 2025 at 08:38:52PM +0000, Kieran Bingham wrote:\n> When converting signed values to hex strings using the utils::hex\n> helpers, signed negative values get sign extended to the larger 64 bit\n> type.\n> \n> This causes values such as 0x80 to be printed as 0xffffffffffffff80\n> instead.\n> \n> Fix this by first adding a test to catch and identify the issue, and\n> secondly by reconfiguring the hex adaptor to use a single templated type\n> which always casts to an unsigned version of the incoming type.\n> \n> Kieran Bingham (2):\n> test: utils: Validate hex sign extension\n> libcamera: base: utils: Simplify hex adaptor\n\nPushed, thank you.\n\n> include/libcamera/base/utils.h | 68 +++++++---------------------------\n> src/libcamera/base/utils.cpp | 3 +-\n> test/utils.cpp | 17 +++++++++\n> 3 files changed, 33 insertions(+), 55 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C112BC3241\n\tfor ;\n\tSun, 2 Nov 2025 12:40:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E607660A80;\n\tSun, 2 Nov 2025 13:40:10 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F7D7606E6\n\tfor ;\n\tSun, 2 Nov 2025 13:40:09 +0100 (CET)","from pendragon.ideasonboard.com (82-203-160-149.bb.dnainternet.fi\n\t[82.203.160.149])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 2E60AB3;\n\tSun, 2 Nov 2025 13:38:17 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"q6CHt67M\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762087097;\n\tbh=z01jYXZBka89eDzaqhCvPeT2RKVBKSlRmsF92eZ2jzk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=q6CHt67MkSGWqv82VeXoEzZdIecPsR4HsEjJn6xTMIcI/Ho+Dne0b7oDCfnzgpmGU\n\tUoiyv7a38asA1Ven06l8J4dscgfWq0Jqqu8wHNaHQNDT7ePsXNjdz0IEW+bPv0H6cK\n\tNYdVgSKh02jVrogHvljYtug3OdJs75EiBp4tHA38=","Date":"Sun, 2 Nov 2025 14:39:55 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ","Subject":"Re: [PATCH v3 0/2] libcamera: base: utils: Prevent hex signed\n\textension","Message-ID":"<20251102123955.GM797@pendragon.ideasonboard.com>","References":"<20251031203854.19021-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20251031203854.19021-1-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]