{"id":24930,"url":"https://patchwork.libcamera.org/api/covers/24930/?format=json","web_url":"https://patchwork.libcamera.org/cover/24930/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251031115216.3776845-1-kieran.bingham@ideasonboard.com>","date":"2025-10-31T11:52:13","name":"[v3,0/2] libcamera: base: utils: Prevent hex signed extension","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/24930/mbox/","series":[{"id":5548,"url":"https://patchwork.libcamera.org/api/series/5548/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5548","date":"2025-10-31T11:52:13","name":"libcamera: base: utils: Prevent hex signed extension","version":3,"mbox":"https://patchwork.libcamera.org/series/5548/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/24930/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0C4AAC3259\n\tfor ;\n\tFri, 31 Oct 2025 11:52:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0CF38609B7;\n\tFri, 31 Oct 2025 12:52:25 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 14B64600CC\n\tfor ;\n\tFri, 31 Oct 2025 12:52:23 +0100 (CET)","from Monstersaurus.hippo-penny.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 372002E0;\n\tFri, 31 Oct 2025 12:50:32 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ub7XKnYr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761911432;\n\tbh=kMQZ8GgO6My6igDeM8KY8Hph1zQSKUq2XQr/A8uvpmU=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=ub7XKnYrlEwig89eoGCHHqvo8gMTaCHzj6gYxHTbfChc5wEnNNWLwUP99fvZgErDy\n\txKaTvUyADvtvTEDSwCmfhWRVlmcYqba/GvG5RsdF+4SiDu8xmFfZO7qq2Zx+qHYofF\n\tKh3zxOIntDaKk1nnGEBzIJODrGZH7+7dxGTlzypQ=","From":"Kieran Bingham ","To":"libcamera devel ","Cc":"Kieran Bingham ","Subject":"[PATCH v3 0/2] libcamera: base: utils: Prevent hex signed extension","Date":"Fri, 31 Oct 2025 11:52:13 +0000","Message-ID":"<20251031115216.3776845-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.50.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When converting signed values to hex strings using the utils::hex\nhelpers, signed negative values get sign extended to the larger 64 bit\ntype.\n\nThis causes values such as 0x80 to be printed as 0xffffffffffffff80\ninstead.\n\nFix this by first adding a test to catch and identify the issue, and\nsecondly by reconfiguring the hex adaptor to use a single templated type\nwhich always casts to an unsigned version of the incoming type.\n\nKieran Bingham (2):\n test: utils: Validate hex sign extension\n libcamera: base: utils: Simplify hex adaptor\n\n include/libcamera/base/utils.h | 68 ++++++----------------------------\n src/libcamera/base/utils.cpp | 2 +-\n test/utils.cpp | 17 +++++++++\n 3 files changed, 30 insertions(+), 57 deletions(-)"}