[{"id":36718,"web_url":"https://patchwork.libcamera.org/comment/36718/","msgid":"<176236126191.2116251.6351199430542552344@neptunite.rasen.tech>","date":"2025-11-05T16:47:41","subject":"Re: [PATCH v2 17/35] libcamera: converter: converter_v4l2_m2m: Add\n\tmakeStream() function","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-10-23 23:48:18)\n> Add a makeStream() function that is called by the converter to create a\n> corresponding stream. This can be overwritten by subclasses to be able\n> to implement a custom stream type.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Paul Elder \n\n> ---\n> include/libcamera/internal/converter/converter_v4l2_m2m.h | 2 ++\n> src/libcamera/converter/converter_v4l2_m2m.cpp | 8 ++++++--\n> 2 files changed, 8 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/internal/converter/converter_v4l2_m2m.h b/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> index 6d2453bb9e06..2d6f361c17e1 100644\n> --- a/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> +++ b/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> @@ -127,6 +127,8 @@ private:\n> Size adjustSizes(const Size &size, const std::vector &ranges,\n> Alignment align);\n> \n> + virtual std::unique_ptr makeStream(const Stream *stream);\n> +\n> std::unique_ptr m2m_;\n> \n> std::map> streams_;\n> diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> index 37377ab24952..2e3966444361 100644\n> --- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n> +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> @@ -556,8 +556,7 @@ int V4L2M2MConverter::configure(const StreamConfiguration &inputCfg,\n> \n> for (unsigned int i = 0; i < outputCfgs.size(); ++i) {\n> const StreamConfiguration &cfg = outputCfgs[i];\n> - std::unique_ptr stream =\n> - std::make_unique(this, cfg.stream());\n> + std::unique_ptr stream = makeStream(cfg.stream());\n> \n> if (!stream->isValid()) {\n> LOG(Converter, Error)\n> @@ -811,6 +810,11 @@ bool V4L2M2MConverter::supportsRequests()\n> return ret;\n> }\n> \n> +std::unique_ptr V4L2M2MConverter::makeStream(const Stream *stream)\n> +{\n> + return std::make_unique(this, stream);\n> +}\n> +\n> /*\n> * \\todo This should be extended to include Feature::Flag to denote\n> * what each converter supports feature-wise.\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D90DDC3241\n\tfor ;\n\tWed, 5 Nov 2025 16:47:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 92AFF60AB3;\n\tWed, 5 Nov 2025 17:47:50 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 30F8A609D8\n\tfor ;\n\tWed, 5 Nov 2025 17:47:49 +0100 (CET)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:d4d0:27ea:7a74:8a9e])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 60BC2C71;\n\tWed, 5 Nov 2025 17:45:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FU8Ew26J\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762361154;\n\tbh=j069xUtlyq2e257//F5P/EX3pCXRHYqDnWG/EvW2mkY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=FU8Ew26JfTU8qh9zvxgr5MPTCtJ4IxTCRc1SodxQNvLaJ5VGNdE+jDNdpszRSsRQk\n\tzQKaRKaat3DVdARnhI3GyxNBJNmRrtGjcHHP50QQJFutPiJfmx4E6mU6kdAnx/ngox\n\tTIz+RsFP5yS8MVhLSUUnTO38CvlBbIQB5BFSwq6c=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251023144841.403689-18-stefan.klug@ideasonboard.com>","References":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>\n\t<20251023144841.403689-18-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v2 17/35] libcamera: converter: converter_v4l2_m2m: Add\n\tmakeStream() function","From":"Paul Elder ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 06 Nov 2025 01:47:41 +0900","Message-ID":"<176236126191.2116251.6351199430542552344@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]