[{"id":36210,"web_url":"https://patchwork.libcamera.org/comment/36210/","msgid":"<176028221476.756374.1617137236632545316@ping.linuxembedded.co.uk>","date":"2025-10-12T15:16:54","subject":"Re: [PATCH v5 0/3] pipeline: simple: Allow buffer counts from 1 to\n\t32","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Robert Mader (2025-10-12 15:20:49)\n> The last and main commit of this series implements what the title says.\n> The first commit is a preparation to avoid regressions and the second\n> commit aligns the internal buffer count for the SW-ISP.\n> \n> Changes in v5:\n> 1. Reorder commits and add cover-letter.\n> 2. Adopted suggestions for commit messages.\n> 3. Added more tags.\n\nThanks.\n\nCI is green on this: https://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1526042\n\nSo I'll merge tomorrow.\n\n--\nKieran\n\n> \n> Changes in v4:\n> 1. Limit the number of queued requests to 4\n> \n> Changes in v3:\n> 1. Adopeted code cleanup suggestion - no change in behavior.\n> 2. Split out change of kNumInternalBuffers.\n> 3. Minor commit message changes.\n> \n> Changes since v1 with title \"pipeline: simple: Allow buffer counts from 1 to 16 for swISP\"\n> 1: Cover all cases, not just the swISP one.\n> 2: Increase maximum to 32 to match vb2 core.\n> 3: Change constant naming to better match similar ones.\n> 4: Bump kNumInternalBuffers to 4.\n> \n> Robert Mader (3):\n> pipeline: simple: Initialize maxQueuedRequestsDevice to 4\n> pipeline: simple: Increase internal buffers for software ISP to 4\n> pipeline: simple: Allow buffer counts from 1 to 32\n> \n> src/libcamera/pipeline/simple/simple.cpp | 24 ++++++++++++++++++++----\n> 1 file changed, 20 insertions(+), 4 deletions(-)\n> \n> -- \n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EC575BE080\n\tfor ;\n\tSun, 12 Oct 2025 15:16:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4D62460449;\n\tSun, 12 Oct 2025 17:16:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D929D603ED\n\tfor ;\n\tSun, 12 Oct 2025 17:16:56 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D7180524;\n\tSun, 12 Oct 2025 17:15:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cH4JK28i\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760282119;\n\tbh=l0r75emj2FO3iUWkgU3hS5z+riY7BOudGJbXNvgZ7Ok=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=cH4JK28iWdhPJCpW5J+x7I8tt69u409RUYOQOMwhsBuIq4bH3mEpVOz3fTRDJ1Bik\n\t69C/QkP9YNDTByQFPCG+eOPY9cpc8ei96frPjvkeA2Ey6KxZFqf2e24ibojt8JteqH\n\t71nBMQiQwoWqOB29k3xBEqSn7Uw8k99wb4oHEesM=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251012142052.90611-1-robert.mader@collabora.com>","References":"<20251012142052.90611-1-robert.mader@collabora.com>","Subject":"Re: [PATCH v5 0/3] pipeline: simple: Allow buffer counts from 1 to\n\t32","From":"Kieran Bingham ","Cc":"Robert Mader ","To":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Sun, 12 Oct 2025 16:16:54 +0100","Message-ID":"<176028221476.756374.1617137236632545316@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]