{"id":24578,"url":"https://patchwork.libcamera.org/api/covers/24578/?format=json","web_url":"https://patchwork.libcamera.org/cover/24578/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251010113332.3030598-1-paul.elder@ideasonboard.com>","date":"2025-10-10T11:33:28","name":"[v3,0/2] Fix ControlSerializer deserializing array controls","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/24578/mbox/","series":[{"id":5483,"url":"https://patchwork.libcamera.org/api/series/5483/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5483","date":"2025-10-10T11:33:28","name":"Fix ControlSerializer deserializing array controls","version":3,"mbox":"https://patchwork.libcamera.org/series/5483/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/24578/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1B9CBE080\n\tfor ;\n\tFri, 10 Oct 2025 11:33:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1BC9E6B60F;\n\tFri, 10 Oct 2025 13:33:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B337D6B599\n\tfor ;\n\tFri, 10 Oct 2025 13:33:47 +0200 (CEST)","from neptunite.hamster-moth.ts.net (unknown\n\t[IPv6:2404:7a81:160:2100:fa2a:8f34:95fc:6e6b])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BE84D664;\n\tFri, 10 Oct 2025 13:32:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jfXapNeY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760095932;\n\tbh=RcFOr8WZEuRILTkt7RV1KYgPkSSvGjRkaoa9L4OjsEk=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=jfXapNeY6c8L7vdA3ghZVoDHL4ziL5aBKYrxJvUbj0SpkRYyvBxcW7MFOO1NLPRR5\n\tC41bvs0lwVHXHmJrk1XEIECtDMdkxf53UKYXwqTXC9lwaDNS0bSd81YVf7iuX2+65t\n\t08sDiOpjjT74fwOA5SkvpCNJ0O0Z1Hu8gzGzgXG0=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Cc":"Paul Elder , barnabas.pocze@ideasonboard.com","Subject":"[PATCH v3 0/2] Fix ControlSerializer deserializing array controls","Date":"Fri, 10 Oct 2025 20:33:28 +0900","Message-ID":"<20251010113332.3030598-1-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.47.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This series fixes bug 285 [0] where running IPAs in isolation with array\ncontrols would cause the control deserialization to fail, since the\ndeserializer didn't properly deserialize array controls.\n\nThis is fixed by making the deserializer properly deserialize array\ncontrols. As a side effect, array controls that didn't report default\narray values must now report default array values, so the second patch\ndoes that.\n\nIn v3 we reuse struct ipa_control_value_entry to store the relevant\ninformation instead, and add them to the serialized form of\nControlInfoMap.\n\nIn v2 the arrayness and size are stored in the serialized form of\nControlValue instead of using the information registered in the\nControlId. This allows us to support variable-length arrays (which v1\ndidn't), and allows us to support both non-array and array types min/max\nControlValues in the ControlInfo, depending on which type of min/max\nvalue makes more sense for the specific control.\n\n[0] https://bugs.libcamera.org/show_bug.cgi?id=285\n\nPaul Elder (2):\n libcamera: control_serializer: Add array info to serialized\n ControlValue\n ipa: ipu3, mali-c55, rkisp1, rpi: Fix reporting non-scalar controls\n\n .../libcamera/internal/control_serializer.h | 8 +++--\n src/ipa/ipu3/ipu3.cpp | 4 ++-\n src/ipa/mali-c55/mali-c55.cpp | 5 +++-\n src/ipa/rkisp1/algorithms/awb.cpp | 5 +++-\n src/ipa/rkisp1/rkisp1.cpp | 4 ++-\n src/ipa/rpi/common/ipa_base.cpp | 7 ++++-\n src/libcamera/control_serializer.cpp | 30 ++++++++++++++-----\n 7 files changed, 49 insertions(+), 14 deletions(-)"}