[{"id":36075,"web_url":"https://patchwork.libcamera.org/comment/36075/","msgid":"<CAPhyPA4mtCAXOf7ehQ1ja9sKF8FOBF2KzzxwgQUme3HwRdfUoA@mail.gmail.com>","date":"2025-10-02T14:10:25","subject":"Re: [PATCH v1 0/4] Raspberry Pi: Decompanding support","submitter":{"id":130,"url":"https://patchwork.libcamera.org/api/people/130/","name":"Nick Hollinghurst","email":"nick.hollinghurst@raspberrypi.com"},"content":"Hi Naush,\n\nOn Thu, 2 Oct 2025 at 14:35, Naushir Patuck <naush@raspberrypi.com> wrote:\n>\n> Hi,\n>\n> This series is a successor to [1] adding support for sensor data decompanding in\n> the frontend.\n>\n> Patch 1 adds support for the algorithm in the IPA, and patches 2-4 update the\n> code to provide initial values to the hardware before the sensor starts\n> streaming.  Without these patches, the first 1-2 frames would not have the\n> decompanding enabled.\n>\n> Thanks,\n> Naush\n>\n> [1]: https://patchwork.libcamera.org/patch/24540/\n>\n> Naushir Patuck (3):\n>   ipa: rpi: Add FE globals as a parameter to applyDecompand()\n>   ipa: rpi: pisp: Add a DecompandAlgorithm class\n>   ipa: rpi: pisp: Allow an initial decompand curve to be set on the FE\n>\n> Sena Asotani (1):\n>   ipa: rpi: pisp: Add decompand support using PiSP hardware block\n>\n>  src/ipa/rpi/controller/decompand_algorithm.h | 26 ++++++++\n>  src/ipa/rpi/controller/decompand_status.h    |  8 +++\n>  src/ipa/rpi/controller/meson.build           |  1 +\n>  src/ipa/rpi/controller/rpi/decompand.cpp     | 66 ++++++++++++++++++++\n>  src/ipa/rpi/controller/rpi/decompand.h       | 31 +++++++++\n>  src/ipa/rpi/pisp/pisp.cpp                    | 56 +++++++++++++++++\n>  6 files changed, 188 insertions(+)\n>  create mode 100644 src/ipa/rpi/controller/decompand_algorithm.h\n>  create mode 100644 src/ipa/rpi/controller/decompand_status.h\n>  create mode 100644 src/ipa/rpi/controller/rpi/decompand.cpp\n>  create mode 100644 src/ipa/rpi/controller/rpi/decompand.h\n>\n> --\n> 2.43.0\n>\n\nTested-by: Nick Hollinghurst <nick.hollinghurst@raspberrypi.com>\n\n Nick","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 20076C324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  2 Oct 2025 14:10:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0BD636B5AA;\n\tThu,  2 Oct 2025 16:10:40 +0200 (CEST)","from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com\n\t[IPv6:2a00:1450:4864:20::52d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3DDEC6B5A2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  2 Oct 2025 16:10:38 +0200 (CEST)","by mail-ed1-x52d.google.com with SMTP id\n\t4fb4d7f45d1cf-6349e3578adso1804368a12.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 02 Oct 2025 07:10:38 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"fw2/f5xl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1759414237; x=1760019037;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=DobMgIDCrck6/Iqfci9HExRPqua/wMkLFNiPXT0ChxA=;\n\tb=fw2/f5xl0zZ8OPA1xE2w5J503iR7mnf2XZTJFqo7VscZxeZu3D+TEZeH25tmVIkDWB\n\t5Ln6+Wnm0XST+7lfrsmtlszeG7QhdjktppO5SoUu7qgLL3LxlWZ7bluiP+J1SoreGWhb\n\tfSB1QfL327juzrd5DIYc2++KzhNFFWi1MmSrl1W8/u49mfh+yu8IIhtoQP2zhc7UM017\n\tZGzGoxt5yg3QIWHeQd62sX88izy7iyksXwslWXyeIZTMpJkxAb0wpARFzhSIh5x2LCKW\n\tYlI9AcxFAbQyAhEPRkWm/bs0Ea19am+aBYCgkvHiBQVGmyTUMMzREHKAY1kufkDfU63C\n\trnlg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1759414237; x=1760019037;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=DobMgIDCrck6/Iqfci9HExRPqua/wMkLFNiPXT0ChxA=;\n\tb=BO0rQREEDuTorofY7gfChCW0OIbhKb+TJYslWjCoIpS3/z6NPEdDclkI8SDvAPvuLj\n\t8SOpetWnS/bp33ZBxlwDixB+4N9oJIEFfa9LCUmCYHeMLBkqmjmqqQD0xIgoVZU0HDLV\n\tNehHgQLYXsumlo68MF35qQwumAgj7FKdQLffdgNEgB97giqoUeIokjd3i44E3JfQr2hb\n\tVbtkfKhlDEEA5YW5nRkPFXbIcNF1c5HNYm/CHeW02FBEni9xqP6AwwvtGqzwpOZuRLcM\n\tTYEU4IC5cTCr67IyJTDY835YH2O99jYrDVNMX8KNNhapVPNxU0dXEO4LjXC398ayENEL\n\twK8Q==","X-Gm-Message-State":"AOJu0YwNBvBasmcYTvr0YYMNDLpQI77rYM1HpVJXduTpqUPSeHLhwBjx\n\tE79PxqHbDYABlLlUFkxO/L8aQ43EuLvg7sCdRSuyMUdzQGIhiMiK41RMvGqOBrDdoPo921FniQQ\n\tLswQfrCPOwR59yoznMx7hMpvWS9UqG+f4tZsbEdTvMw==","X-Gm-Gg":"ASbGncsmUNS3q4SG8bUujHhKx7SlQCXlR5zxX6s7wfVyaiQYK6m24JI7kVys89OVEpU\n\teLqYr8bBgODyYOPhSPMNlNUPfKPcuO2WJaQ4LwJVQzX7MKZ9YC8wJpzwHxRUtX+Jmdghme2y8Tw\n\t6tFw5yl6BM2eE4tAn7WKm2d1cwGKl1liPjkaZ7YJqwuriU8FFmvYAJxPGQ0YeD+VaywDLdtybwq\n\tfDKLs9SVo/yVpGmsmw/1iEhEopwdjpbVZbJ+S/Q9LYa/tpBKUxoSF6cLqMWnKFdbWcVERLLQg==","X-Google-Smtp-Source":"AGHT+IHI34yYOk9VOemDAYnRB5E5fRZbsjkoVQ1bWmans/RAr+tdrFBwbi28IEyEj6vyHibsjqfOW6KVxk/vNawBaco=","X-Received":"by 2002:a05:6402:4405:b0:637:ee5f:d89e with SMTP id\n\t4fb4d7f45d1cf-637ee5fdbcemr1359755a12.20.1759414237604;\n\tThu, 02 Oct 2025 07:10:37 -0700 (PDT)","MIME-Version":"1.0","References":"<20251002133523.293413-1-naush@raspberrypi.com>","In-Reply-To":"<20251002133523.293413-1-naush@raspberrypi.com>","From":"Nick Hollinghurst <nick.hollinghurst@raspberrypi.com>","Date":"Thu, 2 Oct 2025 15:10:25 +0100","X-Gm-Features":"AS18NWAnB-nxb97YEEQuExcVOLzWg3CyXk8dZ08PSvpK-Y4AMy01QK93eArpKuw","Message-ID":"<CAPhyPA4mtCAXOf7ehQ1ja9sKF8FOBF2KzzxwgQUme3HwRdfUoA@mail.gmail.com>","Subject":"Re: [PATCH v1 0/4] Raspberry Pi: Decompanding support","To":"Naushir Patuck <naush@raspberrypi.com>","Cc":"libcamera-devel@lists.libcamera.org, \n\tDavid Plowman <david.plowman@raspberrypi.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]