[{"id":36045,"web_url":"https://patchwork.libcamera.org/comment/36045/","msgid":"","date":"2025-09-29T21:03:23","subject":"Re: [PATCH v5 0/7] Fix stats related problems in software ISP","submitter":{"id":239,"url":"https://patchwork.libcamera.org/api/people/239/","name":"Hans de Goede","email":"hansg@kernel.org"},"content":"Hi All,\n\nOn 29-Sep-25 10:19 PM, Milan Zamazal wrote:\n> Fixes of https://bugs.libcamera.org/show_bug.cgi?id=280 and the related\n> problems discussed there.\n> \n> Tested-by: Maciej S. Szmigiero \n> Tested-by: Robert Mader \n> \n> Changes in v5:\n> - Docstring changes as suggested by Barnabás.\n> - Assertion on non-negative window corner values in\n> SwStatsCpu::setWindow() added.\n> - Cosmetic code changes in debayer_cpu.cpp suggested by Hans.\n> - “Check processed window size alignment” patch dropped (the requirement\n> is already enforced elsewhere.)\n> - Minor code change in awb.cpp suggested by Barnabás.\n> - New patch fixing the initial value type in std::accumulate().\n> \n> Changes in v4:\n> - unsigned int underflow in SwStatsCpu::setWindow eliminated.\n> - Window adjustment clarified in SwStatsCpu::setWindow.\n> \n> Changes in v3:\n> - Possible uint64_t underflow eliminated.\n> \n> Changes in v2:\n> - An extra semicolon removed.\n> - A note about the debayering alignment being an implementation\n> limitation added.\n> - A check for division by zero in AGC added.\n> \n> Milan Zamazal (7):\n> libcamera: software_isp: Fix width adjustment in SwStatsCpu::setWindow\n> libcamera: software_isp: Clarify SwStatsCpu::setWindow use\n> libcamera: software_isp: Pass correct y-coordinate to stats\n> ipa: simple: awb: Avoid incorrect arithmetic in AWB\n> ipa: simple: awb: Use correct type in std::accumulate\n> ipa: simple: blc: Prevent division by zero in BLC\n> ipa: simple: agc: Prevent division by zero in AG\n\nWhile preparing a libcamera Fedora package with some fixes added\n(including these fixes) I've run various tests on these patches:\n\nTested-by: Hans de Goede \n\nfor the series\n\nRegards,\n\nHans","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1FA14C324C\n\tfor ;\n\tMon, 29 Sep 2025 21:03:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 44AEF6B60E;\n\tMon, 29 Sep 2025 23:03:30 +0200 (CEST)","from sea.source.kernel.org (sea.source.kernel.org\n\t[IPv6:2600:3c0a:e001:78e:0:1991:8:25])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 226A86B5FE\n\tfor ;\n\tMon, 29 Sep 2025 23:03:28 +0200 (CEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 4DD6F40944;\n\tMon, 29 Sep 2025 21:03:26 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 0F34AC4CEF4;\n\tMon, 29 Sep 2025 21:03:24 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=kernel.org header.i=@kernel.org\n\theader.b=\"FcJooADI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1759179806;\n\tbh=IWImRlvmvIciBLG09xcsb7nhM87PBLq82LboEUpQ5cE=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=FcJooADI4h6N33UhOfqzhBFKTgBuJe77cX5Fxx6Z9TxgvMyzPRnQ0b1j2i+ZGuHov\n\tSNHDggMw+BynBbfTzwb9BGms5F8vNnLZcxRUdxCzZrhtYpNG3L9YLjari7rU8emgX6\n\tJzLHP+3ONokX5BnKD+hhLfYvP/HOgXwCV7cpWqdgghj+jIftr49NTRcikC9zMKsizR\n\t1QTk5/CVhCBTFb3SWn9aT2FeltQ0iRKGGakBEVzhSxkfFvww5W4LHhjxTCtxPYfzBm\n\tZBNQSYMwrpFOq6ykPA/yXo+XfrKPsykj0tp6VXqPzxpSVbHA/hJeVH7GS+UGSVCkBw\n\tdtBAHKrc5uNxQ==","Message-ID":"","Date":"Mon, 29 Sep 2025 23:03:23 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v5 0/7] Fix stats related problems in software ISP","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Cc":"pobrn@protonmail.com, mail@maciej.szmigiero.name,\n\tRobert Mader ","References":"<20250929201924.45019-1-mzamazal@redhat.com>","From":"Hans de Goede ","Content-Language":"en-US, nl","In-Reply-To":"<20250929201924.45019-1-mzamazal@redhat.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]