[{"id":35859,"web_url":"https://patchwork.libcamera.org/comment/35859/","msgid":"<175811779010.1246375.5674370273351821499@ping.linuxembedded.co.uk>","date":"2025-09-17T14:03:10","subject":"Re: [PATCH v2 0/4] Add vd55g1 support for rpi and libipa","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nI think this series is fine - but there's files in src/ipa/rpi.\n\nI don't think they're contentious - but could you check if you're fine\nwith these please?\n\n--\nRegards\n\nKieran\n\n\nQuoting Benjamin Mugnier (2025-09-17 14:42:10)\n> This series adds the support for vd55g1 in libcamera, both the mono\n> variant (vd55g1) and the color variant (vd65g4).\n> \n> While the vd55g1 is supported kernel side, the vd65g4 support is under\n> review on the linux-media list, and is yet to be merged.\n> \n> This work is pretty close to the vd56g3 support series.\n> \n> This series has been developed originally on the Raspberry Pi libcamera\n> fork and tested on rpi4 and rpi5. Then rebased on mainline and tested\n> again on rpi4 and rpi5 with the mainline rp1-cfe driver.\n> \n> The libipa part has not been tested yet, but changes are rather trivial.\n> If you see any issues with that, please don't hesitate to remove the\n> patch from the series.\n> \n> Signed-off-by: Benjamin Mugnier \n> ---\n> Changes in v2:\n> - Update first patch commit message\n> \n> ---\n> Benjamin Mugnier (4):\n> libcamera: camera_sensor_properties: Add vd55g1 camera sensor\n> ipa: rpi: Add vd55g1 support for rpi\n> ipa: rpi: Add vd55g1 tuning files for rpi\n> libcamera: libipa: Add vd55g1 support for libipa\n> \n> src/ipa/libipa/camera_sensor_helper.cpp | 12 +\n> src/ipa/rpi/cam_helper/cam_helper_vd55g1.cpp | 49 +\n> src/ipa/rpi/cam_helper/meson.build | 1 +\n> src/ipa/rpi/pisp/data/meson.build | 2 +\n> src/ipa/rpi/pisp/data/vd55g1.json | 1209 +++++++++++++++++++++\n> src/ipa/rpi/pisp/data/vd55g1_mono.json | 1079 ++++++++++++++++++\n> src/ipa/rpi/vc4/data/meson.build | 2 +\n> src/ipa/rpi/vc4/data/vd55g1.json | 426 ++++++++\n> src/ipa/rpi/vc4/data/vd55g1_mono.json | 299 +++++\n> src/libcamera/sensor/camera_sensor_properties.cpp | 17 +\n> 10 files changed, 3096 insertions(+)\n> ---\n> base-commit: 6554b6264257af1c3c289d502032b2818d276f65\n> change-id: 20250902-vd55g1_support-c7353682586d\n> \n> Best regards,\n> -- \n> Benjamin Mugnier \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 50911BE173\n\tfor ;\n\tWed, 17 Sep 2025 14:03:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E88E86936F;\n\tWed, 17 Sep 2025 16:03:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 11AB569367\n\tfor ;\n\tWed, 17 Sep 2025 16:03:13 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 340756AE;\n\tWed, 17 Sep 2025 16:01:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KnxDZxN+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1758117714;\n\tbh=ulLLXPLt/eg+1i+usvfYZ/0dvQMjGlD8Pi1DSSNxLXs=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=KnxDZxN+ZEIfz37K0Yl79k6V436KWw+wp2QAlhwhEox8wWIlackjDzDLAYGzF8gUB\n\tqvDBAEe6E2a0yvIV844B6IRD2sKk9jmaC5aq3BDwkfttZPL02IpK4FRUIU6pTHOZes\n\tJX7KZ+bsLZ9Q5TYkHfUeCcVx7S+zLrtfzFYIhgpk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250917-vd55g1_support-v2-0-101b53b66add@foss.st.com>","References":"<20250917-vd55g1_support-v2-0-101b53b66add@foss.st.com>","Subject":"Re: [PATCH v2 0/4] Add vd55g1 support for rpi and libipa","From":"Kieran Bingham ","Cc":"Sylvain Petinot ,\n\tBenjamin Mugnier ,\n\tCyril Liotard ","To":"Benjamin Mugnier ,\n\tNaushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 17 Sep 2025 15:03:10 +0100","Message-ID":"<175811779010.1246375.5674370273351821499@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]