[{"id":35726,"web_url":"https://patchwork.libcamera.org/comment/35726/","msgid":"<8a791ee7-bd28-418a-93a0-17c3c48de914@nxp.com>","date":"2025-09-08T14:38:32","subject":"[PATCH 0/4] ipa: libipa: Introduce V4L2Params","submitter":{"id":218,"url":"https://patchwork.libcamera.org/api/people/218/","name":"Antoine Bouyer","email":"antoine.bouyer@nxp.com"},"content":"On 29/08/2025 13:53, Jacopo Mondi wrote:\n> With the introduction of v4l2-extensible-params in the Linux kernel\n> currently in progress:\n> https://lore.kernel.org/all/20250820-extensible-parameters-validation-v4-0-30fe5a99cb1f@ideasonboard.com/\n> \n> the MaliC55 ISP driver at version in v11 has been ported to use a\n> parameters format compatible with the one defined by v4l2 extensible\n> parameters:\n> https://lore.kernel.org/all/20250714-c55-v11-0-bc20e460e42a@ideasonboard.com/\n> \n> This series\n> 1) Imports v4l2-extensible-params in libcamera\n> 2) Update the Mali C55 header and IPA to compile with v11 of the patch\n> series that introduces MaliC55 support in Linux\n> 3) Introduces V4L2Params by generalizing RkISP1Params\n> 4) Ports the Mali C55 IPA to use the newly introduced V4L2Params\n> \n> Tested on rkisp1 and rzv2h\n> \n> Signed-off-by: Jacopo Mondi \n\nI tested the same on NXP neo ISP locally, which also uses extended params.\n\nFor the series\nTested-By: Antoine Bouyer \n\nBest regards\nAntoine\n\n> ---\n> Jacopo Mondi (4):\n> include: linux: Add v4l2-extensible-params.h\n> ipa: Update Mali C55 header file and adjust IPA\n> ipa: libipa: Introduce V4L2Params\n> ipa: mali-c55: Introduce MaliC55Params\n> \n> include/linux/mali-c55-config.h | 162 +++--------------\n> include/linux/media/v4l2-extensible-params.h | 144 +++++++++++++++\n> src/ipa/libipa/meson.build | 2 +\n> src/ipa/libipa/v4l2_params.cpp | 252 +++++++++++++++++++++++++++\n> src/ipa/libipa/v4l2_params.h | 135 ++++++++++++++\n> src/ipa/mali-c55/algorithms/agc.cpp | 87 ++++-----\n> src/ipa/mali-c55/algorithms/agc.h | 14 +-\n> src/ipa/mali-c55/algorithms/algorithm.h | 2 +-\n> src/ipa/mali-c55/algorithms/awb.cpp | 64 +++----\n> src/ipa/mali-c55/algorithms/awb.h | 10 +-\n> src/ipa/mali-c55/algorithms/blc.cpp | 20 +--\n> src/ipa/mali-c55/algorithms/blc.h | 3 +-\n> src/ipa/mali-c55/algorithms/lsc.cpp | 58 +++---\n> src/ipa/mali-c55/algorithms/lsc.h | 8 +-\n> src/ipa/mali-c55/mali-c55.cpp | 19 +-\n> src/ipa/mali-c55/module.h | 3 +-\n> src/ipa/mali-c55/params.h | 89 ++++++++++\n> src/ipa/rkisp1/params.cpp | 93 +---------\n> src/ipa/rkisp1/params.h | 108 +++++-------\n> 19 files changed, 810 insertions(+), 463 deletions(-)\n> ---\n> base-commit: d54e5537ca0909339bb6950f3a565c9077406a3c\n> change-id: 20250829-v4l2-params-d42aa599e78a\n> \n> Best regards,\n> --\n> Jacopo Mondi \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6E72FC328C\n\tfor ;\n\tMon, 8 Sep 2025 14:37:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5CEFB6935A;\n\tMon, 8 Sep 2025 16:37:09 +0200 (CEST)","from PA4PR04CU001.outbound.protection.outlook.com\n\t(mail-francecentralazlp170130007.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:c20a::7])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E2006934E\n\tfor ;\n\tMon, 8 Sep 2025 16:37:08 +0200 (CEST)","from GVXPR04MB9831.eurprd04.prod.outlook.com (2603:10a6:150:11c::8)\n\tby PA4PR04MB7853.eurprd04.prod.outlook.com (2603:10a6:102:c0::14)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9115.14;\n\tMon, 8 Sep 2025 14:37:06 +0000","from GVXPR04MB9831.eurprd04.prod.outlook.com\n\t([fe80::4634:3d9c:c4a:641a]) by\n\tGVXPR04MB9831.eurprd04.prod.outlook.com\n\t([fe80::4634:3d9c:c4a:641a%6]) with mapi id 15.20.9115.010;\n\tMon, 8 Sep 2025 14:37:05 +0000"],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"TKOgq0Zw\";\n\tdkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=nxp.com;"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n\tb=Qg3e2snQ5Z6439eSiQfIKYSKOeoZyNsNasX6LkcjiJhfxUaUawSDiVFwHY6Yjv0/c72rgj1wUZ15RiAuKR2fdZ//6WdcVlHYWgvcvEmqJm6myr8yMRVKETk1uUj9id9URqIcVIanUXYh6gmQ6mylsbSvD/weUFSTVjIJ3zlGqKYiDs6rVOg91IhC+DB0UjXkejM45a4VFahv5L24qZhj0tl8nzTVOPkCaxQijiQe/sHrcpivsQCWKvJbihikS+uNG1nvHTDRuIJbhF2T08EZHiWQvivvl7DdFIZHPID8Z7kIIxxvBvGpXe44He9a9AnjFHEZN0KGNyeSPBc/V96QxQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector10001;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=14DFm/46GTFp0SIMsLhtuHnrAHJqY5mfrCIjMrBthZc=;\n\tb=pelPrO4tbvCDbDDOyuP+KhX8FjPWGOOLLQJm8KClKhYmyStJ8rKSaDIgplpu4wmtAhM3rkLP/DM+wlAyXj6ynClb2w1+zenKNbXjoKd27IJf6wqf8Duml5OFsaSNyUz3FsnQv19DC8rzi9qqIIpb5PRTiA0MBNNhYSDD0n5KFacwApsXCW67DnZswhXssuNeuMqpuIElEN9SYTU1KVEZxi3edw6mjVH/wesC7jaRDnywJRV6Hm4Cuid6XAGPm1iyL6SU6ExiOeYMYfq8f0K9qcjDUKV5GpXxd+5f5ZJkBigrGFZcfsx3jjuach3agWEDfSelYBm3EH8UUh12xMYmBg==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com;\n\tdkim=pass header.d=nxp.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=14DFm/46GTFp0SIMsLhtuHnrAHJqY5mfrCIjMrBthZc=;\n\tb=TKOgq0ZwmAEvZz9g8TCFO4SBjgYe8MtSrNXji8HiDbJvHjov1P1y161PRb/ayW0qejfnJG7bQ4Lh8jM+ztL7d62dqAgqATbc8iF/ZzIiZTNqC8mjcYJWfJtEsj1TPw6EBF/yBG9cTf4jIu/OdesPh4ha28hT2BygvxpbW7eCKe6gtHKvICyfbXqSavHqMRyyzaIrm0fDCQpVYxDJQbymCl3v7rutdqcouUW9sKYIrADko+ETLGgnBtWHiz0PZGjsZoingmg8g3aiedZWOeKLQJGqNvPqpqq/sx2BvzSjyD9xc6WvMTu2H12JxAGu9kn07ZtSVNq8B1hN/CyQBg6cEg==","Message-ID":"<8a791ee7-bd28-418a-93a0-17c3c48de914@nxp.com>","Date":"Mon, 8 Sep 2025 16:38:32 +0200","User-Agent":"Mozilla Thunderbird","Subject":"[PATCH 0/4] ipa: libipa: Introduce V4L2Params","To":"libcamera-devel@lists.libcamera.org","References":"<20250829-v4l2-params-v1-0-340773fb69ff@ideasonboard.com>","Content-Language":"en-US","From":"Antoine Bouyer ","In-Reply-To":"<20250829-v4l2-params-v1-0-340773fb69ff@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","X-ClientProxiedBy":"BYAPR21CA0003.namprd21.prod.outlook.com\n\t(2603:10b6:a03:114::13) To GVXPR04MB9831.eurprd04.prod.outlook.com\n\t(2603:10a6:150:11c::8)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"GVXPR04MB9831:EE_|PA4PR04MB7853:EE_","X-MS-Office365-Filtering-Correlation-Id":"6473315a-6f65-475e-f7bc-08ddeee52e72","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n\tARA:13230040|19092799006|366016|1800799024|376014; ","X-Microsoft-Antispam-Message-Info":"=?utf-8?q?DbdP8IWuw8XfbeyM7dnMqw8dufXd?=\n\t=?utf-8?q?uj2yYZZiYMVuHzNk4Mg7zaj+0oSxT4cf6ML2GpYN2n4tPmNjLfVwORJk?=\n\t=?utf-8?q?CE7mN5UP3MQe2598TTHwgn++t3M5XM+6I+zIH8BswgUBO5rS5zN5vG8V?=\n\t=?utf-8?q?PgPFo7OFF44Ldm4rH+14TsxMckSZG9+Scy2DzBjVRq5+JpLER0x1mpmt?=\n\t=?utf-8?q?kdwIrCLvxJeuZaG55iR9H4cy7w2zO2g/C55rbq9V1rbvOxPMZqD+aCnV?=\n\t=?utf-8?q?6fiPTwEeW2FPjirtCD7XQSwxRZqAFgBfjHXES9kOstmKHSIiflTAfWPx?=\n\t=?utf-8?q?cpJ2rC0HEhgYlmanYT7yOFIzdPpLvbB9mySJvaToxbnSOL9oeTlGO7T4?=\n\t=?utf-8?q?/njEfRylfPTORmseHsKFY42p6hebs4Jy+ogqqGkesXRqbKXhJWywrIxX?=\n\t=?utf-8?q?7/o0hFPGU8tJmUNBUJDq7idpaFaDs5oHj0O/vN1apVSYWka+nLc8TnS5?=\n\t=?utf-8?q?O3vaccuBh2Z9rQnGaQJ79r5iJL4nXFNqbJMx4YA61rH5Qezo5jGh8G6X?=\n\t=?utf-8?q?g+55HVUTHL51Ey5g3ud5ZmOl9YGiHrPyjG6QVvO5GN8/PEdja8e+z7OV?=\n\t=?utf-8?q?ATDr2DKgpzFCEHv9fpu5IWJ9YrLkeFvbq17OLndHgUhB1lKYO1uhlZx0?=\n\t=?utf-8?q?a/Fi3V+jM1n5f7KinMmyEsX/36GDpuOKHWtKcfgknXlOGemUb2R8V9XM?=\n\t=?utf-8?q?o4HKwsaRWjjGpS+eo1AsxpBsCeegoW0YnyMtYfiyUTWt3LvJpZnkuUgo?=\n\t=?utf-8?q?FY7MCinpPyUM+hHiCiTPNs4C+69cbnALlXBI3UX0/idT1pc0gxnumEO4?=\n\t=?utf-8?q?H6oXpUwffUxxvEZqh8UAKG4TKXcS4mDD1szE+DKSFSaL+Q5fccgg/dTT?=\n\t=?utf-8?q?95G1zh7PZmm3sXjjiAQC7bhnd9MIn4eXldASet+3TnAQWDIcNF6EhBXZ?=\n\t=?utf-8?q?RHSboc7sPNPic2qzCVwODHbbPBp6B/BYVUbytPyjsOb9Z5GLuikN9f12?=\n\t=?utf-8?q?Ky55kb57Bvieku2vaJkZUB4scZEpPXJfcid0e/O8kWphj114nMlfgA7z?=\n\t=?utf-8?q?P65Ht+Xjl3sfiVUlGOTKhFX2Kgpehf1a/Gl9pF5d/XfNFiPVM//sNwwE?=\n\t=?utf-8?q?Is7WzB4WK956qy2o7Mhf9k6w46cACrhaFrrkPbdzCbMYCHHeeIQ3iTwK?=\n\t=?utf-8?q?WkRoJzBXMPS7sm51jLaLQUvDvdlj13yAonxZGnk00L7etOp7Rsx+18hZ?=\n\t=?utf-8?q?8dLXZPQlGh9p8zqWdDUpArpzaAwhE3HfOBwFMw5WmqxYKncapRaRnS8y?=\n\t=?utf-8?q?Jd3PZdjrw/BhShTvETyZMoVrV0fKBkoHq9aiDKnguwF94PKT8CDs9BrI?=\n\t=?utf-8?q?kLZZFdoi+mTjl8US+YQNacycbaGcFqQPyFNV3gF8/nwHRV5UHl/xWRub?=\n\t=?utf-8?q?aPw7cuUDKH6YPA4QlZl+aQtPKcxGhB3rwhH5khqXVlv36b7QFA9TpRdr?=\n\t=?utf-8?q?HNvIY1mTK5gSE3uvwE+Earo=3D?=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:GVXPR04MB9831.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230040)(19092799006)(366016)(1800799024)(376014); DIR:OUT;\n\tSFP:1101; ","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?xIaAs9JyE8oeQshdzr1TfVY3X?=\n\t=?utf-8?q?wKM5lGfNNMdAVXOuK3a7W3PM+wmmUeufxi4KFQl+Rey9nT1QhD4JSaC/?=\n\t=?utf-8?q?Yjq8FkYX0CSkHJx84PwbRQ+izxp0+2SoixwTMhGgd+gkfmDbTAaZdPWL?=\n\t=?utf-8?q?HPQmVk3E9welGzyQFTVH/xtzXDk9NoZAO8hEDdvs96QIVVHn8xS3VSze?=\n\t=?utf-8?q?z7mjk1ScEkHnhxXlSksIJaZTMovygBAA21qUf9xuPW1WpVk4vOjBrNqA?=\n\t=?utf-8?q?Fd3LW2ROv5l4/vKlXsa+DWC0KhcxJBMAE7hjXxSw4+UuMag37XMj/BtN?=\n\t=?utf-8?q?QEDJ4qYf5dM1As7InzmK/JkKfmfR/8E3UL6S78KgrgCZ0v8fnhPSK03S?=\n\t=?utf-8?q?IGyVBm/PX/h+yyeq/Jol2oOzZwws3cEBafEKYIEsQ+GyoEy7bKigi2sh?=\n\t=?utf-8?q?9YKk5+1v/X4lsaHVaZtkMkkM6fM005i4LolvD67a10tbdAzi55Ifj1Kj?=\n\t=?utf-8?q?dq8kxsoaj9UYTrTqvuSMuLPiaTTog/XAgqKuCq8NoGvhj0XKFBKUEwQJ?=\n\t=?utf-8?q?QBbNYdZU4RiRCgZmJZrA2UMoRi8TCZHSZ7q+FUQaW2J0d6nQPK0z/8nZ?=\n\t=?utf-8?q?OoOty72HvAqXghEDjwixAnktUzVg8beLvOPhDwmJuiRuZ4XQmwJtWcPN?=\n\t=?utf-8?q?ESj5Ey6LOROL6pKyOOoRZ/rCQUE6HJjAAHn8zdU1BX7nNxj9DMQaCrCt?=\n\t=?utf-8?q?y9FGe6dyEJcwMS6RXY2EauqHJ+MB33dzepWmYP37SspRC0g2yUzLpshd?=\n\t=?utf-8?q?B5sVquGapSr55QTdenQSoXLv7dwRjgNzMOCA6rZ2/5RgKiyiwFZknTPs?=\n\t=?utf-8?q?8yuxFKEpgEtClLA0+0blx6XnNkLThR3nrDrr4bWDtBaOcYOxt1bbGo2G?=\n\t=?utf-8?q?5nNLy3CQuzM2KUIaqZXjSl23zmPMZLcH0pgn3kV2Ex2SubcZG8HApHK2?=\n\t=?utf-8?q?jFPbmzB3BXEDJbq3aM/VE1V1OAa4q+4jPfs+kTIAZ3oF2iigzxNlAPg0?=\n\t=?utf-8?q?ynR9CZNBKdrg0YGyPsG0x5hnKr1/Z+vogbT64cRAMbCVm/391I6wqhq+?=\n\t=?utf-8?q?RDHPgGAhWnXYf3CkVrMZUVaBpGB3LBBK3iLjCtZCj78/cfvBy64Xjvxn?=\n\t=?utf-8?q?foWMcc1hi5Yr/jMeym8f9YEYGQjtZnirOpyTbISXyM8t8Ch/YYVFrHIw?=\n\t=?utf-8?q?C7j4yl6filZhTJXKybXeoaekTnYYaGQQdeEc7BCK4OXTYlwu1iWP7ktk?=\n\t=?utf-8?q?LmYF86nl4U8NR4k8DCV9qMGzQM1XKjM1Kg2FBiWXeABwYgO/9jChYulI?=\n\t=?utf-8?q?uH+71EjUEunI27ZW/TIJfVujNXgqSq3ScNbzl1e5BJZT72TZBA6qU7B+?=\n\t=?utf-8?q?D+5db9+Ttl8piDCmE4sHIYwJcixplL9iBmKHbaTkcgZA2KPmhm+yyEpv?=\n\t=?utf-8?q?8gj6QFQjW/MwfKgNyy7M19fScWqha+wptwEmr0aR5hdPmDqm0Y3i/orG?=\n\t=?utf-8?q?VzucFjOjYUSju3vaCbn58DzvpzWO9Oka7PXPnaeXoUGsQXNoxDOzzYei?=\n\t=?utf-8?q?wQgVJAxh1UYrVYAdoCaRh+utOIGQsdPCYpYh65f0kpKeRUXLADpRLmhU?=\n\t=?utf-8?q?i1eXkgbyCowYyWBzhT7R0ahIPz8JLHOUDEOFLPTsENZEf+qfRyyq6/Eo?=\n\t=?utf-8?q?4P+XcCpJhQUgewC06id35As+NbkTA=3D=3D?=","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"6473315a-6f65-475e-f7bc-08ddeee52e72","X-MS-Exchange-CrossTenant-AuthSource":"GVXPR04MB9831.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"08 Sep 2025 14:37:05.4240\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"b4guLtZpmz6ZUEOOnD4Ue/CL8r7OcBKPcF8LRKs1FRh6xXwVtwccxn1oGWAJd8MyFP8TWwY/Cls+AyFqgF37IA==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"PA4PR04MB7853","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]