[{"id":35543,"web_url":"https://patchwork.libcamera.org/comment/35543/","msgid":"<6cd8d54e-59d3-49bc-b5a6-b395e12afce8@maciej.szmigiero.name>","date":"2025-08-21T21:35:21","subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","submitter":{"id":237,"url":"https://patchwork.libcamera.org/api/people/237/","name":"Maciej S. Szmigiero","email":"mail@maciej.szmigiero.name"},"content":"Hi Milan,\n\nOn 21.08.2025 15:41, Milan Zamazal wrote:\n> Fixes of https://bugs.libcamera.org/show_bug.cgi?id=280 and the related\n> problems discussed there.\n> \n> Milan Zamazal (5):\n> libcamera: software_isp: Clarify SwStatsCpu::setWindow use\n> libcamera: software_isp: Pass correct y-coordinate to stats\n> libcamera: software_isp: Check processed window size alignment\n> libcamera: simple: Avoid incorrect arithmetic in AWB\n> libcamera: simple: Prevent division by zero in BLC\n\nThanks for this patch series.\n\nI tested it on an IPU6 (Meteor Lake) laptop with an ov02e10 sensor.\n\nThe \"division by zero\" crashes with small capture sizes\nare definitely gone.\n\nHowever a few issues remain on this platform:\n* If I request smaller capture resolution I don't get full\nimage just with smaller capture dimensions, like on most\nself-contained cameras.\n\nInstead, I get a crop of the requested size of the full image.\nFor example with 160 x 120 capture size the captured picture\njust shows my eye.\n\nI presume it is because DebayerCpu::sizes() returns a very\nwide size range and SimpleCameraData::tryPipeline()\nreturns such wide range in config.outputSizes without\nfurther constraining it by capture hardware capabilities?\n\nSuch wide config.outputSizes then gets used in\nSimpleCameraConfiguration::validate() to (not) constrain the\nrequested picture size.\n\n* The AGC algorithm seems to go into unstable oscillation\nmode when the amount of light in the picture exceeds certain\nthreshold, with exposure bins alternating between 0 and tens\nof thousands rapidly.\n\nThis makes the output picture look like it has been shot\nthorough some very slow mechanical shutter, alternating\nrapidly between almost normal picture and almost completely\nblack frame.\n\nThis happens especially with small capture sizes so I\npresume is related to the previous point.\n\nThanks,\nMaciej","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 338C0BEFBE\n\tfor ;\n\tThu, 21 Aug 2025 21:35:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F2A1C692E2;\n\tThu, 21 Aug 2025 23:35:27 +0200 (CEST)","from vps-ovh.mhejs.net (vps-ovh.mhejs.net [145.239.82.108])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 157BD692D1\n\tfor ;\n\tThu, 21 Aug 2025 23:35:27 +0200 (CEST)","from MUA\n\tby vps-ovh.mhejs.net with esmtpsa (TLS1.3) tls TLS_AES_128_GCM_SHA256\n\t(Exim 4.98.2) (envelope-from )\n\tid 1upCwQ-00000001a26-3Wt0; Thu, 21 Aug 2025 23:35:26 +0200"],"Message-ID":"<6cd8d54e-59d3-49bc-b5a6-b395e12afce8@maciej.szmigiero.name>","Date":"Thu, 21 Aug 2025 23:35:21 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","To":"Milan Zamazal ","Cc":"pobrn@protonmail.com, libcamera-devel@lists.libcamera.org","References":"<20250821134141.83236-1-mzamazal@redhat.com>","Content-Language":"en-US, pl-PL","From":"\"Maciej S. Szmigiero\" ","Autocrypt":"addr=mail@maciej.szmigiero.name; keydata=\n\txsFNBFpGusUBEADXUMM2t7y9sHhI79+2QUnDdpauIBjZDukPZArwD+sDlx5P+jxaZ13XjUQc\n\t6oJdk+jpvKiyzlbKqlDtw/Y2Ob24tg1g/zvkHn8AVUwX+ZWWewSZ0vcwp7u/LvA+w2nJbIL1\n\tN0/QUUdmxfkWTHhNqgkNX5hEmYqhwUPozFR0zblfD/6+XFR7VM9yT0fZPLqYLNOmGfqAXlxY\n\tm8nWmi+lxkd/PYqQQwOq6GQwxjRFEvSc09m/YPYo9hxh7a6s8hAP88YOf2PD8oBB1r5E7KGb\n\tFv10Qss4CU/3zaiyRTExWwOJnTQdzSbtnM3S8/ZO/sL0FY/b4VLtlZzERAraxHdnPn8GgxYk\n\toPtAqoyf52RkCabL9dsXPWYQjkwG8WEUPScHDy8Uoo6imQujshG23A99iPuXcWc/5ld9mIo/\n\tEe7kN50MOXwS4vCJSv0cMkVhh77CmGUv5++E/rPcbXPLTPeRVy6SHgdDhIj7elmx2Lgo0cyh\n\tuyxyBKSuzPvb61nh5EKAGL7kPqflNw7LJkInzHqKHDNu57rVuCHEx4yxcKNB4pdE2SgyPxs9\n\t9W7Cz0q2Hd7Yu8GOXvMfQfrBiEV4q4PzidUtV6sLqVq0RMK7LEi0RiZpthwxz0IUFwRw2KS/\n\t9Kgs9LmOXYimodrV0pMxpVqcyTepmDSoWzyXNP2NL1+GuQtaTQARAQABzTBNYWNpZWogUy4g\n\tU3ptaWdpZXJvIDxtYWlsQG1hY2llai5zem1pZ2llcm8ubmFtZT7CwZQEEwEIAD4CGwMFCwkI\n\tBwIGFQoJCAsCBBYCAwECHgECF4AWIQRyeg1N257Z9gOb7O+Ef143kM4JdwUCZ7BxhgUJD0w7\n\twQAKCRCEf143kM4JdwHlD/9Ef793d6Q3WkcapGZLg1hrUg+S3d1brtJSKP6B8Ny0tt/6kjc2\n\tM8q4v0pY6rA/tksIbBw6ZVZNCoce0w3/sy358jcDldh/eYotwUCHQzXl2IZwRT2SbmEoJn9J\n\tnAOnjMCpMFRyBC1yiWzOR3XonLFNB+kWfTK3fwzKWCmpcUkI5ANrmNiDFPcsn+TzfeMV/CzT\n\tFMsqVmr+TCWl29QB3U0eFZP8Y01UiowugS0jW/B/zWYbWo2FvoOqGLRUWgQ20NBXHlV5m0qa\n\twI2Isrbos1kXSl2TDovT0Ppt+66RhV36SGA2qzLs0B9LO7/xqF4/xwmudkpabOoH5g3T20aH\n\txlB0WuTJ7FyxZGnO6NL9QTxx3t86FfkKVfTksKP0FRKujsOxGQ1JpqdazyO6k7yMFfcnxwAb\n\tMyLU6ZepXf/6LvcFFe0oXC+ZNqj7kT6+hoTkZJcxynlcxSRzRSpnS41MRHJbyQM7kjpuVdyQ\n\tBWPdBnW0bYamlsW00w5XaR+fvNr4fV0vcqB991lxD4ayBbYPz11tnjlOwqnawH1ctCy5rdBY\n\teTC6olpkmyUhrrIpTgEuxNU4GvnBK9oEEtNPC/x58AOxQuf1FhqbHYjz8D2Pyhso8TwS7NTa\n\tZ8b8o0vfsuqd3GPJKMiEhLEgu/io2KtLG10ynfh0vDBDQ7bwKoVlqC3It87AzQRaRrwiAQwA\n\txnVmJqeP9VUTISps+WbyYFYlMFfIurl7tzK74bc67KUBp+PHuDP9p4ZcJUGC3UZJP85/GlUV\n\tdE1NairYWEJQUB7bpogTuzMI825QXIB9z842HwWfP2RW5eDtJMeujzJeFaUpmeTG9snzaYxY\n\tN3r0TDKj5dZwSIThIMQpsmhH2zylkT0jH7kBPxb8IkCQ1c6wgKITwoHFjTIO0B75U7bBNSDp\n\tXUaUDvd6T3xd1Fz57ujAvKHrZfWtaNSGwLmUYQAcFvrKDGPB5Z3ggkiTtkmW3OCQbnIxGJJw\n\t/+HefYhB5/kCcpKUQ2RYcYgCZ0/WcES1xU5dnNe4i0a5gsOFSOYCpNCfTHttVxKxZZTQ/rxj\n\tXwTuToXmTI4Nehn96t25DHZ0t9L9UEJ0yxH2y8Av4rtf75K2yAXFZa8dHnQgCkyjA/gs0ujG\n\twD+Gs7dYQxP4i+rLhwBWD3mawJxLxY0vGwkG7k7npqanlsWlATHpOdqBMUiAR22hs02FikAo\n\tiXNgWTy7ABEBAAHCwXwEGAEIACYCGwwWIQRyeg1N257Z9gOb7O+Ef143kM4JdwUCZ7BxrgUJ\n\tD0w6ggAKCRCEf143kM4Jd55ED/9M47pnUYDVoaa1Xu4dVHw2h0XhBS/svPqb80YtjcBVgRp0\n\tPxLkI6afwteLsjpDgr4QbjoF868ctjqs6p/M7+VkFJNSa4hPmCayU310zEawO4EYm+jPRUIJ\n\ti87pEmygoN4ZnXvOYA9lkkbbaJkYB+8rDFSYeeSjuez0qmISbzkRVBwhGXQG5s5Oyij2eJ7f\n\tOvtjExsYkLP3NqmsODWj9aXqWGYsHPa7NpcLvHtkhtc5+SjRRLzh/NWJUtgFkqNPfhGMNwE8\n\tIsgCYA1B0Wam1zwvVgn6yRcwaCycr/SxHZAR4zZQNGyV1CA+Ph3cMiL8s49RluhiAiDqbJDx\n\tvoSNR7+hz6CXrAuFnUljMMWiSSeWDF+qSKVmUJIFHWW4s9RQofkF8/Bd6BZxIWQYxMKZm4S7\n\tdKo+5COEVOhSyYthhxNMCWDxLDuPoiGUbWBu/+8dXBusBV5fgcZ2SeQYnIvBzMj8NJ2vDU2D\n\tm/ajx6lQA/hW0zLYAew2v6WnHFnOXUlI3hv9LusUtj3XtLV2mf1FHvfYlrlI9WQsLiOE5nFN\n\tIsqJLm0TmM0i8WDnWovQHM8D0IzI/eUc4Ktbp0fVwWThP1ehdPEUKGCZflck5gvuU8yqE55r\n\tVrUwC3ocRUs4wXdUGZp67sExrfnb8QC2iXhYb+TpB8g7otkqYjL/nL8cQ8hdmg==","In-Reply-To":"<20250821134141.83236-1-mzamazal@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35544,"web_url":"https://patchwork.libcamera.org/comment/35544/","msgid":"","date":"2025-08-21T23:08:19","subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"Hi, thanks for this series!\n\nI just tested it on a Pixel 3a and a OnePlus6 and am happy to report \nthat it fixes the \"purple tint\" that has previously been visible at \ncertain resolutions for one of the sensors - so this is a great \nimprovement for linux mobile users! I also quickly tested on a Librem5 \nand didn't see any regressions, as expected.\n\nFurther more I checked whether it fixes \nhttps://bugs.libcamera.org/show_bug.cgi?id=236, but unfortunately it \ndoesn't - https://patchwork.libcamera.org/patch/21602/ is still needed \nto make Snapshot  work on the Pixel 3a (we probably really need a patch \nlike the mentioned one - hope to get around to send a v2 for 0.6).\n\nThus this series is:\n\nTested-by: Robert Mader \n\nOn 21.08.25 15:41, Milan Zamazal wrote:\n> Fixes of https://bugs.libcamera.org/show_bug.cgi?id=280 and the related\n> problems discussed there.\n>\n> Milan Zamazal (5):\n> libcamera: software_isp: Clarify SwStatsCpu::setWindow use\n> libcamera: software_isp: Pass correct y-coordinate to stats\n> libcamera: software_isp: Check processed window size alignment\n> libcamera: simple: Avoid incorrect arithmetic in AWB\n> libcamera: simple: Prevent division by zero in BLC\n>\n> src/ipa/simple/algorithms/awb.cpp | 8 ++++---\n> src/ipa/simple/algorithms/blc.cpp | 5 +++++\n> src/libcamera/software_isp/debayer_cpu.cpp | 26 +++++++++++++++++-----\n> src/libcamera/software_isp/swstats_cpu.cpp | 16 +++++++++++++\n> 4 files changed, 46 insertions(+), 9 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 59BB3BD87C\n\tfor ;\n\tThu, 21 Aug 2025 23:08:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4F88C692E0;\n\tFri, 22 Aug 2025 01:08:31 +0200 (CEST)","from sender4-op-o12.zoho.com (sender4-op-o12.zoho.com\n\t[136.143.188.12])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0117A613C1\n\tfor ;\n\tFri, 22 Aug 2025 01:08:28 +0200 (CEST)","by mx.zohomail.com with SMTPS id 1755817703041344.8854684997589;\n\tThu, 21 Aug 2025 16:08:23 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"Ui0o8CYh\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1755817705; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=WiLqoHueG9paQS52BrsEGLFZ2hpsjaL/OchCbvVHGg8p19CLNDphOj3enHXJeWOuNbkO6rUW58z1Xjci/q2xXAe/Q/C/KFih13K6+cLm6CFWLmPViJn9R1YSsbv6Y6bpqlbYuW1srCa6VqBqfYBkihK6mvHuLkqrYsGwm8e/Bv8=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1755817705;\n\th=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc;\n\tbh=p1cwz1+O2V1jqGm2oJxjBadqZJXt4caF7PcXJFt/xZE=; \n\tb=f3+G3WaHOZ6MkUseOeyL4XGkk6Vf1G0N0ibJBnnu/ctSZNw/i9nC2Lz4QYb0BweJx3IVjczU/2CtcN2tZp2fal9opD2J44rcuy5LzgT1zHGG+dRwpWNpL9crWJD2t6g6P8xsONpwcrG9pJ3yM1d+wmeCuqctMqlqER4HpITPIxU=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1755817705;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc;\n\tbh=p1cwz1+O2V1jqGm2oJxjBadqZJXt4caF7PcXJFt/xZE=;\n\tb=Ui0o8CYhgSj5gZYBIUPcjOwd4gdaLcbxQ3+4+C//5EeHWz9baMvKeluvl9zXiy0Q\n\t0cFg4aTtP9UTcIJOq5a3KDJqtvnD/PuCpbT2COzgRI5go+H+QCtcb3GRH0qiKQlQt1N\n\tFKvHfrWIR57ylkQYFBQwfB3idRjd38bChueqdtoU=","Message-ID":"","Date":"Fri, 22 Aug 2025 01:08:19 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","To":"libcamera-devel@lists.libcamera.org","References":"<20250821134141.83236-1-mzamazal@redhat.com>","Content-Language":"en-US, de-DE","From":"Robert Mader ","In-Reply-To":"<20250821134141.83236-1-mzamazal@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35553,"web_url":"https://patchwork.libcamera.org/comment/35553/","msgid":"<85bjo387nn.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-08-25T20:31:56","subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"\"Maciej S. Szmigiero\" writes:\n\n> Hi Milan,\n>\n> On 21.08.2025 15:41, Milan Zamazal wrote:\n>> Fixes of https://bugs.libcamera.org/show_bug.cgi?id=280 and the related\n>> problems discussed there.\n>> Milan Zamazal (5):\n>> libcamera: software_isp: Clarify SwStatsCpu::setWindow use\n>> libcamera: software_isp: Pass correct y-coordinate to stats\n>> libcamera: software_isp: Check processed window size alignment\n>> libcamera: simple: Avoid incorrect arithmetic in AWB\n>> libcamera: simple: Prevent division by zero in BLC\n>\n> Thanks for this patch series.\n>\n> I tested it on an IPU6 (Meteor Lake) laptop with an ov02e10 sensor.\n>\n> The \"division by zero\" crashes with small capture sizes\n> are definitely gone.\n\nGood, thank you for testing.\n\n> However a few issues remain on this platform:\n> * If I request smaller capture resolution I don't get full\n> image just with smaller capture dimensions, like on most\n> self-contained cameras.\n>\n> Instead, I get a crop of the requested size of the full image.\n> For example with 160 x 120 capture size the captured picture\n> just shows my eye.\n> \n> I presume it is because DebayerCpu::sizes() returns a very\n> wide size range and SimpleCameraData::tryPipeline()\n> returns such wide range in config.outputSizes without\n> further constraining it by capture hardware capabilities?\n\nDo you have specific hardware capabilities other than the resolution on\nmind?\n\n> Such wide config.outputSizes then gets used in\n> SimpleCameraConfiguration::validate() to (not) constrain the\n> requested picture size.\n\nSimpleCameraConfiguration::validate() should pick the smallest sensor\nresolution that can accommodate the requested output resolution, is it\notherwise by you? Or are there other parameters that should be\nconsidered?\n\n> * The AGC algorithm seems to go into unstable oscillation\n> mode when the amount of light in the picture exceeds certain\n> threshold, with exposure bins alternating between 0 and tens\n> of thousands rapidly.\n>\n> This makes the output picture look like it has been shot\n> thorough some very slow mechanical shutter, alternating\n> rapidly between almost normal picture and almost completely\n> black frame.\n\nI can reproduce the effect, at least with LED lighting. Does it happen\nunder daylight too?\n\n> This happens especially with small capture sizes so I\n> presume is related to the previous point.\n\nHow specifically? Maybe smaller resolutions are more prone to\nvariations?\n\n> Thanks,\n> Maciej","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E26DBD87C\n\tfor ;\n\tMon, 25 Aug 2025 20:32:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0F2FA692E9;\n\tMon, 25 Aug 2025 22:32:05 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C8132692CA\n\tfor ;\n\tMon, 25 Aug 2025 22:32:02 +0200 (CEST)","from mail-wm1-f72.google.com (mail-wm1-f72.google.com\n\t[209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-180-pxabl0HfPbyjhbwV-dqDvg-1; Mon, 25 Aug 2025 16:32:00 -0400","by mail-wm1-f72.google.com with SMTP id\n\t5b1f17b1804b1-45a1b10418aso27857545e9.3\n\tfor ;\n\tMon, 25 Aug 2025 13:32:00 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-3ca6240b4f9sm3317981f8f.15.2025.08.25.13.31.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 25 Aug 2025 13:31:57 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"icwTs5yd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1756153921;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=MKm6SBdouzh0zPPtB83yk2itIO/ivm+CBBOQbPT5QqM=;\n\tb=icwTs5yd32HXQNNrFvJiVZ28MsQbZ37BHZXLXYxa1YkiWJD7wezPpGpdpVQAjNOD58KonK\n\t7UYsLCACOAr+LiO1qGn1c87itmT0C8/BfRmgX3yZY4ZKymleefypo2uN0lhorRXO6T2iZ2\n\tra2+S8YYdKyT7KznrfV38rdVV5vWZb0=","X-MC-Unique":"pxabl0HfPbyjhbwV-dqDvg-1","X-Mimecast-MFC-AGG-ID":"pxabl0HfPbyjhbwV-dqDvg_1756153919","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1756153918; x=1756758718;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=MKm6SBdouzh0zPPtB83yk2itIO/ivm+CBBOQbPT5QqM=;\n\tb=QqlpdeGt442QLkWKlG1rtDPMmTJriqa6B6FtQfc9LaYwtyulCYtZmLRdRAnp3mEifz\n\tlsw0Y/gPwlnykPOVMFG7nwxls7Ds2xpHtF3xZNXwUlHlp9j+CgIWKF4iUfGE8surGXsm\n\tu4LD9nYuZ47fEMDMRFYPNMGITH59fkXH49TCkUxir+1ULmLHrc7AVKqY2gdz8leEHKkU\n\tlArZtAc5wYdYkLdNFjpBr43hM0P0fKRLpbc0JOBvFT3jsljIkMpZNnMCJ4m++l50LsoI\n\ts1pbWPEhr/WtCZpOUf0RI8IQYi4THZgJYn76I4QGDR0nywMymbjnHIqYDsFp64fPUWXj\n\tsGFg==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCUEZxuyzqZXU3DgWpXDNEQWq4craOM7fbZdhna7a8vIlQ2z8or5+g8i69b8euUul/WVEXRDphHs80vOVcnm+/U=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YyzW70hAJU9+c0DsLmmMYAlVth8jGFiq+2GIZifT6qjV81226lJ\n\tCn3bMcRzYVlcqJQMuEIQy/OpMERbnBXqRQzszIfilCQ31lw0l25vRwBDpNlE+u2yAUNYqC5G8yb\n\tt/VthfYTQIaI9LPqIlzbn76NVAQn9+DVYxGnWHQMeSv+n/q9lcOWGczcqeMwKgoMcc5cn3QtUOu\n\tOV6NiK55EHC6wsVkJ8aKv3FQQNZpuQxMPqSeNseOz72Iu5LvScaDo3+nVwioM=","X-Gm-Gg":"ASbGncsKhasUCxK/cwALI10SLqN/TrJZH55OxYFZtlKt19nJz0bYLP2fSDUXCF3jtlO\n\tm24uVgZTUcXLI4EvOs2W69zP7Fpa1c75WHamINsvrc0FPRrNVCYBu0Dkxt/Nxpk1Yx8jc6dVO5s\n\tvGjAplPEX9GAPtxd5aREVwz2lEAdaCsBRPPhjdmPnHnTPy/JodZcpgIOl6Jtcl+wVv/823zPsS7\n\tzr3DpJgerDG1IPQ3ULbqUyg52J8CibP6L46eHiuDjBxHv+G9yBN35eUdG8DdDEp53G5vtEfx1wu\n\tDER+xqdJvFOEnQa+nhaYBANfzj4BYLYB+lhIbp2tCZsMjfpDjz/UKYnHwRABKQMBtsEcwCmMpc8\n\tIfSSAR99mk6w0LZtz","X-Received":["by 2002:a05:600c:350f:b0:456:a1b:e906 with SMTP id\n\t5b1f17b1804b1-45b517df310mr120044375e9.33.1756153918357; \n\tMon, 25 Aug 2025 13:31:58 -0700 (PDT)","by 2002:a05:600c:350f:b0:456:a1b:e906 with SMTP id\n\t5b1f17b1804b1-45b517df310mr120044195e9.33.1756153917807; \n\tMon, 25 Aug 2025 13:31:57 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IHhpZzp5WZaX9n1P7QpZKfC9tc7uJd1OPWt4tVWBLft6ly1UN1epFZ9UraT0ra04GFemTOlQg==","From":"Milan Zamazal ","To":"\"Maciej S. Szmigiero\" ","Cc":"pobrn@protonmail.com, libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","In-Reply-To":"<6cd8d54e-59d3-49bc-b5a6-b395e12afce8@maciej.szmigiero.name>\n\t(Maciej S. Szmigiero's message of \"Thu, 21 Aug 2025 23:35:21 +0200\")","References":"<20250821134141.83236-1-mzamazal@redhat.com>\n\t<6cd8d54e-59d3-49bc-b5a6-b395e12afce8@maciej.szmigiero.name>","Date":"Mon, 25 Aug 2025 22:31:56 +0200","Message-ID":"<85bjo387nn.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"FikrDk6vuE-3FOjaBapm2-ksNaUFWJi0ExTpdNJGG4E_1756153919","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35554,"web_url":"https://patchwork.libcamera.org/comment/35554/","msgid":"<855xeb86rw.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-08-25T20:50:59","subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Robert,\n\nRobert Mader writes:\n\n> Hi, thanks for this series!\n>\n> I just tested it on a Pixel 3a and a OnePlus6 and am happy to report that it fixes the \"purple tint\" that\n> has previously been visible at certain resolutions for one of the\n> sensors\n\nInteresting.\n\n> - so this is a great improvement for linux mobile users! I also\n> quickly tested on a Librem5 and didn't see any regressions, as\n> expected.\n\nGood to know, thank you for testing.\n\n> Further more I checked whether it fixes https://bugs.libcamera.org/show_bug.cgi?id=236, but unfortunately\n> it doesn't - https://patchwork.libcamera.org/patch/21602/ is still needed to make Snapshot  work on the\n> Pixel 3a (we probably really need a patch like the mentioned one - hope to get around to send a v2 for\n> 0.6).\n\nHmm, what exactly breaks there? With my imx219, for instance, when the\noutput resolution is 1920x1080, which is also one of the resolutions the\nsensor supports, 3280x2464 sensor resolution is selected due to the\nextra width needed for debayering. Which is expected and works. But it\nresults in cropping due to the resolution difference, which is maybe\nwhat Maciej has on mind. The question is what can be done about it\n(this is not the first time I wonder what's worse: possible colour\ntrouble at the borders or the trouble with resolutions).\n\n> Thus this series is:\n>\n> Tested-by: Robert Mader \n>\n> On 21.08.25 15:41, Milan Zamazal wrote:\n>> Fixes of https://bugs.libcamera.org/show_bug.cgi?id=280 and the related\n>> problems discussed there.\n>>\n>> Milan Zamazal (5):\n>> libcamera: software_isp: Clarify SwStatsCpu::setWindow use\n>> libcamera: software_isp: Pass correct y-coordinate to stats\n>> libcamera: software_isp: Check processed window size alignment\n>> libcamera: simple: Avoid incorrect arithmetic in AWB\n>> libcamera: simple: Prevent division by zero in BLC\n>>\n>> src/ipa/simple/algorithms/awb.cpp | 8 ++++---\n>> src/ipa/simple/algorithms/blc.cpp | 5 +++++\n>> src/libcamera/software_isp/debayer_cpu.cpp | 26 +++++++++++++++++-----\n>> src/libcamera/software_isp/swstats_cpu.cpp | 16 +++++++++++++\n>> 4 files changed, 46 insertions(+), 9 deletions(-)\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 42E39BEFBE\n\tfor ;\n\tMon, 25 Aug 2025 20:51:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC39E692E9;\n\tMon, 25 Aug 2025 22:51:07 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9BB09692CA\n\tfor ;\n\tMon, 25 Aug 2025 22:51:05 +0200 (CEST)","from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n\t[209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-543-G8ebkpEpOh6VN5FTD9NxWQ-1; Mon, 25 Aug 2025 16:51:02 -0400","by mail-wm1-f69.google.com with SMTP id\n\t5b1f17b1804b1-45a1b05a59cso34263425e9.1\n\tfor ;\n\tMon, 25 Aug 2025 13:51:02 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-3c7117d5977sm13177269f8f.51.2025.08.25.13.51.00\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 25 Aug 2025 13:51:00 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"P0kSQ/+H\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1756155064;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=4R4G/IQlMmmkBUkQWVc0YGuzhicawNbm8MMWwZsLoz0=;\n\tb=P0kSQ/+HxGUKv0R3ICxtZDVICoPpZCyHrjKDJujnYUxnFl4l56vXDHCWx46FBu8ULkF8cw\n\tra+uwOglgm+bD9ASU4H1jSPCvfZ31E4+L/rjeHAduvUdjumOBDGo3Wx2nX/iKdajXIFMNp\n\tOaawJmDRrLFq3BC+WG+qg78U2dwSuuw=","X-MC-Unique":"G8ebkpEpOh6VN5FTD9NxWQ-1","X-Mimecast-MFC-AGG-ID":"G8ebkpEpOh6VN5FTD9NxWQ_1756155062","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1756155061; x=1756759861;\n\th=content-transfer-encoding:mime-version:user-agent:message-id:date\n\t:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=q0qzZpZiyYrdiv7PkP3aDQ2lkU/iB8IcrRu+tQAlpvA=;\n\tb=QK/5trDREHtss5yL15PlHHjwneUKbhsBLo+OI4Ar5Nenyh4GwYNYaJjZQp7O4rcMfJ\n\tHu9KhlhxOoHhoSBcIy8V/f+Xhd/nZ9ywTjuzPf3mWg8jwd/HEcSfxo4wGsfDowqxXCe9\n\tBWmV0h0ILcTW5oG3cTpSpsqKgcz8Np3WSVV8tPTAK/Mu+9Lgcm9cG75agvvDcLsk4Zmp\n\tNvdkL8mkOLWlhmMRm2ccQ2MAka61b0i+DiD4gb9lQk9xPM34lhg4PSrmrguyu4+aVE1M\n\tydhdJsJJgdZAStbqt/JPwf9BLMN7vqFQ0AD7QGmtPX4Zf4PI4JD7u7tFXg3Y7MVziNUZ\n\tF8kg==","X-Gm-Message-State":"AOJu0Yw9wUkMoU/D30WEwnqC15QKJX8Z5s70FLFtZBzGV6SklAJCY/FI\n\trQjB2ji7MZkUa5uXYLwMDThzLWjEuV1SDHSNR3ChuE5A1YKgcLKgbXhUVAiSkZR9xPDRP/4PdaV\n\tXbUAN45LrsfUP1x6308U0gPe3IDDHlGMOFJL42zdzwmhsp9fA/1D0G89TifLZozonammvSZ/jH7\n\tyLsIMS9YXmYERaUZfOfUKXccdph6v3hSH4s15dT98hGCnlUTy0ZXqyTSrLTL0=","X-Gm-Gg":"ASbGncuF7+UtKPpWNT8QV8Xaxdm3ZcQumn/FyjwsDulw9SkUk5mJWjWLkrlF9SOi5re\n\tJjR6mcH3QUARYXRIy/EhyEP+qwCjbd3rbUT7DkdSg7RO0gfftXDhAkZWi/9gJCPNm/jbPdFi+HY\n\tmtSCRrdkk0Cn3UQnTGT9zdGui+vk07oDyqPAYf4J/w97j1Ruu5Ek75y3Fa7AYCecYxIouHxCDr1\n\takLrBM4tqXndm3Yai1nPH/vFHUrxiwPyCtSHu8uTRrYWYTjuKKKmiun9DsGbaXY3WnTwUMyJ0xd\n\t0MNHno+B6TIiOKlZq7CvgvId63GtRyJhfj5MbkEMnTc4uHLJY7gwWbcSlqW7DWmf0adWc2OiyvF\n\tNw4hqy3ICwyLr2VZq","X-Received":["by 2002:a05:600c:1e85:b0:458:bc2c:b2ed with SMTP id\n\t5b1f17b1804b1-45b5179f402mr114868825e9.7.1756155061377; \n\tMon, 25 Aug 2025 13:51:01 -0700 (PDT)","by 2002:a05:600c:1e85:b0:458:bc2c:b2ed with SMTP id\n\t5b1f17b1804b1-45b5179f402mr114868725e9.7.1756155060906; \n\tMon, 25 Aug 2025 13:51:00 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IExnE+8c0V81OE31gGLlFnnXZPG5i7AcGyqIZo4cKo9YfnhW37VPqPKlZeYYurOp0m/aJUAMg==","From":"Milan Zamazal ","To":"Robert Mader ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","In-Reply-To":" (Robert\n\tMader's message of \"Fri, 22 Aug 2025 01:08:19 +0200\")","References":"<20250821134141.83236-1-mzamazal@redhat.com>\n\t","Date":"Mon, 25 Aug 2025 22:50:59 +0200","Message-ID":"<855xeb86rw.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"lLSjpIGRoZxcvEwv4Sst6o2f5tqLC6isGZENycw-D2o_1756155062","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35595,"web_url":"https://patchwork.libcamera.org/comment/35595/","msgid":"","date":"2025-08-27T21:10:08","subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","submitter":{"id":237,"url":"https://patchwork.libcamera.org/api/people/237/","name":"Maciej S. Szmigiero","email":"mail@maciej.szmigiero.name"},"content":"On 25.08.2025 22:31, Milan Zamazal wrote:\n> \"Maciej S. Szmigiero\" writes:\n> \n>> Hi Milan,\n>>\n(..)\n>> However a few issues remain on this platform:\n>> * If I request smaller capture resolution I don't get full\n>> image just with smaller capture dimensions, like on most\n>> self-contained cameras.\n>>\n>> Instead, I get a crop of the requested size of the full image.\n>> For example with 160 x 120 capture size the captured picture\n>> just shows my eye.\n>>\n>> I presume it is because DebayerCpu::sizes() returns a very\n>> wide size range and SimpleCameraData::tryPipeline()\n>> returns such wide range in config.outputSizes without\n>> further constraining it by capture hardware capabilities?\n> \n> Do you have specific hardware capabilities other than the resolution on\n> mind?\n\nIn my case I meant hardware resolution capabilities.\n\n>> Such wide config.outputSizes then gets used in\n>> SimpleCameraConfiguration::validate() to (not) constrain the\n>> requested picture size.\n> \n> SimpleCameraConfiguration::validate() should pick the smallest sensor\n> resolution that can accommodate the requested output resolution, is it\n> otherwise by you? Or are there other parameters that should be\n> considered?\n\nThis sensor supports just one resolution of 1928x1088:\nhttps://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/media/i2c/ov02e10.c#n208\n\nSo I presume libcamera should allow just this single resolution\nand reject smaller ones like 160x120?\nOr, to be specific, always adjust the resolution in the requested\nconfiguration to 1928x1088.\n\nSince the current behavior of just returning a window crop of the\nmiddle of the picture seems not very useful to libcamera consumers.\n\nAFAIK, there is not even API to move this crop window to return\ndifferent parts of the source image than the center of it.\n\nTraditional V4L2 drivers adjust their analog capture parameters to\nsomething close to the requested resolution and/or have some kind\nof a rescaler on-board.\nEven venerable Bt878 had a built-in video scaler.\n\n>> * The AGC algorithm seems to go into unstable oscillation\n>> mode when the amount of light in the picture exceeds certain\n>> threshold, with exposure bins alternating between 0 and tens\n>> of thousands rapidly.\n>>\n>> This makes the output picture look like it has been shot\n>> thorough some very slow mechanical shutter, alternating\n>> rapidly between almost normal picture and almost completely\n>> black frame.\n> \n> I can reproduce the effect, at least with LED lighting. Does it happen\n> under daylight too?\n\nYes, but only under strong daylight, like summer sun illuminating\nthe scene.\n\nIt's also very borderline with sunlight since even slightly closing\nthe camera privacy shutter lowers the light input below the\nthreshold where this effect happens.\n\n>> This happens especially with small capture sizes so I\n>> presume is related to the previous point.\n> \n> How specifically? Maybe smaller resolutions are more prone to\n> variations?\n> \n\nJust a wild theory that smaller total pixel count somehow provides\nless neighborhood to average any extreme values.\nBut at the other hand, it could be just a coincidence.\n\nThanks,\nMaciej","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 99C6FBD87C\n\tfor ;\n\tWed, 27 Aug 2025 21:10:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 43AB3692EF;\n\tWed, 27 Aug 2025 23:10:17 +0200 (CEST)","from vps-ovh.mhejs.net (vps-ovh.mhejs.net [145.239.82.108])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C07B613BA\n\tfor ;\n\tWed, 27 Aug 2025 23:10:15 +0200 (CEST)","from MUA\n\tby vps-ovh.mhejs.net with esmtpsa (TLS1.3) tls TLS_AES_128_GCM_SHA256\n\t(Exim 4.98.2) (envelope-from )\n\tid 1urNPK-00000001vWs-0HD9; Wed, 27 Aug 2025 23:10:14 +0200"],"Message-ID":"","Date":"Wed, 27 Aug 2025 23:10:08 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","To":"Milan Zamazal ","Cc":"pobrn@protonmail.com, libcamera-devel@lists.libcamera.org","References":"<20250821134141.83236-1-mzamazal@redhat.com>\n\t<6cd8d54e-59d3-49bc-b5a6-b395e12afce8@maciej.szmigiero.name>\n\t<85bjo387nn.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","Content-Language":"en-US, pl-PL","From":"\"Maciej S. Szmigiero\" ","Autocrypt":"addr=mail@maciej.szmigiero.name; keydata=\n\txsFNBFpGusUBEADXUMM2t7y9sHhI79+2QUnDdpauIBjZDukPZArwD+sDlx5P+jxaZ13XjUQc\n\t6oJdk+jpvKiyzlbKqlDtw/Y2Ob24tg1g/zvkHn8AVUwX+ZWWewSZ0vcwp7u/LvA+w2nJbIL1\n\tN0/QUUdmxfkWTHhNqgkNX5hEmYqhwUPozFR0zblfD/6+XFR7VM9yT0fZPLqYLNOmGfqAXlxY\n\tm8nWmi+lxkd/PYqQQwOq6GQwxjRFEvSc09m/YPYo9hxh7a6s8hAP88YOf2PD8oBB1r5E7KGb\n\tFv10Qss4CU/3zaiyRTExWwOJnTQdzSbtnM3S8/ZO/sL0FY/b4VLtlZzERAraxHdnPn8GgxYk\n\toPtAqoyf52RkCabL9dsXPWYQjkwG8WEUPScHDy8Uoo6imQujshG23A99iPuXcWc/5ld9mIo/\n\tEe7kN50MOXwS4vCJSv0cMkVhh77CmGUv5++E/rPcbXPLTPeRVy6SHgdDhIj7elmx2Lgo0cyh\n\tuyxyBKSuzPvb61nh5EKAGL7kPqflNw7LJkInzHqKHDNu57rVuCHEx4yxcKNB4pdE2SgyPxs9\n\t9W7Cz0q2Hd7Yu8GOXvMfQfrBiEV4q4PzidUtV6sLqVq0RMK7LEi0RiZpthwxz0IUFwRw2KS/\n\t9Kgs9LmOXYimodrV0pMxpVqcyTepmDSoWzyXNP2NL1+GuQtaTQARAQABzTBNYWNpZWogUy4g\n\tU3ptaWdpZXJvIDxtYWlsQG1hY2llai5zem1pZ2llcm8ubmFtZT7CwZQEEwEIAD4CGwMFCwkI\n\tBwIGFQoJCAsCBBYCAwECHgECF4AWIQRyeg1N257Z9gOb7O+Ef143kM4JdwUCZ7BxhgUJD0w7\n\twQAKCRCEf143kM4JdwHlD/9Ef793d6Q3WkcapGZLg1hrUg+S3d1brtJSKP6B8Ny0tt/6kjc2\n\tM8q4v0pY6rA/tksIbBw6ZVZNCoce0w3/sy358jcDldh/eYotwUCHQzXl2IZwRT2SbmEoJn9J\n\tnAOnjMCpMFRyBC1yiWzOR3XonLFNB+kWfTK3fwzKWCmpcUkI5ANrmNiDFPcsn+TzfeMV/CzT\n\tFMsqVmr+TCWl29QB3U0eFZP8Y01UiowugS0jW/B/zWYbWo2FvoOqGLRUWgQ20NBXHlV5m0qa\n\twI2Isrbos1kXSl2TDovT0Ppt+66RhV36SGA2qzLs0B9LO7/xqF4/xwmudkpabOoH5g3T20aH\n\txlB0WuTJ7FyxZGnO6NL9QTxx3t86FfkKVfTksKP0FRKujsOxGQ1JpqdazyO6k7yMFfcnxwAb\n\tMyLU6ZepXf/6LvcFFe0oXC+ZNqj7kT6+hoTkZJcxynlcxSRzRSpnS41MRHJbyQM7kjpuVdyQ\n\tBWPdBnW0bYamlsW00w5XaR+fvNr4fV0vcqB991lxD4ayBbYPz11tnjlOwqnawH1ctCy5rdBY\n\teTC6olpkmyUhrrIpTgEuxNU4GvnBK9oEEtNPC/x58AOxQuf1FhqbHYjz8D2Pyhso8TwS7NTa\n\tZ8b8o0vfsuqd3GPJKMiEhLEgu/io2KtLG10ynfh0vDBDQ7bwKoVlqC3It87AzQRaRrwiAQwA\n\txnVmJqeP9VUTISps+WbyYFYlMFfIurl7tzK74bc67KUBp+PHuDP9p4ZcJUGC3UZJP85/GlUV\n\tdE1NairYWEJQUB7bpogTuzMI825QXIB9z842HwWfP2RW5eDtJMeujzJeFaUpmeTG9snzaYxY\n\tN3r0TDKj5dZwSIThIMQpsmhH2zylkT0jH7kBPxb8IkCQ1c6wgKITwoHFjTIO0B75U7bBNSDp\n\tXUaUDvd6T3xd1Fz57ujAvKHrZfWtaNSGwLmUYQAcFvrKDGPB5Z3ggkiTtkmW3OCQbnIxGJJw\n\t/+HefYhB5/kCcpKUQ2RYcYgCZ0/WcES1xU5dnNe4i0a5gsOFSOYCpNCfTHttVxKxZZTQ/rxj\n\tXwTuToXmTI4Nehn96t25DHZ0t9L9UEJ0yxH2y8Av4rtf75K2yAXFZa8dHnQgCkyjA/gs0ujG\n\twD+Gs7dYQxP4i+rLhwBWD3mawJxLxY0vGwkG7k7npqanlsWlATHpOdqBMUiAR22hs02FikAo\n\tiXNgWTy7ABEBAAHCwXwEGAEIACYCGwwWIQRyeg1N257Z9gOb7O+Ef143kM4JdwUCZ7BxrgUJ\n\tD0w6ggAKCRCEf143kM4Jd55ED/9M47pnUYDVoaa1Xu4dVHw2h0XhBS/svPqb80YtjcBVgRp0\n\tPxLkI6afwteLsjpDgr4QbjoF868ctjqs6p/M7+VkFJNSa4hPmCayU310zEawO4EYm+jPRUIJ\n\ti87pEmygoN4ZnXvOYA9lkkbbaJkYB+8rDFSYeeSjuez0qmISbzkRVBwhGXQG5s5Oyij2eJ7f\n\tOvtjExsYkLP3NqmsODWj9aXqWGYsHPa7NpcLvHtkhtc5+SjRRLzh/NWJUtgFkqNPfhGMNwE8\n\tIsgCYA1B0Wam1zwvVgn6yRcwaCycr/SxHZAR4zZQNGyV1CA+Ph3cMiL8s49RluhiAiDqbJDx\n\tvoSNR7+hz6CXrAuFnUljMMWiSSeWDF+qSKVmUJIFHWW4s9RQofkF8/Bd6BZxIWQYxMKZm4S7\n\tdKo+5COEVOhSyYthhxNMCWDxLDuPoiGUbWBu/+8dXBusBV5fgcZ2SeQYnIvBzMj8NJ2vDU2D\n\tm/ajx6lQA/hW0zLYAew2v6WnHFnOXUlI3hv9LusUtj3XtLV2mf1FHvfYlrlI9WQsLiOE5nFN\n\tIsqJLm0TmM0i8WDnWovQHM8D0IzI/eUc4Ktbp0fVwWThP1ehdPEUKGCZflck5gvuU8yqE55r\n\tVrUwC3ocRUs4wXdUGZp67sExrfnb8QC2iXhYb+TpB8g7otkqYjL/nL8cQ8hdmg==","In-Reply-To":"<85bjo387nn.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35599,"web_url":"https://patchwork.libcamera.org/comment/35599/","msgid":"<7b057218-f898-405f-86c7-136a5e411c9b@ideasonboard.com>","date":"2025-08-28T07:11:53","subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n2025. 08. 27. 23:10 keltezéssel, Maciej S. Szmigiero írta:\n> On 25.08.2025 22:31, Milan Zamazal wrote:\n>> \"Maciej S. Szmigiero\" writes:\n>>\n>>> Hi Milan,\n>>>\n> (..)\n>>> However a few issues remain on this platform:\n>>> * If I request smaller capture resolution I don't get full\n>>> image just with smaller capture dimensions, like on most\n>>> self-contained cameras.\n>>>\n>>> Instead, I get a crop of the requested size of the full image.\n>>> For example with 160 x 120 capture size the captured picture\n>>> just shows my eye.\n>>>\n>>> I presume it is because DebayerCpu::sizes() returns a very\n>>> wide size range and SimpleCameraData::tryPipeline()\n>>> returns such wide range in config.outputSizes without\n>>> further constraining it by capture hardware capabilities?\n>>\n>> Do you have specific hardware capabilities other than the resolution on\n>> mind?\n> \n> In my case I meant hardware resolution capabilities.\n> \n>>> Such wide config.outputSizes then gets used in\n>>> SimpleCameraConfiguration::validate() to (not) constrain the\n>>> requested picture size.\n>>\n>> SimpleCameraConfiguration::validate() should pick the smallest sensor\n>> resolution that can accommodate the requested output resolution, is it\n>> otherwise by you?  Or are there other parameters that should be\n>> considered?\n> \n> This sensor supports just one resolution of 1928x1088:\n> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/media/i2c/ov02e10.c#n208\n> \n> So I presume libcamera should allow just this single resolution\n> and reject smaller ones like 160x120?\n> Or, to be specific, always adjust the resolution in the requested\n> configuration to 1928x1088.\n> \n> Since the current behavior of just returning a window crop of the\n> middle of the picture seems not very useful to libcamera consumers.\n\nI agree that it is probably not what users expect. But I imagine it's\nstill better than only offering fewer choices.\n\n\n> \n> AFAIK, there is not even API to move this crop window to return\n> different parts of the source image than the center of it.\n\nI think you're looking for the `ScalerCrop` control. Of course the\n\"simple\" pipeline handler does not support it yet.\n\n\nRegards,\nBarnabás Pőcze\n\n\n> \n> Traditional V4L2 drivers adjust their analog capture parameters to\n> something close to the requested resolution and/or have some kind\n> of a rescaler on-board.\n> Even venerable Bt878 had a built-in video scaler.\n> \n>>> * The AGC algorithm seems to go into unstable oscillation\n>>> mode when the amount of light in the picture exceeds certain\n>>> threshold, with exposure bins alternating between 0 and tens\n>>> of thousands rapidly.\n>>>\n>>> This makes the output picture look like it has been shot\n>>> thorough some very slow mechanical shutter, alternating\n>>> rapidly between almost normal picture and almost completely\n>>> black frame.\n>>\n>> I can reproduce the effect, at least with LED lighting.  Does it happen\n>> under daylight too?\n> \n> Yes, but only under strong daylight, like summer sun illuminating\n> the scene.\n> \n> It's also very borderline with sunlight since even slightly closing\n> the camera privacy shutter lowers the light input below the\n> threshold where this effect happens.\n> \n>>> This happens especially with small capture sizes so I\n>>> presume is related to the previous point.\n>>\n>> How specifically?  Maybe smaller resolutions are more prone to\n>> variations?\n>>\n> \n> Just a wild theory that smaller total pixel count somehow provides\n> less neighborhood to average any extreme values.\n> But at the other hand, it could be just a coincidence.\n> \n> Thanks,\n> Maciej\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7DF8DBEFBE\n\tfor ;\n\tThu, 28 Aug 2025 07:12:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1B5A5692F1;\n\tThu, 28 Aug 2025 09:12:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3EB70613BE\n\tfor ;\n\tThu, 28 Aug 2025 09:11:58 +0200 (CEST)","from [192.168.33.12] (185.221.143.232.nat.pool.zt.hu\n\t[185.221.143.232])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B5BA71785;\n\tThu, 28 Aug 2025 09:10:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FyspcjTr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1756365053;\n\tbh=anq4IlV7lZukFMCESiOUfjek+NUFdDxszocbsvdtbw4=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=FyspcjTrU6fc1IYMbZ92frOr+Z8/aIYefJSCeKhRBnranJwisMrud6DUBTTJsff7W\n\tUQNE7v8Y0QUMNtkDVHzkH4YsWheXixFQCQyxVaEMYF1k4+YLKfXgsz2tILp4i0GrB2\n\tks97R1/p6YUhyXv4Td+DxYV3g359oLby2ECBjOMc=","Message-ID":"<7b057218-f898-405f-86c7-136a5e411c9b@ideasonboard.com>","Date":"Thu, 28 Aug 2025 09:11:53 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","To":"\"Maciej S. Szmigiero\" ","Cc":"libcamera-devel@lists.libcamera.org, Milan Zamazal ","References":"<20250821134141.83236-1-mzamazal@redhat.com>\n\t<6cd8d54e-59d3-49bc-b5a6-b395e12afce8@maciej.szmigiero.name>\n\t<85bjo387nn.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>\n\t","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35611,"web_url":"https://patchwork.libcamera.org/comment/35611/","msgid":"<85349bflyp.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-08-28T16:30:06","subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"\"Maciej S. Szmigiero\" writes:\n\n>>> * The AGC algorithm seems to go into unstable oscillation\n>>> mode when the amount of light in the picture exceeds certain\n>>> threshold, with exposure bins alternating between 0 and tens\n>>> of thousands rapidly.\n>>>\n>>> This makes the output picture look like it has been shot\n>>> thorough some very slow mechanical shutter, alternating\n>>> rapidly between almost normal picture and almost completely\n>>> black frame.\n>> I can reproduce the effect, at least with LED lighting. Does it happen\n>> under daylight too?\n>\n> Yes, but only under strong daylight, like summer sun illuminating\n> the scene.\n>\n> It's also very borderline with sunlight since even slightly closing\n> the camera privacy shutter lowers the light input below the\n> threshold where this effect happens.\n\nThanks for info. These exposure instabilities should really be fixed,\nI'll look at what can be possibly done.\n\nAs for cropping, I don't have a clear opinion what's the best option of\nchanging the resolution, scaling, cropping. As Barnabás pointed out,\nimplementing ScalerCrop would perhaps help substantially.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 694DABEFBE\n\tfor ;\n\tThu, 28 Aug 2025 16:30:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 45C97692F3;\n\tThu, 28 Aug 2025 18:30:17 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 977B5613B8\n\tfor ;\n\tThu, 28 Aug 2025 18:30:14 +0200 (CEST)","from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n\t[209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-396-rf3WFcCDNyiu01IPyuv6vA-1; Thu, 28 Aug 2025 12:30:10 -0400","by mail-wm1-f69.google.com with SMTP id\n\t5b1f17b1804b1-45a1b0c5366so7516585e9.3\n\tfor ;\n\tThu, 28 Aug 2025 09:30:10 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-3c88901520asm20697376f8f.19.2025.08.28.09.30.07\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 28 Aug 2025 09:30:07 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"C6I8/wFF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1756398613;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=3nvzAwkwAwuZMCR5yonBbas0S+CxDbsYjXpi0Uc51hs=;\n\tb=C6I8/wFFG/XOPBYH/iikrcoVlemseJ3cVQG2a8zdg4qqpHxgjAyQFqoGhYlPrFC5v38KIC\n\tTQLnfg1k0ksXcOaZJQEa+pQ0e2DM53rxGeafx/L2YosspeBNRZN8DPDpcvRS/XVBgUD0Zs\n\tCom6JMC9D3yKLXXnbdT+GCy0ZWPZ7Pk=","X-MC-Unique":"rf3WFcCDNyiu01IPyuv6vA-1","X-Mimecast-MFC-AGG-ID":"rf3WFcCDNyiu01IPyuv6vA_1756398609","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1756398609; x=1757003409;\n\th=content-transfer-encoding:mime-version:user-agent:message-id:date\n\t:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=3nvzAwkwAwuZMCR5yonBbas0S+CxDbsYjXpi0Uc51hs=;\n\tb=admf2/cebVkhpbiIp2u/eJisvVKlh2cxpdsF/8ZYhMVABTsoAKspb2KvJdljjY8kJu\n\tffy1wlKbelEhm2z7ej7IbGorFrfoqzrtG8pO5wpeQIfNQhgqeprQ2iv28urEV6WGp+nx\n\tmFE5WzFUUm8b5PmHyPshpBLHY3/ekWBqOSaXeRdhh2cK4UDtjEKs9uEvoWz2wjkowjac\n\t2JoiW+0sB+uPVYBZP+jQENFhhu4jfLaO70/Sa+UxjX+vQiF/qAml28RwsmX5P420FC+X\n\t4GHhs9+BybGD012cCGs/EMS/ykIOyBVDvVd1pOlFo13V93ihDBZsNGfODaBSmh9wgP7S\n\tFpRw==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCXH7FG1R1YTxqs/YY6zpyqMyJ8iDI066u9m0jPH3F7B02aNj3vd10jci0VU6E5JVaqLVuLTOeSM2E4RyLsetA0=@lists.libcamera.org","X-Gm-Message-State":"AOJu0Yy7vcz5sFCBmtPLsfTS9WvfnW6E7nHqmlTEzB3od1SKw0THzWUy\n\th4csjP0thk8Yz+uO5DA829vd92k+bRcL1DO27gKLRakZDH3FrAZAsC7EUrwro6q+g+0eZdgmZlw\n\tSqmRUmFLkEuhPczpkwtDB26TO7JvaEJcZgqRjh0tQjhn6+9+XHRTTNPpxwa/XJF+++i/iVshWT0\n\tN4NZc3cu03I3Poaydy3PWqfEBPjOH/F+mhKRtWZSJ6cPxdQDHA69SqTJIQwVw=","X-Gm-Gg":"ASbGncvhUej/GJ5O6s+u2txpP3OrOy5emKM6kzXu3m2ywh0Zn4FcnWpWKfEpJu9GO2U\n\tMo+JeV4w/gAQlCgaYlZ6ogq6QQR5q3446c/l52gArQwStrcebdIToAFzkQKIzcmbCjq8TOHn0Cz\n\tDxyeQSjrvoWbBG1ciDBdIpm8r7UhPK48p1s38dBltkqE2FhB5aus5XecHxhhvqGxXekRZoevPqk\n\tec5WF3aTedE3vnMmtvoqRYIuFMJdg8FDyjQvFacwYv1keQMIIIANppqGmfV35LmvGQEP+AyuSVv\n\t4BBfUssz9qVZqGNKODQGu33/ZfV1wQSAFrhOttSZCvJS6X1aWOK/2dTfE4lMxjSCUIJmGNERfUS\n\tElSljmY2DlKW7MxxC","X-Received":["by 2002:a05:600c:1386:b0:45b:69c0:1909 with SMTP id\n\t5b1f17b1804b1-45b69c01d6cmr75327025e9.8.1756398608741; \n\tThu, 28 Aug 2025 09:30:08 -0700 (PDT)","by 2002:a05:600c:1386:b0:45b:69c0:1909 with SMTP id\n\t5b1f17b1804b1-45b69c01d6cmr75326685e9.8.1756398608225; \n\tThu, 28 Aug 2025 09:30:08 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IGZYmiyj96ulF6bA4aiHTUovHqVt2VbqDhsZzIsYLgehjzbh72n/LWwyBSZmSlHRFr6oealpw==","From":"Milan Zamazal ","To":"\"Maciej S. Szmigiero\" ","Cc":"pobrn@protonmail.com, libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","In-Reply-To":"\n\t(Maciej S. Szmigiero's message of \"Wed, 27 Aug 2025 23:10:08 +0200\")","References":"<20250821134141.83236-1-mzamazal@redhat.com>\n\t<6cd8d54e-59d3-49bc-b5a6-b395e12afce8@maciej.szmigiero.name>\n\t<85bjo387nn.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>\n\t","Date":"Thu, 28 Aug 2025 18:30:06 +0200","Message-ID":"<85349bflyp.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"72ACVfexlaMvnkNOj3-YAuXZZ-hKfHUN_jf4AYZwmEI_1756398609","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35614,"web_url":"https://patchwork.libcamera.org/comment/35614/","msgid":"","date":"2025-08-28T21:07:35","subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","submitter":{"id":237,"url":"https://patchwork.libcamera.org/api/people/237/","name":"Maciej S. Szmigiero","email":"mail@maciej.szmigiero.name"},"content":"On 28.08.2025 09:11, Barnabás Pőcze wrote:\n> Hi\n> \n> 2025. 08. 27. 23:10 keltezéssel, Maciej S. Szmigiero írta:\n>> On 25.08.2025 22:31, Milan Zamazal wrote:\n>>> \"Maciej S. Szmigiero\" writes:\n>>>\n>>>> Hi Milan,\n>>>>\n>> (..)\n>>>> However a few issues remain on this platform:\n>>>> * If I request smaller capture resolution I don't get full\n>>>> image just with smaller capture dimensions, like on most\n>>>> self-contained cameras.\n>>>>\n>>>> Instead, I get a crop of the requested size of the full image.\n>>>> For example with 160 x 120 capture size the captured picture\n>>>> just shows my eye.\n>>>>\n>>>> I presume it is because DebayerCpu::sizes() returns a very\n>>>> wide size range and SimpleCameraData::tryPipeline()\n>>>> returns such wide range in config.outputSizes without\n>>>> further constraining it by capture hardware capabilities?\n>>>\n>>> Do you have specific hardware capabilities other than the resolution on\n>>> mind?\n>>\n>> In my case I meant hardware resolution capabilities.\n>>\n>>>> Such wide config.outputSizes then gets used in\n>>>> SimpleCameraConfiguration::validate() to (not) constrain the\n>>>> requested picture size.\n>>>\n>>> SimpleCameraConfiguration::validate() should pick the smallest sensor\n>>> resolution that can accommodate the requested output resolution, is it\n>>> otherwise by you?  Or are there other parameters that should be\n>>> considered?\n>>\n>> This sensor supports just one resolution of 1928x1088:\n>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/media/i2c/ov02e10.c#n208\n>>\n>> So I presume libcamera should allow just this single resolution\n>> and reject smaller ones like 160x120?\n>> Or, to be specific, always adjust the resolution in the requested\n>> configuration to 1928x1088.\n>>\n>> Since the current behavior of just returning a window crop of the\n>> middle of the picture seems not very useful to libcamera consumers.\n> \n> I agree that it is probably not what users expect. But I imagine it's\n> still better than only offering fewer choices.\n> \n> \n>>\n>> AFAIK, there is not even API to move this crop window to return\n>> different parts of the source image than the center of it.\n> \n> I think you're looking for the `ScalerCrop` control. Of course the\n> \"simple\" pipeline handler does not support it yet.\n\nYeah, that may be the case here.\n\nStill, libcamera consumers like PipeWire generally expect scaling\nof the full picture rather than cropping when they when they ask for\nlower output resolution.\nMaybe adding a libcamera API flag selecting the behavior would help\nhere.\n\nI created a Bugzilla entry for this issue so it won't get lost:\nhttps://bugs.libcamera.org/show_bug.cgi?id=284\n\nFor now, I simply reduce the DebayerCpu::sizes() output to\nsmall range around the input size with the patch that I attached\nin the aforementioned Bugzilla entry.\nThis makes PipeWire camera applications get what they expect.\n\n> Regards,\n> Barnabás Pőcze\n> \n\nThanks,\nMaciej","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0131CBEFBE\n\tfor ;\n\tThu, 28 Aug 2025 21:07:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2A19969301;\n\tThu, 28 Aug 2025 23:07:43 +0200 (CEST)","from vps-ovh.mhejs.net (vps-ovh.mhejs.net [145.239.82.108])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 17D53692E3\n\tfor ;\n\tThu, 28 Aug 2025 23:07:42 +0200 (CEST)","from MUA\n\tby vps-ovh.mhejs.net with esmtpsa (TLS1.3) tls TLS_AES_128_GCM_SHA256\n\t(Exim 4.98.2) (envelope-from )\n\tid 1urjqP-000000020X6-0ZER; Thu, 28 Aug 2025 23:07:41 +0200"],"Message-ID":"","Date":"Thu, 28 Aug 2025 23:07:35 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org, Milan Zamazal ","References":"<20250821134141.83236-1-mzamazal@redhat.com>\n\t<6cd8d54e-59d3-49bc-b5a6-b395e12afce8@maciej.szmigiero.name>\n\t<85bjo387nn.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>\n\t\n\t<7b057218-f898-405f-86c7-136a5e411c9b@ideasonboard.com>","Content-Language":"en-US, pl-PL","From":"\"Maciej S. Szmigiero\" ","Autocrypt":"addr=mail@maciej.szmigiero.name; keydata=\n\txsFNBFpGusUBEADXUMM2t7y9sHhI79+2QUnDdpauIBjZDukPZArwD+sDlx5P+jxaZ13XjUQc\n\t6oJdk+jpvKiyzlbKqlDtw/Y2Ob24tg1g/zvkHn8AVUwX+ZWWewSZ0vcwp7u/LvA+w2nJbIL1\n\tN0/QUUdmxfkWTHhNqgkNX5hEmYqhwUPozFR0zblfD/6+XFR7VM9yT0fZPLqYLNOmGfqAXlxY\n\tm8nWmi+lxkd/PYqQQwOq6GQwxjRFEvSc09m/YPYo9hxh7a6s8hAP88YOf2PD8oBB1r5E7KGb\n\tFv10Qss4CU/3zaiyRTExWwOJnTQdzSbtnM3S8/ZO/sL0FY/b4VLtlZzERAraxHdnPn8GgxYk\n\toPtAqoyf52RkCabL9dsXPWYQjkwG8WEUPScHDy8Uoo6imQujshG23A99iPuXcWc/5ld9mIo/\n\tEe7kN50MOXwS4vCJSv0cMkVhh77CmGUv5++E/rPcbXPLTPeRVy6SHgdDhIj7elmx2Lgo0cyh\n\tuyxyBKSuzPvb61nh5EKAGL7kPqflNw7LJkInzHqKHDNu57rVuCHEx4yxcKNB4pdE2SgyPxs9\n\t9W7Cz0q2Hd7Yu8GOXvMfQfrBiEV4q4PzidUtV6sLqVq0RMK7LEi0RiZpthwxz0IUFwRw2KS/\n\t9Kgs9LmOXYimodrV0pMxpVqcyTepmDSoWzyXNP2NL1+GuQtaTQARAQABzTBNYWNpZWogUy4g\n\tU3ptaWdpZXJvIDxtYWlsQG1hY2llai5zem1pZ2llcm8ubmFtZT7CwZQEEwEIAD4CGwMFCwkI\n\tBwIGFQoJCAsCBBYCAwECHgECF4AWIQRyeg1N257Z9gOb7O+Ef143kM4JdwUCZ7BxhgUJD0w7\n\twQAKCRCEf143kM4JdwHlD/9Ef793d6Q3WkcapGZLg1hrUg+S3d1brtJSKP6B8Ny0tt/6kjc2\n\tM8q4v0pY6rA/tksIbBw6ZVZNCoce0w3/sy358jcDldh/eYotwUCHQzXl2IZwRT2SbmEoJn9J\n\tnAOnjMCpMFRyBC1yiWzOR3XonLFNB+kWfTK3fwzKWCmpcUkI5ANrmNiDFPcsn+TzfeMV/CzT\n\tFMsqVmr+TCWl29QB3U0eFZP8Y01UiowugS0jW/B/zWYbWo2FvoOqGLRUWgQ20NBXHlV5m0qa\n\twI2Isrbos1kXSl2TDovT0Ppt+66RhV36SGA2qzLs0B9LO7/xqF4/xwmudkpabOoH5g3T20aH\n\txlB0WuTJ7FyxZGnO6NL9QTxx3t86FfkKVfTksKP0FRKujsOxGQ1JpqdazyO6k7yMFfcnxwAb\n\tMyLU6ZepXf/6LvcFFe0oXC+ZNqj7kT6+hoTkZJcxynlcxSRzRSpnS41MRHJbyQM7kjpuVdyQ\n\tBWPdBnW0bYamlsW00w5XaR+fvNr4fV0vcqB991lxD4ayBbYPz11tnjlOwqnawH1ctCy5rdBY\n\teTC6olpkmyUhrrIpTgEuxNU4GvnBK9oEEtNPC/x58AOxQuf1FhqbHYjz8D2Pyhso8TwS7NTa\n\tZ8b8o0vfsuqd3GPJKMiEhLEgu/io2KtLG10ynfh0vDBDQ7bwKoVlqC3It87AzQRaRrwiAQwA\n\txnVmJqeP9VUTISps+WbyYFYlMFfIurl7tzK74bc67KUBp+PHuDP9p4ZcJUGC3UZJP85/GlUV\n\tdE1NairYWEJQUB7bpogTuzMI825QXIB9z842HwWfP2RW5eDtJMeujzJeFaUpmeTG9snzaYxY\n\tN3r0TDKj5dZwSIThIMQpsmhH2zylkT0jH7kBPxb8IkCQ1c6wgKITwoHFjTIO0B75U7bBNSDp\n\tXUaUDvd6T3xd1Fz57ujAvKHrZfWtaNSGwLmUYQAcFvrKDGPB5Z3ggkiTtkmW3OCQbnIxGJJw\n\t/+HefYhB5/kCcpKUQ2RYcYgCZ0/WcES1xU5dnNe4i0a5gsOFSOYCpNCfTHttVxKxZZTQ/rxj\n\tXwTuToXmTI4Nehn96t25DHZ0t9L9UEJ0yxH2y8Av4rtf75K2yAXFZa8dHnQgCkyjA/gs0ujG\n\twD+Gs7dYQxP4i+rLhwBWD3mawJxLxY0vGwkG7k7npqanlsWlATHpOdqBMUiAR22hs02FikAo\n\tiXNgWTy7ABEBAAHCwXwEGAEIACYCGwwWIQRyeg1N257Z9gOb7O+Ef143kM4JdwUCZ7BxrgUJ\n\tD0w6ggAKCRCEf143kM4Jd55ED/9M47pnUYDVoaa1Xu4dVHw2h0XhBS/svPqb80YtjcBVgRp0\n\tPxLkI6afwteLsjpDgr4QbjoF868ctjqs6p/M7+VkFJNSa4hPmCayU310zEawO4EYm+jPRUIJ\n\ti87pEmygoN4ZnXvOYA9lkkbbaJkYB+8rDFSYeeSjuez0qmISbzkRVBwhGXQG5s5Oyij2eJ7f\n\tOvtjExsYkLP3NqmsODWj9aXqWGYsHPa7NpcLvHtkhtc5+SjRRLzh/NWJUtgFkqNPfhGMNwE8\n\tIsgCYA1B0Wam1zwvVgn6yRcwaCycr/SxHZAR4zZQNGyV1CA+Ph3cMiL8s49RluhiAiDqbJDx\n\tvoSNR7+hz6CXrAuFnUljMMWiSSeWDF+qSKVmUJIFHWW4s9RQofkF8/Bd6BZxIWQYxMKZm4S7\n\tdKo+5COEVOhSyYthhxNMCWDxLDuPoiGUbWBu/+8dXBusBV5fgcZ2SeQYnIvBzMj8NJ2vDU2D\n\tm/ajx6lQA/hW0zLYAew2v6WnHFnOXUlI3hv9LusUtj3XtLV2mf1FHvfYlrlI9WQsLiOE5nFN\n\tIsqJLm0TmM0i8WDnWovQHM8D0IzI/eUc4Ktbp0fVwWThP1ehdPEUKGCZflck5gvuU8yqE55r\n\tVrUwC3ocRUs4wXdUGZp67sExrfnb8QC2iXhYb+TpB8g7otkqYjL/nL8cQ8hdmg==","In-Reply-To":"<7b057218-f898-405f-86c7-136a5e411c9b@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35615,"web_url":"https://patchwork.libcamera.org/comment/35615/","msgid":"","date":"2025-08-28T21:09:40","subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","submitter":{"id":237,"url":"https://patchwork.libcamera.org/api/people/237/","name":"Maciej S. Szmigiero","email":"mail@maciej.szmigiero.name"},"content":"On 28.08.2025 18:30, Milan Zamazal wrote:\n> \"Maciej S. Szmigiero\" writes:\n> \n>>>> * The AGC algorithm seems to go into unstable oscillation\n>>>> mode when the amount of light in the picture exceeds certain\n>>>> threshold, with exposure bins alternating between 0 and tens\n>>>> of thousands rapidly.\n>>>>\n>>>> This makes the output picture look like it has been shot\n>>>> thorough some very slow mechanical shutter, alternating\n>>>> rapidly between almost normal picture and almost completely\n>>>> black frame.\n>>> I can reproduce the effect, at least with LED lighting. Does it happen\n>>> under daylight too?\n>>\n>> Yes, but only under strong daylight, like summer sun illuminating\n>> the scene.\n>>\n>> It's also very borderline with sunlight since even slightly closing\n>> the camera privacy shutter lowers the light input below the\n>> threshold where this effect happens.\n> \n> Thanks for info. These exposure instabilities should really be fixed,\n> I'll look at what can be possibly done.\n\nThanks - I created a Bugzilla entry for this too so it won't get lost:\nhttps://bugs.libcamera.org/show_bug.cgi?id=283\n\nBy the way, with the full output picture the amount the camera shutter\nneeds to be closed in order to prevent these osculations in sunlight is\npretty significant, so the \"even slightly closing shutter stops it\" above\nwas effectively a side effect of the small crop size.\n\nThanks,\nMaciej","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 924EEBEFBE\n\tfor ;\n\tThu, 28 Aug 2025 21:09:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9FA7469301;\n\tThu, 28 Aug 2025 23:09:47 +0200 (CEST)","from vps-ovh.mhejs.net (vps-ovh.mhejs.net [145.239.82.108])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3FEDC692E3\n\tfor ;\n\tThu, 28 Aug 2025 23:09:46 +0200 (CEST)","from MUA\n\tby vps-ovh.mhejs.net with esmtpsa (TLS1.3) tls TLS_AES_128_GCM_SHA256\n\t(Exim 4.98.2) (envelope-from )\n\tid 1urjsP-000000020XH-2oP5; Thu, 28 Aug 2025 23:09:45 +0200"],"Message-ID":"","Date":"Thu, 28 Aug 2025 23:09:40 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","To":"Milan Zamazal ","Cc":"pobrn@protonmail.com, libcamera-devel@lists.libcamera.org","References":"<20250821134141.83236-1-mzamazal@redhat.com>\n\t<6cd8d54e-59d3-49bc-b5a6-b395e12afce8@maciej.szmigiero.name>\n\t<85bjo387nn.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>\n\t\n\t<85349bflyp.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","Content-Language":"en-US, pl-PL","From":"\"Maciej S. Szmigiero\" ","Autocrypt":"addr=mail@maciej.szmigiero.name; keydata=\n\txsFNBFpGusUBEADXUMM2t7y9sHhI79+2QUnDdpauIBjZDukPZArwD+sDlx5P+jxaZ13XjUQc\n\t6oJdk+jpvKiyzlbKqlDtw/Y2Ob24tg1g/zvkHn8AVUwX+ZWWewSZ0vcwp7u/LvA+w2nJbIL1\n\tN0/QUUdmxfkWTHhNqgkNX5hEmYqhwUPozFR0zblfD/6+XFR7VM9yT0fZPLqYLNOmGfqAXlxY\n\tm8nWmi+lxkd/PYqQQwOq6GQwxjRFEvSc09m/YPYo9hxh7a6s8hAP88YOf2PD8oBB1r5E7KGb\n\tFv10Qss4CU/3zaiyRTExWwOJnTQdzSbtnM3S8/ZO/sL0FY/b4VLtlZzERAraxHdnPn8GgxYk\n\toPtAqoyf52RkCabL9dsXPWYQjkwG8WEUPScHDy8Uoo6imQujshG23A99iPuXcWc/5ld9mIo/\n\tEe7kN50MOXwS4vCJSv0cMkVhh77CmGUv5++E/rPcbXPLTPeRVy6SHgdDhIj7elmx2Lgo0cyh\n\tuyxyBKSuzPvb61nh5EKAGL7kPqflNw7LJkInzHqKHDNu57rVuCHEx4yxcKNB4pdE2SgyPxs9\n\t9W7Cz0q2Hd7Yu8GOXvMfQfrBiEV4q4PzidUtV6sLqVq0RMK7LEi0RiZpthwxz0IUFwRw2KS/\n\t9Kgs9LmOXYimodrV0pMxpVqcyTepmDSoWzyXNP2NL1+GuQtaTQARAQABzTBNYWNpZWogUy4g\n\tU3ptaWdpZXJvIDxtYWlsQG1hY2llai5zem1pZ2llcm8ubmFtZT7CwZQEEwEIAD4CGwMFCwkI\n\tBwIGFQoJCAsCBBYCAwECHgECF4AWIQRyeg1N257Z9gOb7O+Ef143kM4JdwUCZ7BxhgUJD0w7\n\twQAKCRCEf143kM4JdwHlD/9Ef793d6Q3WkcapGZLg1hrUg+S3d1brtJSKP6B8Ny0tt/6kjc2\n\tM8q4v0pY6rA/tksIbBw6ZVZNCoce0w3/sy358jcDldh/eYotwUCHQzXl2IZwRT2SbmEoJn9J\n\tnAOnjMCpMFRyBC1yiWzOR3XonLFNB+kWfTK3fwzKWCmpcUkI5ANrmNiDFPcsn+TzfeMV/CzT\n\tFMsqVmr+TCWl29QB3U0eFZP8Y01UiowugS0jW/B/zWYbWo2FvoOqGLRUWgQ20NBXHlV5m0qa\n\twI2Isrbos1kXSl2TDovT0Ppt+66RhV36SGA2qzLs0B9LO7/xqF4/xwmudkpabOoH5g3T20aH\n\txlB0WuTJ7FyxZGnO6NL9QTxx3t86FfkKVfTksKP0FRKujsOxGQ1JpqdazyO6k7yMFfcnxwAb\n\tMyLU6ZepXf/6LvcFFe0oXC+ZNqj7kT6+hoTkZJcxynlcxSRzRSpnS41MRHJbyQM7kjpuVdyQ\n\tBWPdBnW0bYamlsW00w5XaR+fvNr4fV0vcqB991lxD4ayBbYPz11tnjlOwqnawH1ctCy5rdBY\n\teTC6olpkmyUhrrIpTgEuxNU4GvnBK9oEEtNPC/x58AOxQuf1FhqbHYjz8D2Pyhso8TwS7NTa\n\tZ8b8o0vfsuqd3GPJKMiEhLEgu/io2KtLG10ynfh0vDBDQ7bwKoVlqC3It87AzQRaRrwiAQwA\n\txnVmJqeP9VUTISps+WbyYFYlMFfIurl7tzK74bc67KUBp+PHuDP9p4ZcJUGC3UZJP85/GlUV\n\tdE1NairYWEJQUB7bpogTuzMI825QXIB9z842HwWfP2RW5eDtJMeujzJeFaUpmeTG9snzaYxY\n\tN3r0TDKj5dZwSIThIMQpsmhH2zylkT0jH7kBPxb8IkCQ1c6wgKITwoHFjTIO0B75U7bBNSDp\n\tXUaUDvd6T3xd1Fz57ujAvKHrZfWtaNSGwLmUYQAcFvrKDGPB5Z3ggkiTtkmW3OCQbnIxGJJw\n\t/+HefYhB5/kCcpKUQ2RYcYgCZ0/WcES1xU5dnNe4i0a5gsOFSOYCpNCfTHttVxKxZZTQ/rxj\n\tXwTuToXmTI4Nehn96t25DHZ0t9L9UEJ0yxH2y8Av4rtf75K2yAXFZa8dHnQgCkyjA/gs0ujG\n\twD+Gs7dYQxP4i+rLhwBWD3mawJxLxY0vGwkG7k7npqanlsWlATHpOdqBMUiAR22hs02FikAo\n\tiXNgWTy7ABEBAAHCwXwEGAEIACYCGwwWIQRyeg1N257Z9gOb7O+Ef143kM4JdwUCZ7BxrgUJ\n\tD0w6ggAKCRCEf143kM4Jd55ED/9M47pnUYDVoaa1Xu4dVHw2h0XhBS/svPqb80YtjcBVgRp0\n\tPxLkI6afwteLsjpDgr4QbjoF868ctjqs6p/M7+VkFJNSa4hPmCayU310zEawO4EYm+jPRUIJ\n\ti87pEmygoN4ZnXvOYA9lkkbbaJkYB+8rDFSYeeSjuez0qmISbzkRVBwhGXQG5s5Oyij2eJ7f\n\tOvtjExsYkLP3NqmsODWj9aXqWGYsHPa7NpcLvHtkhtc5+SjRRLzh/NWJUtgFkqNPfhGMNwE8\n\tIsgCYA1B0Wam1zwvVgn6yRcwaCycr/SxHZAR4zZQNGyV1CA+Ph3cMiL8s49RluhiAiDqbJDx\n\tvoSNR7+hz6CXrAuFnUljMMWiSSeWDF+qSKVmUJIFHWW4s9RQofkF8/Bd6BZxIWQYxMKZm4S7\n\tdKo+5COEVOhSyYthhxNMCWDxLDuPoiGUbWBu/+8dXBusBV5fgcZ2SeQYnIvBzMj8NJ2vDU2D\n\tm/ajx6lQA/hW0zLYAew2v6WnHFnOXUlI3hv9LusUtj3XtLV2mf1FHvfYlrlI9WQsLiOE5nFN\n\tIsqJLm0TmM0i8WDnWovQHM8D0IzI/eUc4Ktbp0fVwWThP1ehdPEUKGCZflck5gvuU8yqE55r\n\tVrUwC3ocRUs4wXdUGZp67sExrfnb8QC2iXhYb+TpB8g7otkqYjL/nL8cQ8hdmg==","In-Reply-To":"<85349bflyp.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35626,"web_url":"https://patchwork.libcamera.org/comment/35626/","msgid":"<20250829132118.GE9916@pendragon.ideasonboard.com>","date":"2025-08-29T13:21:18","subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Aug 28, 2025 at 06:30:06PM +0200, Milan Zamazal wrote:\n> \"Maciej S. Szmigiero\" writes:\n> \n> >>> * The AGC algorithm seems to go into unstable oscillation\n> >>> mode when the amount of light in the picture exceeds certain\n> >>> threshold, with exposure bins alternating between 0 and tens\n> >>> of thousands rapidly.\n> >>>\n> >>> This makes the output picture look like it has been shot\n> >>> thorough some very slow mechanical shutter, alternating\n> >>> rapidly between almost normal picture and almost completely\n> >>> black frame.\n> >> I can reproduce the effect, at least with LED lighting. Does it happen\n> >> under daylight too?\n> >\n> > Yes, but only under strong daylight, like summer sun illuminating\n> > the scene.\n> >\n> > It's also very borderline with sunlight since even slightly closing\n> > the camera privacy shutter lowers the light input below the\n> > threshold where this effect happens.\n> \n> Thanks for info. These exposure instabilities should really be fixed,\n> I'll look at what can be possibly done.\n> \n> As for cropping, I don't have a clear opinion what's the best option of\n> changing the resolution, scaling, cropping. As Barnabás pointed out,\n> implementing ScalerCrop would perhaps help substantially.\n\nWe will likely not support scaling with the CPU-based soft ISP, so\nScalerCrop won't help. The GPU implementation would be a different\nstory, it should hopefully be easy to support scaling there.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4965EBD87C\n\tfor ;\n\tFri, 29 Aug 2025 13:21:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0091569321;\n\tFri, 29 Aug 2025 15:21:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 553CE692E7\n\tfor ;\n\tFri, 29 Aug 2025 15:21:41 +0200 (CEST)","from pendragon.ideasonboard.com (85-76-13-20-nat.elisa-mobile.fi\n\t[85.76.13.20])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id B17351934; \n\tFri, 29 Aug 2025 15:20:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Gn1k5/4Q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1756473636;\n\tbh=rI/W2nMH9QBjPoXVb5K8plyf4p94g3x8HYQ5otnCI14=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Gn1k5/4Q/TY3RxrgU4v7CXWWXQPwYlPodWChSwoJypAHgdumqPH+L0Ldy2/wChYJI\n\t8RbA/E1rlgeIgILa2Cdaew71hLwfp3hUuylHCv016fa3Rii0m28fX1KgtcGjm3mJaw\n\tPJiRwAiw2G2lDRb2J9RZdg7x8TBqeThfd6xaQlTw=","Date":"Fri, 29 Aug 2025 15:21:18 +0200","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"\"Maciej S. Szmigiero\" ,\n\tpobrn@protonmail.com, libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","Message-ID":"<20250829132118.GE9916@pendragon.ideasonboard.com>","References":"<20250821134141.83236-1-mzamazal@redhat.com>\n\t<6cd8d54e-59d3-49bc-b5a6-b395e12afce8@maciej.szmigiero.name>\n\t<85bjo387nn.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>\n\t\n\t<85349bflyp.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<85349bflyp.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35760,"web_url":"https://patchwork.libcamera.org/comment/35760/","msgid":"<46d7c0c4-c873-4c96-b7ef-2977c3ac2d28@maciej.szmigiero.name>","date":"2025-09-10T10:57:30","subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","submitter":{"id":237,"url":"https://patchwork.libcamera.org/api/people/237/","name":"Maciej S. Szmigiero","email":"mail@maciej.szmigiero.name"},"content":"On 21.08.2025 23:35, Maciej S. Szmigiero wrote:\n> Hi Milan,\n> \n> On 21.08.2025 15:41, Milan Zamazal wrote:\n>> Fixes of https://bugs.libcamera.org/show_bug.cgi?id=280 and the related\n>> problems discussed there.\n>>\n>> Milan Zamazal (5):\n>>    libcamera: software_isp: Clarify SwStatsCpu::setWindow use\n>>    libcamera: software_isp: Pass correct y-coordinate to stats\n>>    libcamera: software_isp: Check processed window size alignment\n>>    libcamera: simple: Avoid incorrect arithmetic in AWB\n>>    libcamera: simple: Prevent division by zero in BLC\n> \n> Thanks for this patch series.\n> \n> I tested it on an IPU6 (Meteor Lake) laptop with an ov02e10 sensor.\n> \n> The \"division by zero\" crashes with small capture sizes\n> are definitely gone.\n> \n\nIs this patch series going to be merged?\nI don't see it in the libcamera git, even though it definitely\nimproves things.\n\nIn case this helps:\nTested-by: Maciej S. Szmigiero \n\nThanks,\nMaciej","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 14432C324E\n\tfor ;\n\tWed, 10 Sep 2025 10:57:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D85069367;\n\tWed, 10 Sep 2025 12:57:39 +0200 (CEST)","from vps-ovh.mhejs.net (vps-ovh.mhejs.net [145.239.82.108])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0EEBB69357\n\tfor ;\n\tWed, 10 Sep 2025 12:57:37 +0200 (CEST)","from MUA\n\tby vps-ovh.mhejs.net with esmtpsa (TLS1.3) tls TLS_AES_128_GCM_SHA256\n\t(Exim 4.98.2) (envelope-from )\n\tid 1uwIW8-00000002ZVg-0Y64; Wed, 10 Sep 2025 12:57:36 +0200"],"Message-ID":"<46d7c0c4-c873-4c96-b7ef-2977c3ac2d28@maciej.szmigiero.name>","Date":"Wed, 10 Sep 2025 12:57:30 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","From":"\"Maciej S. Szmigiero\" ","To":"Milan Zamazal ","Cc":"pobrn@protonmail.com, libcamera-devel@lists.libcamera.org","References":"<20250821134141.83236-1-mzamazal@redhat.com>\n\t<6cd8d54e-59d3-49bc-b5a6-b395e12afce8@maciej.szmigiero.name>","Content-Language":"en-US, pl-PL","Autocrypt":"addr=mail@maciej.szmigiero.name; keydata=\n\txsFNBFpGusUBEADXUMM2t7y9sHhI79+2QUnDdpauIBjZDukPZArwD+sDlx5P+jxaZ13XjUQc\n\t6oJdk+jpvKiyzlbKqlDtw/Y2Ob24tg1g/zvkHn8AVUwX+ZWWewSZ0vcwp7u/LvA+w2nJbIL1\n\tN0/QUUdmxfkWTHhNqgkNX5hEmYqhwUPozFR0zblfD/6+XFR7VM9yT0fZPLqYLNOmGfqAXlxY\n\tm8nWmi+lxkd/PYqQQwOq6GQwxjRFEvSc09m/YPYo9hxh7a6s8hAP88YOf2PD8oBB1r5E7KGb\n\tFv10Qss4CU/3zaiyRTExWwOJnTQdzSbtnM3S8/ZO/sL0FY/b4VLtlZzERAraxHdnPn8GgxYk\n\toPtAqoyf52RkCabL9dsXPWYQjkwG8WEUPScHDy8Uoo6imQujshG23A99iPuXcWc/5ld9mIo/\n\tEe7kN50MOXwS4vCJSv0cMkVhh77CmGUv5++E/rPcbXPLTPeRVy6SHgdDhIj7elmx2Lgo0cyh\n\tuyxyBKSuzPvb61nh5EKAGL7kPqflNw7LJkInzHqKHDNu57rVuCHEx4yxcKNB4pdE2SgyPxs9\n\t9W7Cz0q2Hd7Yu8GOXvMfQfrBiEV4q4PzidUtV6sLqVq0RMK7LEi0RiZpthwxz0IUFwRw2KS/\n\t9Kgs9LmOXYimodrV0pMxpVqcyTepmDSoWzyXNP2NL1+GuQtaTQARAQABzTBNYWNpZWogUy4g\n\tU3ptaWdpZXJvIDxtYWlsQG1hY2llai5zem1pZ2llcm8ubmFtZT7CwZQEEwEIAD4CGwMFCwkI\n\tBwIGFQoJCAsCBBYCAwECHgECF4AWIQRyeg1N257Z9gOb7O+Ef143kM4JdwUCZ7BxhgUJD0w7\n\twQAKCRCEf143kM4JdwHlD/9Ef793d6Q3WkcapGZLg1hrUg+S3d1brtJSKP6B8Ny0tt/6kjc2\n\tM8q4v0pY6rA/tksIbBw6ZVZNCoce0w3/sy358jcDldh/eYotwUCHQzXl2IZwRT2SbmEoJn9J\n\tnAOnjMCpMFRyBC1yiWzOR3XonLFNB+kWfTK3fwzKWCmpcUkI5ANrmNiDFPcsn+TzfeMV/CzT\n\tFMsqVmr+TCWl29QB3U0eFZP8Y01UiowugS0jW/B/zWYbWo2FvoOqGLRUWgQ20NBXHlV5m0qa\n\twI2Isrbos1kXSl2TDovT0Ppt+66RhV36SGA2qzLs0B9LO7/xqF4/xwmudkpabOoH5g3T20aH\n\txlB0WuTJ7FyxZGnO6NL9QTxx3t86FfkKVfTksKP0FRKujsOxGQ1JpqdazyO6k7yMFfcnxwAb\n\tMyLU6ZepXf/6LvcFFe0oXC+ZNqj7kT6+hoTkZJcxynlcxSRzRSpnS41MRHJbyQM7kjpuVdyQ\n\tBWPdBnW0bYamlsW00w5XaR+fvNr4fV0vcqB991lxD4ayBbYPz11tnjlOwqnawH1ctCy5rdBY\n\teTC6olpkmyUhrrIpTgEuxNU4GvnBK9oEEtNPC/x58AOxQuf1FhqbHYjz8D2Pyhso8TwS7NTa\n\tZ8b8o0vfsuqd3GPJKMiEhLEgu/io2KtLG10ynfh0vDBDQ7bwKoVlqC3It87AzQRaRrwiAQwA\n\txnVmJqeP9VUTISps+WbyYFYlMFfIurl7tzK74bc67KUBp+PHuDP9p4ZcJUGC3UZJP85/GlUV\n\tdE1NairYWEJQUB7bpogTuzMI825QXIB9z842HwWfP2RW5eDtJMeujzJeFaUpmeTG9snzaYxY\n\tN3r0TDKj5dZwSIThIMQpsmhH2zylkT0jH7kBPxb8IkCQ1c6wgKITwoHFjTIO0B75U7bBNSDp\n\tXUaUDvd6T3xd1Fz57ujAvKHrZfWtaNSGwLmUYQAcFvrKDGPB5Z3ggkiTtkmW3OCQbnIxGJJw\n\t/+HefYhB5/kCcpKUQ2RYcYgCZ0/WcES1xU5dnNe4i0a5gsOFSOYCpNCfTHttVxKxZZTQ/rxj\n\tXwTuToXmTI4Nehn96t25DHZ0t9L9UEJ0yxH2y8Av4rtf75K2yAXFZa8dHnQgCkyjA/gs0ujG\n\twD+Gs7dYQxP4i+rLhwBWD3mawJxLxY0vGwkG7k7npqanlsWlATHpOdqBMUiAR22hs02FikAo\n\tiXNgWTy7ABEBAAHCwXwEGAEIACYCGwwWIQRyeg1N257Z9gOb7O+Ef143kM4JdwUCZ7BxrgUJ\n\tD0w6ggAKCRCEf143kM4Jd55ED/9M47pnUYDVoaa1Xu4dVHw2h0XhBS/svPqb80YtjcBVgRp0\n\tPxLkI6afwteLsjpDgr4QbjoF868ctjqs6p/M7+VkFJNSa4hPmCayU310zEawO4EYm+jPRUIJ\n\ti87pEmygoN4ZnXvOYA9lkkbbaJkYB+8rDFSYeeSjuez0qmISbzkRVBwhGXQG5s5Oyij2eJ7f\n\tOvtjExsYkLP3NqmsODWj9aXqWGYsHPa7NpcLvHtkhtc5+SjRRLzh/NWJUtgFkqNPfhGMNwE8\n\tIsgCYA1B0Wam1zwvVgn6yRcwaCycr/SxHZAR4zZQNGyV1CA+Ph3cMiL8s49RluhiAiDqbJDx\n\tvoSNR7+hz6CXrAuFnUljMMWiSSeWDF+qSKVmUJIFHWW4s9RQofkF8/Bd6BZxIWQYxMKZm4S7\n\tdKo+5COEVOhSyYthhxNMCWDxLDuPoiGUbWBu/+8dXBusBV5fgcZ2SeQYnIvBzMj8NJ2vDU2D\n\tm/ajx6lQA/hW0zLYAew2v6WnHFnOXUlI3hv9LusUtj3XtLV2mf1FHvfYlrlI9WQsLiOE5nFN\n\tIsqJLm0TmM0i8WDnWovQHM8D0IzI/eUc4Ktbp0fVwWThP1ehdPEUKGCZflck5gvuU8yqE55r\n\tVrUwC3ocRUs4wXdUGZp67sExrfnb8QC2iXhYb+TpB8g7otkqYjL/nL8cQ8hdmg==","In-Reply-To":"<6cd8d54e-59d3-49bc-b5a6-b395e12afce8@maciej.szmigiero.name>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35761,"web_url":"https://patchwork.libcamera.org/comment/35761/","msgid":"<175750285990.935713.8693226855238437900@ping.linuxembedded.co.uk>","date":"2025-09-10T11:14:19","subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Maciej S. Szmigiero (2025-09-10 11:57:30)\n> On 21.08.2025 23:35, Maciej S. Szmigiero wrote:\n> > Hi Milan,\n> > \n> > On 21.08.2025 15:41, Milan Zamazal wrote:\n> >> Fixes of https://bugs.libcamera.org/show_bug.cgi?id=280 and the related\n> >> problems discussed there.\n> >>\n> >> Milan Zamazal (5):\n> >>    libcamera: software_isp: Clarify SwStatsCpu::setWindow use\n> >>    libcamera: software_isp: Pass correct y-coordinate to stats\n> >>    libcamera: software_isp: Check processed window size alignment\n> >>    libcamera: simple: Avoid incorrect arithmetic in AWB\n> >>    libcamera: simple: Prevent division by zero in BLC\n> > \n> > Thanks for this patch series.\n> > \n> > I tested it on an IPU6 (Meteor Lake) laptop with an ov02e10 sensor.\n> > \n> > The \"division by zero\" crashes with small capture sizes\n> > are definitely gone.\n> > \n> \n> Is this patch series going to be merged?\n> I don't see it in the libcamera git, even though it definitely\n> improves things.\n> \n> In case this helps:\n> Tested-by: Maciej S. Szmigiero \n\nThank you - that indeed helps know that it improves the issue.\n\nThe actual blockage at the moment is \"Reviewed-by:\" tags. CI won't merge\nanything without at least one RB tag (or an Acked-by: from a\n'maintainer').\n\nI think I see in this series that you may have authored one of the\npatches. That sounds like you're a great candidate to do a review of the\nothers?\n\nCould you read through them and make sure they're ok please?\n\nIf you notice anything, please comment inline - and if you think it's ok\n- just add \"Reviewed-by: <....>\" in the mail.\n\n--\nThanks\n\nKieran\n\n\n> \n> Thanks,\n> Maciej\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2B959BDB13\n\tfor ;\n\tWed, 10 Sep 2025 11:14:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EA1AF6936E;\n\tWed, 10 Sep 2025 13:14:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EEF1769357\n\tfor ;\n\tWed, 10 Sep 2025 13:14:23 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 58818DAB;\n\tWed, 10 Sep 2025 13:13:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wjfcnDqW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1757502789;\n\tbh=PN+MGl8qtXQvi+Q5n5NXCHwJTKm5wXZU4r2NCqAANL8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=wjfcnDqWLI8FYq0PHRxWPeqBa1NoFZNfX2WEFFbqC+3f1RXJfK41JPXlcKAxKcmEC\n\t+vbkYo+yx+j9B/yAAbfcU9bD9fGzlhhxDMPONxP1PkDy+y6oEw3muKFIYJu+iYdiqR\n\t4tMBSWd8Jjy4qezx93ziNTlcUzsiYG2Lo31leGMc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<46d7c0c4-c873-4c96-b7ef-2977c3ac2d28@maciej.szmigiero.name>","References":"<20250821134141.83236-1-mzamazal@redhat.com>\n\t<6cd8d54e-59d3-49bc-b5a6-b395e12afce8@maciej.szmigiero.name>\n\t<46d7c0c4-c873-4c96-b7ef-2977c3ac2d28@maciej.szmigiero.name>","Subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","From":"Kieran Bingham ","Cc":"pobrn@protonmail.com, libcamera-devel@lists.libcamera.org","To":"Maciej S. Szmigiero ,\n\tMilan Zamazal ","Date":"Wed, 10 Sep 2025 12:14:19 +0100","Message-ID":"<175750285990.935713.8693226855238437900@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35763,"web_url":"https://patchwork.libcamera.org/comment/35763/","msgid":"","date":"2025-09-10T12:04:45","subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n2025. 08. 21. 15:41 keltezéssel, Milan Zamazal írta:\n> Fixes of https://bugs.libcamera.org/show_bug.cgi?id=280 and the related\n> problems discussed there.\n\nNot sure if a fix was planned here, so I just wanted to note that \"Agc\"\nalso doesn't handle an empty histogram:\n\ncam0: Capture 32 frames\n../src/ipa/simple/algorithms/agc.cpp:128:30: runtime error: division by zero\n\nThread 3 \"cam\" received signal SIGFPE, Arithmetic exception.\n[Switching to Thread 0x7bffe99ff6c0 (LWP 2447)]\n0x00007bffe9d7f5e8 in libcamera::ipa::soft::algorithms::Agc::process (this=0x7c1fedc16fb0, context=..., frame=0, frameContext=..., stats=0x7fffefe20000, metadata=...) at ../src/ipa/simple/algorithms/agc.cpp:128\n128\t\t\tunsigned int idx = (i - (i / yHistValsPerBinMod)) / yHistValsPerBin;\n(gdb) p yHistValsPerBin\n$1 = 0\n\n\nRegards,\nBarnabás Pőcze\n\n\n> \n> Milan Zamazal (5):\n> libcamera: software_isp: Clarify SwStatsCpu::setWindow use\n> libcamera: software_isp: Pass correct y-coordinate to stats\n> libcamera: software_isp: Check processed window size alignment\n> libcamera: simple: Avoid incorrect arithmetic in AWB\n> libcamera: simple: Prevent division by zero in BLC\n> \n> src/ipa/simple/algorithms/awb.cpp | 8 ++++---\n> src/ipa/simple/algorithms/blc.cpp | 5 +++++\n> src/libcamera/software_isp/debayer_cpu.cpp | 26 +++++++++++++++++-----\n> src/libcamera/software_isp/swstats_cpu.cpp | 16 +++++++++++++\n> 4 files changed, 46 insertions(+), 9 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A7731BDB13\n\tfor ;\n\tWed, 10 Sep 2025 12:04:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 15BF469367;\n\tWed, 10 Sep 2025 14:04:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9023A69357\n\tfor ;\n\tWed, 10 Sep 2025 14:04:50 +0200 (CEST)","from [192.168.33.8] (185.221.142.115.nat.pool.zt.hu\n\t[185.221.142.115])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 90F6BDAB;\n\tWed, 10 Sep 2025 14:03:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pr/eK9wO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1757505816;\n\tbh=7+qsO+Q9IzM4VH45H3Xm7CAfI1noMP/pfFkrFwZW3IA=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=pr/eK9wOtR5MkYCLM5uj9OE54pJSpuv4T070XEgzlVB1svon4AexGeRIA2laRBTWM\n\tZazk5ah6LhiXmJNXx2IZO42++esFxK+csMNvKRLRuIV49fNKmZcSiJ5qBOxc5t6b2K\n\t5ohlODBmAButxvx76ZGUyS3r7Pk49GeuI9l5jZRU=","Message-ID":"","Date":"Wed, 10 Sep 2025 14:04:45 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Cc":"mail@maciej.szmigiero.name","References":"<20250821134141.83236-1-mzamazal@redhat.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20250821134141.83236-1-mzamazal@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35773,"web_url":"https://patchwork.libcamera.org/comment/35773/","msgid":"<471b1501-49f0-46ec-90fb-10f92b24d689@maciej.szmigiero.name>","date":"2025-09-10T21:15:41","subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","submitter":{"id":237,"url":"https://patchwork.libcamera.org/api/people/237/","name":"Maciej S. Szmigiero","email":"mail@maciej.szmigiero.name"},"content":"On 10.09.2025 13:14, Kieran Bingham wrote:\n> Quoting Maciej S. Szmigiero (2025-09-10 11:57:30)\n>> On 21.08.2025 23:35, Maciej S. Szmigiero wrote:\n>>> Hi Milan,\n>>>\n>>> On 21.08.2025 15:41, Milan Zamazal wrote:\n>>>> Fixes of https://bugs.libcamera.org/show_bug.cgi?id=280 and the related\n>>>> problems discussed there.\n>>>>\n>>>> Milan Zamazal (5):\n>>>>    libcamera: software_isp: Clarify SwStatsCpu::setWindow use\n>>>>    libcamera: software_isp: Pass correct y-coordinate to stats\n>>>>    libcamera: software_isp: Check processed window size alignment\n>>>>    libcamera: simple: Avoid incorrect arithmetic in AWB\n>>>>    libcamera: simple: Prevent division by zero in BLC\n>>>\n>>> Thanks for this patch series.\n>>>\n>>> I tested it on an IPU6 (Meteor Lake) laptop with an ov02e10 sensor.\n>>>\n>>> The \"division by zero\" crashes with small capture sizes\n>>> are definitely gone.\n>>>\n>>\n>> Is this patch series going to be merged?\n>> I don't see it in the libcamera git, even though it definitely\n>> improves things.\n>>\n>> In case this helps:\n>> Tested-by: Maciej S. Szmigiero \n> \n> Thank you - that indeed helps know that it improves the issue.\n> \n> The actual blockage at the moment is \"Reviewed-by:\" tags. CI won't merge\n> anything without at least one RB tag (or an Acked-by: from a\n> 'maintainer').\n> \n> I think I see in this series that you may have authored one of the\n> patches. That sounds like you're a great candidate to do a review of the\n> others?\n> \n> Could you read through them and make sure they're ok please?\n>\n> If you notice anything, please comment inline - and if you think it's ok\n> - just add \"Reviewed-by: <....>\" in the mail.\n\nI am actually a newcomer to libcamera, however I will try to do my\nbest to review this series in the coming days or so. \n> --\n> Thanks\n> \n> Kieran\nThanks,\nMaciej","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 71D64C324E\n\tfor ;\n\tWed, 10 Sep 2025 21:15:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 44C166936E;\n\tWed, 10 Sep 2025 23:15:49 +0200 (CEST)","from vps-ovh.mhejs.net (vps-ovh.mhejs.net [145.239.82.108])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C20E269357\n\tfor ;\n\tWed, 10 Sep 2025 23:15:47 +0200 (CEST)","from MUA\n\tby vps-ovh.mhejs.net with esmtpsa (TLS1.3) tls TLS_AES_128_GCM_SHA256\n\t(Exim 4.98.2) (envelope-from )\n\tid 1uwSAM-00000002bHz-2kzK; Wed, 10 Sep 2025 23:15:46 +0200"],"Message-ID":"<471b1501-49f0-46ec-90fb-10f92b24d689@maciej.szmigiero.name>","Date":"Wed, 10 Sep 2025 23:15:41 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","To":"Kieran Bingham ,\n\tMilan Zamazal ","Cc":"pobrn@protonmail.com, libcamera-devel@lists.libcamera.org","References":"<20250821134141.83236-1-mzamazal@redhat.com>\n\t<6cd8d54e-59d3-49bc-b5a6-b395e12afce8@maciej.szmigiero.name>\n\t<46d7c0c4-c873-4c96-b7ef-2977c3ac2d28@maciej.szmigiero.name>\n\t<175750285990.935713.8693226855238437900@ping.linuxembedded.co.uk>","Content-Language":"en-US, pl-PL","From":"\"Maciej S. Szmigiero\" ","Autocrypt":"addr=mail@maciej.szmigiero.name; keydata=\n\txsFNBFpGusUBEADXUMM2t7y9sHhI79+2QUnDdpauIBjZDukPZArwD+sDlx5P+jxaZ13XjUQc\n\t6oJdk+jpvKiyzlbKqlDtw/Y2Ob24tg1g/zvkHn8AVUwX+ZWWewSZ0vcwp7u/LvA+w2nJbIL1\n\tN0/QUUdmxfkWTHhNqgkNX5hEmYqhwUPozFR0zblfD/6+XFR7VM9yT0fZPLqYLNOmGfqAXlxY\n\tm8nWmi+lxkd/PYqQQwOq6GQwxjRFEvSc09m/YPYo9hxh7a6s8hAP88YOf2PD8oBB1r5E7KGb\n\tFv10Qss4CU/3zaiyRTExWwOJnTQdzSbtnM3S8/ZO/sL0FY/b4VLtlZzERAraxHdnPn8GgxYk\n\toPtAqoyf52RkCabL9dsXPWYQjkwG8WEUPScHDy8Uoo6imQujshG23A99iPuXcWc/5ld9mIo/\n\tEe7kN50MOXwS4vCJSv0cMkVhh77CmGUv5++E/rPcbXPLTPeRVy6SHgdDhIj7elmx2Lgo0cyh\n\tuyxyBKSuzPvb61nh5EKAGL7kPqflNw7LJkInzHqKHDNu57rVuCHEx4yxcKNB4pdE2SgyPxs9\n\t9W7Cz0q2Hd7Yu8GOXvMfQfrBiEV4q4PzidUtV6sLqVq0RMK7LEi0RiZpthwxz0IUFwRw2KS/\n\t9Kgs9LmOXYimodrV0pMxpVqcyTepmDSoWzyXNP2NL1+GuQtaTQARAQABzTBNYWNpZWogUy4g\n\tU3ptaWdpZXJvIDxtYWlsQG1hY2llai5zem1pZ2llcm8ubmFtZT7CwZQEEwEIAD4CGwMFCwkI\n\tBwIGFQoJCAsCBBYCAwECHgECF4AWIQRyeg1N257Z9gOb7O+Ef143kM4JdwUCZ7BxhgUJD0w7\n\twQAKCRCEf143kM4JdwHlD/9Ef793d6Q3WkcapGZLg1hrUg+S3d1brtJSKP6B8Ny0tt/6kjc2\n\tM8q4v0pY6rA/tksIbBw6ZVZNCoce0w3/sy358jcDldh/eYotwUCHQzXl2IZwRT2SbmEoJn9J\n\tnAOnjMCpMFRyBC1yiWzOR3XonLFNB+kWfTK3fwzKWCmpcUkI5ANrmNiDFPcsn+TzfeMV/CzT\n\tFMsqVmr+TCWl29QB3U0eFZP8Y01UiowugS0jW/B/zWYbWo2FvoOqGLRUWgQ20NBXHlV5m0qa\n\twI2Isrbos1kXSl2TDovT0Ppt+66RhV36SGA2qzLs0B9LO7/xqF4/xwmudkpabOoH5g3T20aH\n\txlB0WuTJ7FyxZGnO6NL9QTxx3t86FfkKVfTksKP0FRKujsOxGQ1JpqdazyO6k7yMFfcnxwAb\n\tMyLU6ZepXf/6LvcFFe0oXC+ZNqj7kT6+hoTkZJcxynlcxSRzRSpnS41MRHJbyQM7kjpuVdyQ\n\tBWPdBnW0bYamlsW00w5XaR+fvNr4fV0vcqB991lxD4ayBbYPz11tnjlOwqnawH1ctCy5rdBY\n\teTC6olpkmyUhrrIpTgEuxNU4GvnBK9oEEtNPC/x58AOxQuf1FhqbHYjz8D2Pyhso8TwS7NTa\n\tZ8b8o0vfsuqd3GPJKMiEhLEgu/io2KtLG10ynfh0vDBDQ7bwKoVlqC3It87AzQRaRrwiAQwA\n\txnVmJqeP9VUTISps+WbyYFYlMFfIurl7tzK74bc67KUBp+PHuDP9p4ZcJUGC3UZJP85/GlUV\n\tdE1NairYWEJQUB7bpogTuzMI825QXIB9z842HwWfP2RW5eDtJMeujzJeFaUpmeTG9snzaYxY\n\tN3r0TDKj5dZwSIThIMQpsmhH2zylkT0jH7kBPxb8IkCQ1c6wgKITwoHFjTIO0B75U7bBNSDp\n\tXUaUDvd6T3xd1Fz57ujAvKHrZfWtaNSGwLmUYQAcFvrKDGPB5Z3ggkiTtkmW3OCQbnIxGJJw\n\t/+HefYhB5/kCcpKUQ2RYcYgCZ0/WcES1xU5dnNe4i0a5gsOFSOYCpNCfTHttVxKxZZTQ/rxj\n\tXwTuToXmTI4Nehn96t25DHZ0t9L9UEJ0yxH2y8Av4rtf75K2yAXFZa8dHnQgCkyjA/gs0ujG\n\twD+Gs7dYQxP4i+rLhwBWD3mawJxLxY0vGwkG7k7npqanlsWlATHpOdqBMUiAR22hs02FikAo\n\tiXNgWTy7ABEBAAHCwXwEGAEIACYCGwwWIQRyeg1N257Z9gOb7O+Ef143kM4JdwUCZ7BxrgUJ\n\tD0w6ggAKCRCEf143kM4Jd55ED/9M47pnUYDVoaa1Xu4dVHw2h0XhBS/svPqb80YtjcBVgRp0\n\tPxLkI6afwteLsjpDgr4QbjoF868ctjqs6p/M7+VkFJNSa4hPmCayU310zEawO4EYm+jPRUIJ\n\ti87pEmygoN4ZnXvOYA9lkkbbaJkYB+8rDFSYeeSjuez0qmISbzkRVBwhGXQG5s5Oyij2eJ7f\n\tOvtjExsYkLP3NqmsODWj9aXqWGYsHPa7NpcLvHtkhtc5+SjRRLzh/NWJUtgFkqNPfhGMNwE8\n\tIsgCYA1B0Wam1zwvVgn6yRcwaCycr/SxHZAR4zZQNGyV1CA+Ph3cMiL8s49RluhiAiDqbJDx\n\tvoSNR7+hz6CXrAuFnUljMMWiSSeWDF+qSKVmUJIFHWW4s9RQofkF8/Bd6BZxIWQYxMKZm4S7\n\tdKo+5COEVOhSyYthhxNMCWDxLDuPoiGUbWBu/+8dXBusBV5fgcZ2SeQYnIvBzMj8NJ2vDU2D\n\tm/ajx6lQA/hW0zLYAew2v6WnHFnOXUlI3hv9LusUtj3XtLV2mf1FHvfYlrlI9WQsLiOE5nFN\n\tIsqJLm0TmM0i8WDnWovQHM8D0IzI/eUc4Ktbp0fVwWThP1ehdPEUKGCZflck5gvuU8yqE55r\n\tVrUwC3ocRUs4wXdUGZp67sExrfnb8QC2iXhYb+TpB8g7otkqYjL/nL8cQ8hdmg==","In-Reply-To":"<175750285990.935713.8693226855238437900@ping.linuxembedded.co.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35780,"web_url":"https://patchwork.libcamera.org/comment/35780/","msgid":"<85bjnhkvb0.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-09-11T12:50:11","subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Barnabás,\n\nBarnabás Pőcze writes:\n\n> Hi\n>\n> 2025. 08. 21. 15:41 keltezéssel, Milan Zamazal írta:\n>> Fixes of https://bugs.libcamera.org/show_bug.cgi?id=280 and the related\n>> problems discussed there.\n>\n> Not sure if a fix was planned here, so I just wanted to note that \"Agc\"\n> also doesn't handle an empty histogram:\n>\n> cam0: Capture 32 frames\n> ../src/ipa/simple/algorithms/agc.cpp:128:30: runtime error: division by zero\n>\n> Thread 3 \"cam\" received signal SIGFPE, Arithmetic exception.\n> [Switching to Thread 0x7bffe99ff6c0 (LWP 2447)]\n> 0x00007bffe9d7f5e8 in libcamera::ipa::soft::algorithms::Agc::process (this=0x7c1fedc16fb0, context=..., frame=0,\n> frameContext=..., stats=0x7fffefe20000, metadata=...) at ../src/ipa/simple/algorithms/agc.cpp:128\n> 128\t\t\tunsigned int idx = (i - (i / yHistValsPerBinMod)) / yHistValsPerBin;\n> (gdb) p yHistValsPerBin\n> $1 = 0\n\nI missed this one, thanks for pointing it out, I'll add a fix for this.\n\n> Regards,\n> Barnabás Pőcze\n>\n>\n>> Milan Zamazal (5):\n>> libcamera: software_isp: Clarify SwStatsCpu::setWindow use\n>> libcamera: software_isp: Pass correct y-coordinate to stats\n>> libcamera: software_isp: Check processed window size alignment\n>> libcamera: simple: Avoid incorrect arithmetic in AWB\n>> libcamera: simple: Prevent division by zero in BLC\n>> src/ipa/simple/algorithms/awb.cpp | 8 ++++---\n>> src/ipa/simple/algorithms/blc.cpp | 5 +++++\n>> src/libcamera/software_isp/debayer_cpu.cpp | 26 +++++++++++++++++-----\n>> src/libcamera/software_isp/swstats_cpu.cpp | 16 +++++++++++++\n>> 4 files changed, 46 insertions(+), 9 deletions(-)\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC099BDB13\n\tfor ;\n\tThu, 11 Sep 2025 12:50:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E03076936E;\n\tThu, 11 Sep 2025 14:50:17 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 85B886936A\n\tfor ;\n\tThu, 11 Sep 2025 14:50:16 +0200 (CEST)","from mail-wr1-f72.google.com (mail-wr1-f72.google.com\n\t[209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-625-yBQrbhBPMSagzxRkqK6sfg-1; Thu, 11 Sep 2025 08:50:14 -0400","by mail-wr1-f72.google.com with SMTP id\n\tffacd0b85a97d-3e38ae5394aso554595f8f.3\n\tfor ;\n\tThu, 11 Sep 2025 05:50:13 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-45e03718c64sm22598295e9.3.2025.09.11.05.50.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 11 Sep 2025 05:50:11 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"i6lst/kY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1757595015;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=5ehp8KikSLb4AtpWtSrxXRK8PqaQUW4X9zQf5FcD9v8=;\n\tb=i6lst/kY+YsKzlE9fb9ZVzvjDytuXcnorkx6EgPlzqOEnKBeu0gHL/TEW8KBo00y7LVs+Y\n\t7mZkP47Fkfb16yKW4zwrHjrBsHBK4mYtbdCZ+vmlObJFoPwJQ9Xyz1cV5C2McyF3B86+IJ\n\t6ZzQZef40lRE6O3nzM6zc1KXnrJh0U0=","X-MC-Unique":"yBQrbhBPMSagzxRkqK6sfg-1","X-Mimecast-MFC-AGG-ID":"yBQrbhBPMSagzxRkqK6sfg_1757595013","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1757595013; x=1758199813;\n\th=content-transfer-encoding:mime-version:user-agent:message-id:date\n\t:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=PV20U+CNdLHQUpzL7lba4vGvqwlncieem1IQOZQ29N8=;\n\tb=LbduuOwa6HikzPxBwcjHwiN05fOWE0gLvr56w9wjnrEJKalKo7OQFHuruaBQmiP0sT\n\tZlia2WOTk+a/AzLD2dxFr9lEKIp3ZCuQCooyQrPE92CrQgmueUuCSJDwNE/touW6dCYa\n\tip5rGAdEJUfXLI8kn4P9nESmtjdIMebqnLzBdrdOZ2ZDsFRcq6DUitEXc9ycY7V432VS\n\thmVswJbglONS0dsahz17zbnyssUhbMexf6r6gfgkRiZjpajW4ft4xvTr5Me+1zMzdvJD\n\tDE/77Wakm/W6CvPrL+sWMzQqKikaYPdxchPpsInazdBc23jfFzobYqtvMQWIlRWEAeLz\n\t7uXg==","X-Gm-Message-State":"AOJu0Yxd3ni+1FjrnBo5vWQV6oIqaXF4i52MwHoD27joLzd1QkqfXiOy\n\tuHBh+Zvjt9uhSyxnP1yq/jLMyrLY1vPnoQgQvskd5lfnYbcj3rGyiubZi+jzy5mpJCNmzeXi1aJ\n\tSjzFLbw4XPHiTcxP4sIeZ6uhABEe1QT9ZUGO2R1vPbR/cL849vSL6Fw7SBx3EPR2asS/EjdbYdy\n\tI=","X-Gm-Gg":"ASbGncvZ+YHblnjdNbUo2A0CVOtqyMQ/ssRQgd6BiGGRkpzShnXULaW342ALWhtGgBb\n\tdO1i3oSnMlZ6nDo2ZJ4DhUmN57Alhmtbgk057xv45lmcowvb2iyuuF4lmurUvL8EsOv5ltnQwM2\n\tC2V2u337on3xE2cGqiq2lF4zXlae58jupxan+27VcVWt4Yfa3aNGqomKhEr6zn1XkNt1d+TGoLx\n\tAZFaRbuw3yJC2o4x5Kd+bwMvSjJHNzAzC10STDJLadldZPrCTcrkZF4uu8o0P6cHvH+fmT5qdWe\n\tPKWUOXIdKmCWmbwiXFT8KGBnwXQ7ZDyazYRLOqaomAgr/7ovh/P4c2JGMmx35HNBBnvlJty//DT\n\tEhZrdjg7Bq1C4yZRf6w==","X-Received":["by 2002:a5d:5848:0:b0:3e7:63dc:2003 with SMTP id\n\tffacd0b85a97d-3e763dc22bdmr390010f8f.62.1757595012850; \n\tThu, 11 Sep 2025 05:50:12 -0700 (PDT)","by 2002:a5d:5848:0:b0:3e7:63dc:2003 with SMTP id\n\tffacd0b85a97d-3e763dc22bdmr389983f8f.62.1757595012400; \n\tThu, 11 Sep 2025 05:50:12 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IEecJJbOmqiOlD1zPP+FuX+TE0iiq1YFg6dA0eRZkRAWFFqqZIa5ceHkJCcuAUPQr4OQ+JWIg==","From":"Milan Zamazal ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org, mail@maciej.szmigiero.name","Subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","In-Reply-To":" (\n\t=?utf-8?b?IkJhcm5hYsOhcyBQxZFjemUiJ3M=?= message of \"Wed,\n\t10 Sep 2025 14:04:45 +0200\")","References":"<20250821134141.83236-1-mzamazal@redhat.com>\n\t","Date":"Thu, 11 Sep 2025 14:50:11 +0200","Message-ID":"<85bjnhkvb0.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"9Ma2VS0hdL0cyRzX_E7E_hwapgzhY0ZtRtWLP5uQ6nY_1757595013","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35782,"web_url":"https://patchwork.libcamera.org/comment/35782/","msgid":"<857by5kuv0.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-09-11T12:59:47","subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"\"Maciej S. Szmigiero\" writes:\n\n> On 28.08.2025 18:30, Milan Zamazal wrote:\n>> \"Maciej S. Szmigiero\" writes:\n>> \n>\n>>>>> * The AGC algorithm seems to go into unstable oscillation\n>>>>> mode when the amount of light in the picture exceeds certain\n>>>>> threshold, with exposure bins alternating between 0 and tens\n>>>>> of thousands rapidly.\n>>>>>\n>>>>> This makes the output picture look like it has been shot\n>>>>> thorough some very slow mechanical shutter, alternating\n>>>>> rapidly between almost normal picture and almost completely\n>>>>> black frame.\n>>>> I can reproduce the effect, at least with LED lighting. Does it happen\n>>>> under daylight too?\n>>>\n>>> Yes, but only under strong daylight, like summer sun illuminating\n>>> the scene.\n>>>\n>>> It's also very borderline with sunlight since even slightly closing\n>>> the camera privacy shutter lowers the light input below the\n>>> threshold where this effect happens.\n>> Thanks for info. These exposure instabilities should really be fixed,\n>> I'll look at what can be possibly done.\n>\n> Thanks - I created a Bugzilla entry for this too so it won't get lost:\n> https://bugs.libcamera.org/show_bug.cgi?id=283\n\nFor the track, Hans plans to post a fix. IIRC the idea was to adjust\nthe exposure less frequently, to ensure the actual exposure/gain values\nfor the given frame are the expected ones.\n\n> By the way, with the full output picture the amount the camera shutter\n> needs to be closed in order to prevent these osculations in sunlight is\n> pretty significant, so the \"even slightly closing shutter stops it\" above\n> was effectively a side effect of the small crop size.\n>\n> Thanks,\n> Maciej","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8505C324E\n\tfor ;\n\tThu, 11 Sep 2025 13:00:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C39696936A;\n\tThu, 11 Sep 2025 15:00:02 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B59769339\n\tfor ;\n\tThu, 11 Sep 2025 15:00:00 +0200 (CEST)","from mail-wr1-f71.google.com (mail-wr1-f71.google.com\n\t[209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-664-BaWbmdE8MhaIe-OxpVVQ7Q-1; Thu, 11 Sep 2025 08:59:56 -0400","by mail-wr1-f71.google.com with SMTP id\n\tffacd0b85a97d-3e76416ddd5so280338f8f.2\n\tfor ;\n\tThu, 11 Sep 2025 05:59:55 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-45e037d62besm22182355e9.21.2025.09.11.05.59.53\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 11 Sep 2025 05:59:53 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"idXfRE0N\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1757595599;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=Sontzt93n+dUur8Xe1BdrjztXSlAaVc5OrnCqC3IobE=;\n\tb=idXfRE0N5fRp2vHaVsLfNV1cD3gik07czY3NxnkkSLzafbJA0jFUNVgUDzsxEss4FcOoOa\n\tQXvVtRLdIzloPJ4qWh2t5d4pCUF4Yaw7cBYkrqwsL+fOjHOgRkjOHabZPbwWLS49v025+Y\n\teG+W2wd04VidL1wkYWplRYgISPt2c68=","X-MC-Unique":"BaWbmdE8MhaIe-OxpVVQ7Q-1","X-Mimecast-MFC-AGG-ID":"BaWbmdE8MhaIe-OxpVVQ7Q_1757595595","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1757595595; x=1758200395;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=Sontzt93n+dUur8Xe1BdrjztXSlAaVc5OrnCqC3IobE=;\n\tb=j6308rWTSD8Z1aOG5k3FS6jjwtSp8Q5sciC+8ZeMNMXxR+LZEYYz0ACfEi/7WJbaTL\n\tgwlCb+7WOu8lbqLiumV32BdR8gthMa1AyL/paqalumbpC4RE/WEAtYVCP2Pj9bFOkSmQ\n\t6/g2hJBEsujXzBHZv7JcaszlJAsrNOZRhMGulK/AvrMwwDvh/6GO9U829QlO3vtyTcLH\n\taQsdZNxo6/T4kG7uGcYV6jmtstvjeXqXnR/4jDIWGKomlrbm3m9ctDt449307nYqnskL\n\ts+PmVH6oRW7GW1UKWTLjrpEWDxCZWbr+Ngs1ltYGsdhKPflgVVjHfFQIGgbaxRnIIraj\n\t8BXA==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCXLtQaEgwwhC7Gr77OW76qw6YsOrTA2diG4lBmEB7OdOAAbN0C2pkjfn4BAr3edjGkSUyHhYwhv6pacytHyXhg=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YwVHcE0FESmrkQ341no6bM9Dvwx9/FU+xLlHqu6Gr3B5gWpObZ+\n\tOk64NR6odd/SBYmIrOjzuXHZmAT1FDSdl3onvrQE4hVZumUVAMDmAJjUQEH98dEHSquNreOYnct\n\tAVEk3gZioU9G578GNzmEN0tmdyYhoft2QowdSMUuZ2rp0mX1vgTSq1oTHN3rw6j1H8NVw5uzu4B\n\tY=","X-Gm-Gg":"ASbGncs/UHGbA6dEHNnfE+1vTnJ9lctBEHlkUCVHMY67jT1nTTSwpiTNuGDhZ7v5+C2\n\tKb1wvp01Jh7IFt2rKqk9y6HBAodiXcqJz7MzP3P3j7R6U2/1lDA8ttewax0FpYmXxMk05gFmEXV\n\tla5sCYuax93Nuo5SfjRS/k/mCw1P4kSyW4UVhw6zaj20Nyr7j4rKduQBFYf46Eun3nl+D1Bpeir\n\tUv6KNW15pDuyk1b52rtkBpD+PDg3Y9t4PReDmpcWsAFwHPlMYH4rKacQBiNC5bOKha3/QJm/AoC\n\tLDu62ae47GHbg6TWUDRsMkFj7HZbIwnS1Xv/dsfRAHCmPmYcMbwFnpgT+hXuQaMuDzG7KrJkJVi\n\t9N+FBYj09n57WkcgAWg==","X-Received":["by 2002:a05:6000:2012:b0:3e7:63c5:9aae with SMTP id\n\tffacd0b85a97d-3e763c59ffamr614126f8f.15.1757595594690; \n\tThu, 11 Sep 2025 05:59:54 -0700 (PDT)","by 2002:a05:6000:2012:b0:3e7:63c5:9aae with SMTP id\n\tffacd0b85a97d-3e763c59ffamr614105f8f.15.1757595594291; \n\tThu, 11 Sep 2025 05:59:54 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IH2+EW7R336BkIiC6qVEQGwX7HQN9JjDD84bwXHccCKzUm3IFN+9qfKQwowsoyvi2hk6OF3fA==","From":"Milan Zamazal ","To":"\"Maciej S. Szmigiero\" ","Cc":"pobrn@protonmail.com, libcamera-devel@lists.libcamera.org,\n\thdegoede@redhat.com","Subject":"Re: [PATCH 0/5] Fix stats related problems in software ISP","In-Reply-To":"\n\t(Maciej S. Szmigiero's message of \"Thu, 28 Aug 2025 23:09:40 +0200\")","References":"<20250821134141.83236-1-mzamazal@redhat.com>\n\t<6cd8d54e-59d3-49bc-b5a6-b395e12afce8@maciej.szmigiero.name>\n\t<85bjo387nn.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>\n\t\n\t<85349bflyp.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>\n\t","Date":"Thu, 11 Sep 2025 14:59:47 +0200","Message-ID":"<857by5kuv0.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"NfS5FNAYuog47JkaCZwe6vJmsPXU2dcoq0ESDEmVvcQ_1757595595","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]