{"id":24088,"url":"https://patchwork.libcamera.org/api/covers/24088/?format=json","web_url":"https://patchwork.libcamera.org/cover/24088/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250811094926.1308259-1-barnabas.pocze@ideasonboard.com>","date":"2025-08-11T09:49:24","name":"[RFC,v1,0/2] libcamera: pipeline: virtual: Move image generation to separate thread","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/24088/mbox/","series":[{"id":5365,"url":"https://patchwork.libcamera.org/api/series/5365/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5365","date":"2025-08-11T09:49:24","name":"libcamera: pipeline: virtual: Move image generation to separate thread","version":1,"mbox":"https://patchwork.libcamera.org/series/5365/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/24088/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 13395BDCC1\n\tfor ;\n\tMon, 11 Aug 2025 09:49:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D4D236922A;\n\tMon, 11 Aug 2025 11:49:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8606F6145E\n\tfor ;\n\tMon, 11 Aug 2025 11:49:29 +0200 (CEST)","from pb-laptop.local (185.221.140.182.nat.pool.zt.hu\n\t[185.221.140.182])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7DC544A4\n\tfor ;\n\tMon, 11 Aug 2025 11:48:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Sd+aV6jB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1754905717;\n\tbh=b1Ijfc/p4U9arsh7gyNDygEPKqnLzVt8DxAHfe7NxvQ=;\n\th=From:To:Subject:Date:From;\n\tb=Sd+aV6jB8qlph0gOXidTa5Y8gVDkLLm+5kianvmfwHHAWoMBydswa5QHkJQUUHYTg\n\tO3js9AyDpk//KOQbfXqbgYCflN6bgnwdstUWvd2/OBNYNbQeSsLv0nkwTVQw9fkAVl\n\tyxCkxpnW2NeUVJc5i3WMqRqskXVbIeA90j+Jnv2Q=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 0/2] libcamera: pipeline: virtual: Move image\n\tgeneration to separate thread","Date":"Mon, 11 Aug 2025 11:49:24 +0200","Message-ID":"<20250811094926.1308259-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.50.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This seems to be the simplest way. Still there are questions:\n\n* Should there be a `flushMessages(Message::Type)` instead? The lambda approach\n seems more generally useful. Initially I did not have VirtualCameraData::queueRequest()\n and simply moved things into a lambda.\n* Should each camera get its own thread or should they share?\n * If one thread per camera, should that be started when the camera is created or only when\n the camera is started?\n\nBarnabás Pőcze (2):\n libcamera: base: object: Add `invokeMethod` for lamdas\n libcamera: pipeline: virtual: Move image generation to separate thread\n\n include/libcamera/base/object.h | 10 +++\n src/libcamera/base/object.cpp | 24 ++++++-\n src/libcamera/pipeline/virtual/virtual.cpp | 80 ++++++++++++++--------\n src/libcamera/pipeline/virtual/virtual.h | 8 ++-\n 4 files changed, 91 insertions(+), 31 deletions(-)\n\n--\n2.50.1"}