[{"id":34930,"web_url":"https://patchwork.libcamera.org/comment/34930/","msgid":"<175283859611.1988683.11013184995020416655@ping.linuxembedded.co.uk>","date":"2025-07-18T11:36:36","subject":"Re: [PATCH v2 0/2] libcamera: simple: Support RPi's unicam CSI-2\n\treceiver","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Umang Jain (2025-07-18 10:40:46)\n> Couple of patches to stream RPi+IMX219 setup with simple pipeline\n> handler and SoftISP.\n> \n> Patch 1/2 fixes up bayer pattern changes on the sensor due to transforms\n> being applied, which then configures the video node correctly.\n> \n> Patch 2/2 enables the unicam driver in simple pipeline handler with\n> SoftISP.\n> \n> Changes in v2:\n> - Pass the updated format(Bayer applied with transforms) to the\n> converter/SoftISP input configuration as well to configure them\n> correctly.\n\nI /really/ like the fact we're able to use unicam through the simple\npipeline handler.\n\nBut we can't merge this until the configuration file series lands.\n\nCould you support testing / reviewing that series and build this series\non top of that please?\n\nIf we were to merge this - then out of the box Raspberry Pi users are\ntoo likely to hit issues regarding which pipeline gets used.\n\n--\nKieran\n\n\n\n> Umang Jain (2):\n> libcamera: simple: Detect Bayer pattern change during configure()\n> libcamera: simple: Support RPi's unicam CSI-2 receiver\n> \n> src/libcamera/pipeline/simple/simple.cpp | 19 ++++++++++++++++---\n> 1 file changed, 16 insertions(+), 3 deletions(-)\n> \n> -- \n> 2.50.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E9341C3237\n\tfor ;\n\tFri, 18 Jul 2025 11:36:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9844268FA0;\n\tFri, 18 Jul 2025 13:36:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E570468F95\n\tfor ;\n\tFri, 18 Jul 2025 13:36:38 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 069095A01;\n\tFri, 18 Jul 2025 13:36:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZYUTS5aJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1752838564;\n\tbh=w2g52v56VVQixGdsGTdaR90+HTfplB6i8jcFQz50NCs=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=ZYUTS5aJa4aqJw2OoosKtvZn4YvE1aQu/SuPc91iY5NQpiovKaJtWn/Krm98ZjYBU\n\tC9EGOoflM6dPdJmeSJeksmwhujBzbW75KLVv6f993uTKUNtrqOvhY8l6gJW2LLPGno\n\tBhZ9Zne87S03MemupBsgPbZmwNw0TImJItCUMirk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250718094048.59162-1-uajain@igalia.com>","References":"<20250718094048.59162-1-uajain@igalia.com>","Subject":"Re: [PATCH v2 0/2] libcamera: simple: Support RPi's unicam CSI-2\n\treceiver","From":"Kieran Bingham ","Cc":"Milan Zamazal , Umang Jain ","To":"Umang Jain , libcamera-devel@lists.libcamera.org","Date":"Fri, 18 Jul 2025 12:36:36 +0100","Message-ID":"<175283859611.1988683.11013184995020416655@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34940,"web_url":"https://patchwork.libcamera.org/comment/34940/","msgid":"","date":"2025-07-18T14:06:04","subject":"Re: [PATCH v2 0/2] libcamera: simple: Support RPi's unicam CSI-2\n\treceiver","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/people/232/","name":"Umang Jain","email":"uajain@igalia.com"},"content":"On Fri, Jul 18, 2025 at 12:36:36PM +0100, Kieran Bingham wrote:\n> Quoting Umang Jain (2025-07-18 10:40:46)\n> > Couple of patches to stream RPi+IMX219 setup with simple pipeline\n> > handler and SoftISP.\n> > \n> > Patch 1/2 fixes up bayer pattern changes on the sensor due to transforms\n> > being applied, which then configures the video node correctly.\n> > \n> > Patch 2/2 enables the unicam driver in simple pipeline handler with\n> > SoftISP.\n> > \n> > Changes in v2:\n> > - Pass the updated format(Bayer applied with transforms) to the\n> > converter/SoftISP input configuration as well to configure them\n> > correctly.\n> \n> I /really/ like the fact we're able to use unicam through the simple\n> pipeline handler.\n> \n> But we can't merge this until the configuration file series lands.\n> \n> Could you support testing / reviewing that series and build this series\n> on top of that please?\n> \n\nThe argument only applies to 2/2. I can drop it , given it can be enabled\nin the configuration file when that work lands.\n\nPatch 1/2 is independent - it detects Bayer patterns changes due to\ntransforms - and I am sure it has nothing to do with RPi. Any of\nsupported_devices[] where transform != Transform::Identity, will face\nthe issue. \n\n> If we were to merge this - then out of the box Raspberry Pi users are\n> too likely to hit issues regarding which pipeline gets used.\n\nMake sense.\n> \n> --\n> Kieran\n> \n> \n> \n> > Umang Jain (2):\n> > libcamera: simple: Detect Bayer pattern change during configure()\n> > libcamera: simple: Support RPi's unicam CSI-2 receiver\n> > \n> > src/libcamera/pipeline/simple/simple.cpp | 19 ++++++++++++++++---\n> > 1 file changed, 16 insertions(+), 3 deletions(-)\n> > \n> > -- \n> > 2.50.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E53E4C3237\n\tfor ;\n\tFri, 18 Jul 2025 14:06:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 939A168FA8;\n\tFri, 18 Jul 2025 16:06:04 +0200 (CEST)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D598B68FA0\n\tfor ;\n\tFri, 18 Jul 2025 16:06:01 +0200 (CEST)","from [49.36.71.87] (helo=uajain) by fanzine2.igalia.com with\n\tesmtpsa \n\t(Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1ucliq-000b8m-1Z; Fri, 18 Jul 2025 16:06:00 +0200"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"eF2eisQ9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:\n\tSubject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=dwyu8aKMnbsw4JwUdYrC3oOIoShcs9cNvU3LvcGcrNo=;\n\tb=eF2eisQ9Shiakzv4OOEffN+hNk\n\tfKYDNSEV8gsmdNC65iURoY/BcCmvQAsNs9mENDmTCBCTdkY82TQBNf5iLFLopRoiASJsG2ylXOl4o\n\tlVp83PyZZPI0yU6p63US5XOv4TJo4e2TY0NZdosco2UZFO4Og+Rhpn5xBcb0Www6YgyB/0RRXCUyC\n\tomktdECfftR1rW97f6OeA2+H3NXmQgBnsMSyzQ87WVnGTVxOr664VBjKLL716AS3uS05T7saR8W7A\n\tJ5Z12dKRsIw2FkO2tNHyS8IjgjXHo5V9Xf3x23wBsc6zvxi0gTUwXpbZUfnbfO0aU3bKfxRsC7uKX\n\tynCl7JkA==;","Date":"Fri, 18 Jul 2025 19:36:04 +0530","From":"Umang Jain ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org, Milan Zamazal ","Subject":"Re: [PATCH v2 0/2] libcamera: simple: Support RPi's unicam CSI-2\n\treceiver","Message-ID":"","References":"<20250718094048.59162-1-uajain@igalia.com>\n\t<175283859611.1988683.11013184995020416655@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<175283859611.1988683.11013184995020416655@ping.linuxembedded.co.uk>","User-Agent":"NeoMutt/20250510-dirty","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]