[{"id":34819,"web_url":"https://patchwork.libcamera.org/comment/34819/","msgid":"","date":"2025-07-08T06:08:09","subject":"Re: [PATCH v2 0/2] lc-compliance: Ensure stream's colorspace is set\n\tafter validate()","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/people/232/","name":"Umang Jain","email":"uajain@igalia.com"},"content":"Hi,\n\nOn Tue, Jul 01, 2025 at 04:59:20PM +0530, Umang Jain wrote:\n> Patch 1/2 stems from a test result given by 2/2; virtual pipeline\n> handler now sets a colorspace.\n> See https://gitlab.freedesktop.org/camera/libcamera/-/jobs/79412875\n\nCan this be kicked on CI once again, to ensure we don't face any errors?\n\nThanks!\n> \n> Patch 2/2 is the lc-compliance check to ensure pipeline handlers\n> set colorspace after validate().\n\n> \n> Umang Jain (2):\n> pipeline: virtual: Provide and validate colorspace\n> lc-compliance: Ensure stream's colorspace is set after validate()\n> \n> src/apps/lc-compliance/helpers/capture.cpp | 3 +++\n> src/libcamera/pipeline/virtual/virtual.cpp | 12 ++++++++++++\n> 2 files changed, 15 insertions(+)\n> \n> -- \n> 2.50.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AF09DC0DA4\n\tfor ;\n\tTue, 8 Jul 2025 06:08:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E5F2C68ECF;\n\tTue, 8 Jul 2025 08:08:09 +0200 (CEST)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C515A6186C\n\tfor ;\n\tTue, 8 Jul 2025 08:08:07 +0200 (CEST)","from [49.36.71.127] (helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1uZ1Ur-00DsHL-I2\n\tfor ;\n\tTue, 08 Jul 2025 08:08:06 +0200"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"YjpEcMSi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:\n\tSubject:To:From:Date:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=zhTQaEVD5S6XJZIXIZJycrMt/RV70+P8usSxvLd+PaM=;\n\tb=YjpEcMSiGoSgALn2UAKmtd3UtB\n\tQBqLXJNfFmfkyoKtUXBLMxg9OmbGYkGLOvasxf+yoRz4I4wFjA6BWYnbbL/uUmqFmgEWD9OECyFZe\n\tEh5D5w9NLmQedKCnsHcvEkSr+kTmK4aRSTasSDgK4H1BRjVSxi1U6N0XPUDTBhKyAG1/YIUMy8lKI\n\tFtgXKLhYHu+6oyGRKvOxxjscd1qvhO+LlrLac+nAuuP9D7jdIluV3dUEGKKLKIlFxcYeyTYD/ox5W\n\tcP3wbMlbWkaCcgzNVWSz6XKjWP3LJkppBR+NdVymahF0KQVfLI2GoaXYjv0sMOsp2VWksrNB4KsDt\n\tFakqCaRQ==;","Date":"Tue, 8 Jul 2025 11:38:09 +0530","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 0/2] lc-compliance: Ensure stream's colorspace is set\n\tafter validate()","Message-ID":"","References":"<20250701112922.62285-1-uajain@igalia.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20250701112922.62285-1-uajain@igalia.com>","User-Agent":"NeoMutt/20250510-dirty","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34827,"web_url":"https://patchwork.libcamera.org/comment/34827/","msgid":"<175198788696.2538045.14943561340014446757@ping.linuxembedded.co.uk>","date":"2025-07-08T15:18:06","subject":"Re: [PATCH v2 0/2] lc-compliance: Ensure stream's colorspace is set\n\tafter validate()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Umang Jain (2025-07-08 07:08:09)\n> Hi,\n> \n> On Tue, Jul 01, 2025 at 04:59:20PM +0530, Umang Jain wrote:\n> > Patch 1/2 stems from a test result given by 2/2; virtual pipeline\n> > handler now sets a colorspace.\n> > See https://gitlab.freedesktop.org/camera/libcamera/-/jobs/79412875\n> \n> Can this be kicked on CI once again, to ensure we don't face any errors?\n> \n\nThat already ran successfully -\nhttps://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1461603 so\nthis just needs RB tags.\n\n\n\n> Thanks!\n> > \n> > Patch 2/2 is the lc-compliance check to ensure pipeline handlers\n> > set colorspace after validate().\n> \n> > \n> > Umang Jain (2):\n> > pipeline: virtual: Provide and validate colorspace\n> > lc-compliance: Ensure stream's colorspace is set after validate()\n> > \n> > src/apps/lc-compliance/helpers/capture.cpp | 3 +++\n> > src/libcamera/pipeline/virtual/virtual.cpp | 12 ++++++++++++\n> > 2 files changed, 15 insertions(+)\n> > \n> > -- \n> > 2.50.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8C20DC3237\n\tfor ;\n\tTue, 8 Jul 2025 15:18:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 582CC68EE5;\n\tTue, 8 Jul 2025 17:18:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 03D5261519\n\tfor ;\n\tTue, 8 Jul 2025 17:18:10 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 17EDE664;\n\tTue, 8 Jul 2025 17:17:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IJchbued\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1751987863;\n\tbh=lumKA84JENc0V+5wUsqlzOyBIoFUGiyAwghX5w+a+cI=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=IJchbued+5P2ICQqo7sPCqvaOPXJwzIqclJV9goT0AcIIoIg6bR1sL0IknjlrHTZs\n\tPXNh9JqkKyKaCdoQ8JIEo6cLOmDoMamxZjD2zgec07kaANhRTNW06wijSPAPkrWPVj\n\t4kNswQmHh4lUP/GhnYgCL6bo8lA5ow02U5ABNcXs=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20250701112922.62285-1-uajain@igalia.com>\n\t","Subject":"Re: [PATCH v2 0/2] lc-compliance: Ensure stream's colorspace is set\n\tafter validate()","From":"Kieran Bingham ","To":"Umang Jain , libcamera-devel@lists.libcamera.org","Date":"Tue, 08 Jul 2025 16:18:06 +0100","Message-ID":"<175198788696.2538045.14943561340014446757@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":34834,"web_url":"https://patchwork.libcamera.org/comment/34834/","msgid":"<602de858-49c4-4efb-a6dd-a3a45c4f000c@collabora.com>","date":"2025-07-09T19:52:01","subject":"Re: [PATCH v2 0/2] lc-compliance: Ensure stream's colorspace is set\n\tafter validate()","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"On 08.07.25 17:18, Kieran Bingham wrote:\n> That already ran successfully -\n> https://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1461603 so\n> this just needs RB tags.\n\nI just used this to implement colorspace support in the Pipewire plugin \n(https://gitlab.freedesktop.org/pipewire/pipewire/-/merge_requests/2448) \n- thus:\n\nTested-by: Robert Mader ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C56F8C0DA4\n\tfor ;\n\tWed, 9 Jul 2025 19:52:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B70F668EF6;\n\tWed, 9 Jul 2025 21:52:10 +0200 (CEST)","from sender4-op-o12.zoho.com (sender4-op-o12.zoho.com\n\t[136.143.188.12])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 238CF68E8A\n\tfor ;\n\tWed, 9 Jul 2025 21:52:07 +0200 (CEST)","by mx.zohomail.com with SMTPS id 1752090723296336.9265820675463;\n\tWed, 9 Jul 2025 12:52:03 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"OHPtGtg9\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1752090724; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=h9tcRs728D0kh+8he58CmKSTpUlKVJw9J2Emhe5HXESSW7L6eMJh4VJGdqpYdco91zsqqdQs+Jhi3eb8/hOi+GsczgEl22y4SBpVB+fnvZyJNfKYWG1Pus+ZTd+EM9O/wIOfyottkkDA5XeCgQoGtJb6Wi90P3/tqVgDKnGo+2U=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1752090724;\n\th=Content-Type:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc;\n\tbh=TyySj+Pr0IywcnZpjT0nkLo/5TnKjuP1TLXR9tVN7iU=; \n\tb=bAPUBZoHylEXVquQHmGy6sswZg7fgKg/roARNfENcA9ED26SWa4BaZ3kp4uKB4TOXtaMIK9wMQu6vB8UxnvysimyWzmBZhVDHWDDs2qF9n1J8A7daSeVCzR366KGRPvoqXl3vrE5KQuICCum58aKSqpocLTLqp5qb4lbgFHZ8to=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1752090724;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Content-Type:Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Message-Id:Reply-To:Cc;\n\tbh=TyySj+Pr0IywcnZpjT0nkLo/5TnKjuP1TLXR9tVN7iU=;\n\tb=OHPtGtg9bS8zbEW2v2X0qAUP3/Cd3cdd4gEXkvy6ahbq+a4swtBeS6t2MXmRSIQe\n\tRdv7yJQbds4gfuTPQBAVxjRHFnBt9fytF/YfG5gCtLX6PKLxkb539ZcmJXpm0UJRscC\n\tjPfjRhwozlHk6Hi86cCZytwbfgLFw52QrsvRcw1g=","Content-Type":"multipart/alternative;\n\tboundary=\"------------3KHUaDK0SHVGRuaL21o8a0IG\"","Message-ID":"<602de858-49c4-4efb-a6dd-a3a45c4f000c@collabora.com>","Date":"Wed, 9 Jul 2025 21:52:01 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 0/2] lc-compliance: Ensure stream's colorspace is set\n\tafter validate()","To":"libcamera-devel@lists.libcamera.org","References":"<20250701112922.62285-1-uajain@igalia.com>\n\t\n\t<175198788696.2538045.14943561340014446757@ping.linuxembedded.co.uk>","Content-Language":"en-US, de-DE","From":"Robert Mader ","In-Reply-To":"<175198788696.2538045.14943561340014446757@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]